Hadoop Common
  1. Hadoop Common
  2. HADOOP-6274

TestLocalFSFileContextMainOperations tests wrongly expect a certain order to be returned.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test to be more forgiving on the return values of list status calls.

      1. HADOOP-6274.patch
        9 kB
        gary murry
      2. HADOOP-6274.patch
        9 kB
        gary murry
      3. HADOOP-6274.patch
        9 kB
        gary murry
      4. HADOOP-6274.patch
        8 kB
        gary murry

        Issue Links

          Activity

          Hide
          gary murry added a comment -

          This removes the dependency on sort order for return from list status.

          Show
          gary murry added a comment - This removes the dependency on sort order for return from list status.
          Hide
          gary murry added a comment -

          Opps, I hit the wrong link.

          Show
          gary murry added a comment - Opps, I hit the wrong link.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420206/HADOOP-6274.patch
          against trunk revision 816847.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420206/HADOOP-6274.patch against trunk revision 816847. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/57/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          In the situations like this

              Assert.assertTrue(getTestRootPath(TEST_DIR_AAA).equals(paths[0].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA).equals(paths[1].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA).equals(paths[2].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA).equals(paths[3].getPath()));
              Assert.assertTrue(getTestRootPath(TEST_DIR_AXA).equals(paths[0].getPath()) ||
                  getTestRootPath(TEST_DIR_AXA).equals(paths[1].getPath()) ||
                  getTestRootPath(TEST_DIR_AXA).equals(paths[2].getPath()) ||
                  getTestRootPath(TEST_DIR_AXA).equals(paths[3].getPath()));
              Assert.assertTrue(getTestRootPath(TEST_DIR_AXX).equals(paths[0].getPath()) ||
                  getTestRootPath(TEST_DIR_AXX).equals(paths[1].getPath()) ||
                  getTestRootPath(TEST_DIR_AXX).equals(paths[2].getPath()) ||
                  getTestRootPath(TEST_DIR_AXX).equals(paths[3].getPath()));
              Assert.assertTrue(getTestRootPath(TEST_DIR_AAA2).equals(paths[0].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA2).equals(paths[1].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA2).equals(paths[2].getPath()) ||
                  getTestRootPath(TEST_DIR_AAA2).equals(paths[3].getPath()));
          

          you'd better convert paths array into a list structure and test for contains() instead of testing all possible combination of the output. Imaging if this array will have 50 elements?

          Show
          Konstantin Boudnik added a comment - In the situations like this Assert.assertTrue(getTestRootPath(TEST_DIR_AAA).equals(paths[0].getPath()) || getTestRootPath(TEST_DIR_AAA).equals(paths[1].getPath()) || getTestRootPath(TEST_DIR_AAA).equals(paths[2].getPath()) || getTestRootPath(TEST_DIR_AAA).equals(paths[3].getPath())); Assert.assertTrue(getTestRootPath(TEST_DIR_AXA).equals(paths[0].getPath()) || getTestRootPath(TEST_DIR_AXA).equals(paths[1].getPath()) || getTestRootPath(TEST_DIR_AXA).equals(paths[2].getPath()) || getTestRootPath(TEST_DIR_AXA).equals(paths[3].getPath())); Assert.assertTrue(getTestRootPath(TEST_DIR_AXX).equals(paths[0].getPath()) || getTestRootPath(TEST_DIR_AXX).equals(paths[1].getPath()) || getTestRootPath(TEST_DIR_AXX).equals(paths[2].getPath()) || getTestRootPath(TEST_DIR_AXX).equals(paths[3].getPath())); Assert.assertTrue(getTestRootPath(TEST_DIR_AAA2).equals(paths[0].getPath()) || getTestRootPath(TEST_DIR_AAA2).equals(paths[1].getPath()) || getTestRootPath(TEST_DIR_AAA2).equals(paths[2].getPath()) || getTestRootPath(TEST_DIR_AAA2).equals(paths[3].getPath())); you'd better convert paths array into a list structure and test for contains() instead of testing all possible combination of the output. Imaging if this array will have 50 elements?
          Hide
          gary murry added a comment -

          These issues are not showing up local. I am submitting and unsubmitting to force a Hudson run.

          Show
          gary murry added a comment - These issues are not showing up local. I am submitting and unsubmitting to force a Hudson run.
          Hide
          gary murry added a comment -

          Jakob and Cos both bring up good points. We should revamp all the fs related tests. I am going to submit this patch to unblock the build and create a jira to clean things up the right way.

          Show
          gary murry added a comment - Jakob and Cos both bring up good points. We should revamp all the fs related tests. I am going to submit this patch to unblock the build and create a jira to clean things up the right way.
          Hide
          gary murry added a comment -

          Attempting to queue the patch again.

          Show
          gary murry added a comment - Attempting to queue the patch again.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420212/HADOOP-6274.patch
          against trunk revision 816847.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420212/HADOOP-6274.patch against trunk revision 816847. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/58/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420217/HADOOP-6274.patch
          against trunk revision 816847.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420217/HADOOP-6274.patch against trunk revision 816847. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/59/console This message is automatically generated.
          Hide
          gary murry added a comment -

          Addressing some additonal concerns that Jakob had.

          Show
          gary murry added a comment - Addressing some additonal concerns that Jakob had.
          Hide
          Jakob Homan added a comment -

          Looks good. +1

          Show
          Jakob Homan added a comment - Looks good. +1
          Hide
          gary murry added a comment -

          Thanks.

          Show
          gary murry added a comment - Thanks.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420240/HADOOP-6274.patch
          against trunk revision 817416.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420240/HADOOP-6274.patch against trunk revision 817416. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/61/console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          I committed this change. Thank you Gary.

          Show
          Suresh Srinivas added a comment - I committed this change. Thank you Gary.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #48 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/48/)
          . Fix TestLocalFSFileContextMainOperations test failure. Contributed by Gary Murry.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #48 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/48/ ) . Fix TestLocalFSFileContextMainOperations test failure. Contributed by Gary Murry.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #105 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/105/)
          . Fix TestLocalFSFileContextMainOperations test failure. Contributed by Gary Murry.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #105 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/105/ ) . Fix TestLocalFSFileContextMainOperations test failure. Contributed by Gary Murry.

            People

            • Assignee:
              gary murry
              Reporter:
              gary murry
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development