Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This Jira is to add the unit tests associated with HADOOP-4952.

      1. List_glob_TestPlan.html
        6 kB
        gary murry
      2. HADOOP-6260.patch
        21 kB
        gary murry
      3. HADOOP-6260.patch
        22 kB
        gary murry
      4. HADOOP-6260.patch
        22 kB
        gary murry
      5. HADOOP-6260.patch
        22 kB
        gary murry
      6. HADOOP-6260.1.patch
        13 kB
        Suresh Srinivas
      7. HADOOP-6260.1.patch
        22 kB
        Suresh Srinivas

        Issue Links

          Activity

          gary murry created issue -
          gary murry made changes -
          Field Original Value New Value
          Link This issue is blocked by HADOOP-4952 [ HADOOP-4952 ]
          gary murry made changes -
          Attachment List_glob_TestPlan.html [ 12419926 ]
          gary murry made changes -
          Attachment HADOOP-6260.patch [ 12420059 ]
          Hide
          Suresh Srinivas added a comment -

          Comments:

          1. Some new classes are missing the banner
          2. Add a comment to the class to briefly describe what the test is doing
          3. Use log instead of system.out.println
          Show
          Suresh Srinivas added a comment - Comments: Some new classes are missing the banner Add a comment to the class to briefly describe what the test is doing Use log instead of system.out.println
          Hide
          gary murry added a comment -

          Attached a new patch I believe addresses Suresh's comments.

          Show
          gary murry added a comment - Attached a new patch I believe addresses Suresh's comments.
          gary murry made changes -
          Attachment HADOOP-6260.patch [ 12420094 ]
          Suresh Srinivas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420094/HADOOP-6260.patch
          against trunk revision 816794.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 97 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420094/HADOOP-6260.patch against trunk revision 816794. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 97 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/console This message is automatically generated.
          gary murry made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          gary murry added a comment -

          The previous patch passed on windows but was killing Hudson. I changed "/test/..." to "test/..."

          Show
          gary murry added a comment - The previous patch passed on windows but was killing Hudson. I changed "/test/..." to "test/..."
          gary murry made changes -
          Attachment HADOOP-6260.patch [ 12420103 ]
          gary murry made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Konstantin Boudnik added a comment -

          few comments:

          • lot of duplicated string literals. Move them to be the class' member or something. It also will make assertion structure smaller and easier to read (see my comment to HADOOP-6261
          • in the messages like Can't run test it makes sense to add test name - makes it easier to analyze
          • catch and finally are suppose to start next to the closing curve bracket (in the same line, not in the next one)

          Other than that it seems pretty good I think!

          Show
          Konstantin Boudnik added a comment - few comments: lot of duplicated string literals. Move them to be the class' member or something. It also will make assertion structure smaller and easier to read (see my comment to HADOOP-6261 in the messages like Can't run test it makes sense to add test name - makes it easier to analyze catch and finally are suppose to start next to the closing curve bracket (in the same line, not in the next one) Other than that it seems pretty good I think!
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420103/HADOOP-6260.patch
          against trunk revision 816794.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420103/HADOOP-6260.patch against trunk revision 816794. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/console This message is automatically generated.
          gary murry made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          gary murry added a comment -

          This patch addresses cos's comments.

          Show
          gary murry added a comment - This patch addresses cos's comments.
          gary murry made changes -
          Attachment HADOOP-6260.patch [ 12420111 ]
          gary murry made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Suresh Srinivas added a comment -

          Attaching new patch that incorporates new recursive version of mkdir.

          Show
          Suresh Srinivas added a comment - Attaching new patch that incorporates new recursive version of mkdir.
          Suresh Srinivas made changes -
          Attachment HADOOP-6260.1.patch [ 12420113 ]
          Hide
          Suresh Srinivas added a comment -

          New patch that includes missing files

          Show
          Suresh Srinivas added a comment - New patch that includes missing files
          Suresh Srinivas made changes -
          Attachment HADOOP-6260.1.patch [ 12420115 ]
          Hide
          Suresh Srinivas added a comment -

          Hudson is stuck. Ran test manually. All tests pass.

          Show
          Suresh Srinivas added a comment - Hudson is stuck. Ran test manually. All tests pass.
          Hide
          Jakob Homan added a comment -

          test-patch is good:

               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 15 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
          Show
          Jakob Homan added a comment - test-patch is good: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 15 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Suresh Srinivas made changes -
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12313563 ]
          Affects Version/s 0.21.0 [ 12313563 ]
          Hide
          Suresh Srinivas added a comment -

          Just committed the patch. Thanks Gary.

          Show
          Suresh Srinivas added a comment - Just committed the patch. Thanks Gary.
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #45 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/45/)
          . Add additional unit tests for FileContext util methods. Contributed by Gary Murray.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #45 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/45/ ) . Add additional unit tests for FileContext util methods. Contributed by Gary Murray.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/)
          . Add additional unit tests for FileContext util methods. Contributed by Gary Murray.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/ ) . Add additional unit tests for FileContext util methods. Contributed by Gary Murray.
          gary murry made changes -
          Link This issue is related to HADOOP-6274 [ HADOOP-6274 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              gary murry
              Reporter:
              gary murry
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development