Hadoop Common
  1. Hadoop Common
  2. HADOOP-6257

Two TestFileSystem classes are confusing hadoop-hdfs-hdfwithmr

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build, fs, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I propose to rename hadoop-common/src/test/core/org/apache/hadoop/fs/TestFileSystem.java -> src/test/core/org/apache/hadoop/fs/TestFileSystemCaching.java. Otherwise, it conflicts with hadoop-hdfs/src/test/hdfs-with-mr/org/apache/hadoop/fs/TestFileSystem.java.

      1. HADOOP-6257.patch
        4 kB
        Philip Zeyliger

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/98/)
          . Two TestFileSystem classes are confusing hadoop-hdfs-hdfwithmr. Contributed by Philip Zeyliger.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/98/ ) . Two TestFileSystem classes are confusing hadoop-hdfs-hdfwithmr. Contributed by Philip Zeyliger.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #34 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/34/)
          . Two TestFileSystem classes are confusing hadoop-hdfs-hdfwithmr. Contributed by Philip Zeyliger.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #34 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/34/ ) . Two TestFileSystem classes are confusing hadoop-hdfs-hdfwithmr. Contributed by Philip Zeyliger.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Philip!

          Show
          Tom White added a comment - I've just committed this. Thanks Philip!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12419688/HADOOP-6257.patch
          against trunk revision 815524.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419688/HADOOP-6257.patch against trunk revision 815524. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/36/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Sounds like a good idea to me!

          Show
          Konstantin Boudnik added a comment - Sounds like a good idea to me!
          Hide
          Philip Zeyliger added a comment -

          Trivial rename.

          BTW, the conflict showed up in the recent HADOOP-6231. And I ran into it because hadoop-hdfs-hdfswithmr-test's driver was finding the wrong TestFileSystem.

          $ bin/hadoop jar lib/hadoop-hdfs-hdfswithmr-test-0.21.0-dev.jar 
          java.lang.NoSuchMethodException: org.apache.hadoop.fs.TestFileSystem.main([Ljava.lang.String;)
          	at java.lang.Class.getMethod(Class.java:1605)
          	at org.apache.hadoop.util.ProgramDriver$ProgramDescription.<init>(ProgramDriver.java:56)
          	at org.apache.hadoop.util.ProgramDriver.addClass(ProgramDriver.java:99)
          	at org.apache.hadoop.test.HdfsWithMRTestDriver.<init>(HdfsWithMRTestDriver.java:47)
          	at org.apache.hadoop.test.HdfsWithMRTestDriver.<init>(HdfsWithMRTestDriver.java:39)
          	at org.apache.hadoop.test.HdfsWithMRTestDriver.main(HdfsWithMRTestDriver.java:77)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
          	at java.lang.reflect.Method.invoke(Method.java:597)
          	at org.apache.hadoop.util.RunJar.main(RunJar.java:160)
          An example program must be given as the first argument.
          Valid program names are:
            nnbench: A benchmark that stresses the namenode.
          
          Show
          Philip Zeyliger added a comment - Trivial rename. BTW, the conflict showed up in the recent HADOOP-6231 . And I ran into it because hadoop-hdfs-hdfswithmr-test's driver was finding the wrong TestFileSystem. $ bin/hadoop jar lib/hadoop-hdfs-hdfswithmr-test-0.21.0-dev.jar java.lang.NoSuchMethodException: org.apache.hadoop.fs.TestFileSystem.main([Ljava.lang. String ;) at java.lang. Class .getMethod( Class .java:1605) at org.apache.hadoop.util.ProgramDriver$ProgramDescription.<init>(ProgramDriver.java:56) at org.apache.hadoop.util.ProgramDriver.addClass(ProgramDriver.java:99) at org.apache.hadoop.test.HdfsWithMRTestDriver.<init>(HdfsWithMRTestDriver.java:47) at org.apache.hadoop.test.HdfsWithMRTestDriver.<init>(HdfsWithMRTestDriver.java:39) at org.apache.hadoop.test.HdfsWithMRTestDriver.main(HdfsWithMRTestDriver.java:77) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.RunJar.main(RunJar.java:160) An example program must be given as the first argument. Valid program names are: nnbench: A benchmark that stresses the namenode.

            People

            • Assignee:
              Philip Zeyliger
              Reporter:
              Philip Zeyliger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development