Hadoop Common
  1. Hadoop Common
  2. HADOOP-6124

patchJavacWarnings and trunkJavacWarnings are not consistent.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.

      1. c6124_20090701.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. HADOOP-6124.patch
        2 kB
        Giridharan Kesavan

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          In HADOOP-6122, we found that patchJavacWarnings=64 but trunkJavacWarnings=124.

          Show
          Tsz Wo Nicholas Sze added a comment - In HADOOP-6122 , we found that patchJavacWarnings=64 but trunkJavacWarnings=124.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > ... HDFS and MapReduce seem not having this problem.
          I was wrong. HDFS and MapReduce also have this problem.

          The project is not cleaned when patchJavacWarnings.txt is generated. Some java source files may be already compiled and they will not be compiled again. As a result, the warnings inside those files won't be reported. Note that there is a clean when trunkJavacWarnings.txt is generated.

          c6124_20090701.patch: add clean before tar

          Show
          Tsz Wo Nicholas Sze added a comment - > ... HDFS and MapReduce seem not having this problem. I was wrong. HDFS and MapReduce also have this problem. The project is not cleaned when patchJavacWarnings.txt is generated. Some java source files may be already compiled and they will not be compiled again. As a result, the warnings inside those files won't be reported. Note that there is a clean when trunkJavacWarnings.txt is generated. c6124_20090701.patch: add clean before tar
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Giridharan, c6124_20090701.patch does not fix the entire problem. There are still some additional bugs in test-patch.sh. Since you are the assignee, I will leave this issue to you. Thanks for working on this.

          Show
          Tsz Wo Nicholas Sze added a comment - Giridharan, c6124_20090701.patch does not fix the entire problem. There are still some additional bugs in test-patch.sh. Since you are the assignee, I will leave this issue to you. Thanks for working on this.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hope this can be fixed soon. Otherwise, patches with javac warnings may get in without being noticed. Changed the priority to "critical".

          Show
          Tsz Wo Nicholas Sze added a comment - Hope this can be fixed soon. Otherwise, patches with javac warnings may get in without being noticed. Changed the priority to "critical".
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Quite a few javac warnings are getting in without being detected. See MAPREDUCE-716 and MAPREDUCE-743.

          Giridharan, if you are not going to work on this soon, please un-assign yourself. Someone else may want to work on this.

          Show
          Tsz Wo Nicholas Sze added a comment - Quite a few javac warnings are getting in without being detected. See MAPREDUCE-716 and MAPREDUCE-743 . Giridharan, if you are not going to work on this soon, please un-assign yourself. Someone else may want to work on this.
          Hide
          Giridharan Kesavan added a comment -

          this patch adds the clean target before calling the tar while searching for javac warnings and also address the issue mentioned as part of HADOOP-6077.

          Show
          Giridharan Kesavan added a comment - this patch adds the clean target before calling the tar while searching for javac warnings and also address the issue mentioned as part of HADOOP-6077 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          HADOOP-6124.patch has some good changes for HADOOP-6077 but it did not fix the problem in this issue.

               [exec] There appear to be 122 javac compiler warnings before the patch and  
          64 javac compiler warnings after applying the patch.
          
          Show
          Tsz Wo Nicholas Sze added a comment - HADOOP-6124 .patch has some good changes for HADOOP-6077 but it did not fix the problem in this issue. [exec] There appear to be 122 javac compiler warnings before the patch and 64 javac compiler warnings after applying the patch.
          Hide
          Giridharan Kesavan added a comment -

          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] -1 javac. The applied patch generated 100 javac compiler warnings (more than the trunk's current 99 warnings).
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          applied the hadoop-6124.patch and tested a hadoop patch that introduced a javac warning. Here is the result.
          test-patch was able to parse and show the increase in the no of javac warnings.

          Show
          Giridharan Kesavan added a comment - [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The applied patch generated 100 javac compiler warnings (more than the trunk's current 99 warnings). [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. applied the hadoop-6124.patch and tested a hadoop patch that introduced a javac warning. Here is the result. test-patch was able to parse and show the increase in the no of javac warnings.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          If the patch works for you, it may work for Hudson. Let's give it a try.

          +1 Patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - If the patch works for you, it may work for Hudson. Let's give it a try. +1 Patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Script testing is not yet supported (see HADOOP-6174). So I am going to commit this without submitting to Hudson.

          Show
          Tsz Wo Nicholas Sze added a comment - Script testing is not yet supported (see HADOOP-6174 ). So I am going to commit this without submitting to Hudson.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Giridharan!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Giridharan!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #45 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/45/)
          . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #45 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/45/ ) . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #40 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/40/)
          . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #40 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/40/ ) . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #39 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/39/)
          . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #39 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/39/ ) . Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan

            People

            • Assignee:
              Giridharan Kesavan
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development