Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Ran "ant test-patch" with a empty patch. Got

           [exec]     -1 javac.  The applied patch generated 64 javac compiler warnings (more than the trunk's current 124 warnings).
       
      1. c6122_20090630.patch
        2 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/)

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/ )
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #9 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/9/)
          . The great than operator in test-patch.sh should be "-gt" but not ">".

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #9 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/9/ ) . The great than operator in test-patch.sh should be "-gt" but not ">".
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk #13 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/13/)
          . The great than operator in test-patch.sh should be "-gt" but not ">".

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #13 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/13/ ) . The great than operator in test-patch.sh should be "-gt" but not ">".
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Filed HADOOP-6124 for the inconsistency problem.

          Tried test-patch.sh with the patch. It worked fine.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Filed HADOOP-6124 for the inconsistency problem. Tried test-patch.sh with the patch. It worked fine.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > ... For an empty patch, why it says 64 javac warnings but not 124?

          Look like that this is another problem in common but not in hdfs and mapreduce.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > ... For an empty patch, why it says 64 javac warnings but not 124? Look like that this is another problem in common but not in hdfs and mapreduce.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          We still have problems in test-patch.sh: For an empty patch, why it says 64 javac warnings but not 124?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - We still have problems in test-patch.sh: For an empty patch, why it says 64 javac warnings but not 124?
          Hide
          garymurry gary murry added a comment -

          +1

          The patch looks good. Good catch.
          -Gary

          Show
          garymurry gary murry added a comment - +1 The patch looks good. Good catch. -Gary
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          c6122_20090630.patch: test-patch.sh has a bug: ">" should be "-gt"

          -      if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then
          +      if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
          
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - c6122_20090630.patch: test-patch.sh has a bug: ">" should be "-gt" - if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then + if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
          Hide
          pirroh Michele Catasta added a comment -

          Same for me when running "ant test-patch" with the proposed patch in HADOOP-2366.

          Show
          pirroh Michele Catasta added a comment - Same for me when running "ant test-patch" with the proposed patch in HADOOP-2366 .

            People

            • Assignee:
              szetszwo Tsz Wo Nicholas Sze
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development