Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Ran "ant test-patch" with a empty patch. Got

           [exec]     -1 javac.  The applied patch generated 64 javac compiler warnings (more than the trunk's current 124 warnings).
       
      1. c6122_20090630.patch
        2 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Hide
          Michele Catasta added a comment -

          Same for me when running "ant test-patch" with the proposed patch in HADOOP-2366.

          Show
          Michele Catasta added a comment - Same for me when running "ant test-patch" with the proposed patch in HADOOP-2366 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c6122_20090630.patch: test-patch.sh has a bug: ">" should be "-gt"

          -      if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then
          +      if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
          
          Show
          Tsz Wo Nicholas Sze added a comment - c6122_20090630.patch: test-patch.sh has a bug: ">" should be "-gt" - if [[ $patchJavacWarnings > $trunkJavacWarnings ]] ; then + if [[ $patchJavacWarnings -gt $trunkJavacWarnings ]] ; then
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Attachment c6122_20090630.patch [ 12412210 ]
          Tsz Wo Nicholas Sze made changes -
          Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
          Component/s build [ 12311543 ]
          Hide
          gary murry added a comment -

          +1

          The patch looks good. Good catch.
          -Gary

          Show
          gary murry added a comment - +1 The patch looks good. Good catch. -Gary
          Hide
          Tsz Wo Nicholas Sze added a comment -

          We still have problems in test-patch.sh: For an empty patch, why it says 64 javac warnings but not 124?

          Show
          Tsz Wo Nicholas Sze added a comment - We still have problems in test-patch.sh: For an empty patch, why it says 64 javac warnings but not 124?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > ... For an empty patch, why it says 64 javac warnings but not 124?

          Look like that this is another problem in common but not in hdfs and mapreduce.

          Show
          Tsz Wo Nicholas Sze added a comment - > ... For an empty patch, why it says 64 javac warnings but not 124? Look like that this is another problem in common but not in hdfs and mapreduce.
          Tsz Wo Nicholas Sze made changes -
          Link This issue is related to HADOOP-6124 [ HADOOP-6124 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Filed HADOOP-6124 for the inconsistency problem.

          Tried test-patch.sh with the patch. It worked fine.

          Show
          Tsz Wo Nicholas Sze added a comment - Filed HADOOP-6124 for the inconsistency problem. Tried test-patch.sh with the patch. It worked fine.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this.
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12313563 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #13 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/13/)
          . The great than operator in test-patch.sh should be "-gt" but not ">".

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #13 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/13/ ) . The great than operator in test-patch.sh should be "-gt" but not ">".
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #9 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/9/)
          . The great than operator in test-patch.sh should be "-gt" but not ">".

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #9 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/9/ ) . The great than operator in test-patch.sh should be "-gt" but not ">".
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/ )
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          6h 52m 1 Tsz Wo Nicholas Sze 01/Jul/09 01:25
          Resolved Resolved Closed Closed
          419d 19h 13m 1 Tom White 24/Aug/10 20:38

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development