Hadoop Common
  1. Hadoop Common
  2. HADOOP-5896

Remove the dependency of GenericOptionsParser on Option.withArgPattern

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      commons-cli released version does not have Option.withArgPattern API

      1. HADOOP-5896.patch
        3 kB
        Giridharan Kesavan
      2. HADOOP-5896.patch
        5 kB
        Giridharan Kesavan
      3. 5896.patch
        1 kB
        Sharad Agarwal

        Issue Links

          Activity

          Hide
          Jothi Padmanabhan added a comment -

          The following test is not running with the patch.

           
          bin/hadoop  jar build/hadoop-0.21.0-dev-test.jar loadgen -Dtest.randomtextwrite.bytes_per_map=10 -Dtest.randomtextwrite.total_bytes=20 -Dmapred.compress.map.output=false -r 1 -outKey org.apache.hadoop.io.Text -outValue org.apache.hadoop.io.Text -outFormat org.apache.hadoop.mapred.lib.NullOutputFormat -outdir fakeout
          

          After talking to Sharad offline, this looks like it is primarily to do with the version of cli jar not able to handle multiple -D options.

          Show
          Jothi Padmanabhan added a comment - The following test is not running with the patch. bin/hadoop jar build/hadoop-0.21.0-dev-test.jar loadgen -Dtest.randomtextwrite.bytes_per_map=10 -Dtest.randomtextwrite.total_bytes=20 -Dmapred.compress.map.output=false -r 1 -outKey org.apache.hadoop.io.Text -outValue org.apache.hadoop.io.Text -outFormat org.apache.hadoop.mapred.lib.NullOutputFormat -outdir fakeout After talking to Sharad offline, this looks like it is primarily to do with the version of cli jar not able to handle multiple -D options.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12408786/5896.patch
          against trunk revision 778388.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408786/5896.patch against trunk revision 778388. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/console This message is automatically generated.
          Hide
          Giridharan Kesavan added a comment -

          this patch resolves commons-cli for hadoop and commons-cli2 for streaming through ivy.
          tnx!

          Show
          Giridharan Kesavan added a comment - this patch resolves commons-cli for hadoop and commons-cli2 for streaming through ivy. tnx!
          Hide
          Giridharan Kesavan added a comment -

          we need to test this patch by removing lib/commons-cli-2.0-SNAPSHOT.jar
          tnx

          Show
          Giridharan Kesavan added a comment - we need to test this patch by removing lib/commons-cli-2.0-SNAPSHOT.jar tnx
          Hide
          Giridharan Kesavan added a comment -

          added the newly added jar's to the eclipse classpath.

          This patch is expected to fail eclipse classpath as hudson will test this patch w/o deleting the lib/commons-cli jar file.

          Show
          Giridharan Kesavan added a comment - added the newly added jar's to the eclipse classpath. This patch is expected to fail eclipse classpath as hudson will test this patch w/o deleting the lib/commons-cli jar file.
          Hide
          Sharad Agarwal added a comment -

          Tested after removing lib/commons-cli jar, all core tests passed.
          test-patch results:
          -1 overall.
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec] +1 tests included. The patch appears to include 4 new or modified tests.
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          eclipse classpath is expected to fail as mentioned in previous comment.
          Should we commit this ?

          Show
          Sharad Agarwal added a comment - Tested after removing lib/commons-cli jar, all core tests passed. test-patch results: -1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. eclipse classpath is expected to fail as mentioned in previous comment. Should we commit this ?
          Hide
          Tom White added a comment -

          Out of interest, how did you fix the problem of specifying multiple -D options?

          Show
          Tom White added a comment - Out of interest, how did you fix the problem of specifying multiple -D options?
          Hide
          Sharad Agarwal added a comment -

          The current patch does fix the multiple -D options.
          The code changes don't work with the current lib/commons-cli-2.0-SNAPSHOT.jar. However it works with commons-cli-1.2.jar as specified in the ivy file in the patch.

          Show
          Sharad Agarwal added a comment - The current patch does fix the multiple -D options. The code changes don't work with the current lib/commons-cli-2.0-SNAPSHOT.jar. However it works with commons-cli-1.2.jar as specified in the ivy file in the patch.
          Hide
          Sharad Agarwal added a comment -

          I just committed this. Thanks Giri!

          Show
          Sharad Agarwal added a comment - I just committed this. Thanks Giri!

            People

            • Assignee:
              Sharad Agarwal
              Reporter:
              Sharad Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development