Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-5661 removed a deprecated constructor in ClusterStatus without updating callers in TestFairScheduler or TestCapacityScheduler

      1. 5704-0.patch
        2 kB
        Chris Douglas

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/)
        . Fix compilation problems in TestFairScheduler and TestCapacityScheduler. Contributed by Chris Douglas

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/ ) . Fix compilation problems in TestFairScheduler and TestCapacityScheduler. Contributed by Chris Douglas
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Chris!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Chris!
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        Also, tried ant tar. Everyting can be compiled.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Also, tried ant tar. Everyting can be compiled.
        Hide
        Dick King added a comment -

        Looks right to me.

        Show
        Dick King added a comment - Looks right to me.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1

        After applied the patch, both TestFairScheduler and TestCapacityScheduler can be compiled and run successfully.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 After applied the patch, both TestFairScheduler and TestCapacityScheduler can be compiled and run successfully.
        Hide
        Chris Douglas added a comment -

        Naive fix restoring previous behavior. Both testcases pass.

        Show
        Chris Douglas added a comment - Naive fix restoring previous behavior. Both testcases pass.

          People

          • Assignee:
            Chris Douglas
            Reporter:
            Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development