Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

      1. hadoop-5661-v3.patch
        24 kB
        Jothi Padmanabhan
      2. hadoop-5661-v2.patch
        24 kB
        Jothi Padmanabhan
      3. hadoop-5661-v1.patch
        24 kB
        Jothi Padmanabhan
      4. hadoop-5661.patch
        24 kB
        Jothi Padmanabhan

        Issue Links

          Activity

          Jothi Padmanabhan created issue -
          Jothi Padmanabhan made changes -
          Field Original Value New Value
          Link This issue blocks HADOOP-5628 [ HADOOP-5628 ]
          Hide
          Jothi Padmanabhan added a comment -

          Patch fixing all mapred findbugs warnings

          Show
          Jothi Padmanabhan added a comment - Patch fixing all mapred findbugs warnings
          Jothi Padmanabhan made changes -
          Attachment hadoop-5661.patch [ 12405319 ]
          Hide
          Jothi Padmanabhan added a comment -

          ant test and test patch passed with this patch

          Show
          Jothi Padmanabhan added a comment - ant test and test patch passed with this patch
          Jothi Padmanabhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12405319/hadoop-5661.patch
          against trunk revision 764287.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405319/hadoop-5661.patch against trunk revision 764287. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/console This message is automatically generated.
          Hide
          Jothi Padmanabhan added a comment -

          The findbugs warnings reported for the previous patch did not show up in my local box where findbugs version is 1.3.8. We probably should upgrade the findbugs for the automated testing system to 1.3.8 as well. In the interim, attaching a patch that should handle those two warnings.

          The test failures with the previous patch are unrelated.

          Show
          Jothi Padmanabhan added a comment - The findbugs warnings reported for the previous patch did not show up in my local box where findbugs version is 1.3.8. We probably should upgrade the findbugs for the automated testing system to 1.3.8 as well. In the interim, attaching a patch that should handle those two warnings. The test failures with the previous patch are unrelated.
          Jothi Padmanabhan made changes -
          Attachment hadoop-5661-v1.patch [ 12405391 ]
          Jothi Padmanabhan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jothi Padmanabhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12405391/hadoop-5661-v1.patch
          against trunk revision 765427.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405391/hadoop-5661-v1.patch against trunk revision 765427. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/console This message is automatically generated.
          Hide
          Jothi Padmanabhan added a comment -

          Synching patch with the latest trunk

          Show
          Jothi Padmanabhan added a comment - Synching patch with the latest trunk
          Jothi Padmanabhan made changes -
          Attachment hadoop-5661-v2.patch [ 12405746 ]
          Jothi Padmanabhan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jothi Padmanabhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Amareshwari Sriramadasu added a comment -

          One comment:
          Reducetask.ShuffleRamManager.getNumPendingRequests method need not be public.

          Show
          Amareshwari Sriramadasu added a comment - One comment: Reducetask.ShuffleRamManager.getNumPendingRequests method need not be public.
          Hide
          Jothi Padmanabhan added a comment -

          Changed getNumPendingRequests() to be a private method

          Show
          Jothi Padmanabhan added a comment - Changed getNumPendingRequests() to be a private method
          Jothi Padmanabhan made changes -
          Attachment hadoop-5661-v3.patch [ 12405747 ]
          Jothi Padmanabhan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jothi Padmanabhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Amareshwari Sriramadasu added a comment -

          +1 changes look fine to me.

          Show
          Amareshwari Sriramadasu added a comment - +1 changes look fine to me.
          Hide
          Jothi Padmanabhan added a comment -

          ant test and test patch passed on my local box

          Show
          Jothi Padmanabhan added a comment - ant test and test patch passed on my local box
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jothi!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jothi!
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12313563 ]
          Resolution Fixed [ 1 ]
          Hide
          Chris Douglas added a comment -

          TestFairScheduler no longer compiles:

          compile:
               [echo] contrib: fairscheduler
          
          compile-examples:
          
          compile-test:
               [echo] contrib: fairscheduler
              [javac] Compiling 1 source file to /snip/hadoop/build/contrib/fairscheduler/test
              [javac] /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java:128: cannot find symbol
              [javac] symbol  : constructor ClusterStatus(int,int,int,int,int,org.apache.hadoop.mapred.JobTracker.State)
              [javac] location: class org.apache.hadoop.mapred.ClusterStatus
              [javac]       return new ClusterStatus(numTrackers, maps, reduces,
              [javac]              ^
              [javac] Note: /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java uses or overrides a deprecated API.
              [javac] Note: Recompile with -Xlint:deprecation for details.
              [javac] 1 error
          
          BUILD FAILED
          /snip/hadoop/build.xml:774: The following error occurred while executing this line:
          /snip/hadoop/src/contrib/build.xml:48: The following error occurred while executing this line:
          /snip/hadoop/src/contrib/build-contrib.xml:165: Compile failed; see the compiler error output for details.
          
          Total time: 1 minute 2 seconds
          
          Show
          Chris Douglas added a comment - TestFairScheduler no longer compiles: compile: [echo] contrib: fairscheduler compile-examples: compile-test: [echo] contrib: fairscheduler [javac] Compiling 1 source file to /snip/hadoop/build/contrib/fairscheduler/test [javac] /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java:128: cannot find symbol [javac] symbol : constructor ClusterStatus(int,int,int,int,int,org.apache.hadoop.mapred.JobTracker.State) [javac] location: class org.apache.hadoop.mapred.ClusterStatus [javac] return new ClusterStatus(numTrackers, maps, reduces, [javac] ^ [javac] Note: /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 1 error BUILD FAILED /snip/hadoop/build.xml:774: The following error occurred while executing this line: /snip/hadoop/src/contrib/build.xml:48: The following error occurred while executing this line: /snip/hadoop/src/contrib/build-contrib.xml:165: Compile failed; see the compiler error output for details. Total time: 1 minute 2 seconds
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/)
          . Fixes some findbugs warnings in o.a.h.mapred* packages and supresses a bunch of them. Contributed by Jothi Padmanabhan.

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/ ) . Fixes some findbugs warnings in o.a.h.mapred* packages and supresses a bunch of them. Contributed by Jothi Padmanabhan.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #817 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/)
          HADOOP-5709. Remove redundant synchronization added in . Contributed by Jothi Padmanabhan.

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #817 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/ ) HADOOP-5709 . Remove redundant synchronization added in . Contributed by Jothi Padmanabhan.
          Owen O'Malley made changes -
          Component/s mapred [ 12310690 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Jothi Padmanabhan
              Reporter:
              Jothi Padmanabhan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development