Hadoop Common
  1. Hadoop Common
  2. HADOOP-5156

TestHeartbeatHandling uses MiniDFSCluster.getNamesystem() which does not exist in branch 0.20

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.1, 0.20.0
    • Fix Version/s: 0.19.1
    • Component/s: test
    • Labels:
      None

      Description

      This breaks branch 0.20 build, which currently does not compile.
      This will probably require promoting HADOOP-5017 to branch 0.20 or simply using cluster.getNameNode().getNamesystem() in this test.

      1. hbhNS.patch
        0.8 kB
        Hairong Kuang
      2. hbhNS0.19.patch
        3 kB
        Hairong Kuang

        Activity

        Hide
        Konstantin Shvachko added a comment -
        compile-core-test:
            [javac] Compiling 7 source files to branch-0.20/build/test/classes
            [javac] Note: Some input files use unchecked or unsafe operations.
            [javac] Note: Recompile with -Xlint:unchecked for details.
            [javac] Compiling 319 source files to branch-0.20/build/test/classes
            [javac] branch-0.20/src/test/org/apache/hadoop/hdfs/server/namenode/TestHeartbeatHandling.java:30: cannot find symbol
            [javac] symbol  : method getNamesystem()
            [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster
            [javac]       final FSNamesystem namesystem = cluster.getNamesystem();
            [javac]                                              ^
            [javac] Note: Some input files use or override a deprecated API.
            [javac] Note: Recompile with -Xlint:deprecation for details.
            [javac] 1 error
        
        BUILD FAILED
        
        Show
        Konstantin Shvachko added a comment - compile-core-test: [javac] Compiling 7 source files to branch-0.20/build/test/classes [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 319 source files to branch-0.20/build/test/classes [javac] branch-0.20/src/test/org/apache/hadoop/hdfs/server/namenode/TestHeartbeatHandling.java:30: cannot find symbol [javac] symbol : method getNamesystem() [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster [javac] final FSNamesystem namesystem = cluster.getNamesystem(); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 1 error BUILD FAILED
        Hide
        Konstantin Shvachko added a comment -

        More problems with branch 0.19:

        compile-core-test:
            [javac] Compiling 7 source files to branch-0.19/build/test/classes
            [javac] Note: Some input files use unchecked or unsafe operations.
            [javac] Note: Recompile with -Xlint:unchecked for details.
            [javac] Compiling 299 source files to branch-0.19/build/test/classes
            [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/NNThroughputBenchmark.java:729: incompatible types
            [javac] found   : org.apache.hadoop.hdfs.server.protocol.DatanodeCommand[]
            [javac] required: org.apache.hadoop.hdfs.server.protocol.DatanodeCommand
            [javac]       DatanodeCommand cmd = nameNode.sendHeartbeat(
            [javac]                                                   ^
            [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/NNThroughputBenchmark.java:760: incompatible types
            [javac] found   : org.apache.hadoop.hdfs.server.protocol.DatanodeCommand[]
            [javac] required: org.apache.hadoop.hdfs.server.protocol.DatanodeCommand
            [javac]       DatanodeCommand cmd = nameNode.sendHeartbeat(
            [javac]                                                   ^
            [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/server/namenode/TestHeartbeatHandling.java:30: cannot find symbol
            [javac] symbol  : method getNamesystem()
            [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster
            [javac]       final FSNamesystem namesystem = cluster.getNamesystem();
            [javac]                                              ^
            [javac] Note: Some input files use or override a deprecated API.
            [javac] Note: Recompile with -Xlint:deprecation for details.
            [javac] 3 errors
        
        BUILD FAILED
        
        Show
        Konstantin Shvachko added a comment - More problems with branch 0.19: compile-core-test: [javac] Compiling 7 source files to branch-0.19/build/test/classes [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 299 source files to branch-0.19/build/test/classes [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/NNThroughputBenchmark.java:729: incompatible types [javac] found : org.apache.hadoop.hdfs.server.protocol.DatanodeCommand[] [javac] required: org.apache.hadoop.hdfs.server.protocol.DatanodeCommand [javac] DatanodeCommand cmd = nameNode.sendHeartbeat( [javac] ^ [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/NNThroughputBenchmark.java:760: incompatible types [javac] found : org.apache.hadoop.hdfs.server.protocol.DatanodeCommand[] [javac] required: org.apache.hadoop.hdfs.server.protocol.DatanodeCommand [javac] DatanodeCommand cmd = nameNode.sendHeartbeat( [javac] ^ [javac] branch-0.19/src/test/org/apache/hadoop/hdfs/server/namenode/TestHeartbeatHandling.java:30: cannot find symbol [javac] symbol : method getNamesystem() [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster [javac] final FSNamesystem namesystem = cluster.getNamesystem(); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 3 errors BUILD FAILED
        Hide
        Hairong Kuang added a comment -

        Here is the patch that takes the second suggested approach.

        Show
        Hairong Kuang added a comment - Here is the patch that takes the second suggested approach.
        Hide
        Hairong Kuang added a comment -

        This ia a patch for 0.19.

        Show
        Hairong Kuang added a comment - This ia a patch for 0.19.
        Hide
        Hairong Kuang added a comment -

        I've just committed this.

        Show
        Hairong Kuang added a comment - I've just committed this.

          People

          • Assignee:
            Hairong Kuang
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development