Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As stated in the comment:

        public FSNamesystem namesystem; // TODO: This should private. Use getNamesystem() instead. 
      
      1. 5017_20090112.patch
        16 kB
        Tsz Wo Nicholas Sze
      2. 5017_20090114.patch
        17 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          I forgot to post the ant test results. Here it is:

               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 44 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          

          I also tested the patch locally. Everything passed except the problem reported in HADOOP-4907.

          Show
          Tsz Wo Nicholas Sze added a comment - I forgot to post the ant test results. Here it is: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 44 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. I also tested the patch locally. Everything passed except the problem reported in HADOOP-4907 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I just committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I just committed this.
          Hide
          Konstantin Shvachko added a comment -

          +1

          Show
          Konstantin Shvachko added a comment - +1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          5017_20090114.patch: incorporated Konstantin's comments.

          Show
          Tsz Wo Nicholas Sze added a comment - 5017_20090114.patch: incorporated Konstantin's comments.
          Hide
          Konstantin Shvachko added a comment -

          I like the patch. Minor improvements:

          • getNamesystem() need a JavaDoc comment not only the return value.
          • Same in MiniDFSCluster.
            Could you please additionally remove this warning:
          • FileChecksumServlets redundant import of FSConstants
          Show
          Konstantin Shvachko added a comment - I like the patch. Minor improvements: getNamesystem() need a JavaDoc comment not only the return value. Same in MiniDFSCluster. Could you please additionally remove this warning: FileChecksumServlets redundant import of FSConstants
          Hide
          Tsz Wo Nicholas Sze added a comment -

          5017_20090112.patch: declare NameNode.namesystem as private.

          Show
          Tsz Wo Nicholas Sze added a comment - 5017_20090112.patch: declare NameNode.namesystem as private.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development