Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Removed deprecated FileSystem methods .

      Description

      Deprecated FileSystem methods like getReplication(Path src), delete(Path f), etc. should be removed.

      1. 4779_20081204.patch
        17 kB
        Tsz Wo Nicholas Sze
      2. 4779_20081218.patch
        22 kB
        Tsz Wo Nicholas Sze
      3. hadoop-4779-remaining_v1.patch
        23 kB
        Enis Soztutar

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          4779_20081204.patch: removed the following methods:

          • public short getReplication(Path src) throws IOException
          • public abstract boolean delete(Path f) throws IOException;
          • public long getLength(Path f) throws IOException
          • public long getBlockSize(Path f) throws IOException
          Show
          Tsz Wo Nicholas Sze added a comment - 4779_20081204.patch: removed the following methods: public short getReplication(Path src) throws IOException public abstract boolean delete(Path f) throws IOException; public long getLength(Path f) throws IOException public long getBlockSize(Path f) throws IOException
          Hide
          Konstantin Shvachko added a comment -

          +1.
          There are some redundant imports in files you modify. Would be good to remove them as well.
          Should be marked as incompatible change.

          Show
          Konstantin Shvachko added a comment - +1. There are some redundant imports in files you modify. Would be good to remove them as well. Should be marked as incompatible change.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          4779_20081218.patch: removed unused imports and updated with trunk.

          Show
          Tsz Wo Nicholas Sze added a comment - 4779_20081218.patch: removed unused imports and updated with trunk.
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 18 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to cause Findbugs to fail.
               [exec] 
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          

          The detail findbugs report (newPatchFindbugsWarnings.html) does not contain any warning. I suspect the test-patch script does not work correctly in this patch.

          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 18 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to cause Findbugs to fail. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. The detail findbugs report (newPatchFindbugsWarnings.html) does not contain any warning. I suspect the test-patch script does not work correctly in this patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Tested locally, only TestMapReduceLocal failed but it is not related, see HADOOP-4907.

          Show
          Tsz Wo Nicholas Sze added a comment - Tested locally, only TestMapReduceLocal failed but it is not related, see HADOOP-4907 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I just committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I just committed this.
          Hide
          Enis Soztutar added a comment -

          Usage of the fs.delete(Path) method in datajoin causes compile error. Attaching one liner patch to fix it.

          Show
          Enis Soztutar added a comment - Usage of the fs.delete(Path) method in datajoin causes compile error. Attaching one liner patch to fix it.
          Hide
          Amareshwari Sriramadasu added a comment -

          Not just data_join, compilation for many more contrib projects is failing, like failmon, index, streaming etc.

          Show
          Amareshwari Sriramadasu added a comment - Not just data_join, compilation for many more contrib projects is failing, like failmon, index, streaming etc.
          Hide
          Enis Soztutar added a comment -

          Right, should have run ant clean first. I'm working on the patch.

          Show
          Enis Soztutar added a comment - Right, should have run ant clean first. I'm working on the patch.
          Hide
          Enis Soztutar added a comment -

          Attached patch

          • fixes contrib usages of fs.delete(Path)
          • deprecates ClientProtocol#delete(Path)
          • removes InMemoryFileSystem#delete(Path)
          • adds int recursive argument to delete() in libhdfs
          Show
          Enis Soztutar added a comment - Attached patch fixes contrib usages of fs.delete(Path) deprecates ClientProtocol#delete(Path) removes InMemoryFileSystem#delete(Path) adds int recursive argument to delete() in libhdfs
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have reverted 4779_20081218.patch.

          Show
          Tsz Wo Nicholas Sze added a comment - I have reverted 4779_20081218.patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Since there are quite a few deprecated FileSystem methods and some of them are quite involved, let's create sub-issues for removing them.

          Show
          Tsz Wo Nicholas Sze added a comment - Since there are quite a few deprecated FileSystem methods and some of them are quite involved, let's create sub-issues for removing them.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          All deprecated methods are removed except getStatistics(Class<? extends FileSystem> cls) which was deprecated in 0.20 and cannot be removed it in 0.21. Closing this.

          Show
          Tsz Wo Nicholas Sze added a comment - All deprecated methods are removed except getStatistics(Class<? extends FileSystem> cls) which was deprecated in 0.20 and cannot be removed it in 0.21. Closing this.
          Hide
          Robert Chansler added a comment -

          Editorial pass over all release notes prior to publication of 0.21.

          Show
          Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
          Hide
          Eli Collins added a comment -

          Linking in the jira where these were added back.

          Show
          Eli Collins added a comment - Linking in the jira where these were added back.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development