Hadoop Common
  1. Hadoop Common
  2. HADOOP-4779 Remove deprecated FileSystem methods
  3. HADOOP-4941

Remove getBlockSize(Path f), getLength(Path f) and getReplication(Path src)

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed deprecated FileSystem methods getBlockSize(Path f), getLength(Path f), and getReplication(Path src).

      Description

      Remove the following

      • public long getBlockSize(Path f) throws IOException
      • public long getLength(Path f) throws IOException
      • public short getReplication(Path src) throws IOException
      1. 4941_20081224.patch
        13 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Robert Chansler added a comment -

        Editorial pass over all release notes prior to publication of 0.21.

        Show
        Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #707 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/707/)
        . Remove deprecated FileSystem methods: getBlockSize(Path f), getLength(Path f) and getReplication(Path src). (szetszwo)

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #707 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/707/ ) . Remove deprecated FileSystem methods: getBlockSize(Path f), getLength(Path f) and getReplication(Path src). (szetszwo)
        Hide
        Suresh Srinivas added a comment -

        Looks like there was some problem with my build area. +1 for the patch.

        Show
        Suresh Srinivas added a comment - Looks like there was some problem with my build area. +1 for the patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I just committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I just committed this.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > I got a compile error src/contrib/streaming/src/java/org/apache/hadoop/streaming/StreamUtil.java. fs.getLength(p) should be changed to {fs.getFileStatus(p).getLen();}}

        Is it already in 4941_20081224.patch? I tried "ant tar". Everything can be compiled.

        I tested the patch in my machine. Only TestMapReduceLocal failed. See HADOOP-4907.

        Show
        Tsz Wo Nicholas Sze added a comment - > I got a compile error src/contrib/streaming/src/java/org/apache/hadoop/streaming/StreamUtil.java. fs.getLength(p) should be changed to {fs.getFileStatus(p).getLen();}} Is it already in 4941_20081224.patch? I tried "ant tar". Everything can be compiled. I tested the patch in my machine. Only TestMapReduceLocal failed. See HADOOP-4907 .
        Hide
        Suresh Srinivas added a comment -

        I got a compile error src/contrib/streaming/src/java/org/apache/hadoop/streaming/StreamUtil.java. fs.getLength(p) should be changed to {fs.getFileStatus(p).getLen();}}

        Show
        Suresh Srinivas added a comment - I got a compile error src/contrib/streaming/src/java/org/apache/hadoop/streaming/StreamUtil.java. fs.getLength(p) should be changed to {fs.getFileStatus(p).getLen();}}
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 12 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        
        Show
        Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        Hide
        Suresh Srinivas added a comment -

        +1. Patch looks good.

        Show
        Suresh Srinivas added a comment - +1. Patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        4941_20081224.patch: remove the deprecated methods.

        Show
        Tsz Wo Nicholas Sze added a comment - 4941_20081224.patch: remove the deprecated methods.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development