[HADOOP-17138] Fix spotbugs warnings surfaced after upgrade to 4.0.6

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.1, 3.4.0, 3.2.3
• Fix Version/s: 3.3.1, 3.4.0, 3.2.3
• Component/s: build
• Labels: pull-request-available
• Target Version/s: 3.3.1, 3.4.0, 3.2.3
• Hadoop Flags: Reviewed
• Assignee: Masatake Iwasaki
• Reporter: Masatake Iwasaki
• Created: 17/Jul/20 11:04
• Updated: 11/Feb/24 12:54
• Resolved: 22/Jul/20 04:41

Description

Spotbugs 4.0.6 generated additional warnings.

$ find . -name findbugsXml.xml | xargs -n 1 /opt/spotbugs-4.0.6/bin/convertXmlToText -longBugCodes
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String)  At Server.java:[line 3729]
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String)  At Server.java:[line 3717]
H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(Object) overrides the nullness annotation of parameter $L1 in an incompatible way  At DatasetVolumeChecker.java:[line 322]
H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(VolumeCheckResult) overrides the nullness annotation of parameter result in an incompatible way  At DatasetVolumeChecker.java:[lines 358-376]
M D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$2.onSuccess(Object) overrides the nullness annotation of parameter result in an incompatible way  At ThrottledAsyncChecker.java:[lines 170-175]
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L8 in org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.incrOpCount(FSEditLogOpCodes, EnumMap, Step, StartupProgress$Counter)  At FSEditLogLoader.java:[line 1241]
M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be non-null but is marked as nullable  At LocatedFileStatusFetcher.java:[lines 380-397]
M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be non-null but is marked as nullable  At LocatedFileStatusFetcher.java:[lines 291-309]
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L6 in org.apache.hadoop.yarn.sls.SLSRunner.increaseQueueAppNum(String)  At SLSRunner.java:[line 816]
H C UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS UMAC: Uncallable method org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance() defined in anonymous class  At TestTimelineReaderWebServicesHBaseStorage.java:[line 87]
M D DLS_DEAD_LOCAL_STORE DLS: Dead store to entities in org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl)  At TestTimelineReaderHBaseDown.java:[line 190]
M V EI_EXPOSE_REP EI: org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may expose internal representation by returning CosNInputStream$ReadBuffer.buffer  At CosNInputStream.java:[line 87]

Issue Links

• is caused by: HADOOP-16866 Upgrade spotbugs to 4.0.6
• links to: GitHub Pull Request #2155
• links to: GitHub Pull Request #2538
• links to: GitHub Pull Request #2806