Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-17138

Fix spotbugs warnings surfaced after upgrade to 4.0.6

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      Spotbugs 4.0.6 generated additional warnings.

      $ find . -name findbugsXml.xml | xargs -n 1 /opt/spotbugs-4.0.6/bin/convertXmlToText -longBugCodes
      M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String)  At Server.java:[line 3729]
      M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String)  At Server.java:[line 3717]
      H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(Object) overrides the nullness annotation of parameter $L1 in an incompatible way  At DatasetVolumeChecker.java:[line 322]
      H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(VolumeCheckResult) overrides the nullness annotation of parameter result in an incompatible way  At DatasetVolumeChecker.java:[lines 358-376]
      M D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$2.onSuccess(Object) overrides the nullness annotation of parameter result in an incompatible way  At ThrottledAsyncChecker.java:[lines 170-175]
      M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L8 in org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.incrOpCount(FSEditLogOpCodes, EnumMap, Step, StartupProgress$Counter)  At FSEditLogLoader.java:[line 1241]
      M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be non-null but is marked as nullable  At LocatedFileStatusFetcher.java:[lines 380-397]
      M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be non-null but is marked as nullable  At LocatedFileStatusFetcher.java:[lines 291-309]
      M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L6 in org.apache.hadoop.yarn.sls.SLSRunner.increaseQueueAppNum(String)  At SLSRunner.java:[line 816]
      H C UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS UMAC: Uncallable method org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance() defined in anonymous class  At TestTimelineReaderWebServicesHBaseStorage.java:[line 87]
      M D DLS_DEAD_LOCAL_STORE DLS: Dead store to entities in org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl)  At TestTimelineReaderHBaseDown.java:[line 190]
      M V EI_EXPOSE_REP EI: org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may expose internal representation by returning CosNInputStream$ReadBuffer.buffer  At CosNInputStream.java:[line 87]
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            iwasakims Masatake Iwasaki
            iwasakims Masatake Iwasaki
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 10m
                2h 10m

                Slack

                  Issue deployment