[HADOOP-16866] Upgrade spotbugs to 4.0.6

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Masatake Iwasaki
• Reporter: Tsuyoshi Ozawa
• Created: 18/Feb/20 04:53
• Updated: 17/Jul/20 11:16
• Resolved: 17/Jul/20 11:06

Description

https://github.com/spotbugs/spotbugs/releases

spotbugs 4.0.0 is now released. 

 

We can upgrade spotbugs' version to:

1. 3.1.12  (conservative option)

2. 4.0.0 (which might includes incompatible changes, according to the migration guide: https://spotbugs.readthedocs.io/en/stable/migration.html)

 

Step by step approach is also acceptable.

Issue Links

• causes: HADOOP-17138 Fix spotbugs warnings surfaced after upgrade to 4.0.6
• is blocked by: HADOOP-16869 Upgrade findbugs-maven-plugin to 3.0.5 to fix mvn findbugs:findbugs failure
• is related to: HADOOP-14316 Switch from Findbugs to Spotbugs
• links to: GitHub Pull Request #2146