Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14663 Switch to OpenClover
  3. HADOOP-15376

Remove double semi colons on imports that make Clover fall over.

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.0, 3.1.1
    • None
    • None
    • Reviewed

    Description

      Clover will fall over if there are double semicolons on imports.

      The error looks like:

      [INFO] Clover free edition.
      [INFO] Updating existing database at '/Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/target/clover/clover.db'.
      [INFO] Processing files at 1.8 source level.
      [INFO] /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'
      [INFO] Instrumentation error
      com.atlassian.clover.api.CloverException: /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'

       

      Thankfully we only have one location with this:

      $ find . -name \*.java -exec grep '^import .*;;' {} +
      ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:import org.apache.commons.io.FileUtils;;

       

      Attachments

        1. HADOOP-15376.01.patch
          0.7 kB
          Ewan Higgs

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ehiggs Ewan Higgs
            ehiggs Ewan Higgs
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment