[HADOOP-15376] Remove double semi colons on imports that make Clover fall over.

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1
• Hadoop Flags: Reviewed
• Assignee: Ewan Higgs
• Reporter: Ewan Higgs
• Created: 10/Apr/18 09:19
• Updated: 10/Apr/18 15:19
• Resolved: 10/Apr/18 15:00

Description

Clover will fall over if there are double semicolons on imports.

The error looks like:

[INFO] Clover free edition.
[INFO] Updating existing database at '/Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/target/clover/clover.db'.
[INFO] Processing files at 1.8 source level.
[INFO] /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'
[INFO] Instrumentation error
com.atlassian.clover.api.CloverException: /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'

 

Thankfully we only have one location with this:

$ find . -name \*.java -exec grep '^import .*;;' {} +
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:import org.apache.commons.io.FileUtils;;

 

Issue Links

• is broken by: HADOOP-14788 Credentials readTokenStorageFile to stop wrapping IOEs in IOEs