Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14663 Switch to OpenClover
  3. HADOOP-15376

Remove double semi colons on imports that make Clover fall over.

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0, 3.1.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Clover will fall over if there are double semicolons on imports.

      The error looks like:

      [INFO] Clover free edition.
      [INFO] Updating existing database at '/Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/target/clover/clover.db'.
      [INFO] Processing files at 1.8 source level.
      [INFO] /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'
      [INFO] Instrumentation error
      com.atlassian.clover.api.CloverException: /Users/ehiggs/src/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:43:1:expecting EOF, found 'import'

       

      Thankfully we only have one location with this:

      $ find . -name \*.java -exec grep '^import .*;;' {} +
      ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java:import org.apache.commons.io.FileUtils;;

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ehiggs Ewan Higgs
                Reporter:
                ehiggs Ewan Higgs
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: