Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      AMRMClient#waitFor and AMRMClientAsync#waitFor now take java.util.function.Supplier as an argument, rather than com.google.common.base.Supplier.

      Description

      Remove the Guava library Supplier usage in user facing API's in AMRMClient.java and AMRMClientAsync.java

      1. HADOOP-14847.patch
        6 kB
        Bharat Viswanadham

        Activity

        Hide
        bharatviswa Bharat Viswanadham added a comment - - edited

        Updated the code to use java supplier.

        Vinod Kumar Vavilapalli Tsuyoshi Ozawa Junping Du Could you please review the changes.

        Show
        bharatviswa Bharat Viswanadham added a comment - - edited Updated the code to use java supplier. Vinod Kumar Vavilapalli Tsuyoshi Ozawa Junping Du Could you please review the changes.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 14m 38s trunk passed
        +1 compile 0m 22s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 findbugs 0m 31s trunk passed
        +1 javadoc 0m 14s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 22s the patch passed
        +1 javac 0m 22s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 42s the patch passed
        +1 javadoc 0m 12s the patch passed
              Other Tests
        +1 unit 20m 45s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 14s The patch does not generate ASF License warnings.
        41m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HADOOP-14847
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885905/HADOOP-14847.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 17c737d60fb1 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 83449ab
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13197/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13197/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 38s trunk passed +1 compile 0m 22s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 23s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 14s trunk passed       Patch Compile Tests +1 mvninstall 0m 23s the patch passed +1 compile 0m 22s the patch passed +1 javac 0m 22s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 12s the patch passed       Other Tests +1 unit 20m 45s hadoop-yarn-client in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 41m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HADOOP-14847 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885905/HADOOP-14847.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17c737d60fb1 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 83449ab Default Java 1.8.0_144 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13197/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13197/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Bharat Viswanadham for the patch! LGTM +1. Will commit it tomorrow unless there is future comment.

        Show
        haibochen Haibo Chen added a comment - Thanks Bharat Viswanadham for the patch! LGTM +1. Will commit it tomorrow unless there is future comment.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Bharat Viswanadham for your contribution. I have committed it to trunk and branch-3.0

        Show
        haibochen Haibo Chen added a comment - Thanks Bharat Viswanadham for your contribution. I have committed it to trunk and branch-3.0
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Haibo Chen, you forgot to set the fix-version.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Haibo Chen , you forgot to set the fix-version.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12827 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12827/)
        HADOOP-14847. Remove Guava Supplier and change to java Supplier in (haibochen: rev 8edc60531fec4f4070955b3e82a78ba70ba40ec0)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/AMRMClientAsync.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12827 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12827/ ) HADOOP-14847 . Remove Guava Supplier and change to java Supplier in (haibochen: rev 8edc60531fec4f4070955b3e82a78ba70ba40ec0) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/AMRMClientAsync.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java
        Hide
        haibochen Haibo Chen added a comment -

        Thanks for the reminder, Vinod Kumar Vavilapalli. Will do now.

        Show
        haibochen Haibo Chen added a comment - Thanks for the reminder, Vinod Kumar Vavilapalli . Will do now.

          People

          • Assignee:
            bharatviswa Bharat Viswanadham
            Reporter:
            bharatviswa Bharat Viswanadham
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development