Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14804

correct wrong parameters format order in core-default.xml

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1, 3.1.0
    • Component/s: None
    • Labels:
      None

      Description

      descriptions of "HTTP CORS" parameters is before the names:
      <property>
      <description>Comma separated list of headers that are allowed for web
      services needing cross-origin (CORS) support.</description>
      <name>hadoop.http.cross-origin.allowed-headers</name>
      <value>X-Requested-With,Content-Type,Accept,Origin</value>
      </property>
      ..........
      but they should be following value as others.

      1. HADOOP-14804.001.patch
        3 kB
        Chen Hongfei
      2. HADOOP-14804.002.patch
        4 kB
        Chen Hongfei
      3. HADOOP-14804.003.patch
        10 kB
        Chen Hongfei

        Activity

        Hide
        vagarychen Chen Liang added a comment -

        Thanks Chen Hongfei for the catch!

        It seems there are several more places that have the same issue, such as (but not limited to)

        hadoop.http.staticuser.user
        hadoop.registry.rm.enabled
        hadoop.registry.zk.root
        
        Show
        vagarychen Chen Liang added a comment - Thanks Chen Hongfei for the catch! It seems there are several more places that have the same issue, such as (but not limited to) hadoop.http.staticuser.user hadoop.registry.rm.enabled hadoop.registry.zk.root
        Hide
        Hongfei Chen Chen Hongfei added a comment -

        Thanks Chen Liang !
        I have added the three param into this patch.

        Show
        Hongfei Chen Chen Hongfei added a comment - Thanks Chen Liang ! I have added the three param into this patch.
        Hide
        Hongfei Chen Chen Hongfei added a comment -

        Oh My God,I find some more places again :

        hadoop.registry.zk.session.timeout.ms
        hadoop.registry.zk.connection.timeout.ms
        hadoop.registry.zk.retry.times
        hadoop.registry.zk.retry.interval.ms
        hadoop.registry.zk.retry.ceiling.ms
        hadoop.registry.zk.quorum
        hadoop.registry.secure
        hadoop.registry.system.acls
        hadoop.registry.kerberos.realm
        hadoop.registry.jaas.context
        hadoop.shell.missing.defaultFs.warning

        hadoop.http.logs.enabled

        hadoop.zk.address
        hadoop.zk.num-retries
        hadoop.zk.retry-interval-ms
        hadoop.zk.timeout-ms
        hadoop.zk.acl
        hadoop.zk.auth

        Show
        Hongfei Chen Chen Hongfei added a comment - Oh My God,I find some more places again : hadoop.registry.zk.session.timeout.ms hadoop.registry.zk.connection.timeout.ms hadoop.registry.zk.retry.times hadoop.registry.zk.retry.interval.ms hadoop.registry.zk.retry.ceiling.ms hadoop.registry.zk.quorum hadoop.registry.secure hadoop.registry.system.acls hadoop.registry.kerberos.realm hadoop.registry.jaas.context hadoop.shell.missing.defaultFs.warning hadoop.http.logs.enabled hadoop.zk.address hadoop.zk.num-retries hadoop.zk.retry-interval-ms hadoop.zk.timeout-ms hadoop.zk.acl hadoop.zk.auth
        Hide
        Hongfei Chen Chen Hongfei added a comment -

        Now this patch should be corrected all places in core-default.xml .

        Show
        Hongfei Chen Chen Hongfei added a comment - Now this patch should be corrected all places in core-default.xml .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 20s trunk passed
        +1 compile 17m 39s trunk passed
        +1 mvnsite 1m 17s trunk passed
        +1 javadoc 1m 1s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 55s the patch passed
        +1 compile 13m 53s the patch passed
        +1 javac 13m 53s the patch passed
        +1 mvnsite 1m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 0s the patch passed
              Other Tests
        -1 unit 9m 56s hadoop-common in the patch failed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        63m 17s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HADOOP-14804
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885508/HADOOP-14804.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 93bfa711a095 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b3a4d7d
        Default Java 1.8.0_144
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 20s trunk passed +1 compile 17m 39s trunk passed +1 mvnsite 1m 17s trunk passed +1 javadoc 1m 1s trunk passed       Patch Compile Tests +1 mvninstall 0m 55s the patch passed +1 compile 13m 53s the patch passed +1 javac 13m 53s the patch passed +1 mvnsite 1m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 0s the patch passed       Other Tests -1 unit 9m 56s hadoop-common in the patch failed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 63m 17s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HADOOP-14804 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885508/HADOOP-14804.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 93bfa711a095 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b3a4d7d Default Java 1.8.0_144 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13205/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Hongfei Chen Chen Hongfei added a comment -

        Chen Liang This patch has no errors, can you help me to submit this patch? thanks~

        Show
        Hongfei Chen Chen Hongfei added a comment - Chen Liang This patch has no errors, can you help me to submit this patch? thanks~
        Hide
        vagarychen Chen Liang added a comment -

        Thanks Chen Hongfei for the followup, I've committed to trunk and branch-3.0. Thanks for the contribution!

        Show
        vagarychen Chen Liang added a comment - Thanks Chen Hongfei for the followup, I've committed to trunk and branch-3.0. Thanks for the contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12860 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12860/)
        HADOOP-14804. correct wrong parameters format order in core-default.xml. (cliang: rev 10b2cfa96cec8582799c9ae864dfb4eb8a42aeb7)

        • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12860 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12860/ ) HADOOP-14804 . correct wrong parameters format order in core-default.xml. (cliang: rev 10b2cfa96cec8582799c9ae864dfb4eb8a42aeb7) (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml

          People

          • Assignee:
            Hongfei Chen Chen Hongfei
            Reporter:
            Hongfei Chen Chen Hongfei
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development