Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14754

TestCommonConfigurationFields failed: core-default.xml has 2 wasb properties missing in classes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0, 3.0.0-beta1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: common, fs/azure
    • Labels:
      None

      Description

      https://builds.apache.org/job/PreCommit-HADOOP-Build/13004/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt:

      core-default.xml has 2 properties missing in  class org.apache.hadoop.fs.CommonConfigurationKeys
        class org.apache.hadoop.fs.CommonConfigurationKeysPublic  class org.apache.hadoop.fs.local.LocalConfigKeys
        class org.apache.hadoop.fs.ftp.FtpConfigKeys  class org.apache.hadoop.ha.SshFenceByTcpPort
        class org.apache.hadoop.security.LdapGroupsMapping  class org.apache.hadoop.ha.ZKFailoverController
        class org.apache.hadoop.security.ssl.SSLFactory  class org.apache.hadoop.security.CompositeGroupsMapping
        class org.apache.hadoop.io.erasurecode.CodecUtil
      

      Unfortunately, it does not show which 2 properties missing. A manual test run revealed these 2 wasb properties recently added by HADOOP-14183:

        fs.wasbs.impl
        fs.wasb.impl
      

        Issue Links

          Activity

          Hide
          jzhuge John Zhuge added a comment -

          Thanks Steve Loughran for the review and commit!

          Show
          jzhuge John Zhuge added a comment - Thanks Steve Loughran for the review and commit!
          Hide
          aw Allen Wittenauer added a comment -

          Just need to add a custom test to the hadoop personality.

          Ironically, that still wouldn't have helped here given that precommit wasn't allowed to run before the breaking patch was committed....

          Show
          aw Allen Wittenauer added a comment - Just need to add a custom test to the hadoop personality. Ironically, that still wouldn't have helped here given that precommit wasn't allowed to run before the breaking patch was committed....
          Hide
          jzhuge John Zhuge added a comment -

          My fault as well. Failed to detect it in code review.

          Allen Wittenauer Can we add a rule to Yetus so that TestCommonConfigurationFields is run whenever core-default.xml is changed?

          Show
          jzhuge John Zhuge added a comment - My fault as well. Failed to detect it in code review. Allen Wittenauer Can we add a rule to Yetus so that TestCommonConfigurationFields is run whenever core-default.xml is changed?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12164 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12164/)
          HADOOP-14754. TestCommonConfigurationFields failed: core-default.xml has (stevel: rev d964062f66c0772f4b1a029bfcdff921fbaaf91c)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12164 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12164/ ) HADOOP-14754 . TestCommonConfigurationFields failed: core-default.xml has (stevel: rev d964062f66c0772f4b1a029bfcdff921fbaaf91c) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          This was my fault. sorry.

          What are we meant to do when adding new props to core-default? That is, what's our policy/process for making matching changes here?

          Show
          stevel@apache.org Steve Loughran added a comment - This was my fault. sorry. What are we meant to do when adding new props to core-default? That is, what's our policy/process for making matching changes here?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          jzhuge John Zhuge added a comment -

          TestRaceWhenRelogin failure is unrelated.

          Show
          jzhuge John Zhuge added a comment - TestRaceWhenRelogin failure is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 18m 16s trunk passed
          +1 compile 21m 19s trunk passed
          +1 checkstyle 0m 49s trunk passed
          +1 mvnsite 1m 57s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 1m 5s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 53s the patch passed
          +1 compile 16m 12s the patch passed
          +1 javac 16m 12s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 1m 51s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 1m 6s the patch passed
                Other Tests
          -1 unit 8m 20s hadoop-common in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          79m 51s



          Reason Tests
          Failed junit tests hadoop.security.TestRaceWhenRelogin



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14754
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881378/HADOOP-14754.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 06b4135cf5a9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a32e013
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 18m 16s trunk passed +1 compile 21m 19s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 57s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 5s trunk passed       Patch Compile Tests +1 mvninstall 0m 53s the patch passed +1 compile 16m 12s the patch passed +1 javac 16m 12s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 1m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 1m 6s the patch passed       Other Tests -1 unit 8m 20s hadoop-common in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 79m 51s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14754 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881378/HADOOP-14754.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 06b4135cf5a9 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a32e013 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13006/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Add WASB entries to TestCommonConfigurationFields
          Show
          jzhuge John Zhuge added a comment - Patch 001 Add WASB entries to TestCommonConfigurationFields

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development