Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      The deprecated FileStatus::isDir method has been marked as final. FileSystems should override FileStatus::isDirectory

      Description

      FileStatus#isDir was deprecated in 0.21 (HADOOP-6585).

      1. HADOOP-14726.000.patch
        24 kB
        Chris Douglas
      2. HADOOP-14726.001.patch
        26 kB
        Chris Douglas
      3. HADOOP-14726.002.patch
        26 kB
        Chris Douglas
      4. HADOOP-14726.003.patch
        25 kB
        Chris Douglas
      5. HADOOP-14726.004.patch
        25 kB
        Chris Douglas

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12187 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12187/)
        HADOOP-14726. Mark FileStatus::isDir as final (cdouglas: rev 645a8f2a4d09acb5a21820f52ee78784d9e4cc8a)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
        • (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/snative/SwiftFileStatus.java
        • (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemDirectories.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemPartitionedUploads.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestCombineFileInputFormat.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3Utils.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestOutOfBandAzureBlobOperations.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
        • (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/snative/SwiftNativeFileSystemStore.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsFileStatus.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestInitializeSharedEdits.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12187 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12187/ ) HADOOP-14726 . Mark FileStatus::isDir as final (cdouglas: rev 645a8f2a4d09acb5a21820f52ee78784d9e4cc8a) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/snative/SwiftFileStatus.java (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemDirectories.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java (edit) hadoop-tools/hadoop-openstack/src/test/java/org/apache/hadoop/fs/swift/TestSwiftFileSystemPartitionedUploads.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestCombineFileInputFormat.java (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3Utils.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestOutOfBandAzureBlobOperations.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStartup.java (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/snative/SwiftNativeFileSystemStore.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsFileStatus.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestInitializeSharedEdits.java
        Hide
        chris.douglas Chris Douglas added a comment -

        I committed this. Thanks for the review, Steve Loughran

        Show
        chris.douglas Chris Douglas added a comment - I committed this. Thanks for the review, Steve Loughran
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM

        +1

        (I know the TestCommonConfigurationFields is unrelated (& now fixed)); others seem unrelated too

        Show
        stevel@apache.org Steve Loughran added a comment - LGTM +1 (I know the TestCommonConfigurationFields is unrelated (& now fixed)); others seem unrelated too
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 22m 37s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 28s Maven dependency ordering for branch
        +1 mvninstall 14m 59s trunk passed
        +1 compile 17m 2s trunk passed
        +1 checkstyle 2m 15s trunk passed
        +1 mvnsite 5m 22s trunk passed
        -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 3m 43s trunk passed
              Patch Compile Tests
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 3m 53s the patch passed
        +1 compile 12m 52s the patch passed
        +1 javac 12m 52s root generated 0 new + 1352 unchanged - 22 fixed = 1352 total (was 1374)
        +1 checkstyle 2m 13s root: The patch generated 0 new + 582 unchanged - 5 fixed = 582 total (was 587)
        +1 mvnsite 5m 24s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 10m 8s the patch passed
        +1 javadoc 5m 2s the patch passed
              Other Tests
        -1 unit 8m 45s hadoop-common in the patch failed.
        +1 unit 1m 47s hadoop-hdfs-client in the patch passed.
        -1 unit 109m 12s hadoop-hdfs in the patch failed.
        +1 unit 2m 24s hadoop-hdfs-nfs in the patch passed.
        +1 unit 106m 26s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 unit 0m 36s hadoop-openstack in the patch passed.
        +1 unit 2m 26s hadoop-azure in the patch passed.
        +1 asflicense 0m 53s The patch does not generate ASF License warnings.
        370m 59s



        Reason Tests
        Failed junit tests hadoop.conf.TestCommonConfigurationFields
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.server.namenode.TestAuditLogs
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14726
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881359/HADOOP-14726.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 95ab25046ae8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a32e013
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 22m 37s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.       trunk Compile Tests 0 mvndep 1m 28s Maven dependency ordering for branch +1 mvninstall 14m 59s trunk passed +1 compile 17m 2s trunk passed +1 checkstyle 2m 15s trunk passed +1 mvnsite 5m 22s trunk passed -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 56s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 43s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 3m 53s the patch passed +1 compile 12m 52s the patch passed +1 javac 12m 52s root generated 0 new + 1352 unchanged - 22 fixed = 1352 total (was 1374) +1 checkstyle 2m 13s root: The patch generated 0 new + 582 unchanged - 5 fixed = 582 total (was 587) +1 mvnsite 5m 24s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 10m 8s the patch passed +1 javadoc 5m 2s the patch passed       Other Tests -1 unit 8m 45s hadoop-common in the patch failed. +1 unit 1m 47s hadoop-hdfs-client in the patch passed. -1 unit 109m 12s hadoop-hdfs in the patch failed. +1 unit 2m 24s hadoop-hdfs-nfs in the patch passed. +1 unit 106m 26s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 0m 36s hadoop-openstack in the patch passed. +1 unit 2m 26s hadoop-azure in the patch passed. +1 asflicense 0m 53s The patch does not generate ASF License warnings. 370m 59s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14726 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881359/HADOOP-14726.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 95ab25046ae8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a32e013 Default Java 1.8.0_144 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13003/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        Fixed the checkstyle warning. Steve Loughran or Andrew Wang, could you give this a quick look?

        Show
        chris.douglas Chris Douglas added a comment - Fixed the checkstyle warning. Steve Loughran or Andrew Wang , could you give this a quick look?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 15m 52s trunk passed
        +1 compile 16m 26s trunk passed
        +1 checkstyle 2m 14s trunk passed
        +1 mvnsite 5m 40s trunk passed
        -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 2m 8s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 3m 35s trunk passed
              Patch Compile Tests
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 3m 27s the patch passed
        +1 compile 10m 42s the patch passed
        +1 javac 10m 42s root generated 0 new + 1355 unchanged - 22 fixed = 1355 total (was 1377)
        -0 checkstyle 2m 10s root: The patch generated 1 new + 582 unchanged - 5 fixed = 583 total (was 587)
        +1 mvnsite 5m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 8m 30s the patch passed
        +1 javadoc 3m 51s the patch passed
              Other Tests
        -1 unit 8m 12s hadoop-common in the patch failed.
        +1 unit 1m 30s hadoop-hdfs-client in the patch passed.
        -1 unit 67m 0s hadoop-hdfs in the patch failed.
        +1 unit 2m 21s hadoop-hdfs-nfs in the patch passed.
        +1 unit 101m 59s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 unit 0m 34s hadoop-openstack in the patch passed.
        +1 unit 2m 31s hadoop-azure in the patch passed.
        +1 asflicense 0m 44s The patch does not generate ASF License warnings.
        294m 54s



        Reason Tests
        Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem
          hadoop.security.TestKDiag
          hadoop.net.TestDNS
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14726
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880906/HADOOP-14726.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b448023c4e26 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e0c2414
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.       trunk Compile Tests 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 15m 52s trunk passed +1 compile 16m 26s trunk passed +1 checkstyle 2m 14s trunk passed +1 mvnsite 5m 40s trunk passed -1 findbugs 1m 47s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 2m 8s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 35s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 3m 27s the patch passed +1 compile 10m 42s the patch passed +1 javac 10m 42s root generated 0 new + 1355 unchanged - 22 fixed = 1355 total (was 1377) -0 checkstyle 2m 10s root: The patch generated 1 new + 582 unchanged - 5 fixed = 583 total (was 587) +1 mvnsite 5m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 30s the patch passed +1 javadoc 3m 51s the patch passed       Other Tests -1 unit 8m 12s hadoop-common in the patch failed. +1 unit 1m 30s hadoop-hdfs-client in the patch passed. -1 unit 67m 0s hadoop-hdfs in the patch failed. +1 unit 2m 21s hadoop-hdfs-nfs in the patch passed. +1 unit 101m 59s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 0m 34s hadoop-openstack in the patch passed. +1 unit 2m 31s hadoop-azure in the patch passed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 294m 54s Reason Tests Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem   hadoop.security.TestKDiag   hadoop.net.TestDNS   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14726 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880906/HADOOP-14726.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b448023c4e26 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e0c2414 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12987/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        Some of the test failures are related to the FileStatus::toString changes. It looks like it's exposing a bug, so I'll revert it for this JIRA.

        Show
        chris.douglas Chris Douglas added a comment - Some of the test failures are related to the FileStatus::toString changes. It looks like it's exposing a bug, so I'll revert it for this JIRA.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 15m 6s trunk passed
        +1 compile 15m 45s trunk passed
        +1 checkstyle 2m 17s trunk passed
        +1 mvnsite 5m 17s trunk passed
        -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 1m 59s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 3m 43s trunk passed
              Patch Compile Tests
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 3m 53s the patch passed
        +1 compile 10m 31s the patch passed
        +1 javac 10m 31s root generated 0 new + 1355 unchanged - 22 fixed = 1355 total (was 1377)
        +1 checkstyle 2m 4s root: The patch generated 0 new + 582 unchanged - 5 fixed = 582 total (was 587)
        +1 mvnsite 5m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 8m 19s the patch passed
        +1 javadoc 3m 57s the patch passed
              Other Tests
        -1 unit 8m 6s hadoop-common in the patch failed.
        +1 unit 1m 24s hadoop-hdfs-client in the patch passed.
        -1 unit 65m 18s hadoop-hdfs in the patch failed.
        +1 unit 2m 1s hadoop-hdfs-nfs in the patch passed.
        +1 unit 98m 35s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 unit 0m 37s hadoop-openstack in the patch passed.
        +1 unit 2m 28s hadoop-azure in the patch passed.
        +1 asflicense 0m 43s The patch does not generate ASF License warnings.
        287m 9s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag
          hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
          hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
          hadoop.net.TestDNS
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14726
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880787/HADOOP-14726.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 017c12ae9e63 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 55a181f
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.       trunk Compile Tests 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 15m 6s trunk passed +1 compile 15m 45s trunk passed +1 checkstyle 2m 17s trunk passed +1 mvnsite 5m 17s trunk passed -1 findbugs 1m 32s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 59s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 43s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 3m 53s the patch passed +1 compile 10m 31s the patch passed +1 javac 10m 31s root generated 0 new + 1355 unchanged - 22 fixed = 1355 total (was 1377) +1 checkstyle 2m 4s root: The patch generated 0 new + 582 unchanged - 5 fixed = 582 total (was 587) +1 mvnsite 5m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 19s the patch passed +1 javadoc 3m 57s the patch passed       Other Tests -1 unit 8m 6s hadoop-common in the patch failed. +1 unit 1m 24s hadoop-hdfs-client in the patch passed. -1 unit 65m 18s hadoop-hdfs in the patch failed. +1 unit 2m 1s hadoop-hdfs-nfs in the patch passed. +1 unit 98m 35s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 0m 37s hadoop-openstack in the patch passed. +1 unit 2m 28s hadoop-azure in the patch passed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 287m 9s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem   hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem   hadoop.net.TestDNS   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14726 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880787/HADOOP-14726.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 017c12ae9e63 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 55a181f Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12980/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        OK. v002 makes isDir final.

        Show
        chris.douglas Chris Douglas added a comment - OK. v002 makes isDir final.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Who overrides isDir internally? Do we? If so, this is only external FS clients we have to worry about.

        People doing filesystems will have to assume they need to rebuild/retest on Hadoop 3. anyway

        I'm +1 for making it final in Hadoop 3.

        Show
        stevel@apache.org Steve Loughran added a comment - Who overrides isDir internally? Do we? If so, this is only external FS clients we have to worry about. People doing filesystems will have to assume they need to rebuild/retest on Hadoop 3. anyway I'm +1 for making it final in Hadoop 3.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 35s Maven dependency ordering for branch
        +1 mvninstall 13m 47s trunk passed
        +1 compile 13m 46s trunk passed
        +1 checkstyle 2m 4s trunk passed
        +1 mvnsite 4m 57s trunk passed
        -1 findbugs 1m 31s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings.
        -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 3m 35s trunk passed
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 3m 24s the patch passed
        +1 compile 10m 25s the patch passed
        +1 javac 10m 25s root generated 0 new + 1396 unchanged - 22 fixed = 1396 total (was 1418)
        -0 checkstyle 2m 6s root: The patch generated 1 new + 582 unchanged - 5 fixed = 583 total (was 587)
        +1 mvnsite 5m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 8m 13s the patch passed
        +1 javadoc 3m 57s the patch passed
              Other Tests
        -1 unit 8m 7s hadoop-common in the patch failed.
        +1 unit 1m 25s hadoop-hdfs-client in the patch passed.
        -1 unit 64m 30s hadoop-hdfs in the patch failed.
        +1 unit 1m 58s hadoop-hdfs-nfs in the patch passed.
        +1 unit 102m 36s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 unit 0m 41s hadoop-openstack in the patch passed.
        +1 unit 2m 24s hadoop-azure in the patch passed.
        +1 asflicense 0m 45s The patch does not generate ASF License warnings.
        286m 24s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag
          hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
          hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14726
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880497/HADOOP-14726.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2b96fc0bdd26 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 024c3ec
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.       trunk Compile Tests 0 mvndep 1m 35s Maven dependency ordering for branch +1 mvninstall 13m 47s trunk passed +1 compile 13m 46s trunk passed +1 checkstyle 2m 4s trunk passed +1 mvnsite 4m 57s trunk passed -1 findbugs 1m 31s hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2 extant Findbugs warnings. -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 35s trunk passed       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 24s the patch passed +1 compile 10m 25s the patch passed +1 javac 10m 25s root generated 0 new + 1396 unchanged - 22 fixed = 1396 total (was 1418) -0 checkstyle 2m 6s root: The patch generated 1 new + 582 unchanged - 5 fixed = 583 total (was 587) +1 mvnsite 5m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 13s the patch passed +1 javadoc 3m 57s the patch passed       Other Tests -1 unit 8m 7s hadoop-common in the patch failed. +1 unit 1m 25s hadoop-hdfs-client in the patch passed. -1 unit 64m 30s hadoop-hdfs in the patch failed. +1 unit 1m 58s hadoop-hdfs-nfs in the patch passed. +1 unit 102m 36s hadoop-mapreduce-client-jobclient in the patch passed. +1 unit 0m 41s hadoop-openstack in the patch passed. +1 unit 2m 24s hadoop-azure in the patch passed. +1 asflicense 0m 45s The patch does not generate ASF License warnings. 286m 24s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem   hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14726 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880497/HADOOP-14726.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2b96fc0bdd26 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 024c3ec Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12962/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        FWIW, not making isDir final would not break compilation, but it would cause infinite recursion in FileSystem implementations that override isDirectory to call isDir, but isDir calls super.isDir, isDir is not overridden, etc.

        Personally, I'd lean toward making isDir final to cause compilation failures instead of this class of bugs for FileSystem implementations. But I'll go with the prevailing taste consensus.

        Show
        chris.douglas Chris Douglas added a comment - FWIW, not making isDir final would not break compilation, but it would cause infinite recursion in FileSystem implementations that override isDirectory to call isDir , but isDir calls super.isDir , isDir is not overridden, etc. Personally, I'd lean toward making isDir final to cause compilation failures instead of this class of bugs for FileSystem implementations. But I'll go with the prevailing taste consensus.
        Hide
        chris.douglas Chris Douglas added a comment -

        Same patch, but no longer makes isDir final. v001 also removes a redundant assignment and fixes toString to call methods instead of referencing fields. I'll update the description (and remove the "incompatible change" flag if this looks OK.

        Show
        chris.douglas Chris Douglas added a comment - Same patch, but no longer makes isDir final. v001 also removes a redundant assignment and fixes toString to call methods instead of referencing fields. I'll update the description (and remove the "incompatible change" flag if this looks OK.
        Hide
        chris.douglas Chris Douglas added a comment -

        I think it's too late to remove at this point in the release cycle; if we're serious about doing this for Hadoop 4, then let's file JIRAs for these downstreams to switch over.

        Hrm; seems like it's too late to remove this, ever. So it goes.

        It is still incompatible though, since marking isDir final breaks out-of-tree FileSystems that override it. Is this necessary?

        It's not necessary, it's the most aggressive variant we could push in Hadoop 3. I could make something up about JIT efficiency when isDir is final, but the only real argument in favor is to make sure FileSystem implementors override these two calls consistently. It's a corner of a corner case, either way.

        Show
        chris.douglas Chris Douglas added a comment - I think it's too late to remove at this point in the release cycle; if we're serious about doing this for Hadoop 4, then let's file JIRAs for these downstreams to switch over. Hrm; seems like it's too late to remove this, ever. So it goes. It is still incompatible though, since marking isDir final breaks out-of-tree FileSystems that override it. Is this necessary? It's not necessary, it's the most aggressive variant we could push in Hadoop 3. I could make something up about JIT efficiency when isDir is final, but the only real argument in favor is to make sure FileSystem implementors override these two calls consistently. It's a corner of a corner case, either way.
        Hide
        andrew.wang Andrew Wang added a comment -

        I did a grep and there's a lot of hits for "isDir(" in downstream projects: Avro, Crunch, HBase, Hive, Hue, Kite, Oozie, Parquet, Pig, Sqoop, Zookeeper. I think it's too late to remove at this point in the release cycle; if we're serious about doing this for Hadoop 4, then let's file JIRAs for these downstreams to switch over.

        The idea of v000 seems okay to me too. It is still incompatible though, since marking isDir final breaks out-of-tree FileSystems that override it. Is this necessary?

        Show
        andrew.wang Andrew Wang added a comment - I did a grep and there's a lot of hits for "isDir(" in downstream projects: Avro, Crunch, HBase, Hive, Hue, Kite, Oozie, Parquet, Pig, Sqoop, Zookeeper. I think it's too late to remove at this point in the release cycle; if we're serious about doing this for Hadoop 4, then let's file JIRAs for these downstreams to switch over. The idea of v000 seems okay to me too. It is still incompatible though, since marking isDir final breaks out-of-tree FileSystems that override it. Is this necessary?
        Hide
        chris.douglas Chris Douglas added a comment -

        if it's cut, what downstream apps stop building?

        No idea; I don't have access to an environment to test that.

        v000 seems like the better solution. There's little harm in keeping this call- even though it's been deprecated since 2010- since removing it would certainly break some applications.

        Show
        chris.douglas Chris Douglas added a comment - if it's cut, what downstream apps stop building? No idea; I don't have access to an environment to test that. v000 seems like the better solution. There's little harm in keeping this call- even though it's been deprecated since 2010- since removing it would certainly break some applications.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        if it's cut, what downstream apps stop building?

        Show
        stevel@apache.org Steve Loughran added a comment - if it's cut, what downstream apps stop building?
        Hide
        chris.douglas Chris Douglas added a comment -

        Alternative marking FileStatus#isDir as final, delegating to FileStatus#isDirectory (and removing calls to isDir within the project. If we can't remove this in 3.0, we can at least set its semantics.

        Show
        chris.douglas Chris Douglas added a comment - Alternative marking FileStatus#isDir as final, delegating to FileStatus#isDirectory (and removing calls to isDir within the project. If we can't remove this in 3.0, we can at least set its semantics.

          People

          • Assignee:
            chris.douglas Chris Douglas
            Reporter:
            chris.douglas Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development