Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14706

Adding a helper method to determine whether a log is Log4j implement

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: util
    • Labels:
      None

      Description

      Base on the comments in YARN-6873, we'd like to add a helper method to determine whether a log is Log4j implement.
      Using this helper method, we don't have to care about it's org.apache.commons.logging or org.slf4j.Logger used in our system.

      1. HADOOP-14706-branch-2.002.patch
        3 kB
        Wenxin He
      2. HADOOP-14706-branch-2.001.patch
        3 kB
        Wenxin He
      3. HADOOP-14706.001.patch
        3 kB
        Wenxin He

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wenxinhe opened a pull request:

          https://github.com/apache/hadoop/pull/257

          HADOOP-14706. Adding a helper method to determine whether a log is Log4j implement.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wenxinhe/hadoop HADOOP-14706.Adding_a_helper_method

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/257.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #257


          commit c2f9b2023bca984ad555a785fdc516b6e24db74f
          Author: wenxinhe <wenxin.he@gmail.com>
          Date: 2017-08-01T08:19:00Z

          HADOOP-14706. Adding a helper method to determine whether a log is Log4j implement.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wenxinhe opened a pull request: https://github.com/apache/hadoop/pull/257 HADOOP-14706 . Adding a helper method to determine whether a log is Log4j implement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wenxinhe/hadoop HADOOP-14706 .Adding_a_helper_method Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/257.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #257 commit c2f9b2023bca984ad555a785fdc516b6e24db74f Author: wenxinhe <wenxin.he@gmail.com> Date: 2017-08-01T08:19:00Z HADOOP-14706 . Adding a helper method to determine whether a log is Log4j implement.
          Hide
          vincent he Wenxin He added a comment -

          I'm not sure placing this method in GenericsUtil is suitable or in org.apache.hadoop.util.LogAdapter is better?
          So I create a GenericsUtil version to see any feedback.

          Show
          vincent he Wenxin He added a comment - I'm not sure placing this method in GenericsUtil is suitable or in org.apache.hadoop.util.LogAdapter is better? So I create a GenericsUtil version to see any feedback.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 44s trunk passed
          +1 compile 15m 42s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 findbugs 1m 25s trunk passed
          +1 javadoc 0m 49s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 39s the patch passed
          +1 compile 10m 15s the patch passed
          +1 javac 10m 15s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 34s the patch passed
          +1 javadoc 0m 54s the patch passed
                Other Tests
          -1 unit 8m 48s hadoop-common in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          61m 35s



          Reason Tests
          Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem
            hadoop.net.TestClusterTopology
            hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14706
          GITHUB PR https://github.com/apache/hadoop/pull/257
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 32957530080f 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b38a1ee
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 44s trunk passed +1 compile 15m 42s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 31s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 49s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 10m 15s the patch passed +1 javac 10m 15s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests -1 unit 8m 48s hadoop-common in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 61m 35s Reason Tests Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem   hadoop.net.TestClusterTopology   hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14706 GITHUB PR https://github.com/apache/hadoop/pull/257 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 32957530080f 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b38a1ee Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12911/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you Wenxin He for creating the patch.
          I prefer GenericsUtil rather than LogAdapter. LogAdapter has some instance variables and non-static methods, so it's not good to add a static helper method there.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you Wenxin He for creating the patch. I prefer GenericsUtil rather than LogAdapter. LogAdapter has some instance variables and non-static methods, so it's not good to add a static helper method there.
          Hide
          vincent he Wenxin He added a comment -

          It sounds reasonable, Akira Ajisaka. I accept it. Thank you.
          Now the patch is ready for review. A branch-2 patch will be attached later.

          Show
          vincent he Wenxin He added a comment - It sounds reasonable, Akira Ajisaka . I accept it. Thank you. Now the patch is ready for review. A branch-2 patch will be attached later.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wenxinhe opened a pull request:

          https://github.com/apache/hadoop/pull/258

          HADOOP-14706. Adding a helper method to determine whether a log is Log4j implement.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wenxinhe/hadoop HADOOP-14706.Adding_a_helper_method.branch-2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/258.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #258


          commit e20b1f4dbe2a68003c740164f6bf42ac31ac9916
          Author: wenxinhe <wenxin.he@gmail.com>
          Date: 2017-08-01T08:19:00Z

          HADOOP-14706. Adding a helper method to determine whether a log is Log4j implement.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wenxinhe opened a pull request: https://github.com/apache/hadoop/pull/258 HADOOP-14706 . Adding a helper method to determine whether a log is Log4j implement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wenxinhe/hadoop HADOOP-14706 .Adding_a_helper_method.branch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/258.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #258 commit e20b1f4dbe2a68003c740164f6bf42ac31ac9916 Author: wenxinhe <wenxin.he@gmail.com> Date: 2017-08-01T08:19:00Z HADOOP-14706 . Adding a helper method to determine whether a log is Log4j implement.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 52s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          -1 mvninstall 4m 11s root in branch-2 failed.
          -1 compile 2m 15s root in branch-2 failed with JDK v1.8.0_131.
          -1 compile 2m 20s root in branch-2 failed with JDK v1.7.0_131.
          +1 checkstyle 0m 28s branch-2 passed
          +1 mvnsite 1m 7s branch-2 passed
          +1 findbugs 1m 55s branch-2 passed
          +1 javadoc 0m 48s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 55s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 49s the patch passed
          -1 compile 2m 15s root in the patch failed with JDK v1.8.0_131.
          -1 javac 2m 15s root in the patch failed with JDK v1.8.0_131.
          -1 compile 2m 17s root in the patch failed with JDK v1.7.0_131.
          -1 javac 2m 17s root in the patch failed with JDK v1.7.0_131.
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 13s the patch passed
          +1 javadoc 0m 49s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 54s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 9m 46s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          64m 5s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14706
          GITHUB PR https://github.com/apache/hadoop/pull/258
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 04f5d18729b0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 6ee0fe7
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-compile-root-jdk1.8.0_131.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 52s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests -1 mvninstall 4m 11s root in branch-2 failed. -1 compile 2m 15s root in branch-2 failed with JDK v1.8.0_131. -1 compile 2m 20s root in branch-2 failed with JDK v1.7.0_131. +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 1m 7s branch-2 passed +1 findbugs 1m 55s branch-2 passed +1 javadoc 0m 48s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 55s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 49s the patch passed -1 compile 2m 15s root in the patch failed with JDK v1.8.0_131. -1 javac 2m 15s root in the patch failed with JDK v1.8.0_131. -1 compile 2m 17s root in the patch failed with JDK v1.7.0_131. -1 javac 2m 17s root in the patch failed with JDK v1.7.0_131. +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 49s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 54s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 9m 46s hadoop-common in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 64m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14706 GITHUB PR https://github.com/apache/hadoop/pull/258 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 04f5d18729b0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 6ee0fe7 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-compile-root-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/branch-compile-root-jdk1.7.0_131.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12927/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 47s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 7m 27s branch-2 passed
          +1 compile 6m 42s branch-2 passed with JDK v1.8.0_144
          +1 compile 7m 15s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 25s branch-2 passed
          +1 mvnsite 1m 7s branch-2 passed
          +1 findbugs 1m 49s branch-2 passed
          +1 javadoc 0m 44s branch-2 passed with JDK v1.8.0_144
          +1 javadoc 0m 51s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 39s the patch passed
          +1 compile 5m 41s the patch passed with JDK v1.8.0_144
          +1 javac 5m 41s the patch passed
          +1 compile 6m 43s the patch passed with JDK v1.7.0_131
          +1 javac 6m 43s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 0m 59s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 52s the patch passed
          +1 javadoc 0m 44s the patch passed with JDK v1.8.0_144
          +1 javadoc 0m 50s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 9m 17s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          82m 45s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14706
          GITHUB PR https://github.com/apache/hadoop/pull/258
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 338c04934ce2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 065a906
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12936/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12936/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 17m 47s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 7m 27s branch-2 passed +1 compile 6m 42s branch-2 passed with JDK v1.8.0_144 +1 compile 7m 15s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 25s branch-2 passed +1 mvnsite 1m 7s branch-2 passed +1 findbugs 1m 49s branch-2 passed +1 javadoc 0m 44s branch-2 passed with JDK v1.8.0_144 +1 javadoc 0m 51s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_144 +1 javac 5m 41s the patch passed +1 compile 6m 43s the patch passed with JDK v1.7.0_131 +1 javac 6m 43s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 59s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_144 +1 javadoc 0m 50s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 9m 17s hadoop-common in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 82m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14706 GITHUB PR https://github.com/apache/hadoop/pull/258 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 338c04934ce2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 065a906 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12936/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12936/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, I'll commit this tomorrow if there are no objection.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, I'll commit this tomorrow if there are no objection.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/hadoop/pull/257

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/257
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Wenxin He for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Wenxin He for the contribution!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aajisaka commented on the issue:

          https://github.com/apache/hadoop/pull/258

          Hi @wenxinhe, would you close this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user aajisaka commented on the issue: https://github.com/apache/hadoop/pull/258 Hi @wenxinhe, would you close this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wenxinhe closed the pull request at:

          https://github.com/apache/hadoop/pull/258

          Show
          githubbot ASF GitHub Bot added a comment - Github user wenxinhe closed the pull request at: https://github.com/apache/hadoop/pull/258
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aajisaka commented on the issue:

          https://github.com/apache/hadoop/pull/258

          Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user aajisaka commented on the issue: https://github.com/apache/hadoop/pull/258 Thanks!
          Hide
          vincent he Wenxin He added a comment -

          Thanks for your review and commit, Akira Ajisaka. The pull request is closed.

          Show
          vincent he Wenxin He added a comment - Thanks for your review and commit, Akira Ajisaka . The pull request is closed.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12116 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12116/)
          HADOOP-14706. Adding a helper method to determine whether a log is Log4j (aajisaka: rev 691bf5ec5d641c0552f4b243c4efa34ec2e529dc)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12116 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12116/ ) HADOOP-14706 . Adding a helper method to determine whether a log is Log4j (aajisaka: rev 691bf5ec5d641c0552f4b243c4efa34ec2e529dc) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java (edit) hadoop-common-project/hadoop-common/pom.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java

            People

            • Assignee:
              vincent he Wenxin He
              Reporter:
              vincent he Wenxin He
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development