Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-beta1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: fs/azure
    • Labels:
      None
    • Target Version/s:
    • Release Note:
      Hide
      WASB now includes the current Apache Hadoop version in the User-Agent string passed to Azure Blob service. Users also may include optional additional information to identify their application. See the documentation of configuration property fs.wasb.user.agent.id for further details.
      Show
      WASB now includes the current Apache Hadoop version in the User-Agent string passed to Azure Blob service. Users also may include optional additional information to identify their application. See the documentation of configuration property fs.wasb.user.agent.id for further details.
    • Flags:
      Patch

      Description

      WASB passes a User-Agent header to the Azure back-end. Right now, it uses the default value set by the Azure Client SDK, so Hadoop traffic doesn't appear any different from general Blob traffic. If we customize the User-Agent header, then it will enable better troubleshooting and analysis by Azure service.

      The following configuration
      <property>
      <name>fs.azure.user.agent.prefix</name>
      <value>MSFT</value>
      </property>

      set the user agent to
      User-Agent: WASB/3.0.0-alpha4-SNAPSHOT (MSFT) Azure-Storage/4.2.0 (JavaJRE 1.8.0_131; WindowsServer2012R2 6.3)

      Test Results :
      Tests run: 703, Failures: 0, Errors: 0, Skipped: 119

      1. HADOOP-14518-01.patch
        4 kB
        Georgi Chalakov
      2. HADOOP-14518-01-test.txt
        10 kB
        Georgi Chalakov
      3. HADOOP-14518-02.patch
        6 kB
        Georgi Chalakov
      4. HADOOP-14518-03.patch
        7 kB
        Georgi Chalakov
      5. HADOOP-14518-04.patch
        6 kB
        Georgi Chalakov
      6. HADOOP-14518-05.patch
        25 kB
        Georgi Chalakov
      7. HADOOP-14518-06.patch
        25 kB
        Georgi Chalakov
      8. HADOOP-14518-branch-2.01.patch
        27 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          Are the stats available to customers, or for Azure internal team only? Either way, I'm +1 on the proposal.

          The patch:

          1. USER_AGENT_ID_NAME -> USER_AGENT_ID_KEY, and DEFAULT_USER_AGENT_ID -> USER_AGENT_ID_DEFAULT
          2. Add doc to index.md and default values to core-default.xml
          Show
          liuml07 Mingliang Liu added a comment - Are the stats available to customers, or for Azure internal team only? Either way, I'm +1 on the proposal. The patch: USER_AGENT_ID_NAME -> USER_AGENT_ID_KEY , and DEFAULT_USER_AGENT_ID -> USER_AGENT_ID_DEFAULT Add doc to index.md and default values to core-default.xml
          Hide
          liuml07 Mingliang Liu added a comment -

          I have added you as Hadoop contributor in the issue system, and assigned this JIRA to you. Thanks for the contribution.

          Show
          liuml07 Mingliang Liu added a comment - I have added you as Hadoop contributor in the issue system, and assigned this JIRA to you. Thanks for the contribution.
          Hide
          Georgi Georgi Chalakov added a comment -

          Thanks for reviewing the change. In the new patch, I have replaced the names and added info in index.md and the default value in core-default.xml.

          Show
          Georgi Georgi Chalakov added a comment - Thanks for reviewing the change. In the new patch, I have replaced the names and added info in index.md and the default value in core-default.xml.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 13m 9s trunk passed
          +1 compile 13m 29s trunk passed
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 1m 31s trunk passed
          -1 findbugs 1m 22s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 12s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 10m 6s the patch passed
          +1 javac 10m 6s the patch passed
          -0 checkstyle 1m 56s root: The patch generated 2 new + 36 unchanged - 0 fixed = 38 total (was 36)
          +1 mvnsite 1m 35s the patch passed
          -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 22s the patch passed
          +1 javadoc 1m 18s the patch passed
          -1 unit 7m 35s hadoop-common in the patch failed.
          +1 unit 1m 32s hadoop-azure in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          83m 58s



          Reason Tests
          Failed junit tests hadoop.net.TestClusterTopology
            hadoop.conf.TestCommonConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872443/HADOOP-14518-02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux c0f87ea416d3 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a2121cb
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 9s trunk passed +1 compile 13m 29s trunk passed +1 checkstyle 1m 54s trunk passed +1 mvnsite 1m 31s trunk passed -1 findbugs 1m 22s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 12s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 10m 6s the patch passed +1 javac 10m 6s the patch passed -0 checkstyle 1m 56s root: The patch generated 2 new + 36 unchanged - 0 fixed = 38 total (was 36) +1 mvnsite 1m 35s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 22s the patch passed +1 javadoc 1m 18s the patch passed -1 unit 7m 35s hadoop-common in the patch failed. +1 unit 1m 32s hadoop-azure in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 83m 58s Reason Tests Failed junit tests hadoop.net.TestClusterTopology   hadoop.conf.TestCommonConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872443/HADOOP-14518-02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux c0f87ea416d3 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2121cb Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12515/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Failing test TestCommonConfigurationFields is related. Please fix it. Also can you keep the existing "import" in AzureNativeFileSystemStore to make the patch minimized?

          Ping Steve Loughran for 2nd opinion.

          Show
          liuml07 Mingliang Liu added a comment - Failing test TestCommonConfigurationFields is related. Please fix it. Also can you keep the existing "import" in AzureNativeFileSystemStore to make the patch minimized? Ping Steve Loughran for 2nd opinion.
          Hide
          Georgi Georgi Chalakov added a comment - - edited

          HADOOP-14518-03.patch:

          Running org.apache.hadoop.conf.TestCommonConfigurationFields
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.39 sec - in org.apache.hadoop.conf.TestCommonConfigurationFields

          Show
          Georgi Georgi Chalakov added a comment - - edited HADOOP-14518 -03.patch: Running org.apache.hadoop.conf.TestCommonConfigurationFields Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.39 sec - in org.apache.hadoop.conf.TestCommonConfigurationFields
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 13m 8s trunk passed
          +1 compile 13m 23s trunk passed
          +1 checkstyle 1m 52s trunk passed
          +1 mvnsite 1m 32s trunk passed
          -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 14s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 10m 9s the patch passed
          +1 javac 10m 9s the patch passed
          -0 checkstyle 1m 57s root: The patch generated 3 new + 41 unchanged - 0 fixed = 44 total (was 41)
          +1 mvnsite 1m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 20s the patch passed
          -1 unit 7m 31s hadoop-common in the patch failed.
          +1 unit 1m 33s hadoop-azure in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          83m 53s



          Reason Tests
          Failed junit tests hadoop.security.TestRaceWhenRelogin



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872467/HADOOP-14518-03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 0770c3ee81a1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e86eef9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 8s trunk passed +1 compile 13m 23s trunk passed +1 checkstyle 1m 52s trunk passed +1 mvnsite 1m 32s trunk passed -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 14s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 10m 9s the patch passed +1 javac 10m 9s the patch passed -0 checkstyle 1m 57s root: The patch generated 3 new + 41 unchanged - 0 fixed = 44 total (was 41) +1 mvnsite 1m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 20s the patch passed -1 unit 7m 31s hadoop-common in the patch failed. +1 unit 1m 33s hadoop-azure in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 83m 53s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872467/HADOOP-14518-03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 0770c3ee81a1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e86eef9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12517/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks pretty good, just needs some final tuning

          • typo "configuraion" in docs.
          • checkstyle has found 3 minor issues, which we need to get in
            ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:57:import org.apache.hadoop.fs.azure.SyncableDataOutputStream;:1: Redundant import from the same package - org.apache.hadoop.fs.azure.SyncableDataOutputStream. [RedundantImport]
            ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:58:import org.apache.hadoop.fs.azure.SelfThrottlingIntercept;:1: Redundant import from the same package - org.apache.hadoop.fs.azure.SelfThrottlingIntercept. [RedundantImport]
            ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:1927:        connection.setRequestProperty(Constants.HeaderConstants.USER_AGENT,userAgentInfo);:76: ',' is not followed by whitespace. [WhitespaceAfter]
            
          Show
          stevel@apache.org Steve Loughran added a comment - looks pretty good, just needs some final tuning typo "configuraion" in docs. checkstyle has found 3 minor issues, which we need to get in ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:57: import org.apache.hadoop.fs.azure.SyncableDataOutputStream;:1: Redundant import from the same package - org.apache.hadoop.fs.azure.SyncableDataOutputStream. [RedundantImport] ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:58: import org.apache.hadoop.fs.azure.SelfThrottlingIntercept;:1: Redundant import from the same package - org.apache.hadoop.fs.azure.SelfThrottlingIntercept. [RedundantImport] ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:1927: connection.setRequestProperty(Constants.HeaderConstants.USER_AGENT,userAgentInfo);:76: ',' is not followed by whitespace. [WhitespaceAfter]
          Hide
          Georgi Georgi Chalakov added a comment -

          Thanks for reviewing the change. The 3 style errors and the two typos are fixed in the new patch.

          Show
          Georgi Georgi Chalakov added a comment - Thanks for reviewing the change. The 3 style errors and the two typos are fixed in the new patch.
          Hide
          liuml07 Mingliang Liu added a comment -

          Georgi Chalakov, you have to change this JIRA to "Patch Available" by Submit Patch to trigger pre-commit Jenkins run. That is needed before every commit. Thanks,

          Show
          liuml07 Mingliang Liu added a comment - Georgi Chalakov , you have to change this JIRA to "Patch Available" by Submit Patch to trigger pre-commit Jenkins run. That is needed before every commit. Thanks,
          Hide
          Georgi.Chalakov@microsoft.com Georgi Chalakov added a comment -

          It is not clear to us what the correct sequence of step is to get a patch reviewed, tested, and approved.

          Can you share a link to document or just a paragraph that describes the lifetime of a Jira issue?

          Thanks
          Georgi

          Get Outlook for iOS<https://aka.ms/o0ukef>

          Show
          Georgi.Chalakov@microsoft.com Georgi Chalakov added a comment - It is not clear to us what the correct sequence of step is to get a patch reviewed, tested, and approved. Can you share a link to document or just a paragraph that describes the lifetime of a Jira issue? Thanks Georgi Get Outlook for iOS< https://aka.ms/o0ukef >
          Show
          liuml07 Mingliang Liu added a comment - https://cwiki.apache.org/confluence/display/HADOOP/HowToContribute may be helpful. Thanks,
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 31s Maven dependency ordering for branch
          +1 mvninstall 16m 55s trunk passed
          +1 compile 21m 37s trunk passed
          +1 checkstyle 2m 21s trunk passed
          +1 mvnsite 2m 1s trunk passed
          -1 findbugs 1m 54s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 1m 30s trunk passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 1m 17s the patch passed
          +1 compile 13m 5s the patch passed
          +1 javac 13m 5s the patch passed
          +1 checkstyle 2m 2s the patch passed
          +1 mvnsite 1m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 24s the patch passed
          +1 javadoc 1m 20s the patch passed
          -1 unit 8m 7s hadoop-common in the patch failed.
          +1 unit 1m 34s hadoop-azure in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          103m 19s



          Reason Tests
          Failed junit tests hadoop.fs.TestHarFileSystem
            hadoop.fs.TestFilterFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873345/HADOOP-14518-04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux ef96b5d10d50 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6460df2
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 16m 55s trunk passed +1 compile 21m 37s trunk passed +1 checkstyle 2m 21s trunk passed +1 mvnsite 2m 1s trunk passed -1 findbugs 1m 54s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 30s trunk passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 13m 5s the patch passed +1 javac 13m 5s the patch passed +1 checkstyle 2m 2s the patch passed +1 mvnsite 1m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 24s the patch passed +1 javadoc 1m 20s the patch passed -1 unit 8m 7s hadoop-common in the patch failed. +1 unit 1m 34s hadoop-azure in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 103m 19s Reason Tests Failed junit tests hadoop.fs.TestHarFileSystem   hadoop.fs.TestFilterFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873345/HADOOP-14518-04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux ef96b5d10d50 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6460df2 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12557/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Test failures appear unrelated; I'll have to see if I can replicate them & work out what changed. I can't see how it has broken from your patch, certainly.

          Regarding this patch, the production code looks OK.

          1. I'd like to see a test which sets the property to something other than the default, just to make sure that codepath doesn't have surprises. You can just add it to some existing test suite, like TestWasbUriAndConfiguration or similar: just set the property one time an agent is created. Maybe also unset it entirely to see what happens.
          • I'll require a declaration from you as to which azure endpoint you tested against. I'm confident you have the ability to do this, I just want the rigorousness. Yetus/Jenkins can't test the azure client (no credentials), so we absolutely require that due diligence from the submitter. (we committers generally do a test run too, but I don't want to invest the time until its ready to play with)
          Show
          stevel@apache.org Steve Loughran added a comment - Test failures appear unrelated; I'll have to see if I can replicate them & work out what changed. I can't see how it has broken from your patch, certainly. Regarding this patch, the production code looks OK. I'd like to see a test which sets the property to something other than the default, just to make sure that codepath doesn't have surprises. You can just add it to some existing test suite, like TestWasbUriAndConfiguration or similar: just set the property one time an agent is created. Maybe also unset it entirely to see what happens. I'll require a declaration from you as to which azure endpoint you tested against. I'm confident you have the ability to do this, I just want the rigorousness. Yetus/Jenkins can't test the azure client (no credentials), so we absolutely require that due diligence from the submitter. (we committers generally do a test run too, but I don't want to invest the time until its ready to play with)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          test failures were unrelated: HADOOP-14538

          Show
          stevel@apache.org Steve Loughran added a comment - test failures were unrelated: HADOOP-14538
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looking at s3a, the property for setting the prefix is "fs.s3a.user.agent.prefix". Could you do something similar with fs.azure.user.agent.prefix. It's good not just for users to have consistent attribute names, but for anyone fielding support calls trying to work out why the setting isn't being picked up. Now is the time to get it right.

          Show
          stevel@apache.org Steve Loughran added a comment - Looking at s3a, the property for setting the prefix is "fs.s3a.user.agent.prefix". Could you do something similar with fs.azure.user.agent.prefix . It's good not just for users to have consistent attribute names, but for anyone fielding support calls trying to work out why the setting isn't being picked up. Now is the time to get it right.
          Hide
          Georgi Georgi Chalakov added a comment -

          The name of the key is changed to "fs.azure.user.agent.prefix"
          New test added "testUserAgentConfig"

          Show
          Georgi Georgi Chalakov added a comment - The name of the key is changed to "fs.azure.user.agent.prefix" New test added "testUserAgentConfig"
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 25s Maven dependency ordering for branch
          +1 mvninstall 12m 16s trunk passed
          +1 compile 13m 23s trunk passed
          +1 checkstyle 1m 38s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 58s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 54s the patch passed
          +1 compile 9m 51s the patch passed
          +1 javac 9m 51s the patch passed
          +1 checkstyle 1m 42s root: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47)
          +1 mvnsite 1m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 1m 15s the patch passed
          +1 unit 7m 15s hadoop-common in the patch passed.
          +1 unit 1m 36s hadoop-azure in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          81m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874547/HADOOP-14518-05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux f32b71079417 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a9d3412
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12628/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12628/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 25s Maven dependency ordering for branch +1 mvninstall 12m 16s trunk passed +1 compile 13m 23s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 1m 23s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 58s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 9m 51s the patch passed +1 javac 9m 51s the patch passed +1 checkstyle 1m 42s root: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47) +1 mvnsite 1m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 2m 6s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 7m 15s hadoop-common in the patch passed. +1 unit 1m 36s hadoop-azure in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 81m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874547/HADOOP-14518-05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux f32b71079417 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a9d3412 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12628/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12628/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          The patch looks ok to me, however it needs to be rebased to latest trunk. Also, the latest patch has many unintended diff lines that make the patch look large.

          Georgi Chalakov, please upload a rebased patch.

          Show
          jnp Jitendra Nath Pandey added a comment - The patch looks ok to me, however it needs to be rebased to latest trunk. Also, the latest patch has many unintended diff lines that make the patch look large. Georgi Chalakov , please upload a rebased patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 15s Maven dependency ordering for branch
          -1 mvninstall 15m 7s root in trunk failed.
          +1 compile 13m 31s trunk passed
          +1 checkstyle 1m 56s trunk passed
          +1 mvnsite 1m 55s trunk passed
          +1 findbugs 2m 0s trunk passed
          +1 javadoc 1m 13s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 2s the patch passed
          +1 compile 10m 13s the patch passed
          +1 javac 10m 13s the patch passed
          +1 checkstyle 1m 57s root: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
          +1 mvnsite 2m 3s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 2m 48s the patch passed
          +1 javadoc 1m 20s the patch passed
                Other Tests
          -1 unit 8m 7s hadoop-common in the patch failed.
          +1 unit 1m 38s hadoop-azure in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          87m 53s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag
            hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878420/HADOOP-14518-06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 291a2b3a0287 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 465c213
          Default Java 1.8.0_131
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 0m 15s Maven dependency ordering for branch -1 mvninstall 15m 7s root in trunk failed. +1 compile 13m 31s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 1m 55s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 1m 13s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 2s the patch passed +1 compile 10m 13s the patch passed +1 javac 10m 13s the patch passed +1 checkstyle 1m 57s root: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40) +1 mvnsite 2m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 2m 48s the patch passed +1 javadoc 1m 20s the patch passed       Other Tests -1 unit 8m 7s hadoop-common in the patch failed. +1 unit 1m 38s hadoop-azure in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 87m 53s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878420/HADOOP-14518-06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 291a2b3a0287 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 465c213 Default Java 1.8.0_131 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12837/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1 for the latest patch. The test failures are unrelated to the patch.

          Show
          jnp Jitendra Nath Pandey added a comment - +1 for the latest patch. The test failures are unrelated to the patch.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          Attaching branch-2 patch for pre-commit run.

          Show
          jnp Jitendra Nath Pandey added a comment - Attaching branch-2 patch for pre-commit run.
          Hide
          shanem Shane Mainali added a comment -
          Show
          shanem Shane Mainali added a comment - Thanks Jitendra Nath Pandey !
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 39s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                branch-2 Compile Tests
          0 mvndep 0m 52s Maven dependency ordering for branch
          +1 mvninstall 6m 51s branch-2 passed
          +1 compile 6m 23s branch-2 passed with JDK v1.8.0_131
          +1 compile 6m 50s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 1m 28s branch-2 passed
          +1 mvnsite 1m 24s branch-2 passed
          +1 findbugs 2m 17s branch-2 passed
          +1 javadoc 1m 0s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 1m 8s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 6m 55s the patch passed with JDK v1.8.0_131
          +1 javac 6m 55s the patch passed
          +1 compile 7m 39s the patch passed with JDK v1.7.0_131
          +1 javac 7m 39s the patch passed
          +1 checkstyle 1m 39s root: The patch generated 0 new + 33 unchanged - 1 fixed = 33 total (was 34)
          +1 mvnsite 1m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 0s the patch passed
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_131
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 11m 15s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 unit 1m 49s hadoop-azure in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          113m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14518
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878701/HADOOP-14518-branch-2.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 54f3b45766b0 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 9b6e787
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12849/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12849/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 12m 39s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 52s Maven dependency ordering for branch +1 mvninstall 6m 51s branch-2 passed +1 compile 6m 23s branch-2 passed with JDK v1.8.0_131 +1 compile 6m 50s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 28s branch-2 passed +1 mvnsite 1m 24s branch-2 passed +1 findbugs 2m 17s branch-2 passed +1 javadoc 1m 0s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 8s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 6m 55s the patch passed with JDK v1.8.0_131 +1 javac 6m 55s the patch passed +1 compile 7m 39s the patch passed with JDK v1.7.0_131 +1 javac 7m 39s the patch passed +1 checkstyle 1m 39s root: The patch generated 0 new + 33 unchanged - 1 fixed = 33 total (was 34) +1 mvnsite 1m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 0s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 11m 15s hadoop-common in the patch passed with JDK v1.7.0_131. +1 unit 1m 49s hadoop-azure in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 113m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14518 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878701/HADOOP-14518-branch-2.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 54f3b45766b0 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 9b6e787 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12849/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12849/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12052/)
          HADOOP-14518. Customize User-Agent header sent in HTTP/HTTPS requests by (jitendra: rev f2921e51f0fe613abce0a9f415a0d8ab6144aa6e)

          • (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
          • (edit) hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • (edit) hadoop-tools/hadoop-azure/src/site/markdown/index.md
          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12052 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12052/ ) HADOOP-14518 . Customize User-Agent header sent in HTTP/HTTPS requests by (jitendra: rev f2921e51f0fe613abce0a9f415a0d8ab6144aa6e) (edit) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestWasbUriAndConfiguration.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java (edit) hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml (edit) hadoop-tools/hadoop-azure/src/site/markdown/index.md (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          Hide
          jnp Jitendra Nath Pandey added a comment -

          I have committed this to trunk and branch-2. Thanks for the contribution, Georgi Chalakov.

          Show
          jnp Jitendra Nath Pandey added a comment - I have committed this to trunk and branch-2. Thanks for the contribution, Georgi Chalakov .

            People

            • Assignee:
              Georgi Georgi Chalakov
              Reporter:
              Georgi Georgi Chalakov
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development