Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14413

Add Javadoc comment for jitter parameter on CachingGetSpaceUsed

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When the jitter parameter was added in HADOOP-12975, the Javadoc was not updated accordingly.

      1. HADOOP-14413.000.patch
        1.0 kB
        Erik Krogen
      2. HADOOP-14413.001.patch
        1.0 kB
        Erik Krogen

        Activity

        Hide
        xkrogen Erik Krogen added a comment -

        Attaching patch which adds this Javadoc. Pretty trivial. Konstantin Shvachko, if you get a chance can you review/commit?

        Show
        xkrogen Erik Krogen added a comment - Attaching patch which adds this Javadoc. Pretty trivial. Konstantin Shvachko , if you get a chance can you review/commit?
        Hide
        templedf Daniel Templeton added a comment -

        Am I overthinking it to ask you to point out that it's a uniform distribution?

        Show
        templedf Daniel Templeton added a comment - Am I overthinking it to ask you to point out that it's a uniform distribution?
        Hide
        xkrogen Erik Krogen added a comment -

        Daniel Templeton, no that's fair. Uploaded v001 patch.

        Show
        xkrogen Erik Krogen added a comment - Daniel Templeton , no that's fair. Uploaded v001 patch.
        Hide
        templedf Daniel Templeton added a comment - - edited

        LGTM +1 pending Jenkins

        Show
        templedf Daniel Templeton added a comment - - edited LGTM +1 pending Jenkins
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 15m 3s trunk passed
        +1 compile 16m 48s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 1m 5s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 49s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 14m 21s the patch passed
        +1 javac 14m 21s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 49s the patch passed
        +1 unit 7m 55s hadoop-common in the patch passed.
        +1 asflicense 0m 36s The patch does not generate ASF License warnings.
        66m 4s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14413
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867615/HADOOP-14413.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dc2f92f6b7c0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 51b671e
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 15m 3s trunk passed +1 compile 16m 48s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 20s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 49s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 14m 21s the patch passed +1 javac 14m 21s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 7m 55s hadoop-common in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 66m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14413 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867615/HADOOP-14413.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dc2f92f6b7c0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 51b671e Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12293/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Erik Krogen. Committed to trunk and branch-2.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Erik Krogen . Committed to trunk and branch-2.
        Hide
        xkrogen Erik Krogen added a comment -
        Show
        xkrogen Erik Krogen added a comment - Thanks Daniel Templeton !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 15m 13s trunk passed
        +1 compile 21m 43s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 18s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        -1 findbugs 1m 39s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 1m 5s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 18m 43s the patch passed
        +1 javac 18m 43s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvnsite 1m 11s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 1m 14s the patch passed
        +1 unit 9m 0s hadoop-common in the patch passed.
        +1 asflicense 0m 57s The patch does not generate ASF License warnings.
        79m 46s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14413
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867616/HADOOP-14413.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9612ca5bd546 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 51b671e
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 15m 13s trunk passed +1 compile 21m 43s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 18s trunk passed +1 mvneclipse 0m 25s trunk passed -1 findbugs 1m 39s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 5s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 18m 43s the patch passed +1 javac 18m 43s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 1m 14s the patch passed +1 unit 9m 0s hadoop-common in the patch passed. +1 asflicense 0m 57s The patch does not generate ASF License warnings. 79m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14413 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867616/HADOOP-14413.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9612ca5bd546 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 51b671e Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12294/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11724 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11724/)
        HADOOP-14413. Add Javadoc comment for jitter parameter on (templedf: rev 09f28da2d2aae1487bae85ff110794f8346f92a4)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CachingGetSpaceUsed.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11724 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11724/ ) HADOOP-14413 . Add Javadoc comment for jitter parameter on (templedf: rev 09f28da2d2aae1487bae85ff110794f8346f92a4) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CachingGetSpaceUsed.java

          People

          • Assignee:
            xkrogen Erik Krogen
            Reporter:
            xkrogen Erik Krogen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development