Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Running DU across lots of disks is very expensive and running all of the processes at the same time creates a noticeable IO spike. We should add some jitter.

      1. HADOOP-12975-branch-2.7.006.patch
        6 kB
        Erik Krogen
      2. HADOOP-12975v0.patch
        2 kB
        Elliott Clark
      3. HADOOP-12975v1.patch
        2 kB
        Elliott Clark
      4. HADOOP-12975v2.patch
        2 kB
        Elliott Clark
      5. HADOOP-12975v3.patch
        9 kB
        Elliott Clark
      6. HADOOP-12975v4.patch
        9 kB
        Elliott Clark
      7. HADOOP-12975v5.patch
        9 kB
        Elliott Clark
      8. HADOOP-12975v6.patch
        9 kB
        Elliott Clark

        Issue Links

          Activity

          Hide
          eclark Elliott Clark added a comment -

          Also based upon HADOOP-12973

          Show
          eclark Elliott Clark added a comment - Also based upon HADOOP-12973
          Hide
          eclark Elliott Clark added a comment -

          Rebased patch.

          Show
          eclark Elliott Clark added a comment - Rebased patch.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Good idea.

          Can we make the jitter percentage configurable? What motivates choosing 50% of the full refresh period as the jitter default? For people with really long DU periods, this could extend that refresh time by quite a bit. Perhaps jitter should be specified as a maximum number of seconds uniformly randomly added, rather than a percentage of the full refresh period?

          I think this can get in separately from HADOOP-12973.

          Show
          cmccabe Colin P. McCabe added a comment - Good idea. Can we make the jitter percentage configurable? What motivates choosing 50% of the full refresh period as the jitter default? For people with really long DU periods, this could extend that refresh time by quite a bit. Perhaps jitter should be specified as a maximum number of seconds uniformly randomly added, rather than a percentage of the full refresh period? I think this can get in separately from HADOOP-12973 .
          Hide
          eclark Elliott Clark added a comment -

          What motivates choosing 50% of the full refresh period as the jitter default?

          50% is probably too high, I'll change it to 15%.

          But a percentage is chosen as it makes the jitter scale with anyone who changes du periods. If it's a set number then someone with a refresh period of days won't get any benefit from the jitter.

          Show
          eclark Elliott Clark added a comment - What motivates choosing 50% of the full refresh period as the jitter default? 50% is probably too high, I'll change it to 15%. But a percentage is chosen as it makes the jitter scale with anyone who changes du periods. If it's a set number then someone with a refresh period of days won't get any benefit from the jitter.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 12s trunk passed
          +1 compile 11m 56s trunk passed with JDK v1.8.0_77
          +1 compile 8m 46s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 17s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 50s the patch passed
          +1 compile 9m 12s the patch passed with JDK v1.8.0_77
          +1 javac 9m 12s the patch passed
          +1 compile 8m 32s the patch passed with JDK v1.7.0_95
          +1 javac 8m 32s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 1m 12s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 23s the patch passed
          +1 javadoc 1m 17s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95
          -1 unit 12m 23s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 10m 39s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          86m 9s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798774/HADOOP-12975v2.patch
          JIRA Issue HADOOP-12975
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2ab84282d052 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c970f1d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 12s trunk passed +1 compile 11m 56s trunk passed with JDK v1.8.0_77 +1 compile 8m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 17s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 50s the patch passed +1 compile 9m 12s the patch passed with JDK v1.8.0_77 +1 javac 9m 12s the patch passed +1 compile 8m 32s the patch passed with JDK v1.7.0_95 +1 javac 8m 32s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 23s the patch passed +1 javadoc 1m 17s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95 -1 unit 12m 23s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 10m 39s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 86m 9s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0 Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798774/HADOOP-12975v2.patch JIRA Issue HADOOP-12975 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2ab84282d052 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c970f1d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9094/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment - - edited

          But a percentage is chosen as it makes the jitter scale with anyone who changes du periods. If it's a set number then someone with a refresh period of days won't get any benefit from the jitter.

          Hmm. It seems like a fixed amount of jitter still provides a benefit, even to someone with a longer refresh interval. Let's say my refresh period is 7 days. At the end of that, I would still appreciate having my DU processes launch at slightly different times on the 7th day, rather than all launching at once.

          My concern with varying based on a percentage is that there will be enormous variations in how long different volumes go between DU operations, when longer refresh intervals are in use. Like if I have a 7 day period and one volume refreshes after 3.5 days, and the other waits for the full 7 days, that's quite a variation. Similarly, if our period is short – like 1 hour-- having some datanodes refresh after only 30 minutes seems unwelcome. That's why I suggested a fixed jitter amount, to be configured by the sysadmin.

          I don't feel very strongly about this, though, so if you want to make it percentage-based, that's fine too. As long as it's configurable and the defaults are reasonable. I definitely think that a maximum jitter percentage of 0.15 or 0.20 seems more reasonable than 0.5.

          Show
          cmccabe Colin P. McCabe added a comment - - edited But a percentage is chosen as it makes the jitter scale with anyone who changes du periods. If it's a set number then someone with a refresh period of days won't get any benefit from the jitter. Hmm. It seems like a fixed amount of jitter still provides a benefit, even to someone with a longer refresh interval. Let's say my refresh period is 7 days. At the end of that, I would still appreciate having my DU processes launch at slightly different times on the 7th day, rather than all launching at once. My concern with varying based on a percentage is that there will be enormous variations in how long different volumes go between DU operations, when longer refresh intervals are in use. Like if I have a 7 day period and one volume refreshes after 3.5 days, and the other waits for the full 7 days, that's quite a variation. Similarly, if our period is short – like 1 hour-- having some datanodes refresh after only 30 minutes seems unwelcome. That's why I suggested a fixed jitter amount, to be configured by the sysadmin. I don't feel very strongly about this, though, so if you want to make it percentage-based, that's fine too. As long as it's configurable and the defaults are reasonable. I definitely think that a maximum jitter percentage of 0.15 or 0.20 seems more reasonable than 0.5.
          Hide
          eclark Elliott Clark added a comment -
          • Added a default jitter config that's a set time.
          Show
          eclark Elliott Clark added a comment - Added a default jitter config that's a set time.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-12975 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802713/HADOOP-12975v3.patch
          JIRA Issue HADOOP-12975
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9308/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-12975 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802713/HADOOP-12975v3.patch JIRA Issue HADOOP-12975 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9308/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Does this need a rebase?

          Show
          cmccabe Colin P. McCabe added a comment - Does this need a rebase?
          Hide
          eclark Elliott Clark added a comment -

          Probably I hadn't pulled in a while.

          Show
          eclark Elliott Clark added a comment - Probably I hadn't pulled in a while.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 8s trunk passed
          +1 compile 10m 25s trunk passed with JDK v1.8.0_91
          +1 compile 9m 32s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 19s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 2m 13s trunk passed
          +1 javadoc 1m 20s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 57s the patch passed
          +1 compile 10m 16s the patch passed with JDK v1.8.0_91
          +1 javac 10m 16s the patch passed
          +1 compile 9m 28s the patch passed with JDK v1.7.0_95
          +1 javac 9m 28s the patch passed
          -1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 22s the patch passed
          +1 javadoc 1m 20s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95
          +1 unit 11m 3s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 10m 6s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          87m 24s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802731/HADOOP-12975v4.patch
          JIRA Issue HADOOP-12975
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9651e606b5fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2835f14
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 8s trunk passed +1 compile 10m 25s trunk passed with JDK v1.8.0_91 +1 compile 9m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 19s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 20s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 57s the patch passed +1 compile 10m 16s the patch passed with JDK v1.8.0_91 +1 javac 10m 16s the patch passed +1 compile 9m 28s the patch passed with JDK v1.7.0_95 +1 javac 9m 28s the patch passed -1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 22s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95 +1 unit 11m 3s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 10m 6s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 87m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802731/HADOOP-12975v4.patch JIRA Issue HADOOP-12975 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9651e606b5fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2835f14 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9313/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eclark Elliott Clark added a comment -

          Fixed the checkstyle warning.

          Show
          eclark Elliott Clark added a comment - Fixed the checkstyle warning.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 27s trunk passed
          +1 compile 9m 13s trunk passed with JDK v1.8.0_91
          +1 compile 8m 53s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 53s the patch passed
          +1 compile 9m 17s the patch passed with JDK v1.8.0_91
          +1 javac 9m 17s the patch passed
          +1 compile 8m 53s the patch passed with JDK v1.7.0_95
          +1 javac 8m 53s the patch passed
          +1 checkstyle 0m 29s the patch passed
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95
          +1 unit 10m 29s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 9m 59s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          81m 7s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802765/HADOOP-12975v5.patch
          JIRA Issue HADOOP-12975
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 98974f080c95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8ef75a7
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9317/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9317/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 27s trunk passed +1 compile 9m 13s trunk passed with JDK v1.8.0_91 +1 compile 8m 53s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 53s the patch passed +1 compile 9m 17s the patch passed with JDK v1.8.0_91 +1 javac 9m 17s the patch passed +1 compile 8m 53s the patch passed with JDK v1.7.0_95 +1 javac 8m 53s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95 +1 unit 10m 29s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 9m 59s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 81m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802765/HADOOP-12975v5.patch JIRA Issue HADOOP-12975 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 98974f080c95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ef75a7 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9317/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9317/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Elliott Clark.

          169	            // add/subtract the jitter.
          170	            refreshInterval +=
          171	                ThreadLocalRandom.current()
          172	                                 .nextLong(jitter, jitter);
          

          Hmm, is this a typo? It seems like this is always going to return exactly 'jitter' since the 'least' and the 'bound' arguments are the same? That seems to defeat the point of randomization. https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadLocalRandom.html#nextLong(long,%20long)

          126	        if (configuration == null) {
          127	          return DEFAULT_JITTER;
          128	        }
          

          Can we throw an exception in GetSpaceUsed#build if conf == null? It's a weird special case to have no Configuration object, and I'm not sure why we'd ever want to do that. Then this function could just be return this.conf.getLong(JITTER_KEY, DEFAULT_JITTER);.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Elliott Clark . 169 // add/subtract the jitter. 170 refreshInterval += 171 ThreadLocalRandom.current() 172 .nextLong(jitter, jitter); Hmm, is this a typo? It seems like this is always going to return exactly 'jitter' since the 'least' and the 'bound' arguments are the same? That seems to defeat the point of randomization. https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadLocalRandom.html#nextLong(long,%20long ) 126 if (configuration == null ) { 127 return DEFAULT_JITTER; 128 } Can we throw an exception in GetSpaceUsed#build if conf == null ? It's a weird special case to have no Configuration object, and I'm not sure why we'd ever want to do that. Then this function could just be return this.conf.getLong(JITTER_KEY, DEFAULT_JITTER); .
          Hide
          eclark Elliott Clark added a comment -

          Yeah that's a typo.

          Show
          eclark Elliott Clark added a comment - Yeah that's a typo.
          Hide
          eclark Elliott Clark added a comment -

          Can we throw an exception

          We could but most of the tests do not have a conf. I don't think there's any harm in falling back. Right now getKlass does the same.

          Show
          eclark Elliott Clark added a comment - Can we throw an exception We could but most of the tests do not have a conf. I don't think there's any harm in falling back. Right now getKlass does the same.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Elliott Clark. +1 pending jenkins

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Elliott Clark . +1 pending jenkins
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 6m 2s trunk passed with JDK v1.8.0_91
          +1 compile 6m 52s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 37s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.8.0_91
          +1 javac 6m 33s the patch passed
          +1 compile 6m 58s the patch passed with JDK v1.7.0_95
          +1 javac 6m 58s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 52s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          61m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803693/HADOOP-12975v6.patch
          JIRA Issue HADOOP-12975
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b17401f12320 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0bbe01f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9382/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9382/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 6m 2s trunk passed with JDK v1.8.0_91 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 33s the patch passed with JDK v1.8.0_91 +1 javac 6m 33s the patch passed +1 compile 6m 58s the patch passed with JDK v1.7.0_95 +1 javac 6m 58s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 61m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803693/HADOOP-12975v6.patch JIRA Issue HADOOP-12975 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b17401f12320 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0bbe01f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9382/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9382/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eclark Elliott Clark added a comment -

          Ping?

          Show
          eclark Elliott Clark added a comment - Ping?
          Hide
          cmccabe Colin P. McCabe added a comment -

          I was just adding jitter to the commit date.

          +1. Thanks, Elliott Clark.

          Show
          cmccabe Colin P. McCabe added a comment - I was just adding jitter to the commit date. +1. Thanks, Elliott Clark .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9973 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9973/)
          HADOOP-12975. Add jitter to CachingGetSpaceUsed's thread (Elliott Clark (cmccabe: rev bf780406f2b30e627bdf36ac07973f6931f81106)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GetSpaceUsed.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CachingGetSpaceUsed.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/WindowsGetSpaceUsed.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9973 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9973/ ) HADOOP-12975 . Add jitter to CachingGetSpaceUsed's thread (Elliott Clark (cmccabe: rev bf780406f2b30e627bdf36ac07973f6931f81106) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GetSpaceUsed.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CachingGetSpaceUsed.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/WindowsGetSpaceUsed.java
          Hide
          eclark Elliott Clark added a comment -

          Hahah thanks!

          Show
          eclark Elliott Clark added a comment - Hahah thanks!
          Hide
          vinayrpet Vinayakumar B added a comment -

          While rebasing the patch from v3 to v4, changes from HADOOP-13072 is missed.

          Show
          vinayrpet Vinayakumar B added a comment - While rebasing the patch from v3 to v4, changes from HADOOP-13072 is missed.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks for the heads up, Vinayakumar B. I fixed the accidental revert of HADOOP-13072.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks for the heads up, Vinayakumar B . I fixed the accidental revert of HADOOP-13072 .
          Hide
          shv Konstantin Shvachko added a comment -

          Committed backport from HADOOP-14408 to branch-2.7. Changed fixVersion.

          Show
          shv Konstantin Shvachko added a comment - Committed backport from HADOOP-14408 to branch-2.7. Changed fixVersion.
          Hide
          xkrogen Erik Krogen added a comment -

          Attaching the branch-2.7 patch from HADOOP-14408. It is based off of the v6 trunk patch. Renamed HADOOP-12975-branch-2.7.006.patch to match this ticket.

          Show
          xkrogen Erik Krogen added a comment - Attaching the branch-2.7 patch from HADOOP-14408 . It is based off of the v6 trunk patch. Renamed HADOOP-12975 -branch-2.7.006.patch to match this ticket.

            People

            • Assignee:
              eclark Elliott Clark
              Reporter:
              eclark Elliott Clark
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development