Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14343

Wrong pid file name in error message when starting secure daemon

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      # this is for the daemon pid creation
        #shellcheck disable=SC2086
        echo $! > "${jsvcpidfile}" 2>/dev/null
        if [[ $? -gt 0 ]]; then
          hadoop_error "ERROR:  Cannot write ${daemonname} pid ${daemonpidfile}."
        fi

      It will log datanode's pid file instead of JSVC's pid file.

      1. HADOOP-14343.02.patch
        0.8 kB
        Andras Bokor
      2. HADOOP-14343.01.patch
        0.7 kB
        Andras Bokor

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 22s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvnsite 0m 54s the patch passed
        +1 shellcheck 2m 34s There were no new shellcheck issues.
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 2m 4s hadoop-common in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        21m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ac17dc
        JIRA Issue HADOOP-14343
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864500/HADOOP-14343.01.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux a87668cfd936 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b080338
        shellcheck v0.4.6
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12153/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12153/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 22s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvnsite 0m 54s the patch passed +1 shellcheck 2m 34s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 2m 4s hadoop-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 21m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-14343 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12864500/HADOOP-14343.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux a87668cfd936 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b080338 shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12153/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12153/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        While we are here, let's fix the exit condition (a new error shellcheck added) by combining

        echo $! > "${jsvcpidfile}" 2>/dev/null
          if [[ $? -gt 0 ]]; then
        
        Show
        aw Allen Wittenauer added a comment - While we are here, let's fix the exit condition (a new error shellcheck added) by combining echo $! > "${jsvcpidfile}" 2>/dev/ null if [[ $? -gt 0 ]]; then
        Hide
        boky01 Andras Bokor added a comment -

        Allen Wittenauer,

        I have attached HADOOP-14343.02.patch. That was you meant?

        Show
        boky01 Andras Bokor added a comment - Allen Wittenauer , I have attached HADOOP-14343.02.patch . That was you meant?
        Hide
        boky01 Andras Bokor added a comment -

        Reattach last patch to kick Hadoop QA.

        Show
        boky01 Andras Bokor added a comment - Reattach last patch to kick Hadoop QA .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 38s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvnsite 0m 56s the patch passed
        +1 shellcheck 2m 43s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
        +1 shelldocs 0m 8s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 2m 4s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        22m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14343
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866663/HADOOP-14343.02.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 62b471e10b04 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e4f34ec
        shellcheck v0.4.6
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12252/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12252/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 38s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvnsite 0m 56s the patch passed +1 shellcheck 2m 43s The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75) +1 shelldocs 0m 8s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 2m 4s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 22m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14343 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866663/HADOOP-14343.02.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 62b471e10b04 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e4f34ec shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12252/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12252/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        eepayne Eric Payne added a comment -

        Andras Bokor, thanks for the effort on this patch.

        Patch LGTM. +1

        Allen Wittenauer, did you have anything you wanted to add?

        Show
        eepayne Eric Payne added a comment - Andras Bokor , thanks for the effort on this patch. Patch LGTM. +1 Allen Wittenauer , did you have anything you wanted to add?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 9s trunk passed
        +1 mvnsite 1m 36s trunk passed
              Patch Compile Tests
        +1 mvnsite 1m 31s the patch passed
        +1 shellcheck 0m 4s The patch generated 0 new + 20 unchanged - 1 fixed = 20 total (was 21)
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
              Other Tests
        +1 unit 2m 3s hadoop-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        21m 30s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14343
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866663/HADOOP-14343.02.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 75a263d88d6d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2be9412
        shellcheck v0.4.6
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12905/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12905/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 9s trunk passed +1 mvnsite 1m 36s trunk passed       Patch Compile Tests +1 mvnsite 1m 31s the patch passed +1 shellcheck 0m 4s The patch generated 0 new + 20 unchanged - 1 fixed = 20 total (was 21) +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 3s hadoop-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 21m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14343 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866663/HADOOP-14343.02.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 75a263d88d6d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2be9412 shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12905/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12905/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        +1 thanks committed to trunk

        Show
        aw Allen Wittenauer added a comment - +1 thanks committed to trunk
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12086 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12086/)
        HADOOP-14343. Wrong pid file name in error message when starting secure (aw: rev abbf4129a24c99fbce6d70b191ec19cf0d17e9be)

        • (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12086 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12086/ ) HADOOP-14343 . Wrong pid file name in error message when starting secure (aw: rev abbf4129a24c99fbce6d70b191ec19cf0d17e9be) (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        boky01 Andras Bokor added a comment -

        Thanks Allen Wittenauer and Eric Payne for the review.

        Show
        boky01 Andras Bokor added a comment - Thanks Allen Wittenauer and Eric Payne for the review.

          People

          • Assignee:
            boky01 Andras Bokor
            Reporter:
            boky01 Andras Bokor
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development