[HADOOP-14178] Move Mockito up to version 2.23.4

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.0
• Fix Version/s: 3.3.0
• Component/s: test
• Target Version/s: 3.3.0

Release Note

Hadoop migrated from mockito1 (mockito-all) to mockito2 (mockito-core).
Downstream applications that depends on Hadoop's test utilities will have to migrate to mockito2 as well to avoid test failures.

• Assignee: Akira Ajisaka
• Reporter: Steve Loughran
• Created: 13/Mar/17 10:15
• Updated: 01/Jun/21 02:29
• Resolved: 30/Jan/19 02:32

Description

I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the switch to maven in 2011.

Mockito is now at version 2.1, with lots of Java 8 support. That' s not just defining actions as closures, but in supporting Optional types, mocking methods in interfaces, etc.

It's only used for testing, and, provided there aren't regressions, cost of upgrade is low. The good news: test tools usually come with good test coverage. The bad: mockito does go deep into java bytecodes.

Issue Links

• blocks: HADOOP-15338 Java 11 runtime support
• breaks: YARN-9251 Build failure for -Dhbase.profile=2.0
• breaks: HDDS-1032 Package builds are failing with missing org.mockito:mockito-core dependency version
• contains: HADOOP-15225 mvn javadoc:test-javadoc goal throws cannot find symbol
• depends upon: HADOOP-14932 Move Mockito up to 1.10.19 to be compatible with HBase
• is blocked by: HADOOP-14188 Remove the usage of org.mockito.internal.util.reflection.Whitebox
• is blocked by: HADOOP-14218 Replace assertThat with assertTrue in MetricsAsserts
• is blocked by: HADOOP-14245 Use Mockito.when instead of Mockito.stub
• is related to: YARN-10071 Sync Mockito version with other modules
• is related to: HADOOP-16600 StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1
• is related to: HDFS-14871 StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1
• is related to: HADOOP-12427 [JDK8] Upgrade Mockito version to 1.10.19
• supercedes: HADOOP-15398 StagingTestBase uses methods not available in Mockito 1.8.5