Details

    • Type: Sub-task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.9.0
    • Fix Version/s: None
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the switch to maven in 2011.

      Mockito is now at version 2.1, with lots of Java 8 support. That' s not just defining actions as closures, but in supporting Optional types, mocking methods in interfaces, etc.

      It's only used for testing, and, provided there aren't regressions, cost of upgrade is low. The good news: test tools usually come with good test coverage. The bad: mockito does go deep into java bytecodes.

      1. HADOOP-14178.001.patch
        84 kB
        Akira Ajisaka
      2. HADOOP-14178.002.patch
        84 kB
        Akira Ajisaka
      3. HADOOP-14178.003.patch
        123 kB
        Akira Ajisaka
      4. HADOOP-14178.004.patch
        127 kB
        Akira Ajisaka
      5. HADOOP-14178.005.patch
        130 kB
        Akira Ajisaka
      6. HADOOP-14178.005-wip.patch
        159 kB
        Akira Ajisaka
      7. HADOOP-14178.005-wip2.patch
        388 kB
        Akira Ajisaka
      8. HADOOP-14178.005-wip3.patch
        426 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          005-wip3.patch:

          • Fixed some tests
          • Fixed javac warnings
          Show
          ajisakaa Akira Ajisaka added a comment - 005-wip3.patch: Fixed some tests Fixed javac warnings
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 57s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 243 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 18m 16s trunk passed
          +1 compile 16m 13s trunk passed
          +1 checkstyle 4m 12s trunk passed
          +1 mvnsite 12m 46s trunk passed
          +1 shadedclient 28m 5s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 25m 31s trunk passed
          +1 javadoc 4m 43s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 34m 14s the patch passed
          +1 compile 12m 24s the patch passed
          -1 javac 12m 24s root generated 201 new + 1236 unchanged - 12 fixed = 1437 total (was 1248)
          -0 checkstyle 3m 12s root: The patch generated 22 new + 6529 unchanged - 75 fixed = 6551 total (was 6604)
          +1 mvnsite 10m 39s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 46s The patch has no ill-formed XML file.
          +1 shadedclient 11m 15s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 30m 47s the patch passed
          +1 javadoc 4m 39s the patch passed
                Other Tests
          -1 unit 49m 59s root in the patch failed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          290m 50s



          Reason Tests
          Failed junit tests hadoop.hdfs.web.TestTokenAspect
            hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
            hadoop.yarn.server.nodemanager.scheduler.TestDistributedScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:ca8ddc6
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893951/HADOOP-14178.005-wip2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux 35b030bcaaa4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 54b72ac
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 57s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 243 new or modified test files.       trunk Compile Tests 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 18m 16s trunk passed +1 compile 16m 13s trunk passed +1 checkstyle 4m 12s trunk passed +1 mvnsite 12m 46s trunk passed +1 shadedclient 28m 5s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 25m 31s trunk passed +1 javadoc 4m 43s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 34m 14s the patch passed +1 compile 12m 24s the patch passed -1 javac 12m 24s root generated 201 new + 1236 unchanged - 12 fixed = 1437 total (was 1248) -0 checkstyle 3m 12s root: The patch generated 22 new + 6529 unchanged - 75 fixed = 6551 total (was 6604) +1 mvnsite 10m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 46s The patch has no ill-formed XML file. +1 shadedclient 11m 15s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 30m 47s the patch passed +1 javadoc 4m 39s the patch passed       Other Tests -1 unit 49m 59s root in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 290m 50s Reason Tests Failed junit tests hadoop.hdfs.web.TestTokenAspect   hadoop.yarn.server.nodemanager.TestNodeStatusUpdater   hadoop.yarn.server.nodemanager.scheduler.TestDistributedScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:ca8ddc6 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893951/HADOOP-14178.005-wip2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux 35b030bcaaa4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 54b72ac maven version: Apache Maven 3.3.9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13576/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          005-wip2

          • fixed some yarn tests
          • fixed some javac warnings (Matchers -> ArgumentMatchers)
          Show
          ajisakaa Akira Ajisaka added a comment - 005-wip2 fixed some yarn tests fixed some javac warnings (Matchers -> ArgumentMatchers)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 89 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 13m 45s trunk passed
          +1 compile 15m 51s trunk passed
          +1 checkstyle 3m 15s trunk passed
          +1 mvnsite 12m 57s trunk passed
          +1 shadedclient 28m 31s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 30m 27s trunk passed
          +1 javadoc 6m 51s trunk passed
                Patch Compile Tests
          0 mvndep 0m 31s Maven dependency ordering for patch
          +1 mvninstall 40m 27s the patch passed
          +1 compile 11m 22s the patch passed
          -1 javac 11m 22s root generated 602 new + 1225 unchanged - 23 fixed = 1827 total (was 1248)
          -0 checkstyle 2m 36s root: The patch generated 11 new + 2486 unchanged - 19 fixed = 2497 total (was 2505)
          +1 mvnsite 8m 59s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 46s The patch has no ill-formed XML file.
          +1 shadedclient 14m 29s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 29m 0s the patch passed
          +1 javadoc 4m 47s the patch passed
                Other Tests
          -1 unit 14m 43s root in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          253m 26s



          Reason Tests
          Failed junit tests hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:ca8ddc6
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893724/HADOOP-14178.005-wip.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux adebe26c275d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b90750c
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 89 new or modified test files.       trunk Compile Tests 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 13m 45s trunk passed +1 compile 15m 51s trunk passed +1 checkstyle 3m 15s trunk passed +1 mvnsite 12m 57s trunk passed +1 shadedclient 28m 31s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 30m 27s trunk passed +1 javadoc 6m 51s trunk passed       Patch Compile Tests 0 mvndep 0m 31s Maven dependency ordering for patch +1 mvninstall 40m 27s the patch passed +1 compile 11m 22s the patch passed -1 javac 11m 22s root generated 602 new + 1225 unchanged - 23 fixed = 1827 total (was 1248) -0 checkstyle 2m 36s root: The patch generated 11 new + 2486 unchanged - 19 fixed = 2497 total (was 2505) +1 mvnsite 8m 59s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 46s The patch has no ill-formed XML file. +1 shadedclient 14m 29s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 29m 0s the patch passed +1 javadoc 4m 47s the patch passed       Other Tests -1 unit 14m 43s root in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 253m 26s Reason Tests Failed junit tests hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:ca8ddc6 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893724/HADOOP-14178.005-wip.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux adebe26c275d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b90750c maven version: Apache Maven 3.3.9 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13571/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          don't worry about KDIag; HADOOP-14030 fixes that (parallel test run & no unique keytab paths problem)

          Show
          stevel@apache.org Steve Loughran added a comment - don't worry about KDIag; HADOOP-14030 fixes that (parallel test run & no unique keytab paths problem)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          005-wip: Fixed some HDFS test failures

          Show
          ajisakaa Akira Ajisaka added a comment - 005-wip: Fixed some HDFS test failures
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'll run all the tests to check if there are some other test failures.

          I ran all the tests and found about 50 tests were broken by the upgrade
          Now I'm fixing the failures. Very tough work.

          Show
          ajisakaa Akira Ajisaka added a comment - I'll run all the tests to check if there are some other test failures. I ran all the tests and found about 50 tests were broken by the upgrade Now I'm fixing the failures. Very tough work.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 78 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 26s Maven dependency ordering for branch
          +1 mvninstall 13m 22s trunk passed
          +1 compile 15m 18s trunk passed
          +1 checkstyle 2m 41s trunk passed
          +1 mvnsite 10m 1s trunk passed
          +1 shadedclient 23m 57s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 23m 48s trunk passed
          +1 javadoc 5m 27s trunk passed
                Patch Compile Tests
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 37m 22s the patch passed
          +1 compile 12m 41s the patch passed
          -1 javac 12m 41s root generated 607 new + 1229 unchanged - 27 fixed = 1836 total (was 1256)
          -0 checkstyle 2m 39s root: The patch generated 3 new + 2330 unchanged - 17 fixed = 2333 total (was 2347)
          +1 mvnsite 9m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 51s The patch has no ill-formed XML file.
          +1 shadedclient 12m 6s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 28m 12s the patch passed
          +1 javadoc 5m 40s the patch passed
                Other Tests
          -1 unit 14m 48s root in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          236m 21s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0de40f0
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892739/HADOOP-14178.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux 1002e9b901bd 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2523e1c
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 78 new or modified test files.       trunk Compile Tests 0 mvndep 1m 26s Maven dependency ordering for branch +1 mvninstall 13m 22s trunk passed +1 compile 15m 18s trunk passed +1 checkstyle 2m 41s trunk passed +1 mvnsite 10m 1s trunk passed +1 shadedclient 23m 57s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 23m 48s trunk passed +1 javadoc 5m 27s trunk passed       Patch Compile Tests 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 37m 22s the patch passed +1 compile 12m 41s the patch passed -1 javac 12m 41s root generated 607 new + 1229 unchanged - 27 fixed = 1836 total (was 1256) -0 checkstyle 2m 39s root: The patch generated 3 new + 2330 unchanged - 17 fixed = 2333 total (was 2347) +1 mvnsite 9m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 51s The patch has no ill-formed XML file. +1 shadedclient 12m 6s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 28m 12s the patch passed +1 javadoc 5m 40s the patch passed       Other Tests -1 unit 14m 48s root in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 236m 21s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:0de40f0 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892739/HADOOP-14178.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux 1002e9b901bd 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2523e1c Default Java 1.8.0_144 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13540/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          005 patch

          • Rebased
          • Fixed test failures

          I'll run all the tests to check if there are some other test failures.

          Show
          ajisakaa Akira Ajisaka added a comment - 005 patch Rebased Fixed test failures I'll run all the tests to check if there are some other test failures.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Andras Bokor for the review. I found that the test failures without TestKDiag are related.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Andras Bokor for the review. I found that the test failures without TestKDiag are related. TestCopy: Since Mockito 2.1.0, ArgumentMatchers.any(Class<T>) does not treat null as a valid value. I fixed to use ArgumentMatchers.any() to accept null. http://static.javadoc.io/org.mockito/mockito-core/2.10.0/org/mockito/ArgumentMatchers.html#any-java.lang.Class- ViewFsBaseTest#testGetFileChecksum: There is a mock inside the real method of another mock, and it's broken after upgrade. Since this is a bad practice, I refactored the test case without callRealMethod() and the test passed after update.
          Hide
          boky01 Andras Bokor added a comment -

          The 607 javac warnings make sense:

          • 385 because Matchers class has been deprecated. ArgumentMatchers should be used instead.
          • 169 because of new WhiteBox.java
          • 6 because of org.mockito.runners.MockitoJUnitRunner was moved to org.mockito.junit.MockitoJUnitRunner.
          • The rest 47 warnings are because of Java8's Target Type feature. So in Mockito 2 any() can be used instead of anyObject, anyList insterad of anyListOf and so on.

          So all the 607 warnings because API change in Mockito so nothing dangerous.

          I think they can be fixed either with this JIRA or separate JIRA(s) it's up to you.

          Show
          boky01 Andras Bokor added a comment - The 607 javac warnings make sense: 385 because Matchers class has been deprecated. ArgumentMatchers should be used instead. 169 because of new WhiteBox.java 6 because of org.mockito.runners.MockitoJUnitRunner was moved to org.mockito.junit.MockitoJUnitRunner. The rest 47 warnings are because of Java8's Target Type feature. So in Mockito 2 any() can be used instead of anyObject, anyList insterad of anyListOf and so on. So all the 607 warnings because API change in Mockito so nothing dangerous. I think they can be fixed either with this JIRA or separate JIRA(s) it's up to you.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 76 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 13m 28s trunk passed
          +1 compile 14m 25s trunk passed
          +1 checkstyle 2m 32s trunk passed
          +1 mvnsite 9m 6s trunk passed
          +1 shadedclient 22m 48s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 21m 41s trunk passed
          +1 javadoc 4m 51s trunk passed
                Patch Compile Tests
          0 mvndep 0m 22s Maven dependency ordering for patch
          +1 mvninstall 33m 40s the patch passed
          +1 compile 11m 2s the patch passed
          -1 javac 11m 2s root generated 607 new + 1229 unchanged - 27 fixed = 1836 total (was 1256)
          +1 checkstyle 2m 39s root: The patch generated 0 new + 2224 unchanged - 17 fixed = 2224 total (was 2241)
          +1 mvnsite 9m 16s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 43s The patch has no ill-formed XML file.
          +1 shadedclient 11m 37s patch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 27m 46s the patch passed
          +1 javadoc 5m 4s the patch passed
                Other Tests
          -1 unit 14m 38s root in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          224m 25s



          Reason Tests
          Failed junit tests hadoop.fs.shell.TestCopy
            hadoop.security.TestKDiag
            hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
            hadoop.fs.viewfs.TestViewFsLocalFs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0de40f0
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892268/HADOOP-14178.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux 3b90459edbd7 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 87ea1df
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/diff-compile-javac-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 76 new or modified test files.       trunk Compile Tests 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 13m 28s trunk passed +1 compile 14m 25s trunk passed +1 checkstyle 2m 32s trunk passed +1 mvnsite 9m 6s trunk passed +1 shadedclient 22m 48s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 21m 41s trunk passed +1 javadoc 4m 51s trunk passed       Patch Compile Tests 0 mvndep 0m 22s Maven dependency ordering for patch +1 mvninstall 33m 40s the patch passed +1 compile 11m 2s the patch passed -1 javac 11m 2s root generated 607 new + 1229 unchanged - 27 fixed = 1836 total (was 1256) +1 checkstyle 2m 39s root: The patch generated 0 new + 2224 unchanged - 17 fixed = 2224 total (was 2241) +1 mvnsite 9m 16s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 43s The patch has no ill-formed XML file. +1 shadedclient 11m 37s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 27m 46s the patch passed +1 javadoc 5m 4s the patch passed       Other Tests -1 unit 14m 38s root in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 224m 25s Reason Tests Failed junit tests hadoop.fs.shell.TestCopy   hadoop.security.TestKDiag   hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs   hadoop.fs.viewfs.TestViewFsLocalFs Subsystem Report/Notes Docker Image:yetus/hadoop:0de40f0 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892268/HADOOP-14178.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux 3b90459edbd7 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 87ea1df Default Java 1.8.0_144 findbugs v3.1.0-RC1 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/diff-compile-javac-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13516/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          004: Add missing WhiteBox.java

          Show
          ajisakaa Akira Ajisaka added a comment - 004: Add missing WhiteBox.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 13m 23s trunk passed
          +1 compile 14m 28s trunk passed
          +1 checkstyle 2m 32s trunk passed
          +1 mvnsite 9m 11s trunk passed
          +1 shadedclient 22m 48s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 22m 19s trunk passed
          +1 javadoc 5m 16s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          -1 mvninstall 0m 39s hadoop-common in the patch failed.
          -1 mvninstall 0m 12s hadoop-nfs in the patch failed.
          -1 mvninstall 0m 13s hadoop-kms in the patch failed.
          -1 mvninstall 0m 16s hadoop-hdfs-client in the patch failed.
          -1 mvninstall 0m 29s hadoop-hdfs in the patch failed.
          -1 mvninstall 0m 14s hadoop-hdfs-httpfs in the patch failed.
          -1 mvninstall 0m 15s hadoop-hdfs-nfs in the patch failed.
          -1 mvninstall 0m 25s hadoop-yarn-common in the patch failed.
          -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed.
          -1 mvninstall 0m 17s hadoop-yarn-server-nodemanager in the patch failed.
          -1 mvninstall 0m 13s hadoop-yarn-server-web-proxy in the patch failed.
          -1 mvninstall 0m 15s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 mvninstall 0m 14s hadoop-yarn-server-timelineservice in the patch failed.
          -1 mvninstall 0m 20s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 mvninstall 0m 14s hadoop-yarn-server-tests in the patch failed.
          -1 mvninstall 0m 15s hadoop-yarn-client in the patch failed.
          -1 mvninstall 0m 12s hadoop-yarn-server-sharedcachemanager in the patch failed.
          -1 mvninstall 0m 12s hadoop-yarn-server-timeline-pluginstorage in the patch failed.
          -1 mvninstall 0m 13s hadoop-yarn-server-router in the patch failed.
          -1 mvninstall 0m 13s hadoop-yarn-applications-distributedshell in the patch failed.
          -1 mvninstall 0m 21s hadoop-mapreduce-client in the patch failed.
          -1 mvninstall 0m 20s hadoop-mapreduce-client-core in the patch failed.
          -1 mvninstall 0m 14s hadoop-mapreduce-client-hs in the patch failed.
          -1 mvninstall 0m 14s hadoop-mapreduce-client-nativetask in the patch failed.
          -1 mvninstall 0m 21s hadoop-mapreduce-project in the patch failed.
          -1 mvninstall 0m 14s hadoop-streaming in the patch failed.
          -1 mvninstall 0m 14s hadoop-distcp in the patch failed.
          -1 mvninstall 0m 12s hadoop-archives in the patch failed.
          -1 mvninstall 0m 14s hadoop-gridmix in the patch failed.
          -1 mvninstall 0m 12s hadoop-datajoin in the patch failed.
          -1 mvninstall 0m 13s hadoop-extras in the patch failed.
          -1 mvninstall 0m 13s hadoop-aws in the patch failed.
          -1 mvninstall 0m 12s hadoop-kafka in the patch failed.
          -1 mvninstall 0m 14s hadoop-azure in the patch failed.
          -1 mvninstall 1m 2s root in the patch failed.
          -1 compile 1m 4s root in the patch failed.
          -1 javac 1m 4s root in the patch failed.
          +1 checkstyle 2m 26s root: The patch generated 0 new + 2224 unchanged - 17 fixed = 2224 total (was 2241)
          -1 mvnsite 2m 0s root in the patch failed.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 47s The patch has no ill-formed XML file.
          -1 shadedclient 3m 8s patch has errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          -1 findbugs 0m 30s hadoop-common in the patch failed.
          -1 findbugs 0m 17s hadoop-nfs in the patch failed.
          -1 findbugs 0m 17s hadoop-kms in the patch failed.
          -1 findbugs 0m 25s hadoop-hdfs-client in the patch failed.
          -1 findbugs 0m 31s hadoop-hdfs in the patch failed.
          -1 findbugs 0m 18s hadoop-hdfs-httpfs in the patch failed.
          -1 findbugs 0m 17s hadoop-hdfs-nfs in the patch failed.
          -1 findbugs 0m 26s hadoop-yarn-common in the patch failed.
          -1 findbugs 0m 17s hadoop-yarn-server-common in the patch failed.
          -1 findbugs 0m 20s hadoop-yarn-server-nodemanager in the patch failed.
          -1 findbugs 0m 16s hadoop-yarn-server-web-proxy in the patch failed.
          -1 findbugs 0m 18s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 findbugs 0m 17s hadoop-yarn-server-timelineservice in the patch failed.
          -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 findbugs 0m 18s hadoop-yarn-client in the patch failed.
          -1 findbugs 0m 16s hadoop-yarn-server-sharedcachemanager in the patch failed.
          -1 findbugs 0m 16s hadoop-yarn-server-timeline-pluginstorage in the patch failed.
          -1 findbugs 0m 16s hadoop-yarn-server-router in the patch failed.
          -1 findbugs 0m 17s hadoop-yarn-applications-distributedshell in the patch failed.
          -1 findbugs 0m 23s hadoop-mapreduce-client-core in the patch failed.
          -1 findbugs 0m 18s hadoop-mapreduce-client-hs in the patch failed.
          -1 findbugs 0m 17s hadoop-mapreduce-client-nativetask in the patch failed.
          -1 findbugs 0m 18s hadoop-streaming in the patch failed.
          -1 findbugs 0m 16s hadoop-distcp in the patch failed.
          -1 findbugs 0m 16s hadoop-archives in the patch failed.
          -1 findbugs 0m 16s hadoop-gridmix in the patch failed.
          -1 findbugs 0m 18s hadoop-datajoin in the patch failed.
          -1 findbugs 0m 15s hadoop-extras in the patch failed.
          -1 findbugs 0m 18s hadoop-aws in the patch failed.
          -1 findbugs 0m 15s hadoop-kafka in the patch failed.
          -1 findbugs 0m 18s hadoop-azure in the patch failed.
          +1 javadoc 5m 12s the patch passed
                Other Tests
          -1 unit 6m 44s root in the patch failed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          151m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0de40f0
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892223/HADOOP-14178.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux 76ddf75bb17c 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 133d7ca
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-nfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-kms.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-streaming.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-gridmix.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-datajoin.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-aws.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-kafka.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-compile-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvnsite-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-nfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-streaming.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-distcp.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-archives.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-gridmix.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-datajoin.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-extras.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-aws.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-kafka.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 75 new or modified test files.       trunk Compile Tests 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 13m 23s trunk passed +1 compile 14m 28s trunk passed +1 checkstyle 2m 32s trunk passed +1 mvnsite 9m 11s trunk passed +1 shadedclient 22m 48s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 22m 19s trunk passed +1 javadoc 5m 16s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch -1 mvninstall 0m 39s hadoop-common in the patch failed. -1 mvninstall 0m 12s hadoop-nfs in the patch failed. -1 mvninstall 0m 13s hadoop-kms in the patch failed. -1 mvninstall 0m 16s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 29s hadoop-hdfs in the patch failed. -1 mvninstall 0m 14s hadoop-hdfs-httpfs in the patch failed. -1 mvninstall 0m 15s hadoop-hdfs-nfs in the patch failed. -1 mvninstall 0m 25s hadoop-yarn-common in the patch failed. -1 mvninstall 0m 15s hadoop-yarn-server-common in the patch failed. -1 mvninstall 0m 17s hadoop-yarn-server-nodemanager in the patch failed. -1 mvninstall 0m 13s hadoop-yarn-server-web-proxy in the patch failed. -1 mvninstall 0m 15s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 mvninstall 0m 14s hadoop-yarn-server-timelineservice in the patch failed. -1 mvninstall 0m 20s hadoop-yarn-server-resourcemanager in the patch failed. -1 mvninstall 0m 14s hadoop-yarn-server-tests in the patch failed. -1 mvninstall 0m 15s hadoop-yarn-client in the patch failed. -1 mvninstall 0m 12s hadoop-yarn-server-sharedcachemanager in the patch failed. -1 mvninstall 0m 12s hadoop-yarn-server-timeline-pluginstorage in the patch failed. -1 mvninstall 0m 13s hadoop-yarn-server-router in the patch failed. -1 mvninstall 0m 13s hadoop-yarn-applications-distributedshell in the patch failed. -1 mvninstall 0m 21s hadoop-mapreduce-client in the patch failed. -1 mvninstall 0m 20s hadoop-mapreduce-client-core in the patch failed. -1 mvninstall 0m 14s hadoop-mapreduce-client-hs in the patch failed. -1 mvninstall 0m 14s hadoop-mapreduce-client-nativetask in the patch failed. -1 mvninstall 0m 21s hadoop-mapreduce-project in the patch failed. -1 mvninstall 0m 14s hadoop-streaming in the patch failed. -1 mvninstall 0m 14s hadoop-distcp in the patch failed. -1 mvninstall 0m 12s hadoop-archives in the patch failed. -1 mvninstall 0m 14s hadoop-gridmix in the patch failed. -1 mvninstall 0m 12s hadoop-datajoin in the patch failed. -1 mvninstall 0m 13s hadoop-extras in the patch failed. -1 mvninstall 0m 13s hadoop-aws in the patch failed. -1 mvninstall 0m 12s hadoop-kafka in the patch failed. -1 mvninstall 0m 14s hadoop-azure in the patch failed. -1 mvninstall 1m 2s root in the patch failed. -1 compile 1m 4s root in the patch failed. -1 javac 1m 4s root in the patch failed. +1 checkstyle 2m 26s root: The patch generated 0 new + 2224 unchanged - 17 fixed = 2224 total (was 2241) -1 mvnsite 2m 0s root in the patch failed. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 47s The patch has no ill-formed XML file. -1 shadedclient 3m 8s patch has errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . -1 findbugs 0m 30s hadoop-common in the patch failed. -1 findbugs 0m 17s hadoop-nfs in the patch failed. -1 findbugs 0m 17s hadoop-kms in the patch failed. -1 findbugs 0m 25s hadoop-hdfs-client in the patch failed. -1 findbugs 0m 31s hadoop-hdfs in the patch failed. -1 findbugs 0m 18s hadoop-hdfs-httpfs in the patch failed. -1 findbugs 0m 17s hadoop-hdfs-nfs in the patch failed. -1 findbugs 0m 26s hadoop-yarn-common in the patch failed. -1 findbugs 0m 17s hadoop-yarn-server-common in the patch failed. -1 findbugs 0m 20s hadoop-yarn-server-nodemanager in the patch failed. -1 findbugs 0m 16s hadoop-yarn-server-web-proxy in the patch failed. -1 findbugs 0m 18s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 findbugs 0m 17s hadoop-yarn-server-timelineservice in the patch failed. -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. -1 findbugs 0m 18s hadoop-yarn-client in the patch failed. -1 findbugs 0m 16s hadoop-yarn-server-sharedcachemanager in the patch failed. -1 findbugs 0m 16s hadoop-yarn-server-timeline-pluginstorage in the patch failed. -1 findbugs 0m 16s hadoop-yarn-server-router in the patch failed. -1 findbugs 0m 17s hadoop-yarn-applications-distributedshell in the patch failed. -1 findbugs 0m 23s hadoop-mapreduce-client-core in the patch failed. -1 findbugs 0m 18s hadoop-mapreduce-client-hs in the patch failed. -1 findbugs 0m 17s hadoop-mapreduce-client-nativetask in the patch failed. -1 findbugs 0m 18s hadoop-streaming in the patch failed. -1 findbugs 0m 16s hadoop-distcp in the patch failed. -1 findbugs 0m 16s hadoop-archives in the patch failed. -1 findbugs 0m 16s hadoop-gridmix in the patch failed. -1 findbugs 0m 18s hadoop-datajoin in the patch failed. -1 findbugs 0m 15s hadoop-extras in the patch failed. -1 findbugs 0m 18s hadoop-aws in the patch failed. -1 findbugs 0m 15s hadoop-kafka in the patch failed. -1 findbugs 0m 18s hadoop-azure in the patch failed. +1 javadoc 5m 12s the patch passed       Other Tests -1 unit 6m 44s root in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 151m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:0de40f0 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892223/HADOOP-14178.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux 76ddf75bb17c 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 133d7ca Default Java 1.8.0_144 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-nfs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-kms.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-nfs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-streaming.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-gridmix.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-datajoin.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-aws.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-kafka.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-compile-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-mvnsite-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-nfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-nfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-streaming.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-distcp.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-archives.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-gridmix.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-datajoin.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-extras.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-aws.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-kafka.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13514/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          003: fixed compilation failure

          Show
          ajisakaa Akira Ajisaka added a comment - 003: fixed compilation failure
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 58 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 35s Maven dependency ordering for branch
          +1 mvninstall 13m 42s trunk passed
          +1 compile 14m 19s trunk passed
          +1 checkstyle 2m 19s trunk passed
          +1 mvnsite 10m 34s trunk passed
          +1 shadedclient 23m 56s branch has no errors when building and testing our client artifacts.
          0 findbugs 0m 1s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          +1 findbugs 22m 18s trunk passed
          +1 javadoc 5m 41s trunk passed
                Patch Compile Tests
          0 mvndep 0m 23s Maven dependency ordering for patch
          -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed.
          -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 mvninstall 0m 22s hadoop-yarn-client in the patch failed.
          -1 mvninstall 0m 35s hadoop-mapreduce-client in the patch failed.
          -1 mvninstall 0m 31s hadoop-mapreduce-client-core in the patch failed.
          -1 mvninstall 0m 31s hadoop-mapreduce-project in the patch failed.
          -1 mvninstall 0m 25s hadoop-aws in the patch failed.
          -1 mvninstall 0m 22s hadoop-azure in the patch failed.
          -1 mvninstall 5m 6s root in the patch failed.
          -1 compile 4m 34s root in the patch failed.
          -1 javac 4m 34s root in the patch failed.
          +1 checkstyle 2m 16s root: The patch generated 0 new + 1199 unchanged - 3 fixed = 1199 total (was 1202)
          -1 mvnsite 4m 44s root in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 44s The patch has no ill-formed XML file.
          -1 shadedclient 4m 49s patch has errors when building and testing our client artifacts.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster .
          -1 findbugs 0m 25s hadoop-yarn-server-nodemanager in the patch failed.
          -1 findbugs 0m 30s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 findbugs 0m 23s hadoop-yarn-client in the patch failed.
          -1 findbugs 0m 24s hadoop-mapreduce-client-core in the patch failed.
          -1 findbugs 0m 22s hadoop-aws in the patch failed.
          -1 findbugs 0m 22s hadoop-azure in the patch failed.
          +1 javadoc 4m 54s the patch passed
                Other Tests
          -1 unit 14m 8s root in the patch failed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          194m 12s



          Reason Tests
          Failed junit tests hadoop.fs.shell.TestCopy
            hadoop.security.TestKDiag
            hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
            hadoop.fs.viewfs.TestViewFsLocalFs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0de40f0
          JIRA Issue HADOOP-14178
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892205/HADOOP-14178.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
          uname Linux 95a60026c216 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 133d7ca
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-aws.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-compile-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvnsite-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-aws.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 58 new or modified test files.       trunk Compile Tests 0 mvndep 1m 35s Maven dependency ordering for branch +1 mvninstall 13m 42s trunk passed +1 compile 14m 19s trunk passed +1 checkstyle 2m 19s trunk passed +1 mvnsite 10m 34s trunk passed +1 shadedclient 23m 56s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 1s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . +1 findbugs 22m 18s trunk passed +1 javadoc 5m 41s trunk passed       Patch Compile Tests 0 mvndep 0m 23s Maven dependency ordering for patch -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed. -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed. -1 mvninstall 0m 22s hadoop-yarn-client in the patch failed. -1 mvninstall 0m 35s hadoop-mapreduce-client in the patch failed. -1 mvninstall 0m 31s hadoop-mapreduce-client-core in the patch failed. -1 mvninstall 0m 31s hadoop-mapreduce-project in the patch failed. -1 mvninstall 0m 25s hadoop-aws in the patch failed. -1 mvninstall 0m 22s hadoop-azure in the patch failed. -1 mvninstall 5m 6s root in the patch failed. -1 compile 4m 34s root in the patch failed. -1 javac 4m 34s root in the patch failed. +1 checkstyle 2m 16s root: The patch generated 0 new + 1199 unchanged - 3 fixed = 1199 total (was 1202) -1 mvnsite 4m 44s root in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 44s The patch has no ill-formed XML file. -1 shadedclient 4m 49s patch has errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project hadoop-client-modules/hadoop-client-minicluster . -1 findbugs 0m 25s hadoop-yarn-server-nodemanager in the patch failed. -1 findbugs 0m 30s hadoop-yarn-server-resourcemanager in the patch failed. -1 findbugs 0m 23s hadoop-yarn-client in the patch failed. -1 findbugs 0m 24s hadoop-mapreduce-client-core in the patch failed. -1 findbugs 0m 22s hadoop-aws in the patch failed. -1 findbugs 0m 22s hadoop-azure in the patch failed. +1 javadoc 4m 54s the patch passed       Other Tests -1 unit 14m 8s root in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 194m 12s Reason Tests Failed junit tests hadoop.fs.shell.TestCopy   hadoop.security.TestKDiag   hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs   hadoop.fs.viewfs.TestViewFsLocalFs Subsystem Report/Notes Docker Image:yetus/hadoop:0de40f0 JIRA Issue HADOOP-14178 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892205/HADOOP-14178.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle uname Linux 95a60026c216 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 133d7ca Default Java 1.8.0_144 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-aws.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-azure.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-compile-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-mvnsite-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-aws.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-azure.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-minicluster . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13510/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Andras Bokor for the review! I'll update the patch shortly.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Andras Bokor for the review! I'll update the patch shortly.
          Hide
          boky01 Andras Bokor added a comment -

          Akira Ajisaka,
          I found only some very minor thing:

          1. Declaration of InfoWithSameName class is now longer than 80 chars (it was 79 before the patch)
          2. InfoWithSameName: return expected.equals((info).name()); brackets around info seem unnecessary

          Otherwise looks good.

          Show
          boky01 Andras Bokor added a comment - Akira Ajisaka , I found only some very minor thing: Declaration of InfoWithSameName class is now longer than 80 chars (it was 79 before the patch) InfoWithSameName: return expected.equals((info).name()); brackets around info seem unnecessary Otherwise looks good.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch. This includes HADOOP-14188.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch. This includes HADOOP-14188 .
          Hide
          busbey Sean Busbey added a comment -

          Ted Yu
          Can Hbase use hadoop shaded jars to avoid these kind of issue?

          Maybe in the future? Right now HBase's dependency on Hadoop is kind of messy for a few reasons.

          1. we have to keep working on top of Hadoop 2.x and Hadoop 3.x. We mostly have this abstracted.
          2. we have parts of HBase that make use of Hadoop internals such that we can't currently move all of the Hadoop-3 build version on to the client artifacts
          3. The parts of HBase that use Hadoop internals are currently all mixed up with parts that are proper downstream consumers, so we can't even e.g. isolate the problem parts and then avoid mockito there.
          Show
          busbey Sean Busbey added a comment - Ted Yu Can Hbase use hadoop shaded jars to avoid these kind of issue? Maybe in the future? Right now HBase's dependency on Hadoop is kind of messy for a few reasons. we have to keep working on top of Hadoop 2.x and Hadoop 3.x. We mostly have this abstracted. we have parts of HBase that make use of Hadoop internals such that we can't currently move all of the Hadoop-3 build version on to the client artifacts The parts of HBase that use Hadoop internals are currently all mixed up with parts that are proper downstream consumers, so we can't even e.g. isolate the problem parts and then avoid mockito there.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Logged HDFS-12599

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Logged HDFS-12599
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Ted, the problem you have is that HDFS-11164 restored the dependency MiniDFS cluster had on mockito which HDFS-9226 cut away. If you can move the new method DataNodeTestUtils.mockDatanodeBlkPinning to a new class of mock test utils, we can make this stack trace go away

          Show
          stevel@apache.org Steve Loughran added a comment - Ted, the problem you have is that HDFS-11164 restored the dependency MiniDFS cluster had on mockito which HDFS-9226 cut away. If you can move the new method DataNodeTestUtils.mockDatanodeBlkPinning to a new class of mock test utils, we can make this stack trace go away
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm seeing both Mockito 1.8.5 and 1.10.19 have the interface, anyway using shaded jars seems fine. You can use hadoop-client-minicluster instead of hadoop-minicluster. Thanks Ted Yu and Bharat Viswanadham.

          Show
          ajisakaa Akira Ajisaka added a comment - I'm seeing both Mockito 1.8.5 and 1.10.19 have the interface, anyway using shaded jars seems fine. You can use hadoop-client-minicluster instead of hadoop-minicluster. Thanks Ted Yu and Bharat Viswanadham .
          Hide
          bharatviswa Bharat Viswanadham added a comment -

          Ted Yu
          Can Hbase use hadoop shaded jars to avoid these kind of issue?

          Show
          bharatviswa Bharat Viswanadham added a comment - Ted Yu Can Hbase use hadoop shaded jars to avoid these kind of issue?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          However mockito 1.10.19 doesn't have it.
          MiniDFSCluster would use 1.10.19 in hbase tests.

          HBASE-18925 is upgrading to mockito 2.1.0 :

          -    <mockito-all.version>1.10.19</mockito-all.version>
          +    <mockito-core.version>2.1.0</mockito-core.version>
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - However mockito 1.10.19 doesn't have it. MiniDFSCluster would use 1.10.19 in hbase tests. HBASE-18925 is upgrading to mockito 2.1.0 : - <mockito-all.version>1.10.19</mockito-all.version> + <mockito-core.version>2.1.0</mockito-core.version>
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Umm, Mockito 1.8.5 has org.mockito.stubbing.Answer, so I don't think the NoClassDefFoundError is caused by the conflict of the Mockito versions.

          Show
          ajisakaa Akira Ajisaka added a comment - Umm, Mockito 1.8.5 has org.mockito.stubbing.Answer, so I don't think the NoClassDefFoundError is caused by the conflict of the Mockito versions.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed HADOOP-14932.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed HADOOP-14932 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Now I don't think this is going to Hadoop 3.0 GA.

          If not, how about upgrading to 1.10.19 for hadoop-3 ?

          Agreed. I'll file a jira.

          Show
          ajisakaa Akira Ajisaka added a comment - Now I don't think this is going to Hadoop 3.0 GA. If not, how about upgrading to 1.10.19 for hadoop-3 ? Agreed. I'll file a jira.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment - - edited

          Is this going to hadoop-3 beta / GA ?

          If not, how about upgrading to 1.10.19 for hadoop-3 ?

          I got the following when starting hadoop-3 mini dfs cluster within hbase unit test:

          2017-10-05 08:31:26,525 WARN  [main] hbase.HBaseTestingUtility(1077): error starting mini dfs
          java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
            at org.apache.hadoop.hdfs.MiniDFSCluster.shouldWait(MiniDFSCluster.java:2668)
            at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2564)
            at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2607)
            at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1667)
            at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:874)
            at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:769)
            at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:661)
            at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1075)
            at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:953)
          

          hbase uses mockito-all 1.10.19

          If I downgrade to 1.8.5 (hadoop), hbase code won't compile:

          [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java:[146,62] cannot find symbol
          [ERROR] symbol:   method getArgumentAt(int,java.lang.Class<org.apache.hadoop.hbase.client.ScannerCallableWithReplicas>)
          [ERROR] location: variable invocation of type org.mockito.invocation.InvocationOnMock
          [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java:[207,60] cannot find symbol
          [ERROR] symbol:   method getArgumentAt(int,java.lang.Class<org.apache.hadoop.hbase.client.ScannerCallableWithReplicas>)
          [ERROR] location: variable invocation of type org.mockito.invocation.InvocationOnMock
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - - edited Is this going to hadoop-3 beta / GA ? If not, how about upgrading to 1.10.19 for hadoop-3 ? I got the following when starting hadoop-3 mini dfs cluster within hbase unit test: 2017-10-05 08:31:26,525 WARN [main] hbase.HBaseTestingUtility(1077): error starting mini dfs java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer at org.apache.hadoop.hdfs.MiniDFSCluster.shouldWait(MiniDFSCluster.java:2668) at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2564) at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2607) at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1667) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:874) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:769) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:661) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1075) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:953) hbase uses mockito-all 1.10.19 If I downgrade to 1.8.5 (hadoop), hbase code won't compile: [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java:[146,62] cannot find symbol [ERROR] symbol: method getArgumentAt( int ,java.lang. Class <org.apache.hadoop.hbase.client.ScannerCallableWithReplicas>) [ERROR] location: variable invocation of type org.mockito.invocation.InvocationOnMock [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java:[207,60] cannot find symbol [ERROR] symbol: method getArgumentAt( int ,java.lang. Class <org.apache.hadoop.hbase.client.ScannerCallableWithReplicas>) [ERROR] location: variable invocation of type org.mockito.invocation.InvocationOnMock
          Hide
          boky01 Andras Bokor added a comment -

          FYI,
          mvn javadoc:test-javadoc goal generates errors because we use mockito-all.
          mockito-all includes Hamcrest classes but a different version. Let's see TestReflectionUtils as an example:
          import static org.hamcrest.CoreMatchers.containsString; will result in error.
          Somehow mvn javadoc:test-javadoc will find Mockito's CoreMatchers class on the classpath which has no containsString method.

          I did not raise new JIRA for this since from Mockito 2 the mockito-all is discontinued so this ticket will solve this.
          Any way I can help on this?

          Show
          boky01 Andras Bokor added a comment - FYI, mvn javadoc:test-javadoc goal generates errors because we use mockito-all. mockito-all includes Hamcrest classes but a different version. Let's see TestReflectionUtils as an example: import static org.hamcrest.CoreMatchers.containsString; will result in error. Somehow mvn javadoc:test-javadoc will find Mockito's CoreMatchers class on the classpath which has no containsString method. I did not raise new JIRA for this since from Mockito 2 the mockito-all is discontinued so this ticket will solve this. Any way I can help on this?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          FYI: This blocks HADOOP-11123 since Mockito 1.x does not support Java9.

          Show
          ajisakaa Akira Ajisaka added a comment - FYI: This blocks HADOOP-11123 since Mockito 1.x does not support Java9.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed HADOOP-14245 for replacing Mockito.stub with Mockito.when.

          For ArgumentMatcher, we need to fix the code when upgrading Mockito.
          https://github.com/mockito/mockito/blob/v2.7.19/src/main/java/org/mockito/ArgumentMatcher.java#L88

           * All existing custom implementations of <code>ArgumentMatcher</code> will no longer compile.
           * All locations where hamcrest matchers are passed to <code>argThat()</code> will no longer compile.
           * There are 2 approaches to fix the problems:
           * <ul>
           * <li>a) Refactor the hamcrest matcher to Mockito matcher:
           * Use "implements ArgumentMatcher" instead of "extends ArgumentMatcher".
           * Then refactor <code>describeTo()</code> method into <code>toString()</code> method.
           * </li>
           * <li>
           * b) Use <code>org.mockito.hamcrest.MockitoHamcrest.argThat()</code> instead of <code>Mockito.argThat()</code>.
           * Ensure that there is <a href="http://hamcrest.org/JavaHamcrest/">hamcrest</a> dependency on classpath
           * (Mockito does not depend on hamcrest any more).
          

          I prefer option a) because it does not depend on hamcrest.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed HADOOP-14245 for replacing Mockito.stub with Mockito.when. For ArgumentMatcher, we need to fix the code when upgrading Mockito. https://github.com/mockito/mockito/blob/v2.7.19/src/main/java/org/mockito/ArgumentMatcher.java#L88 * All existing custom implementations of <code>ArgumentMatcher</code> will no longer compile. * All locations where hamcrest matchers are passed to <code>argThat()</code> will no longer compile. * There are 2 approaches to fix the problems: * <ul> * <li>a) Refactor the hamcrest matcher to Mockito matcher: * Use " implements ArgumentMatcher" instead of " extends ArgumentMatcher" . * Then refactor <code>describeTo()</code> method into <code>toString()</code> method. * </li> * <li> * b) Use <code>org.mockito.hamcrest.MockitoHamcrest.argThat()</code> instead of <code>Mockito.argThat()</code>. * Ensure that there is <a href= "http: //hamcrest.org/JavaHamcrest/" >hamcrest</a> dependency on classpath * (Mockito does not depend on hamcrest any more). I prefer option a) because it does not depend on hamcrest.
          Hide
          ajisakaa Akira Ajisaka added a comment -
          Show
          ajisakaa Akira Ajisaka added a comment - Filed HADOOP-14188
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The upgrade will be very big change, so I'd like to split this into some sub-tasks to reduce the cost of review. The first sub-task is to remove the usage of Whitebox, which was removed in Mockito 2.1. I'll add sub-tasks later if needed.

          Show
          ajisakaa Akira Ajisaka added a comment - The upgrade will be very big change, so I'd like to split this into some sub-tasks to reduce the cost of review. The first sub-task is to remove the usage of Whitebox, which was removed in Mockito 2.1. I'll add sub-tasks later if needed.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Why not get on the common developer list and ask for advice. Right now, this week, one where help would be appreciated is probably just in downloading, testing the Hadoop 2.8.0 RC that's been put up

          Show
          stevel@apache.org Steve Loughran added a comment - Why not get on the common developer list and ask for advice. Right now, this week, one where help would be appreciated is probably just in downloading, testing the Hadoop 2.8.0 RC that's been put up
          Hide
          anujjain Anuj Jain added a comment -

          Steve, I understand what you mean.Can you please help me choosing a smaller task to start.

          Show
          anujjain Anuj Jain added a comment - Steve, I understand what you mean.Can you please help me choosing a smaller task to start.
          Hide
          stevel@apache.org Steve Loughran added a comment - - edited

          Anuj, I would advise you to tread carefully with this one, as it's a bigger patch than it looks

          • updating POMs have dramatic consequences downstream
          • if the imports change, it will span more of the code
          • If it finds bugs in tests, the tests need to be changed, which means that the patch will need to work out the real intent of the test, otherwise the fix could actually hide problems.

          I think we'd be scared of any big patch for this. A small one, fine. But big: it'll span the hadoop modules, need review, and so likely to stutter along.

          Show
          stevel@apache.org Steve Loughran added a comment - - edited Anuj, I would advise you to tread carefully with this one, as it's a bigger patch than it looks updating POMs have dramatic consequences downstream if the imports change, it will span more of the code If it finds bugs in tests, the tests need to be changed, which means that the patch will need to work out the real intent of the test, otherwise the fix could actually hide problems. I think we'd be scared of any big patch for this. A small one, fine. But big: it'll span the hadoop modules, need review, and so likely to stutter along.
          Hide
          anujjain Anuj Jain added a comment -

          Can I take up this task.I am new to hadoop project and I am looking for a task to start contributing

          Show
          anujjain Anuj Jain added a comment - Can I take up this task.I am new to hadoop project and I am looking for a task to start contributing
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Not an easy update, at least from one review https://asolntsev.github.io/en/2016/10/11/mockito-2.1/

          No just from API changes, but a stricter tool finds problems in existing mock declarations. And, given how the outcome on failed mocks is usually a stack trace of hard-to-diagnose issues, that could take time.

          The change long makes it clear that for full java 8 support, the update is needed. But: as its not a published dependency of any production artifact, just the test ones, it is a JAR which can be upgraded with less risk than others

          Show
          stevel@apache.org Steve Loughran added a comment - Not an easy update, at least from one review https://asolntsev.github.io/en/2016/10/11/mockito-2.1/ No just from API changes, but a stricter tool finds problems in existing mock declarations. And, given how the outcome on failed mocks is usually a stack trace of hard-to-diagnose issues, that could take time. The change long makes it clear that for full java 8 support, the update is needed. But: as its not a published dependency of any production artifact, just the test ones, it is a JAR which can be upgraded with less risk than others

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:

                Development