Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None
    • Target Version/s:

      Description

      The current version is 1.8.5 - inserted in 2011.

      JDK 8 has been supported since 1.10.0.
      https://github.com/mockito/mockito/blob/master/doc/release-notes/official.md

      "Compatible with JDK8 with exception of defender methods, JDK8 support will improve in 2.0"
      http://mockito.org/

      1. HADOOP-12427.v0.patch
        0.4 kB
        Giovanni Matteo Fumarola

        Issue Links

          Activity

          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          No test needed

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - No test needed
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 13s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 9m 27s There were no new javac warning messages.
          +1 javadoc 11m 44s There were no new javadoc warning messages.
          +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 51s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
              43m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761772/HADOOP-12427.v0.patch
          Optional Tests javadoc javac unit
          git revision trunk / cc2b473
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7687/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7687/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 27s There were no new javac warning messages. +1 javadoc 11m 44s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 51s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.     43m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761772/HADOOP-12427.v0.patch Optional Tests javadoc javac unit git revision trunk / cc2b473 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7687/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7687/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I just tried to apply this locally and it didn't apply. Let's see what jenkins does...

          Show
          stevel@apache.org Steve Loughran added a comment - I just tried to apply this locally and it didn't apply. Let's see what jenkins does...
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          FYI: on my local, "git apply -p0 HADOOP-12427.v0.patch" works well.

          Show
          ozawa Tsuyoshi Ozawa added a comment - FYI: on my local, "git apply -p0 HADOOP-12427 .v0.patch" works well.
          Hide
          giovanni.fumarola Giovanni Matteo Fumarola added a comment -

          Steve Loughran The patch works fine in the current trunk.
          I selected all the tests that use Mockito (find . -name Test*.java -exec grep -H org.mockito.Mockito {} \; | cut -d ':' -f 1 | sort | uniq | while read f; do basename $f .java ; done)
          and I executed all to see if the new version creates trouble in trunk.

          I got 2 failures with the new version:
          --) TestEditLogRace.testSaveRightBeforeSync:515 null
          --) TestResourceLocalizationService.testFailedDirsResourceRelease:2333
          Argument(s) are different! Wanted:
          eventHandler.handle(
          <custom argument matcher>
          );
          -> at org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService.testFailedDirsResourceRelease(TestResourceLocalizationService.java:2333)
          Actual invocation has different arguments:
          eventHandler.handle(
          EventType: APPLICATION_INITED
          );
          -> at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:183)

          Any hints?

          Show
          giovanni.fumarola Giovanni Matteo Fumarola added a comment - Steve Loughran The patch works fine in the current trunk. I selected all the tests that use Mockito (find . -name Test*.java -exec grep -H org.mockito.Mockito {} \; | cut -d ':' -f 1 | sort | uniq | while read f; do basename $f .java ; done) and I executed all to see if the new version creates trouble in trunk. I got 2 failures with the new version: --) TestEditLogRace.testSaveRightBeforeSync:515 null --) TestResourceLocalizationService.testFailedDirsResourceRelease:2333 Argument(s) are different! Wanted: eventHandler.handle( <custom argument matcher> ); -> at org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService.testFailedDirsResourceRelease(TestResourceLocalizationService.java:2333) Actual invocation has different arguments: eventHandler.handle( EventType: APPLICATION_INITED ); -> at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:183) Any hints?
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Giovanni Matteo Fumarola I got the same error even when I upgraded mockito version to 1.9.0. One possibility is that some incompatible change happen in 1.9.0.

          https://code.google.com/p/mockito/issues/list?can=1&q=label%3AMilestone-Release1.9&colspec=ID+Type+Status+Priority+Milestone+Owner+Summary&cells=tiles

          Show
          ozawa Tsuyoshi Ozawa added a comment - Giovanni Matteo Fumarola I got the same error even when I upgraded mockito version to 1.9.0. One possibility is that some incompatible change happen in 1.9.0. https://code.google.com/p/mockito/issues/list?can=1&q=label%3AMilestone-Release1.9&colspec=ID+Type+Status+Priority+Milestone+Owner+Summary&cells=tiles
          Hide
          stevel@apache.org Steve Loughran added a comment -

          given mockito is only used @ test time, is it an issue that things aren't backwards compatible here? We aren't exporting any mockito tests for downstream use, after all, so other apps can stay on the older version

          Show
          stevel@apache.org Steve Loughran added a comment - given mockito is only used @ test time, is it an issue that things aren't backwards compatible here? We aren't exporting any mockito tests for downstream use, after all, so other apps can stay on the older version
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 54s trunk passed
          +1 compile 0m 8s trunk passed with JDK v1.8.0_66
          +1 compile 0m 9s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 13s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 9s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 7s the patch passed
          +1 compile 0m 5s the patch passed with JDK v1.8.0_66
          +1 javac 0m 5s the patch passed
          +1 compile 0m 6s the patch passed with JDK v1.7.0_91
          +1 javac 0m 6s the patch passed
          +1 mvnsite 0m 10s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 7s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 8s the patch passed with JDK v1.7.0_91
          +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          11m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12761772/HADOOP-12427.v0.patch
          JIRA Issue HADOOP-12427
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 7a5588bb0c14 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c0537bc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8401/testReport/
          modules C: hadoop-project U: hadoop-project
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8401/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 54s trunk passed +1 compile 0m 8s trunk passed with JDK v1.8.0_66 +1 compile 0m 9s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 13s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 9s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 7s the patch passed +1 compile 0m 5s the patch passed with JDK v1.8.0_66 +1 javac 0m 5s the patch passed +1 compile 0m 6s the patch passed with JDK v1.7.0_91 +1 javac 0m 6s the patch passed +1 mvnsite 0m 10s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 8s the patch passed with JDK v1.7.0_91 +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.8.0_66. +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 11m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12761772/HADOOP-12427.v0.patch JIRA Issue HADOOP-12427 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 7a5588bb0c14 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c0537bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8401/testReport/ modules C: hadoop-project U: hadoop-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8401/console This message was automatically generated.

            People

            • Assignee:
              giovanni.fumarola Giovanni Matteo Fumarola
              Reporter:
              giovanni.fumarola Giovanni Matteo Fumarola
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development