Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: conf
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      Changes the type of JobConf.DEFAULT_LOG_LEVEL from a Log4J Level to a String. Clients that referenced this field will need to be recompiled and may need to alter their source to account for the type change. The level itself remains conceptually at "INFO".
      Show
      Changes the type of JobConf.DEFAULT_LOG_LEVEL from a Log4J Level to a String. Clients that referenced this field will need to be recompiled and may need to alter their source to account for the type change. The level itself remains conceptually at "INFO".

      Description

      Replace the use of log4j classes from JobConf so that the dependency is not needed unless folks are making use of our custom log4j appenders or loading a logging bridge to use that system.

      1. HADOOP-13921.0.patch
        3 kB
        Sean Busbey
      2. HADOOP-13921.1.patch
        4 kB
        Sean Busbey

        Issue Links

          Activity

          Hide
          busbey Sean Busbey added a comment -

          -00

          • replace DEFAULT_LOG_LEVEL with equivalent value already present in MR internals.

          I have to test this still, but looks like it should be a simple change to use an existing string representation. I can't find anything internal to Hadoop that actually made use of the Log4J Level directly.

          Show
          busbey Sean Busbey added a comment - -00 replace DEFAULT_LOG_LEVEL with equivalent value already present in MR internals. I have to test this still, but looks like it should be a simple change to use an existing string representation. I can't find anything internal to Hadoop that actually made use of the Log4J Level directly.
          Hide
          andrew.wang Andrew Wang added a comment -

          FWIW I grepped all of CDH for DEFAULT_LOG_LEVEL and it's not referred to anywhere besides Hadoop.

          Show
          andrew.wang Andrew Wang added a comment - FWIW I grepped all of CDH for DEFAULT_LOG_LEVEL and it's not referred to anywhere besides Hadoop.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 14m 22s trunk passed
          +1 compile 15m 41s trunk passed
          +1 checkstyle 1m 57s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 1m 7s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 1m 24s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 57s the patch passed
          +1 compile 15m 21s the patch passed
          +1 javac 15m 21s the patch passed
          +1 checkstyle 1m 59s the patch passed
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 1m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 2m 26s the patch passed
          -1 javadoc 0m 35s hadoop-mapreduce-client-core in the patch failed.
          +1 unit 2m 57s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 0m 56s hadoop-mapreduce-client-common in the patch passed.
          +1 unit 0m 23s hadoop-client-runtime in the patch passed.
          +1 asflicense 0m 42s The patch does not generate ASF License warnings.
          96m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13921
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866447/HADOOP-13921.0.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux ebac005b39c9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 81092b1
          Default Java 1.8.0_121
          findbugs v3.1.0-RC1
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/artifact/patchprocess/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 14m 22s trunk passed +1 compile 15m 41s trunk passed +1 checkstyle 1m 57s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 1m 7s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 1m 50s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 57s the patch passed +1 compile 15m 21s the patch passed +1 javac 15m 21s the patch passed +1 checkstyle 1m 59s the patch passed +1 mvnsite 1m 36s the patch passed +1 mvneclipse 1m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 2m 26s the patch passed -1 javadoc 0m 35s hadoop-mapreduce-client-core in the patch failed. +1 unit 2m 57s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 56s hadoop-mapreduce-client-common in the patch passed. +1 unit 0m 23s hadoop-client-runtime in the patch passed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 96m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866447/HADOOP-13921.0.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux ebac005b39c9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81092b1 Default Java 1.8.0_121 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/artifact/patchprocess/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12239/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Adjusting JIRA fields since we'd like this in for alpha3.

          Show
          andrew.wang Andrew Wang added a comment - Adjusting JIRA fields since we'd like this in for alpha3.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Javadoc errors are related to the patch. Would you fix them?

          [ERROR] /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java:335: error: reference not found
          [ERROR] * Configuration key to set the logging {@link Level} for the map task.
          [ERROR] ^
          [ERROR] /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java:344: error: reference not found
          [ERROR] * Configuration key to set the logging {@link Level} for the reduce task.
          [ERROR] ^
          
          Show
          ajisakaa Akira Ajisaka added a comment - Javadoc errors are related to the patch. Would you fix them? [ERROR] /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java:335: error: reference not found [ERROR] * Configuration key to set the logging {@link Level} for the map task. [ERROR] ^ [ERROR] /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java:344: error: reference not found [ERROR] * Configuration key to set the logging {@link Level} for the reduce task. [ERROR] ^
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 15m 0s trunk passed
          +1 compile 14m 42s trunk passed
          +1 checkstyle 2m 1s trunk passed
          +1 mvnsite 1m 31s trunk passed
          +1 mvneclipse 1m 9s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 2m 2s trunk passed
          +1 javadoc 1m 24s trunk passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 2m 50s the patch passed
          +1 compile 15m 27s the patch passed
          +1 javac 15m 27s the patch passed
          +1 checkstyle 1m 57s the patch passed
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 1m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 2m 5s the patch passed
          -1 javadoc 0m 35s hadoop-mapreduce-client-core in the patch failed.
          +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 0m 55s hadoop-mapreduce-client-common in the patch passed.
          +1 unit 0m 26s hadoop-client-runtime in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          95m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13921
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866447/HADOOP-13921.0.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 0fc543a04b0c 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9855225
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/artifact/patchprocess/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 15m 0s trunk passed +1 compile 14m 42s trunk passed +1 checkstyle 2m 1s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 1m 9s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 2m 2s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 50s the patch passed +1 compile 15m 27s the patch passed +1 javac 15m 27s the patch passed +1 checkstyle 1m 57s the patch passed +1 mvnsite 1m 33s the patch passed +1 mvneclipse 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 2m 5s the patch passed -1 javadoc 0m 35s hadoop-mapreduce-client-core in the patch failed. +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 55s hadoop-mapreduce-client-common in the patch passed. +1 unit 0m 26s hadoop-client-runtime in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 95m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866447/HADOOP-13921.0.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 0fc543a04b0c 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9855225 Default Java 1.8.0_131 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/artifact/patchprocess/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12367/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          Sean Busbey, can you add details on the incompatible change to the release notes field? I'm not sure I follow exactly what it is so far. Is it basically that we're removing log4j from mapred client, so if users need log4j they'll have to manually add it from now on?

          Show
          rkanter Robert Kanter added a comment - Sean Busbey , can you add details on the incompatible change to the release notes field? I'm not sure I follow exactly what it is so far. Is it basically that we're removing log4j from mapred client, so if users need log4j they'll have to manually add it from now on?
          Hide
          busbey Sean Busbey added a comment -

          -01

          • removes references to log4j Level in javadocs
          Show
          busbey Sean Busbey added a comment - -01 removes references to log4j Level in javadocs
          Hide
          busbey Sean Busbey added a comment -

          Is it basically that we're removing log4j from mapred client, so if users need log4j they'll have to manually add it from now on?

          It was a change in type. The patch as is doesn't alter where Log4j itself shows up as a dependency. FWIW, the module this changes didn't list log4j as a dependency in the first place, it's relying on it happening to get pulled in by maven from some other dependency.

          Show
          busbey Sean Busbey added a comment - Is it basically that we're removing log4j from mapred client, so if users need log4j they'll have to manually add it from now on? It was a change in type. The patch as is doesn't alter where Log4j itself shows up as a dependency. FWIW, the module this changes didn't list log4j as a dependency in the first place, it's relying on it happening to get pulled in by maven from some other dependency.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 14m 7s trunk passed
          +1 compile 13m 54s trunk passed
          +1 checkstyle 2m 0s trunk passed
          +1 mvnsite 1m 28s trunk passed
          +1 mvneclipse 1m 5s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 1m 17s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 45s the patch passed
          +1 compile 14m 11s the patch passed
          +1 javac 14m 11s the patch passed
          +1 checkstyle 2m 2s the patch passed
          +1 mvnsite 1m 34s the patch passed
          +1 mvneclipse 1m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 23s the patch passed
          +1 unit 3m 0s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 0m 59s hadoop-mapreduce-client-common in the patch passed.
          +1 unit 0m 22s hadoop-client-runtime in the patch passed.
          +1 asflicense 0m 41s The patch does not generate ASF License warnings.
          90m 56s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13921
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869485/HADOOP-13921.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux e1a8e29b4bd3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 52661e0
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12378/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12378/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 14m 7s trunk passed +1 compile 13m 54s trunk passed +1 checkstyle 2m 0s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 1m 5s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 1m 50s trunk passed +1 javadoc 1m 17s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 45s the patch passed +1 compile 14m 11s the patch passed +1 javac 14m 11s the patch passed +1 checkstyle 2m 2s the patch passed +1 mvnsite 1m 34s the patch passed +1 mvneclipse 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-client-modules/hadoop-client-runtime +1 findbugs 2m 8s the patch passed +1 javadoc 1m 23s the patch passed +1 unit 3m 0s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 59s hadoop-mapreduce-client-common in the patch passed. +1 unit 0m 22s hadoop-client-runtime in the patch passed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 90m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13921 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869485/HADOOP-13921.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux e1a8e29b4bd3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 52661e0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12378/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-client-modules/hadoop-client-runtime U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12378/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          If folks would like me to come up with a way of testing for log4j classes or some such, let me know. Otherwise I don't think this kind of removal warrants a test case specific to it.

          Show
          busbey Sean Busbey added a comment - If folks would like me to come up with a way of testing for log4j classes or some such, let me know. Otherwise I don't think this kind of removal warrants a test case specific to it.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, thanks Sean.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, thanks Sean.
          Hide
          busbey Sean Busbey added a comment -

          excellent. Anything else we're waiting on here? Robert Kanter, have your concerns all been addressed?

          Show
          busbey Sean Busbey added a comment - excellent. Anything else we're waiting on here? Robert Kanter , have your concerns all been addressed?
          Hide
          busbey Sean Busbey added a comment -

          bump. Would a committer mind pushing this change to the needed branches?

          Show
          busbey Sean Busbey added a comment - bump. Would a committer mind pushing this change to the needed branches?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Pushed this to trunk. Thanks Sean Busbey!

          Show
          ajisakaa Akira Ajisaka added a comment - Pushed this to trunk. Thanks Sean Busbey !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11809 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11809/)
          HADOOP-13921. Remove log4j classes from JobConf. (aajisaka: rev f5517a82001eea2207a93d3b70d42ad8f4ddeccb)

          • (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11809 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11809/ ) HADOOP-13921 . Remove log4j classes from JobConf. (aajisaka: rev f5517a82001eea2207a93d3b70d42ad8f4ddeccb) (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development