Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13789

Hadoop Common includes generated test protos in both jar and test-jar

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: build, common
    • Labels:
      None

      Description

      Right now our ProtocMojo always adds source directories to the main compile phase and we use it in hadoop-common to both generate main files as well as test files. This results in the test files getting added to both our test jar (correct) and our main jar (not correct).

      We should either add a main-vs-test flag to the configuration for ProtocMojo or make a ProtocTestMojo that always adds as a test sources.

      1. HADOOP-13789.1.patch
        2 kB
        Sean Busbey
      2. HADOOP-13789.2.patch
        36 kB
        Sean Busbey
      3. HADOOP-13789.3.patch
        40 kB
        Sean Busbey
      4. HADOOP-13789.4.patch
        40 kB
        Sean Busbey

        Issue Links

          Activity

          Hide
          busbey Sean Busbey added a comment -

          -01

          • add flag to ProtocMojo for test vs main sources
          • use flag when we have a pom that outputs to generated-test-sources
          Show
          busbey Sean Busbey added a comment - -01 add flag to ProtocMojo for test vs main sources use flag when we have a pom that outputs to generated-test-sources
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 7m 31s trunk passed
          +1 compile 7m 47s trunk passed
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 1m 14s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 58s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 0m 53s the patch passed
          +1 compile 7m 16s the patch passed
          +1 javac 7m 16s the patch passed
          +1 checkstyle 1m 34s the patch passed
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 16s the patch passed
          +1 javadoc 1m 2s the patch passed
          +1 unit 0m 17s hadoop-maven-plugins in the patch passed.
          +1 unit 7m 31s hadoop-common in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          68m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13789
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836759/HADOOP-13789.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux c679fca60fd5 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0e75496
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10975/testReport/
          modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10975/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 31s trunk passed +1 compile 7m 47s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 58s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 7m 16s the patch passed +1 javac 7m 16s the patch passed +1 checkstyle 1m 34s the patch passed +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 2s the patch passed +1 unit 0m 17s hadoop-maven-plugins in the patch passed. +1 unit 7m 31s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 68m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13789 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836759/HADOOP-13789.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux c679fca60fd5 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0e75496 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10975/testReport/ modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10975/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          I didn't add any tests because this fixes a condition of the build's working files. The only test I can think to add would be checking generated main artifacts to make sure there aren't classes named TestXxxx, but that 1) seems excessive and 2) won't be detected as including a test by yetus.

          Show
          busbey Sean Busbey added a comment - I didn't add any tests because this fixes a condition of the build's working files. The only test I can think to add would be checking generated main artifacts to make sure there aren't classes named TestXxxx , but that 1) seems excessive and 2) won't be detected as including a test by yetus.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for working on this Sean!

          Would this be cleaner as a new "protoc-test" goal rather than a flag? The Maven resources plugin for instance has both resources and testResources goals: https://maven.apache.org/plugins/maven-resources-plugin/plugin-info.html

          There are also other test protoc invocations in other modules besides hadoop-common, e.g. hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml. Do these need to be updated as well?

          Show
          andrew.wang Andrew Wang added a comment - Thanks for working on this Sean! Would this be cleaner as a new "protoc-test" goal rather than a flag? The Maven resources plugin for instance has both resources and testResources goals: https://maven.apache.org/plugins/maven-resources-plugin/plugin-info.html There are also other test protoc invocations in other modules besides hadoop-common, e.g. hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml . Do these need to be updated as well?
          Hide
          busbey Sean Busbey added a comment -

          Would this be cleaner as a new "protoc-test" goal rather than a flag?

          I'm not sure. a new goal requires a new class, so definitely more code to do it as a different goal. I don't think it'd take me long to do as two goals, so let me know if you'd prefer that.

          There are also other test protoc invocations in other modules besides hadoop-common, e.g. hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml. Do these need to be updated as well?

          Interesting. Each of those examples I can find now is outputting the generated files into generated-sources/java instead of generated-test-sources/java. I think this means those sources only end up in the main artifact and not the test artifact at all. That could be intentional or could be a mistake. I'll confirm that they're only in one place. I suspect someone more familiar with YARN would be needed to determine if they ought be in the test jar instead of the main artifact.

          Show
          busbey Sean Busbey added a comment - Would this be cleaner as a new "protoc-test" goal rather than a flag? I'm not sure. a new goal requires a new class, so definitely more code to do it as a different goal. I don't think it'd take me long to do as two goals, so let me know if you'd prefer that. There are also other test protoc invocations in other modules besides hadoop-common, e.g. hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml. Do these need to be updated as well? Interesting. Each of those examples I can find now is outputting the generated files into generated-sources/java instead of generated-test-sources/java . I think this means those sources only end up in the main artifact and not the test artifact at all. That could be intentional or could be a mistake. I'll confirm that they're only in one place. I suspect someone more familiar with YARN would be needed to determine if they ought be in the test jar instead of the main artifact.
          Hide
          andrew.wang Andrew Wang added a comment -

          Would this be cleaner as a new "protoc-test" goal rather than a flag?

          Codewise, you're right that having two goals will be a bigger change, but I think a new goal is more inline with a Maven user's expectations since it seems common to have different goals for src vs. test, like with the aforementioned resource plugin and the jar plugin's jar and test-jar.

          Having separate goals would also let us set the default output directory based on src vs. test, which would help prevent this probable YARN mistake.

          FWIW I looked at the YARN protos and it looks like a copy-paste error. These protos are referenced in some tests in src/test/java. I also grepped all of CDH and only found references to these classes in Hadoop, so I think we're okay.

          Show
          andrew.wang Andrew Wang added a comment - Would this be cleaner as a new "protoc-test" goal rather than a flag? Codewise, you're right that having two goals will be a bigger change, but I think a new goal is more inline with a Maven user's expectations since it seems common to have different goals for src vs. test, like with the aforementioned resource plugin and the jar plugin's jar and test-jar . Having separate goals would also let us set the default output directory based on src vs. test, which would help prevent this probable YARN mistake. FWIW I looked at the YARN protos and it looks like a copy-paste error. These protos are referenced in some tests in src/test/java. I also grepped all of CDH and only found references to these classes in Hadoop, so I think we're okay.
          Hide
          busbey Sean Busbey added a comment -

          moving out of patch available while I update for two protoc goals.

          Show
          busbey Sean Busbey added a comment - moving out of patch available while I update for two protoc goals.
          Hide
          busbey Sean Busbey added a comment -

          -02

          • move to independent mojos for protoc and test-protoc
          • clean up poms that give configuration items with defaults

          Here's the refactoring, let's see how the test runs do in precommit. Making two Mojos was a bit awkward since it appears each has to directly extend AbstractMojo to work.

          Show
          busbey Sean Busbey added a comment - -02 move to independent mojos for protoc and test-protoc clean up poms that give configuration items with defaults Here's the refactoring, let's see how the test runs do in precommit. Making two Mojos was a bit awkward since it appears each has to directly extend AbstractMojo to work.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 6m 54s trunk passed
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          +1 findbugs 1m 48s trunk passed
          +1 javadoc 0m 57s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 0m 53s the patch passed
          +1 compile 8m 36s the patch passed
          +1 javac 8m 36s the patch passed
          +1 checkstyle 1m 34s the patch passed
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 1m 3s the patch passed
          +1 unit 0m 18s hadoop-maven-plugins in the patch passed.
          +1 unit 7m 40s hadoop-common in the patch passed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          67m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13789
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836759/HADOOP-13789.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 8687b51da320 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de01327
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10997/testReport/
          modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10997/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 57s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 8m 36s the patch passed +1 javac 8m 36s the patch passed +1 checkstyle 1m 34s the patch passed +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 3s the patch passed +1 unit 0m 18s hadoop-maven-plugins in the patch passed. +1 unit 7m 40s hadoop-common in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 67m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13789 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836759/HADOOP-13789.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 8687b51da320 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de01327 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10997/testReport/ modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10997/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment - - edited

          huh. that's the wrong patch. (edit: that precommit ran on just now)

          Show
          busbey Sean Busbey added a comment - - edited huh. that's the wrong patch. (edit: that precommit ran on just now)
          Hide
          busbey Sean Busbey added a comment -

          curl got a transient SSL error for the v2 patch in that run. resubmitted now and it looks like the correct patch is being tested.

          Show
          busbey Sean Busbey added a comment - curl got a transient SSL error for the v2 patch in that run. resubmitted now and it looks like the correct patch is being tested.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 31s Maven dependency ordering for branch
          +1 mvninstall 7m 35s trunk passed
          +1 compile 7m 26s trunk passed
          +1 checkstyle 1m 28s trunk passed
          +1 mvnsite 7m 20s trunk passed
          +1 mvneclipse 3m 26s trunk passed
          +1 findbugs 13m 15s trunk passed
          +1 javadoc 5m 25s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 6m 10s the patch passed
          +1 compile 6m 59s the patch passed
          +1 javac 6m 59s the patch passed
          -0 checkstyle 1m 33s root: The patch generated 4 new + 1 unchanged - 1 fixed = 5 total (was 2)
          +1 mvnsite 8m 12s the patch passed
          +1 mvneclipse 3m 55s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 15s The patch has no ill-formed XML file.
          -1 findbugs 0m 35s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 findbugs 0m 21s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
          +1 javadoc 6m 2s the patch passed
          +1 unit 0m 19s hadoop-maven-plugins in the patch passed.
          +1 unit 8m 23s hadoop-common in the patch passed.
          +1 unit 59m 20s hadoop-hdfs in the patch passed.
          +1 unit 1m 17s hadoop-hdfs-client in the patch passed.
          +1 unit 1m 20s hadoop-mapreduce-client-common in the patch passed.
          +1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 unit 0m 34s hadoop-yarn-api in the patch passed.
          -1 unit 16m 56s hadoop-yarn-client in the patch failed.
          +1 unit 2m 44s hadoop-yarn-common in the patch passed.
          +1 unit 3m 10s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 41s hadoop-yarn-server-common in the patch passed.
          +1 unit 15m 53s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 38m 35s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 4m 34s hadoop-yarn-server-tests in the patch failed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          276m 16s



          Reason Tests
          FindBugs module:hadoop-maven-plugins
            new org.apache.hadoop.maven.plugin.protoc.ProtocRunner(MavenProject, File[], File, FileSet, String, String, String, AbstractMojo, boolean) may expose internal representation by storing an externally mutable object into ProtocRunner.imports At ProtocRunner.java:String, String, String, AbstractMojo, boolean) may expose internal representation by storing an externally mutable object into ProtocRunner.imports At ProtocRunner.java:[line 55]
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity
          Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestOpportunisticContainerAllocation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13789
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837268/HADOOP-13789.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux a63e2d0c4a08 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de01327
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/testReport/
          modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 7m 35s trunk passed +1 compile 7m 26s trunk passed +1 checkstyle 1m 28s trunk passed +1 mvnsite 7m 20s trunk passed +1 mvneclipse 3m 26s trunk passed +1 findbugs 13m 15s trunk passed +1 javadoc 5m 25s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 6m 10s the patch passed +1 compile 6m 59s the patch passed +1 javac 6m 59s the patch passed -0 checkstyle 1m 33s root: The patch generated 4 new + 1 unchanged - 1 fixed = 5 total (was 2) +1 mvnsite 8m 12s the patch passed +1 mvneclipse 3m 55s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 15s The patch has no ill-formed XML file. -1 findbugs 0m 35s hadoop-maven-plugins generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 findbugs 0m 21s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml) +1 javadoc 6m 2s the patch passed +1 unit 0m 19s hadoop-maven-plugins in the patch passed. +1 unit 8m 23s hadoop-common in the patch passed. +1 unit 59m 20s hadoop-hdfs in the patch passed. +1 unit 1m 17s hadoop-hdfs-client in the patch passed. +1 unit 1m 20s hadoop-mapreduce-client-common in the patch passed. +1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch passed. +1 unit 0m 34s hadoop-yarn-api in the patch passed. -1 unit 16m 56s hadoop-yarn-client in the patch failed. +1 unit 2m 44s hadoop-yarn-common in the patch passed. +1 unit 3m 10s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 41s hadoop-yarn-server-common in the patch passed. +1 unit 15m 53s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 38m 35s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 4m 34s hadoop-yarn-server-tests in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 276m 16s Reason Tests FindBugs module:hadoop-maven-plugins   new org.apache.hadoop.maven.plugin.protoc.ProtocRunner(MavenProject, File[], File, FileSet, String, String, String, AbstractMojo, boolean) may expose internal representation by storing an externally mutable object into ProtocRunner.imports At ProtocRunner.java:String, String, String, AbstractMojo, boolean) may expose internal representation by storing an externally mutable object into ProtocRunner.imports At ProtocRunner.java: [line 55] Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestOpportunisticContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13789 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837268/HADOOP-13789.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux a63e2d0c4a08 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de01327 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/new-findbugs-hadoop-maven-plugins.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/testReport/ modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10999/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment - - edited

          -03

          • rebase to trunk (de3b4aa)
          • precommit cleanup

          I don't think the test failures are related, but I'm running through them again locally to check.

          Show
          busbey Sean Busbey added a comment - - edited -03 rebase to trunk (de3b4aa) precommit cleanup I don't think the test failures are related, but I'm running through them again locally to check.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 pending Jenkins, thanks for working on this Sean! I ran "mvn generate-sources" and "mvn generate-test-sources" and it looks good. Appreciate the new cleaner protoc plugin configuration also.

          Show
          andrew.wang Andrew Wang added a comment - +1 pending Jenkins, thanks for working on this Sean! I ran "mvn generate-sources" and "mvn generate-test-sources" and it looks good. Appreciate the new cleaner protoc plugin configuration also.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 30s trunk passed
          +1 compile 11m 18s trunk passed
          +1 checkstyle 1m 39s trunk passed
          +1 mvnsite 9m 31s trunk passed
          +1 mvneclipse 5m 32s trunk passed
          +1 findbugs 14m 18s trunk passed
          +1 javadoc 7m 28s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 6m 18s the patch passed
          +1 compile 9m 41s the patch passed
          +1 javac 9m 41s the patch passed
          +1 checkstyle 1m 40s root: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 mvnsite 10m 0s the patch passed
          +1 mvneclipse 6m 25s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 15s The patch has no ill-formed XML file.
          -1 findbugs 0m 30s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
          +1 javadoc 8m 41s the patch passed
          +1 unit 0m 27s hadoop-maven-plugins in the patch passed.
          +1 unit 8m 28s hadoop-common in the patch passed.
          -1 unit 55m 50s hadoop-hdfs in the patch failed.
          +1 unit 1m 13s hadoop-hdfs-client in the patch passed.
          +1 unit 1m 2s hadoop-mapreduce-client-common in the patch passed.
          +1 unit 0m 38s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 unit 0m 43s hadoop-yarn-api in the patch passed.
          -1 unit 16m 21s hadoop-yarn-client in the patch failed.
          +1 unit 2m 36s hadoop-yarn-common in the patch passed.
          +1 unit 3m 1s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 45s hadoop-yarn-server-common in the patch passed.
          -1 unit 15m 7s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 37m 32s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 unit 4m 50s hadoop-yarn-server-tests in the patch failed.
          +1 asflicense 0m 48s The patch does not generate ASF License warnings.
          294m 16s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestLargeBlockReport
            hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
          Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestOpportunisticContainerAllocation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13789
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837844/HADOOP-13789.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux db9737d09141 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de3b4aa
          Default Java 1.8.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/testReport/
          modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 30s trunk passed +1 compile 11m 18s trunk passed +1 checkstyle 1m 39s trunk passed +1 mvnsite 9m 31s trunk passed +1 mvneclipse 5m 32s trunk passed +1 findbugs 14m 18s trunk passed +1 javadoc 7m 28s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 6m 18s the patch passed +1 compile 9m 41s the patch passed +1 javac 9m 41s the patch passed +1 checkstyle 1m 40s root: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 mvnsite 10m 0s the patch passed +1 mvneclipse 6m 25s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 15s The patch has no ill-formed XML file. -1 findbugs 0m 30s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml) +1 javadoc 8m 41s the patch passed +1 unit 0m 27s hadoop-maven-plugins in the patch passed. +1 unit 8m 28s hadoop-common in the patch passed. -1 unit 55m 50s hadoop-hdfs in the patch failed. +1 unit 1m 13s hadoop-hdfs-client in the patch passed. +1 unit 1m 2s hadoop-mapreduce-client-common in the patch passed. +1 unit 0m 38s hadoop-mapreduce-client-shuffle in the patch passed. +1 unit 0m 43s hadoop-yarn-api in the patch passed. -1 unit 16m 21s hadoop-yarn-client in the patch failed. +1 unit 2m 36s hadoop-yarn-common in the patch passed. +1 unit 3m 1s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 45s hadoop-yarn-server-common in the patch passed. -1 unit 15m 7s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 37m 32s hadoop-yarn-server-resourcemanager in the patch failed. -1 unit 4m 50s hadoop-yarn-server-tests in the patch failed. +1 asflicense 0m 48s The patch does not generate ASF License warnings. 294m 16s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestLargeBlockReport   hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestOpportunisticContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13789 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837844/HADOOP-13789.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux db9737d09141 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de3b4aa Default Java 1.8.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/testReport/ modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11015/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment - - edited

          -1 findbugs 0m 30s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)

          Not sure what's up with this warning. I don't see anything in the output to indicate findbugs failed. (and nothing in the pom change there should have caused a difference in the findings)

          Show
          busbey Sean Busbey added a comment - - edited -1 findbugs 0m 30s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml) Not sure what's up with this warning. I don't see anything in the output to indicate findbugs failed. (and nothing in the pom change there should have caused a difference in the findings)
          Hide
          busbey Sean Busbey added a comment -

          -4

          • rebase to trunk (026b39a)
          • fixes additional whitespace nit.

          locally I can confirm no new findbugs issues in the module that didn't make an xml output.

          locally I can also confirm the stated failed tests either also fail on trunk ref 026b39a (TestContainerManagerSecurity) or they don't fail (the rest).

          Show
          busbey Sean Busbey added a comment - -4 rebase to trunk (026b39a) fixes additional whitespace nit. locally I can confirm no new findbugs issues in the module that didn't make an xml output. locally I can also confirm the stated failed tests either also fail on trunk ref 026b39a (TestContainerManagerSecurity) or they don't fail (the rest).
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 pending. Jenkins will take a while since it's running the full test suite, but I'll commit when it comes back.

          Show
          andrew.wang Andrew Wang added a comment - +1 pending. Jenkins will take a while since it's running the full test suite, but I'll commit when it comes back.
          Hide
          andrew.wang Andrew Wang added a comment -

          It looks like the build was aborted. Precommit can have a hard time with big patches.

          Considering v4 just fixes the whitespace nit, I'm going to go ahead and commit it. This will hopefully free up HADOOP-11804 too.

          Show
          andrew.wang Andrew Wang added a comment - It looks like the build was aborted. Precommit can have a hard time with big patches. Considering v4 just fixes the whitespace nit, I'm going to go ahead and commit it. This will hopefully free up HADOOP-11804 too.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for working on this Sean! I've committed this to trunk and branch-2.

          Show
          andrew.wang Andrew Wang added a comment - Thanks for working on this Sean! I've committed this to trunk and branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13789 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-13789
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838026/HADOOP-13789.4.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11039/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13789 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13789 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838026/HADOOP-13789.4.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11039/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10794 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10794/)
          HADOOP-13789. Hadoop Common includes generated test protos in both jar (wang: rev e1c6ef2efa9d87fdfc7474ca63998a13a3929874)

          • (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocTestMojo.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/package-info.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/pom.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocRunner.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/pom.xml
          • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocMojo.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10794 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10794/ ) HADOOP-13789 . Hadoop Common includes generated test protos in both jar (wang: rev e1c6ef2efa9d87fdfc7474ca63998a13a3929874) (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocTestMojo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs-client/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/package-info.java (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/pom.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml (add) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocRunner.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/pom.xml (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocMojo.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml (edit) hadoop-common-project/hadoop-common/pom.xml

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development