Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13789

Hadoop Common includes generated test protos in both jar and test-jar

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: build, common
    • Labels:
      None

      Description

      Right now our ProtocMojo always adds source directories to the main compile phase and we use it in hadoop-common to both generate main files as well as test files. This results in the test files getting added to both our test jar (correct) and our main jar (not correct).

      We should either add a main-vs-test flag to the configuration for ProtocMojo or make a ProtocTestMojo that always adds as a test sources.

        Attachments

        1. HADOOP-13789.1.patch
          2 kB
          Sean Busbey
        2. HADOOP-13789.2.patch
          36 kB
          Sean Busbey
        3. HADOOP-13789.3.patch
          40 kB
          Sean Busbey
        4. HADOOP-13789.4.patch
          40 kB
          Sean Busbey

        Issue Links

          Activity

          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment