Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13770

Shell.checkIsBashSupported swallowed an interrupted exception

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Shell.checkIsBashSupported() creates a bash shell command to verify if the system supports bash. However, its error message is misleading, and the logic should be updated.

      If the shell command throws an IOException, it does not imply the bash did not run successfully. If the shell command process was interrupted, its internal logic throws an InterruptedIOException, which is a subclass of IOException.

      Shell.checkIsBashSupported
          ShellCommandExecutor shexec;
          boolean supported = true;
          try {
            String[] args = {"bash", "-c", "echo 1000"};
            shexec = new ShellCommandExecutor(args);
            shexec.execute();
          } catch (IOException ioe) {
            LOG.warn("Bash is not supported by the OS", ioe);
            supported = false;
          }
      

      An example of it appeared in a recent jenkins job
      https://builds.apache.org/job/PreCommit-HADOOP-Build/8257/testReport/org.apache.hadoop.ipc/TestRPCWaitForProxy/testInterruptedWaitForProxy/

      The test logic in TestRPCWaitForProxy.testInterruptedWaitForProxy starts a thread, wait it for 1 second, and interrupt the thread, expecting the thread to terminate. However, the method Shell.checkIsBashSupported swallowed the interrupt, and therefore failed.

      2015-12-16 21:31:53,797 WARN  util.Shell (Shell.java:checkIsBashSupported(718)) - Bash is not supported by the OS
      java.io.InterruptedIOException: java.lang.InterruptedException
      	at org.apache.hadoop.util.Shell.runCommand(Shell.java:930)
      	at org.apache.hadoop.util.Shell.run(Shell.java:838)
      	at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:1117)
      	at org.apache.hadoop.util.Shell.checkIsBashSupported(Shell.java:716)
      	at org.apache.hadoop.util.Shell.<clinit>(Shell.java:705)
      	at org.apache.hadoop.util.StringUtils.<clinit>(StringUtils.java:79)
      	at org.apache.hadoop.security.SecurityUtil.getAuthenticationMethod(SecurityUtil.java:639)
      	at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:273)
      	at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:261)
      	at org.apache.hadoop.security.UserGroupInformation.loginUserFromSubject(UserGroupInformation.java:803)
      	at org.apache.hadoop.security.UserGroupInformation.getLoginUser(UserGroupInformation.java:773)
      	at org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:646)
      	at org.apache.hadoop.ipc.RPC.waitForProtocolProxy(RPC.java:397)
      	at org.apache.hadoop.ipc.RPC.waitForProtocolProxy(RPC.java:350)
      	at org.apache.hadoop.ipc.RPC.waitForProxy(RPC.java:330)
      	at org.apache.hadoop.ipc.TestRPCWaitForProxy$RpcThread.run(TestRPCWaitForProxy.java:115)
      Caused by: java.lang.InterruptedException
      	at java.lang.Object.wait(Native Method)
      	at java.lang.Object.wait(Object.java:503)
      	at java.lang.UNIXProcess.waitFor(UNIXProcess.java:264)
      	at org.apache.hadoop.util.Shell.runCommand(Shell.java:920)
      	... 15 more
      

      The original design is not desirable, as it swallowed a potential interrupt, causing TestRPCWaitForProxy.testInterruptedWaitForProxy to fail. Unfortunately, Java does not allow this static method to throw exception. We should removed the static member variable, so that the method can throw the interrupt exception. The node manager should call the static method, instead of using the static member variable.

      This fix has an associated benefit: the tests could run faster, because it will no longer need to spawn a bash process when it uses a Shell static method variable (which happens quite often for checking what operating system Hadoop is running on)

      1. HADOOP-12652.001.patch
        0.8 kB
        Wei-Chiu Chuang
      2. YARN-4467.001.patch
        2 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev01: catch InterruptedIOException and log that the exception is due to interrupt.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev01: catch InterruptedIOException and log that the exception is due to interrupt.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 8m 4s trunk passed with JDK v1.8.0_66
          +1 compile 8m 50s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 48s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 38s the patch passed
          +1 compile 7m 59s the patch passed with JDK v1.8.0_66
          +1 javac 7m 59s the patch passed
          +1 compile 8m 42s the patch passed with JDK v1.7.0_91
          +1 javac 8m 42s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91
          -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 27s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 12s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.fs.TestSymlinkLocalFSFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778125/HADOOP-12652.001.patch
          JIRA Issue HADOOP-12652
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dcddedf79ace 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d4e766d
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 40s trunk passed +1 compile 8m 4s trunk passed with JDK v1.8.0_66 +1 compile 8m 50s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 7m 59s the patch passed with JDK v1.8.0_66 +1 javac 7m 59s the patch passed +1 compile 8m 42s the patch passed with JDK v1.7.0_91 +1 javac 8m 42s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91 -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 7m 27s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 12s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.fs.TestSymlinkLocalFSFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778125/HADOOP-12652.001.patch JIRA Issue HADOOP-12652 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dcddedf79ace 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d4e766d findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8260/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev02: the original design is not desirable, as it swallowed a potential interrupt, causing TestRPCWaitForProxy.testInterruptedWaitForProxy to fail. Unfortunately, Java does not allow this static method to throw exception. The rev02 removed the static member variable, so that the method can throw the interrupt exception.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev02: the original design is not desirable, as it swallowed a potential interrupt, causing TestRPCWaitForProxy.testInterruptedWaitForProxy to fail. Unfortunately, Java does not allow this static method to throw exception. The rev02 removed the static member variable, so that the method can throw the interrupt exception.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 41s trunk passed
          +1 compile 8m 17s trunk passed with JDK v1.8.0_66
          +1 compile 8m 51s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 0s trunk passed
          +1 mvnsite 1m 33s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 41s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 24s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 10s the patch passed
          +1 compile 8m 0s the patch passed with JDK v1.8.0_66
          +1 javac 8m 0s the patch passed
          +1 compile 8m 48s the patch passed with JDK v1.7.0_91
          +1 javac 8m 48s the patch passed
          +1 checkstyle 0m 58s the patch passed
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 1s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 24s the patch passed with JDK v1.7.0_91
          +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 27s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 unit 9m 1s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          93m 5s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
          JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch
          JIRA Issue YARN-4467
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c8ab788eda79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d85f729
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10027/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10027/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 8m 17s trunk passed with JDK v1.8.0_66 +1 compile 8m 51s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 0s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 41s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 24s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 10s the patch passed +1 compile 8m 0s the patch passed with JDK v1.8.0_66 +1 javac 8m 0s the patch passed +1 compile 8m 48s the patch passed with JDK v1.7.0_91 +1 javac 8m 48s the patch passed +1 checkstyle 0m 58s the patch passed +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 1s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 24s the patch passed with JDK v1.7.0_91 +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 27s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 9m 1s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 93m 5s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch JIRA Issue YARN-4467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c8ab788eda79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d85f729 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10027/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10027/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Both test failures look unrelated to this patch

          Show
          jojochuang Wei-Chiu Chuang added a comment - Both test failures look unrelated to this patch
          Hide
          billie.rinaldi Billie Rinaldi added a comment -

          +1 (non-binding), this patch LGTM.

          Show
          billie.rinaldi Billie Rinaldi added a comment - +1 (non-binding), this patch LGTM.
          Hide
          jlowe Jason Lowe added a comment -

          +1, kicked Jenkins again to get a fresh run. I also marked this as a Blocker for 2.8. We will not be allowed to remove the public member of a Public class once the public member ships in a release or we risk breaking backwards compatibility. Fortunately this public member hasn't been released yet, so we have a chance to fix it cleanly.

          Show
          jlowe Jason Lowe added a comment - +1, kicked Jenkins again to get a fresh run. I also marked this as a Blocker for 2.8. We will not be allowed to remove the public member of a Public class once the public member ships in a release or we risk breaking backwards compatibility. Fortunately this public member hasn't been released yet, so we have a chance to fix it cleanly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 6m 51s trunk passed
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 1m 59s trunk passed
          +1 javadoc 1m 4s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 3s the patch passed
          +1 compile 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          +1 checkstyle 1m 31s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 23s the patch passed
          +1 javadoc 1m 8s the patch passed
          +1 unit 7m 15s hadoop-common in the patch passed.
          +1 unit 15m 11s hadoop-yarn-server-nodemanager in the patch passed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          81m 56s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-4467
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5bc334ab1efc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 022bf78
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13602/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13602/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 6m 51s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 4s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 3s the patch passed +1 compile 6m 51s the patch passed +1 javac 6m 51s the patch passed +1 checkstyle 1m 31s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 23s the patch passed +1 javadoc 1m 8s the patch passed +1 unit 7m 15s hadoop-common in the patch passed. +1 unit 15m 11s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 81m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4467 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5bc334ab1efc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 022bf78 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13602/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/13602/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Moving this back to HADOOP since the change is primarily against that project and is in response to another HADOOP JIRA that broke this, HADOOP-12441.

          Committing this.

          Show
          jlowe Jason Lowe added a comment - Moving this back to HADOOP since the change is primarily against that project and is in response to another HADOOP JIRA that broke this, HADOOP-12441 . Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Wei-Chiu Chuang for the contribution and to Billie Rinaldi for additional review! I committed this to trunk, branch-2, and branch-2.8.

          Show
          jlowe Jason Lowe added a comment - Thanks to Wei-Chiu Chuang for the contribution and to Billie Rinaldi for additional review! I committed this to trunk, branch-2, and branch-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10719 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10719/)
          HADOOP-13770. Shell.checkIsBashSupported swallowed an interrupted (jlowe: rev c017171da00a6cd71a2901c84a0298ce14a49e23)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10719 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10719/ ) HADOOP-13770 . Shell.checkIsBashSupported swallowed an interrupted (jlowe: rev c017171da00a6cd71a2901c84a0298ce14a49e23) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 58s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 8m 10s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 1m 35s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          +1 findbugs 2m 24s trunk passed
          +1 javadoc 1m 3s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 5s the patch passed
          +1 compile 7m 1s the patch passed
          +1 javac 7m 1s the patch passed
          +1 checkstyle 1m 33s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 41s the patch passed
          +1 javadoc 1m 12s the patch passed
          +1 unit 8m 51s hadoop-common in the patch passed.
          -1 unit 14m 50s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          86m 50s



          Reason Tests
          Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13770
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 765cab3a542a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3de1302
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 58s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 8m 10s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 30s trunk passed +1 findbugs 2m 24s trunk passed +1 javadoc 1m 3s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 7m 1s the patch passed +1 javac 7m 1s the patch passed +1 checkstyle 1m 33s root: The patch generated 0 new + 66 unchanged - 1 fixed = 66 total (was 67) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 41s the patch passed +1 javadoc 1m 12s the patch passed +1 unit 8m 51s hadoop-common in the patch passed. -1 unit 14m 50s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 86m 50s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13770 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778308/YARN-4467.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 765cab3a542a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3de1302 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10915/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development