Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13658

Replace config key literal strings with config key names I: hadoop common

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha2
    • conf
    • None
    • Reviewed

    Description

      In Hadoop Common, there are several places where the config keys are used by the literal strings instead of their names as in configuration key classes. The default values have the same issue. For example

      in o.a.h.i.f.t.Compression.java
      conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024);
      

      should be

      conf.setInt(
          CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY,
          CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT);
      

      instead

      Attachments

        1. HADOOP-13658.001.patch
          3 kB
          Chen Liang
        2. HADOOP-13658.002.patch
          25 kB
          Chen Liang
        3. HADOOP-13658.003.patch
          25 kB
          Chen Liang

        Issue Links

          Activity

            People

              vagarychen Chen Liang
              vagarychen Chen Liang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: