Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10903

Replace config key literal strings with config key names II: hadoop hdfs

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In Hadoop HDFS, there are some places that use config key literal strings instead of config key names, e.g.

      IOUtils.java
          copyBytes(in, out, conf.getInt("io.file.buffer.size", 4096), true);
      

      We should replace places like this.

      1. HADOOP-13644.001.patch
        17 kB
        Chen Liang
      2. HDFS-10903.002.patch
        4 kB
        Chen Liang
      3. HDFS-10903.003.patch
        7 kB
        Chen Liang
      4. HDFS-10903-branch-2.004.patch
        8 kB
        Chen Liang
      5. HDFS-10903-branch-2.005.patch
        7 kB
        Chen Liang

        Issue Links

          Activity

          Hide
          vagarychen Chen Liang added a comment -

          I did some checking and it turns out there are actually a lot of usages like this in different modules. Based on some offline discussion with Mingliang Liu, we decided to fix them in a step-by-step fashion. Here the v001 patch only tries to resolve the use of "io.file.buffer.size" in hadoop-commons. Will file other JIRAs to solve other usages like such.

          Show
          vagarychen Chen Liang added a comment - I did some checking and it turns out there are actually a lot of usages like this in different modules. Based on some offline discussion with Mingliang Liu , we decided to fix them in a step-by-step fashion. Here the v001 patch only tries to resolve the use of "io.file.buffer.size" in hadoop-commons. Will file other JIRAs to solve other usages like such.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for the patch.

          For easy review and Jenkins process, we can fix them by modules, e.g. hadoop common, hadoop hdfs, hadoop tools, hadoop yarn etc. For each module, we can replace those key literal strings in one patch. This JIRA can be an umbrella one.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for the patch. For easy review and Jenkins process, we can fix them by modules, e.g. hadoop common, hadoop hdfs, hadoop tools, hadoop yarn etc. For each module, we can replace those key literal strings in one patch. This JIRA can be an umbrella one.
          Hide
          liuml07 Mingliang Liu added a comment -

          Per offline discussion, we address this issue by modules. This JIRA is to track the effort of HDFS module, and HADOOP-13658 is about the hadoop common module. We can create separate JIRAs for other modules like hadoop tools, yarn, mapreduce, etc, for easy review and Jenkins pre-commit.

          Show
          liuml07 Mingliang Liu added a comment - Per offline discussion, we address this issue by modules. This JIRA is to track the effort of HDFS module, and HADOOP-13658 is about the hadoop common module. We can create separate JIRAs for other modules like hadoop tools, yarn, mapreduce, etc, for easy review and Jenkins pre-commit.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 8m 16s trunk passed
          +1 compile 8m 53s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 14s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 47s trunk passed
          +1 javadoc 0m 52s trunk passed
          +1 mvninstall 0m 53s the patch passed
          +1 compile 7m 10s the patch passed
          +1 javac 7m 10s the patch passed
          -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 2 new + 453 unchanged - 3 fixed = 455 total (was 456)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 29s the patch passed
          +1 javadoc 0m 49s the patch passed
          -1 unit 16m 49s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          52m 40s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13644
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830109/HADOOP-13644.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d63f1af94d30 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4815d02
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 16s trunk passed +1 compile 8m 53s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 7m 10s the patch passed +1 javac 7m 10s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 2 new + 453 unchanged - 3 fixed = 455 total (was 456) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 49s the patch passed -1 unit 16m 49s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 52m 40s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13644 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830109/HADOOP-13644.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d63f1af94d30 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4815d02 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10594/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 7m 25s trunk passed
          +1 compile 8m 31s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 28s trunk passed
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 8m 27s the patch passed
          +1 javac 8m 27s the patch passed
          -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 2 new + 453 unchanged - 3 fixed = 455 total (was 456)
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 42s the patch passed
          +1 javadoc 0m 49s the patch passed
          +1 unit 8m 4s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          43m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10903
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830109/HADOOP-13644.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 494e21e4aa79 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4815d02
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16865/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16865/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16865/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 8m 31s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 8m 27s the patch passed +1 javac 8m 27s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 2 new + 453 unchanged - 3 fixed = 455 total (was 456) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 8m 4s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 43m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10903 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830109/HADOOP-13644.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 494e21e4aa79 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4815d02 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16865/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16865/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16865/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment - - edited

          Thanks Mingliang Liu for reporting this and Chen Liang for posting the patch. The change looks good to me.
          Can you also fix the "io.file.buffer.zie" usage in o.a.h.fs.contract.ContractTestUtils.java? +1 after that is fixed.

          Also, we should move this JIRA from Hadoop HDFS to Hadoop Common.

          Show
          xyao Xiaoyu Yao added a comment - - edited Thanks Mingliang Liu for reporting this and Chen Liang for posting the patch. The change looks good to me. Can you also fix the "io.file.buffer.zie" usage in o.a.h.fs.contract.ContractTestUtils.java? +1 after that is fixed. Also, we should move this JIRA from Hadoop HDFS to Hadoop Common.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Xiaoyu Yao for the review.

          We plan to address the problem by modules for short/independent Jenkins run, and review. HADOOP-13658 should cover the changes in hadoop common module, and this one is for hadoop HDFS module. Chen Liang can you merge the changes with HADOOP-13658 and also address Xiaoyu Yao's comments about the io.file.buffer.zie usage in o.a.h.fs.contract.ContractTestUtils.java?

          Show
          liuml07 Mingliang Liu added a comment - Thanks Xiaoyu Yao for the review. We plan to address the problem by modules for short/independent Jenkins run, and review. HADOOP-13658 should cover the changes in hadoop common module, and this one is for hadoop HDFS module. Chen Liang can you merge the changes with HADOOP-13658 and also address Xiaoyu Yao 's comments about the io.file.buffer.zie usage in o.a.h.fs.contract.ContractTestUtils.java ?
          Hide
          vagarychen Chen Liang added a comment -

          Thanks Xiaoyu Yao and Mingliang Liu for the comments!

          It turns out there are quite a number of places with the same issue as io.file.buffer.size. So just as Mingliang Liu mentioned, we plan to have this JIRA for all such fixes in HDFS and HADOOP-13658 for all such fixes in hadoop-commons.

          Will surely merge the change and include ContractTestUtils and update the patch.

          Show
          vagarychen Chen Liang added a comment - Thanks Xiaoyu Yao and Mingliang Liu for the comments! It turns out there are quite a number of places with the same issue as io.file.buffer.size . So just as Mingliang Liu mentioned, we plan to have this JIRA for all such fixes in HDFS and HADOOP-13658 for all such fixes in hadoop-commons. Will surely merge the change and include ContractTestUtils and update the patch.
          Hide
          vagarychen Chen Liang added a comment -

          Uploaded v02 patch.

          Whether to expose the key of dfs.namenode.fslock.fair is being tracked in, so excluded from this patch, also excluded deprecated keys such as mapred.temp.dir.

          Show
          vagarychen Chen Liang added a comment - Uploaded v02 patch. Whether to expose the key of dfs.namenode.fslock.fair is being tracked in, so excluded from this patch, also excluded deprecated keys such as mapred.temp.dir .
          Hide
          liuml07 Mingliang Liu added a comment -

          dfs.namenode.fslock.fair is being tracked in HDFS-5239.

          Show
          liuml07 Mingliang Liu added a comment - dfs.namenode.fslock.fair is being tracked in HDFS-5239 .
          Hide
          liuml07 Mingliang Liu added a comment -

          +1 pending on Jenkins.

          Show
          liuml07 Mingliang Liu added a comment - +1 pending on Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 6s Maven dependency ordering for branch
          +1 mvninstall 6m 32s trunk passed
          +1 compile 1m 21s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 14s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          +1 findbugs 2m 2s trunk passed
          +1 javadoc 0m 52s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 12s the patch passed
          +1 compile 1m 16s the patch passed
          +1 javac 1m 16s the patch passed
          +1 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 0 new + 487 unchanged - 1 fixed = 487 total (was 488)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 15s the patch passed
          +1 javadoc 0m 48s the patch passed
          -1 unit 58m 0s hadoop-hdfs in the patch failed.
          +1 unit 3m 48s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          84m 20s



          Reason Tests
          Failed junit tests hadoop.tools.TestHdfsConfigFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10903
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832014/HDFS-10903.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bdf59385b589 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bf37217
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17054/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17054/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17054/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 6s Maven dependency ordering for branch +1 mvninstall 6m 32s trunk passed +1 compile 1m 21s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 2m 2s trunk passed +1 javadoc 0m 52s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 1m 16s the patch passed +1 javac 1m 16s the patch passed +1 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 0 new + 487 unchanged - 1 fixed = 487 total (was 488) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 15s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 58m 0s hadoop-hdfs in the patch failed. +1 unit 3m 48s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 84m 20s Reason Tests Failed junit tests hadoop.tools.TestHdfsConfigFields Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10903 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832014/HDFS-10903.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bdf59385b589 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf37217 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17054/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17054/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17054/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Test failure hadoop.tools.TestHdfsConfigFields is related. We can fix this either by documenting it in config xml files, or adding it to TestHdfsConfigFields#configurationPropsToSkipCompare. I prefer the former one. Akira Ajisaka any thoughts? Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Test failure hadoop.tools.TestHdfsConfigFields is related. We can fix this either by documenting it in config xml files, or adding it to TestHdfsConfigFields#configurationPropsToSkipCompare . I prefer the former one. Akira Ajisaka any thoughts? Thanks.
          Hide
          liuml07 Mingliang Liu added a comment -

          ipc.client.connect.max.retries is used in some tests as string literals (e.g. TestFileAppend4), please also address them in this JIRA. Thanks.

          Show
          liuml07 Mingliang Liu added a comment - ipc.client.connect.max.retries is used in some tests as string literals (e.g. TestFileAppend4 ), please also address them in this JIRA. Thanks.
          Hide
          vagarychen Chen Liang added a comment -

          Thanks Mingliang Liu for the comments, uploaded v03 patch to include these changes.

          Show
          vagarychen Chen Liang added a comment - Thanks Mingliang Liu for the comments, uploaded v03 patch to include these changes.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 1m 29s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 17s trunk passed
          +1 javadoc 0m 54s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 20s the patch passed
          +1 javac 1m 20s the patch passed
          +1 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 0 new + 541 unchanged - 1 fixed = 541 total (was 542)
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 57s the patch passed
          +1 javadoc 1m 1s the patch passed
          +1 unit 77m 21s hadoop-hdfs in the patch passed.
          +1 unit 4m 12s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          107m 16s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10903
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832735/HDFS-10903.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux f8e1c9c7fb6d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2fb392a
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17107/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17107/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 1m 29s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 17s trunk passed +1 javadoc 0m 54s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 20s the patch passed +1 javac 1m 20s the patch passed +1 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 0 new + 541 unchanged - 1 fixed = 541 total (was 542) +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 57s the patch passed +1 javadoc 1m 1s the patch passed +1 unit 77m 21s hadoop-hdfs in the patch passed. +1 unit 4m 12s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 107m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10903 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832735/HDFS-10903.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f8e1c9c7fb6d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2fb392a Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17107/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17107/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk branch. Can you also provide a branch-2 patch? I found conflicts when cherry-picking. Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk branch. Can you also provide a branch-2 patch? I found conflicts when cherry-picking. Thanks.
          Hide
          liuml07 Mingliang Liu added a comment -

          +1

          Show
          liuml07 Mingliang Liu added a comment - +1
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10592 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10592/)
          HDFS-10903. Replace config key literal strings with config key names II: (liuml07: rev 3c9a01062e9097c2ed1db75318482543db2e382f)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/service/hadoop/FileSystemAccessService.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileAppend4.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10592 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10592/ ) HDFS-10903 . Replace config key literal strings with config key names II: (liuml07: rev 3c9a01062e9097c2ed1db75318482543db2e382f) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/service/hadoop/FileSystemAccessService.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileAppend4.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          vagarychen Chen Liang added a comment -

          Uploaded v004 patch for branch-2.

          Show
          vagarychen Chen Liang added a comment - Uploaded v004 patch for branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HDFS-10903 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-10903
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832985/HDFS-10903-branch-2.004.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17129/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-10903 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-10903 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832985/HDFS-10903-branch-2.004.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17129/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vagarychen Chen Liang added a comment -

          fix rebase issue in v005 patch

          Show
          vagarychen Chen Liang added a comment - fix rebase issue in v005 patch
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 38s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 2m 12s Maven dependency ordering for branch
          +1 mvninstall 7m 18s branch-2 passed
          +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101
          +1 compile 1m 23s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 39s branch-2 passed
          +1 mvnsite 1m 34s branch-2 passed
          +1 mvneclipse 0m 30s branch-2 passed
          +1 findbugs 2m 28s branch-2 passed
          +1 javadoc 1m 11s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 52s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 1m 19s the patch passed with JDK v1.8.0_101
          +1 javac 1m 19s the patch passed
          +1 compile 1m 24s the patch passed with JDK v1.7.0_111
          +1 javac 1m 24s the patch passed
          +1 checkstyle 0m 35s hadoop-hdfs-project: The patch generated 0 new + 503 unchanged - 1 fixed = 503 total (was 504)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 51s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 49s the patch passed with JDK v1.7.0_111
          +1 unit 47m 47s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          +1 unit 3m 49s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          153m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-10903
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832988/HDFS-10903-branch-2.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 0e9731266534 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / f131d61
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17130/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17130/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 38s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 2m 12s Maven dependency ordering for branch +1 mvninstall 7m 18s branch-2 passed +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101 +1 compile 1m 23s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 39s branch-2 passed +1 mvnsite 1m 34s branch-2 passed +1 mvneclipse 0m 30s branch-2 passed +1 findbugs 2m 28s branch-2 passed +1 javadoc 1m 11s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 52s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 1m 19s the patch passed with JDK v1.8.0_101 +1 javac 1m 19s the patch passed +1 compile 1m 24s the patch passed with JDK v1.7.0_111 +1 javac 1m 24s the patch passed +1 checkstyle 0m 35s hadoop-hdfs-project: The patch generated 0 new + 503 unchanged - 1 fixed = 503 total (was 504) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 51s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 49s the patch passed with JDK v1.7.0_111 +1 unit 47m 47s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 unit 3m 49s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 153m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10903 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832988/HDFS-10903-branch-2.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 0e9731266534 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / f131d61 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17130/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17130/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed branch-2 patch to branch-2 and branch-2.8. Thanks for your contribution, Chen Liang.

          Show
          liuml07 Mingliang Liu added a comment - Committed branch-2 patch to branch-2 and branch-2.8 . Thanks for your contribution, Chen Liang .

            People

            • Assignee:
              vagarychen Chen Liang
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development