Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13640

Fix findbugs warning in VersionInfoMojo.java

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha2
    • None
    • None
    • Reviewed

    Description

      Reported by Arpit on HADOOP-13602

      [INFO] org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo.getSvnUriInfo(String) uses String.indexOf(String) instead of String.indexOf(int) ["org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo"] At VersionInfoMojo.java:[lines 49-341]

      Attachments

        1. HADOOP-13640.001.patch
          0.8 kB
          Yuanbo Liu

        Activity

          yuanbo Yuanbo Liu added a comment -

          ozawa and ajisakaa Sorry to bother you both, I'm new to use findbugs, I'm wondering how to get the information which you mentioned in the description. Here is my maven command and I don't find some related info:

          mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true
          

          Any help will be appreciated. Thanks in advance.

          yuanbo Yuanbo Liu added a comment - ozawa and ajisakaa Sorry to bother you both, I'm new to use findbugs, I'm wondering how to get the information which you mentioned in the description. Here is my maven command and I don't find some related info: mvn -DskipTests test-compile findbugs:findbugs -DskipTests= true Any help will be appreciated. Thanks in advance.
          aajisaka Akira Ajisaka added a comment - Please see this document. http://qiita.com/ajis_ka/items/877be5edafa770485978
          yuanbo Yuanbo Liu added a comment -

          Thanks very much!

          yuanbo Yuanbo Liu added a comment - Thanks very much!
          yuanbo Yuanbo Liu added a comment -

          The bug pattern is `IIO_INEFFICIENT_INDEX_OF` and it belongs to performance detector. I don't know why findbugs plugin in my Intellij Idea disables performance check.

          yuanbo Yuanbo Liu added a comment - The bug pattern is `IIO_INEFFICIENT_INDEX_OF` and it belongs to performance detector. I don't know why findbugs plugin in my Intellij Idea disables performance check.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 0s trunk passed
          +1 compile 0m 12s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 14s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 24s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 10s the patch passed
          +1 compile 0m 9s the patch passed
          +1 javac 0m 9s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 11s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 9s the patch passed
          +1 unit 0m 10s hadoop-maven-plugins in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          12m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13640
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830450/HADOOP-13640.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1fab6b59ce6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e17a497
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10605/testReport/
          modules C: hadoop-maven-plugins U: hadoop-maven-plugins
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10605/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 0s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 10s the patch passed +1 compile 0m 9s the patch passed +1 javac 0m 9s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 10s hadoop-maven-plugins in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 12m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13640 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830450/HADOOP-13640.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1fab6b59ce6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e17a497 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10605/testReport/ modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10605/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          yuanbo Yuanbo Liu added a comment -

          ozawa and ajisakaa, please take a look at it if you have time. Thanks in advance.

          yuanbo Yuanbo Liu added a comment - ozawa and ajisakaa , please take a look at it if you have time. Thanks in advance.
          aajisaka Akira Ajisaka added a comment -

          +1, checking this in.

          aajisaka Akira Ajisaka added a comment - +1, checking this in.
          aajisaka Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks yuanbo for the contribution.

          aajisaka Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks yuanbo for the contribution.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10517 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10517/)
          HADOOP-13640. Fix findbugs warning in VersionInfoMojo.java. Contributed (aajisaka: rev 82c55dcbc8e3d5314aae9f8f600c660759213e45)

          • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/versioninfo/VersionInfoMojo.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10517 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10517/ ) HADOOP-13640 . Fix findbugs warning in VersionInfoMojo.java. Contributed (aajisaka: rev 82c55dcbc8e3d5314aae9f8f600c660759213e45) (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/versioninfo/VersionInfoMojo.java

          People

            yuanbo Yuanbo Liu
            ozawa Tsuyoshi Ozawa
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: