Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13602

Fix some warnings by findbugs in hadoop-maven-plugin

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10473 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10473/)
        HADOOP-13602. Fix some warnings by findbugs in hadoop-maven-plugin. (ozawa: rev 8d619b4896ac31f63fd0083594b6e7d207ef71a0)

        • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/versioninfo/VersionInfoMojo.java
        • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java
        • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java
        • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java
        • (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10473 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10473/ ) HADOOP-13602 . Fix some warnings by findbugs in hadoop-maven-plugin. (ozawa: rev 8d619b4896ac31f63fd0083594b6e7d207ef71a0) (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/versioninfo/VersionInfoMojo.java (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/protoc/ProtocMojo.java
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Opened HADOOP-13640 to track a remaining warning.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Opened HADOOP-13640 to track a remaining warning.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Arpit Agarwal thanks for the review! I Checking this in and creating new ticket for addressing the warning.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Arpit Agarwal thanks for the review! I Checking this in and creating new ticket for addressing the warning.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        There's one remaining warning:

        [INFO] org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo.getSvnUriInfo(String) uses String.indexOf(String) instead of String.indexOf(int) ["org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo"] At VersionInfoMojo.java:[lines 49-341]
        

        Okay to fix that either here or separately.

        Show
        arpitagarwal Arpit Agarwal added a comment - There's one remaining warning: [INFO] org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo.getSvnUriInfo( String ) uses String .indexOf( String ) instead of String .indexOf( int ) [ "org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo" ] At VersionInfoMojo.java:[lines 49-341] Okay to fix that either here or separately.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1

        Show
        arpitagarwal Arpit Agarwal added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 3s trunk passed
        +1 compile 0m 12s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 14s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 0m 21s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 9s the patch passed
        +1 compile 0m 10s the patch passed
        +1 javac 0m 10s the patch passed
        +1 checkstyle 0m 8s the patch passed
        +1 mvnsite 0m 10s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 0m 10s hadoop-maven-plugins in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        11m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13602
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828286/HADOOP-13602.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bcac9bd9af6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e793309
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10494/testReport/
        modules C: hadoop-maven-plugins U: hadoop-maven-plugins
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10494/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 3s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 9s the patch passed +1 compile 0m 10s the patch passed +1 javac 0m 10s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 10s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 10s hadoop-maven-plugins in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 11m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13602 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828286/HADOOP-13602.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bcac9bd9af6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e793309 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10494/testReport/ modules C: hadoop-maven-plugins U: hadoop-maven-plugins Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10494/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -
        • CompileMojo, TestMojo: calling toLowerCase with locale.
        • ProtocMojo: adding null check to avoid NPE
        • Exec: Handling IOE/IE instead of Exception class
        • VersionInfoMojo: removing needless try-catch and creating MD5Comparator to avoid SIC_INNER_SHOULD_BE_STATIC_ANON.
        Show
        ozawa Tsuyoshi Ozawa added a comment - CompileMojo, TestMojo: calling toLowerCase with locale. ProtocMojo: adding null check to avoid NPE Exec: Handling IOE/IE instead of Exception class VersionInfoMojo: removing needless try-catch and creating MD5Comparator to avoid SIC_INNER_SHOULD_BE_STATIC_ANON.

          People

          • Assignee:
            ozawa Tsuyoshi Ozawa
            Reporter:
            ozawa Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development