Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13595

Rework hadoop_usage to be broken up by clients/daemons/etc.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-beta1
    • Component/s: scripts
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      This patch changes how usage output is generated to now require a sub-command type. This allows users to see who the intended audience for a command is or it is a daemon.

      Description

      Part of the feedback from HADOOP-13341 was that it wasn't obvious what was a client and what was a daemon. Reworking the hadoop_usage output so that it is obvious helps fix this issue.

      1. HADOOP-13595.00.patch
        29 kB
        Allen Wittenauer
      2. HADOOP-13595.01.patch
        35 kB
        Allen Wittenauer
      3. HADOOP-13595.02.patch
        35 kB
        Allen Wittenauer
      4. HADOOP-13595.03.patch
        29 kB
        Allen Wittenauer
      5. HADOOP-13595.04.patch
        35 kB
        Allen Wittenauer
      6. HADOOP-13595.05.patch
        35 kB
        Allen Wittenauer
      7. HADOOP-13595.06.patch
        36 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          aw Allen Wittenauer added a comment -

          Thanks!

          Show
          aw Allen Wittenauer added a comment - Thanks!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12106 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12106/)
          HADOOP-13595. Rework hadoop_usage to be broken up by (mackrorysd: rev 1a1bf6b7d044929bc9d6a4763780d916b00ccf5a)

          • (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_add_array_param.bats
          • (edit) hadoop-common-project/hadoop-kms/src/main/libexec/shellprofile.d/hadoop-kms.sh
          • (edit) hadoop-tools/hadoop-archive-logs/src/main/shellprofile.d/hadoop-archive-logs.sh
          • (edit) hadoop-tools/hadoop-gridmix/src/main/shellprofile.d/hadoop-gridmix.sh
          • (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_sort_array.bats
          • (edit) hadoop-common-project/hadoop-common/src/site/markdown/UnixShellGuide.md
          • (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_array_contains.bats
          • (edit) hadoop-tools/hadoop-distcp/src/main/shellprofile.d/hadoop-distcp.sh
          • (edit) hadoop-tools/hadoop-streaming/src/main/shellprofile.d/hadoop-streaming.sh
          • (edit) hadoop-mapreduce-project/bin/mapred
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh
          • (edit) hadoop-tools/hadoop-extras/src/main/shellprofile.d/hadoop-extras.sh
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          • (edit) hadoop-tools/hadoop-rumen/src/main/shellprofile.d/hadoop-rumen.sh
          • (edit) hadoop-yarn-project/hadoop-yarn/bin/yarn
          • (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop
          • (edit) hadoop-tools/hadoop-archives/src/main/shellprofile.d/hadoop-archives.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12106 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12106/ ) HADOOP-13595 . Rework hadoop_usage to be broken up by (mackrorysd: rev 1a1bf6b7d044929bc9d6a4763780d916b00ccf5a) (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_add_array_param.bats (edit) hadoop-common-project/hadoop-kms/src/main/libexec/shellprofile.d/hadoop-kms.sh (edit) hadoop-tools/hadoop-archive-logs/src/main/shellprofile.d/hadoop-archive-logs.sh (edit) hadoop-tools/hadoop-gridmix/src/main/shellprofile.d/hadoop-gridmix.sh (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_sort_array.bats (edit) hadoop-common-project/hadoop-common/src/site/markdown/UnixShellGuide.md (add) hadoop-common-project/hadoop-common/src/test/scripts/hadoop_array_contains.bats (edit) hadoop-tools/hadoop-distcp/src/main/shellprofile.d/hadoop-distcp.sh (edit) hadoop-tools/hadoop-streaming/src/main/shellprofile.d/hadoop-streaming.sh (edit) hadoop-mapreduce-project/bin/mapred (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh (edit) hadoop-tools/hadoop-extras/src/main/shellprofile.d/hadoop-extras.sh (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh (edit) hadoop-tools/hadoop-rumen/src/main/shellprofile.d/hadoop-rumen.sh (edit) hadoop-yarn-project/hadoop-yarn/bin/yarn (edit) hadoop-common-project/hadoop-common/src/main/bin/hadoop (edit) hadoop-tools/hadoop-archives/src/main/shellprofile.d/hadoop-archives.sh
          Hide
          mackrorysd Sean Mackrory added a comment -

          Pushed.

          Show
          mackrorysd Sean Mackrory added a comment - Pushed.
          Hide
          mackrorysd Sean Mackrory added a comment -

          +1. Can commit shortly...

          Show
          mackrorysd Sean Mackrory added a comment - +1. Can commit shortly...
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 34s Maven dependency ordering for branch
          +1 mvninstall 17m 10s trunk passed
          +1 mvnsite 14m 21s trunk passed
                Patch Compile Tests
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvnsite 14m 20s the patch passed
          +1 shellcheck 1m 30s There were no new shellcheck issues.
          +1 shelldocs 0m 9s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 unit 2m 18s hadoop-common in the patch passed.
          +1 unit 0m 30s hadoop-kms in the patch passed.
          +1 unit 1m 8s hadoop-hdfs in the patch passed.
          +1 unit 0m 28s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 11m 0s hadoop-yarn in the patch passed.
          +1 unit 2m 32s hadoop-mapreduce-project in the patch passed.
          +1 unit 0m 34s hadoop-streaming in the patch passed.
          +1 unit 0m 35s hadoop-distcp in the patch passed.
          +1 unit 0m 32s hadoop-archives in the patch passed.
          +1 unit 0m 31s hadoop-archive-logs in the patch passed.
          +1 unit 0m 34s hadoop-rumen in the patch passed.
          +1 unit 0m 36s hadoop-gridmix in the patch passed.
          +1 unit 0m 31s hadoop-extras in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          72m 45s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880061/HADOOP-13595.05.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux fb8cf5542e16 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5e4434f
          shellcheck v0.4.6
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12933/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12933/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 17m 10s trunk passed +1 mvnsite 14m 21s trunk passed       Patch Compile Tests 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvnsite 14m 20s the patch passed +1 shellcheck 1m 30s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 18s hadoop-common in the patch passed. +1 unit 0m 30s hadoop-kms in the patch passed. +1 unit 1m 8s hadoop-hdfs in the patch passed. +1 unit 0m 28s hadoop-hdfs-httpfs in the patch passed. +1 unit 11m 0s hadoop-yarn in the patch passed. +1 unit 2m 32s hadoop-mapreduce-project in the patch passed. +1 unit 0m 34s hadoop-streaming in the patch passed. +1 unit 0m 35s hadoop-distcp in the patch passed. +1 unit 0m 32s hadoop-archives in the patch passed. +1 unit 0m 31s hadoop-archive-logs in the patch passed. +1 unit 0m 34s hadoop-rumen in the patch passed. +1 unit 0m 36s hadoop-gridmix in the patch passed. +1 unit 0m 31s hadoop-extras in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 72m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880061/HADOOP-13595.05.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux fb8cf5542e16 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e4434f shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12933/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12933/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -06:

          • restore IFS in sort_array
          • add IFS check to the sort test code (which failed before!)

          Thanks for catching that!

          Show
          aw Allen Wittenauer added a comment - -06: restore IFS in sort_array add IFS check to the sort test code (which failed before!) Thanks for catching that!
          Hide
          aw Allen Wittenauer added a comment - - edited

          Argh. Actually, it's not getting reset because there is no fork, built-in being called (see the column printer code), and the $() call doesn't count. I should add that to the unit test.

          It kind of sucks that IFS getting set like this is situational.

          Show
          aw Allen Wittenauer added a comment - - edited Argh. Actually, it's not getting reset because there is no fork, built-in being called (see the column printer code), and the $() call doesn't count. I should add that to the unit test. It kind of sucks that IFS getting set like this is situational.
          Hide
          mackrorysd Sean Mackrory added a comment -

          Ooh I see that now. Thanks. +1 from me, pending clean Yetus run.

          Show
          mackrorysd Sean Mackrory added a comment - Ooh I see that now. Thanks. +1 from me, pending clean Yetus run.
          Hide
          aw Allen Wittenauer added a comment -

          It's actually not needed. IFS should get reset at the next line.

          Show
          aw Allen Wittenauer added a comment - It's actually not needed. IFS should get reset at the next line.
          Hide
          mackrorysd Sean Mackrory added a comment -

          Thanks for the iteration. What's up with oifs stuff missing in the latest patch?

          Show
          mackrorysd Sean Mackrory added a comment - Thanks for the iteration. What's up with oifs stuff missing in the latest patch?
          Hide
          aw Allen Wittenauer added a comment -

          -05:

          • fix shellcheck errors
          Show
          aw Allen Wittenauer added a comment - -05: fix shellcheck errors
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 17m 10s trunk passed
          +1 mvnsite 14m 19s trunk passed
                Patch Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvnsite 13m 45s the patch passed
          -1 shellcheck 1m 31s The patch generated 11 new + 20 unchanged - 0 fixed = 31 total (was 20)
          +1 shelldocs 0m 9s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 unit 2m 18s hadoop-common in the patch passed.
          +1 unit 0m 22s hadoop-kms in the patch passed.
          +1 unit 1m 6s hadoop-hdfs in the patch passed.
          +1 unit 0m 25s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 10m 55s hadoop-yarn in the patch passed.
          +1 unit 2m 36s hadoop-mapreduce-project in the patch passed.
          +1 unit 0m 34s hadoop-streaming in the patch passed.
          +1 unit 0m 35s hadoop-distcp in the patch passed.
          +1 unit 0m 30s hadoop-archives in the patch passed.
          +1 unit 0m 31s hadoop-archive-logs in the patch passed.
          +1 unit 0m 34s hadoop-rumen in the patch passed.
          +1 unit 0m 35s hadoop-gridmix in the patch passed.
          +1 unit 0m 30s hadoop-extras in the patch passed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          71m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879955/HADOOP-13595.04.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux fc790b4aa405 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6814324
          shellcheck v0.4.6
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/artifact/patchprocess/diff-patch-shellcheck.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 17m 10s trunk passed +1 mvnsite 14m 19s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvnsite 13m 45s the patch passed -1 shellcheck 1m 31s The patch generated 11 new + 20 unchanged - 0 fixed = 31 total (was 20) +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 18s hadoop-common in the patch passed. +1 unit 0m 22s hadoop-kms in the patch passed. +1 unit 1m 6s hadoop-hdfs in the patch passed. +1 unit 0m 25s hadoop-hdfs-httpfs in the patch passed. +1 unit 10m 55s hadoop-yarn in the patch passed. +1 unit 2m 36s hadoop-mapreduce-project in the patch passed. +1 unit 0m 34s hadoop-streaming in the patch passed. +1 unit 0m 35s hadoop-distcp in the patch passed. +1 unit 0m 30s hadoop-archives in the patch passed. +1 unit 0m 31s hadoop-archive-logs in the patch passed. +1 unit 0m 34s hadoop-rumen in the patch passed. +1 unit 0m 35s hadoop-gridmix in the patch passed. +1 unit 0m 30s hadoop-extras in the patch passed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 71m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879955/HADOOP-13595.04.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux fc790b4aa405 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6814324 shellcheck v0.4.6 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/artifact/patchprocess/diff-patch-shellcheck.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12924/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -04:

          • address feedback
          • speed this code up
          Show
          aw Allen Wittenauer added a comment - -04: address feedback speed this code up
          Hide
          aw Allen Wittenauer added a comment -

          We're pretty much allowed to break compatibility up until beta-1. Unfortunately, I fully expect that a lot of incompat changes that really should be in it won't make it. This means we'll be stuck with broken APIs and bad decisions for another 7 years.

          Show
          aw Allen Wittenauer added a comment - We're pretty much allowed to break compatibility up until beta-1. Unfortunately, I fully expect that a lot of incompat changes that really should be in it won't make it. This means we'll be stuck with broken APIs and bad decisions for another 7 years.
          Hide
          mackrorysd Sean Mackrory added a comment - - edited

          Allen Wittenauer - I just reviewed this and did some testing. I'm mostly supportive, but a couple of issues:

          • Are you aware the .bats files are missing from your latest patch?
          • Instead of appending "-type" to the section headings in the output, what about " Commands". I think "Admin Commands", "Client Commands" and "Daemon Commands" would be much clearer than "Admin-type", "Client-type", and "Daemon-type". Thoughts?

          If we consider bash functions to be covered by the term "CLI programs" then we're breaking compatibility even in a major release (according to https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI), but I don't think interpret it that way and other than that the only thing changing is the help output, so I don't think there's actually a compatibility concern here. But I'm a +1 to put this in beta-1 anyway, if we can address the two points above.

          Show
          mackrorysd Sean Mackrory added a comment - - edited Allen Wittenauer - I just reviewed this and did some testing. I'm mostly supportive, but a couple of issues: Are you aware the .bats files are missing from your latest patch? Instead of appending "-type" to the section headings in the output, what about " Commands". I think "Admin Commands", "Client Commands" and "Daemon Commands" would be much clearer than "Admin-type", "Client-type", and "Daemon-type". Thoughts? If we consider bash functions to be covered by the term "CLI programs" then we're breaking compatibility even in a major release (according to https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI ), but I don't think interpret it that way and other than that the only thing changing is the help output, so I don't think there's actually a compatibility concern here. But I'm a +1 to put this in beta-1 anyway, if we can address the two points above.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 32s Maven dependency ordering for branch
          +1 mvninstall 13m 41s trunk passed
          +1 mvnsite 10m 27s trunk passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvnsite 9m 58s the patch passed
          -1 shellcheck 1m 20s The patch generated 17 new + 21 unchanged - 0 fixed = 38 total (was 21)
          +1 shelldocs 0m 9s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 2m 7s hadoop-common in the patch passed.
          +1 unit 0m 19s hadoop-kms in the patch passed.
          +1 unit 0m 52s hadoop-hdfs in the patch passed.
          +1 unit 0m 21s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 8m 44s hadoop-yarn in the patch passed.
          +1 unit 2m 4s hadoop-mapreduce-project in the patch passed.
          +1 unit 0m 28s hadoop-streaming in the patch passed.
          +1 unit 0m 29s hadoop-distcp in the patch passed.
          +1 unit 0m 26s hadoop-archives in the patch passed.
          +1 unit 0m 26s hadoop-archive-logs in the patch passed.
          +1 unit 0m 27s hadoop-rumen in the patch passed.
          +1 unit 0m 30s hadoop-gridmix in the patch passed.
          +1 unit 0m 26s hadoop-extras in the patch passed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          56m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875309/HADOOP-13595.03.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux ef4f102bb181 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fa1aaee
          shellcheck v0.4.6
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/artifact/patchprocess/diff-patch-shellcheck.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 32s Maven dependency ordering for branch +1 mvninstall 13m 41s trunk passed +1 mvnsite 10m 27s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvnsite 9m 58s the patch passed -1 shellcheck 1m 20s The patch generated 17 new + 21 unchanged - 0 fixed = 38 total (was 21) +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 2m 7s hadoop-common in the patch passed. +1 unit 0m 19s hadoop-kms in the patch passed. +1 unit 0m 52s hadoop-hdfs in the patch passed. +1 unit 0m 21s hadoop-hdfs-httpfs in the patch passed. +1 unit 8m 44s hadoop-yarn in the patch passed. +1 unit 2m 4s hadoop-mapreduce-project in the patch passed. +1 unit 0m 28s hadoop-streaming in the patch passed. +1 unit 0m 29s hadoop-distcp in the patch passed. +1 unit 0m 26s hadoop-archives in the patch passed. +1 unit 0m 26s hadoop-archive-logs in the patch passed. +1 unit 0m 27s hadoop-rumen in the patch passed. +1 unit 0m 30s hadoop-gridmix in the patch passed. +1 unit 0m 26s hadoop-extras in the patch passed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 56m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875309/HADOOP-13595.03.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux ef4f102bb181 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa1aaee shellcheck v0.4.6 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/artifact/patchprocess/diff-patch-shellcheck.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12692/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Change this to be a blocker, since it is an incompatible change that needs to go in before beta1.

          Show
          aw Allen Wittenauer added a comment - Change this to be a blocker, since it is an incompatible change that needs to go in before beta1.
          Hide
          aw Allen Wittenauer added a comment -

          -03:

          • rebase
          Show
          aw Allen Wittenauer added a comment - -03: rebase
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 13m 31s trunk passed
          +1 mvnsite 10m 23s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvnsite 9m 52s the patch passed
          +1 shellcheck 2m 41s There were no new shellcheck issues.
          +1 shelldocs 0m 10s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 2m 11s hadoop-common in the patch passed.
          +1 unit 0m 19s hadoop-kms in the patch passed.
          +1 unit 0m 52s hadoop-hdfs in the patch passed.
          +1 unit 0m 21s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 11m 58s hadoop-yarn in the patch passed.
          +1 unit 0m 29s hadoop-streaming in the patch passed.
          +1 unit 0m 29s hadoop-distcp in the patch passed.
          +1 unit 0m 28s hadoop-archives in the patch passed.
          +1 unit 0m 27s hadoop-archive-logs in the patch passed.
          +1 unit 0m 28s hadoop-rumen in the patch passed.
          +1 unit 0m 30s hadoop-gridmix in the patch passed.
          +1 unit 0m 27s hadoop-extras in the patch passed.
          +1 unit 1m 57s hadoop-mapreduce-project in the patch passed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          59m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865672/HADOOP-13595.02.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 090d651159aa 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 19a7e94
          shellcheck v0.4.6
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12214/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12214/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 31s trunk passed +1 mvnsite 10m 23s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvnsite 9m 52s the patch passed +1 shellcheck 2m 41s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 2m 11s hadoop-common in the patch passed. +1 unit 0m 19s hadoop-kms in the patch passed. +1 unit 0m 52s hadoop-hdfs in the patch passed. +1 unit 0m 21s hadoop-hdfs-httpfs in the patch passed. +1 unit 11m 58s hadoop-yarn in the patch passed. +1 unit 0m 29s hadoop-streaming in the patch passed. +1 unit 0m 29s hadoop-distcp in the patch passed. +1 unit 0m 28s hadoop-archives in the patch passed. +1 unit 0m 27s hadoop-archive-logs in the patch passed. +1 unit 0m 28s hadoop-rumen in the patch passed. +1 unit 0m 30s hadoop-gridmix in the patch passed. +1 unit 0m 27s hadoop-extras in the patch passed. +1 unit 1m 57s hadoop-mapreduce-project in the patch passed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 59m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865672/HADOOP-13595.02.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 090d651159aa 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19a7e94 shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12214/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12214/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -02:

          • fix shellcheck errors
          Show
          aw Allen Wittenauer added a comment - -02: fix shellcheck errors
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 42s Maven dependency ordering for branch
          +1 mvninstall 14m 32s trunk passed
          +1 mvnsite 11m 41s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvnsite 11m 36s the patch passed
          -1 shellcheck 2m 42s The patch generated 17 new + 75 unchanged - 0 fixed = 92 total (was 75)
          +1 shelldocs 0m 8s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 1m 59s hadoop-common in the patch passed.
          +1 unit 0m 21s hadoop-kms in the patch passed.
          +1 unit 1m 2s hadoop-hdfs in the patch passed.
          +1 unit 0m 23s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 11m 39s hadoop-yarn in the patch passed.
          +1 unit 0m 32s hadoop-streaming in the patch passed.
          +1 unit 0m 30s hadoop-distcp in the patch passed.
          +1 unit 0m 27s hadoop-archives in the patch passed.
          +1 unit 0m 28s hadoop-archive-logs in the patch passed.
          +1 unit 0m 29s hadoop-rumen in the patch passed.
          +1 unit 0m 31s hadoop-gridmix in the patch passed.
          +1 unit 0m 27s hadoop-extras in the patch passed.
          +1 unit 1m 57s hadoop-mapreduce-project in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          65m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ac17dc
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865634/HADOOP-13595.01.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 7812b0fb37d2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2e52789
          shellcheck v0.4.6
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/artifact/patchprocess/diff-patch-shellcheck.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 42s Maven dependency ordering for branch +1 mvninstall 14m 32s trunk passed +1 mvnsite 11m 41s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvnsite 11m 36s the patch passed -1 shellcheck 2m 42s The patch generated 17 new + 75 unchanged - 0 fixed = 92 total (was 75) +1 shelldocs 0m 8s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 59s hadoop-common in the patch passed. +1 unit 0m 21s hadoop-kms in the patch passed. +1 unit 1m 2s hadoop-hdfs in the patch passed. +1 unit 0m 23s hadoop-hdfs-httpfs in the patch passed. +1 unit 11m 39s hadoop-yarn in the patch passed. +1 unit 0m 32s hadoop-streaming in the patch passed. +1 unit 0m 30s hadoop-distcp in the patch passed. +1 unit 0m 27s hadoop-archives in the patch passed. +1 unit 0m 28s hadoop-archive-logs in the patch passed. +1 unit 0m 29s hadoop-rumen in the patch passed. +1 unit 0m 31s hadoop-gridmix in the patch passed. +1 unit 0m 27s hadoop-extras in the patch passed. +1 unit 1m 57s hadoop-mapreduce-project in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 65m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865634/HADOOP-13595.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 7812b0fb37d2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e52789 shellcheck v0.4.6 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/artifact/patchprocess/diff-patch-shellcheck.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12209/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          anu Anu Engineer added a comment - - edited

          A non-privileged user can run diskbalancer and mover? That's... surprising. Also, mover has the

          Sorry, I was not very clear. For diskbalancer you can read the data layout from the datanode and create plan, you don't have to be an admin for that. But to submit that plan for execution to the datanode, you need to be an admin.

          So the command we are talking about is the client side tool. Actual data movement is done inside a datanode thread.

          Show
          anu Anu Engineer added a comment - - edited A non-privileged user can run diskbalancer and mover? That's... surprising. Also, mover has the Sorry, I was not very clear. For diskbalancer you can read the data layout from the datanode and create plan, you don't have to be an admin for that. But to submit that plan for execution to the datanode, you need to be an admin. So the command we are talking about is the client side tool. Actual data movement is done inside a datanode thread.
          Hide
          aw Allen Wittenauer added a comment -

          -01:

          • add some unit tests
          Show
          aw Allen Wittenauer added a comment - -01: add some unit tests
          Hide
          aw Allen Wittenauer added a comment -

          A non-privileged user can run diskbalancer and mover? That's... surprising. Also, mover has the HADOOP_SUBCMD_SUPPORTDAEMONIZATION set to "true" flag... which means it is technically a daemon.

          Show
          aw Allen Wittenauer added a comment - A non-privileged user can run diskbalancer and mover? That's... surprising. Also, mover has the HADOOP_SUBCMD_SUPPORTDAEMONIZATION set to "true" flag... which means it is technically a daemon.
          Hide
          anu Anu Engineer added a comment -

          Allen Wittenauer Thank you for getting this done. I really appreciate it. +1 on these changes.

          However I did have a very minor suggestion to change the category of some of these commands if it makes sense. Here are my suggestions.

          • "daemonlog" client ==> admin
          • "diskbalancer" daemon ==> client
          • "mover" daemon ==> client
          Show
          anu Anu Engineer added a comment - Allen Wittenauer Thank you for getting this done. I really appreciate it. +1 on these changes. However I did have a very minor suggestion to change the category of some of these commands if it makes sense. Here are my suggestions. "daemonlog" client ==> admin "diskbalancer" daemon ==> client "mover" daemon ==> client
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 45s Maven dependency ordering for branch
          +1 mvninstall 12m 54s trunk passed
          +1 mvnsite 9m 53s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvnsite 9m 20s the patch passed
          -1 shellcheck 2m 31s The patch generated 17 new + 69 unchanged - 0 fixed = 86 total (was 69)
          +1 shelldocs 0m 9s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 2m 7s hadoop-common in the patch passed.
          +1 unit 0m 18s hadoop-kms in the patch passed.
          +1 unit 0m 50s hadoop-hdfs in the patch passed.
          +1 unit 0m 20s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 10m 24s hadoop-yarn in the patch passed.
          +1 unit 0m 29s hadoop-streaming in the patch passed.
          +1 unit 0m 28s hadoop-distcp in the patch passed.
          +1 unit 0m 25s hadoop-archives in the patch passed.
          +1 unit 0m 26s hadoop-archive-logs in the patch passed.
          +1 unit 0m 27s hadoop-rumen in the patch passed.
          +1 unit 0m 29s hadoop-gridmix in the patch passed.
          +1 unit 0m 26s hadoop-extras in the patch passed.
          +1 unit 1m 54s hadoop-mapreduce-project in the patch passed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          57m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13595
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862559/HADOOP-13595.00.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux fda99ca06377 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 39fa371
          shellcheck v0.4.5
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/artifact/patchprocess/diff-patch-shellcheck.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 45s Maven dependency ordering for branch +1 mvninstall 12m 54s trunk passed +1 mvnsite 9m 53s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvnsite 9m 20s the patch passed -1 shellcheck 2m 31s The patch generated 17 new + 69 unchanged - 0 fixed = 86 total (was 69) +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 2m 7s hadoop-common in the patch passed. +1 unit 0m 18s hadoop-kms in the patch passed. +1 unit 0m 50s hadoop-hdfs in the patch passed. +1 unit 0m 20s hadoop-hdfs-httpfs in the patch passed. +1 unit 10m 24s hadoop-yarn in the patch passed. +1 unit 0m 29s hadoop-streaming in the patch passed. +1 unit 0m 28s hadoop-distcp in the patch passed. +1 unit 0m 25s hadoop-archives in the patch passed. +1 unit 0m 26s hadoop-archive-logs in the patch passed. +1 unit 0m 27s hadoop-rumen in the patch passed. +1 unit 0m 29s hadoop-gridmix in the patch passed. +1 unit 0m 26s hadoop-extras in the patch passed. +1 unit 1m 54s hadoop-mapreduce-project in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 57m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13595 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862559/HADOOP-13595.00.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux fda99ca06377 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 39fa371 shellcheck v0.4.5 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/artifact/patchprocess/diff-patch-shellcheck.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-tools/hadoop-streaming hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12066/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          ping Anu Engineer since this was his request.

          Show
          aw Allen Wittenauer added a comment - ping Anu Engineer since this was his request.
          Hide
          aw Allen Wittenauer added a comment -

          -00:

          • add a "type" field when adding things to the usage output
          • touch all of the usage bits to use thew new type
          • add a few array helper functions
          • rework the logic of the usage output routines to show the type

          To-do:

          • Add/fix unit tests
          Show
          aw Allen Wittenauer added a comment - -00: add a "type" field when adding things to the usage output touch all of the usage bits to use thew new type add a few array helper functions rework the logic of the usage output routines to show the type To-do: Add/fix unit tests

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development