Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      GenericTestUtils$LogCapturer is useful for assertions against service logs. However it should be fixed in following aspects:

      1. In the constructor, it uses the stdout appender's layout.
        Layout layout = Logger.getRootLogger().getAppender("stdout").getLayout();
        

        However, the stdout appender may be named "console" or alike which makes the constructor throw NPE. Actually the layout does not matter and we can use a default pattern layout that only captures application logs.

      2. stopCapturing() method is not working. The major reason is that the appender internal variable is never assigned and thus removing it to stop capturing makes no sense.
      3. It does not support org.slf4j.Logger which is preferred to log4j in many modules.
      4. There is no unit test for it.

      This jira is to address these.

      1. HADOOP-13470.002.patch
        5 kB
        Mingliang Liu
      2. HADOOP-13470.001.patch
        4 kB
        Mingliang Liu
      3. HADOOP-13470.000.patch
        4 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10289/)
          HADOOP-13470. GenericTestUtils$LogCapturer is flaky. (Contributed by (liuml07: rev 23532716fcd3f7e5e20b8f9fc66188041638510a)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10289/ ) HADOOP-13470 . GenericTestUtils$LogCapturer is flaky. (Contributed by (liuml07: rev 23532716fcd3f7e5e20b8f9fc66188041638510a) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Hide
          liuml07 Mingliang Liu added a comment -

          I have committed the v2 patch to trunk, branch-2 and branch-2.8. Thanks for prompt review Chris Nauroth.

          Show
          liuml07 Mingliang Liu added a comment - I have committed the v2 patch to trunk , branch-2 and branch-2.8 . Thanks for prompt review Chris Nauroth .
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v2. I verified TestFileSystemOperationsWithThreads and TestBootstrapStandby. Thank you, Mingliang.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v2. I verified TestFileSystemOperationsWithThreads and TestBootstrapStandby . Thank you, Mingliang.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 27s trunk passed
          +1 compile 8m 2s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 24s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 42s the patch passed
          +1 compile 7m 32s the patch passed
          +1 javac 7m 32s the patch passed
          +1 checkstyle 1m 33s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 10m 25s hadoop-common in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          45m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824024/HADOOP-13470.002.patch
          JIRA Issue HADOOP-13470
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7247a83cce75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 27a6e09
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10266/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10266/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 27s trunk passed +1 compile 8m 2s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 32s the patch passed +1 javac 7m 32s the patch passed +1 checkstyle 1m 33s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 10m 25s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 45m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824024/HADOOP-13470.002.patch JIRA Issue HADOOP-13470 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7247a83cce75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27a6e09 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10266/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10266/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10287 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10287/)
          Revert "HADOOP-13470. GenericTestUtils$LogCapturer is flaky. (liuml07: rev 27a6e09c4e22b9b5fee4e8ced7321eed92d566a4)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10287 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10287/ ) Revert " HADOOP-13470 . GenericTestUtils$LogCapturer is flaky. (liuml07: rev 27a6e09c4e22b9b5fee4e8ced7321eed92d566a4) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Attaching the v2 patch according to latest discussion. Thanks!

          Show
          liuml07 Mingliang Liu added a comment - Attaching the v2 patch according to latest discussion. Thanks!
          Hide
          cnauroth Chris Nauroth added a comment -

          Actually, this looks like a good candidate to revert and then post an updated patch, given that the original patch was isolated and there have been no additional conflicting changes. Thanks again, Mingliang.

          Show
          cnauroth Chris Nauroth added a comment - Actually, this looks like a good candidate to revert and then post an updated patch, given that the original patch was isolated and there have been no additional conflicting changes. Thanks again, Mingliang.
          Hide
          cnauroth Chris Nauroth added a comment -

          A simple fix is to use default PatternLayout only if the stdout and console appender are not defined.

          That sounds perfect. That would be backward-compatible for any existing tests that rely on a specific pattern in log4j.properties. Thanks! Please feel free to notify me for code review on the new patch, and I'll try TestFileSystemOperationsWithThreads with it.

          Show
          cnauroth Chris Nauroth added a comment - A simple fix is to use default PatternLayout only if the stdout and console appender are not defined. That sounds perfect. That would be backward-compatible for any existing tests that rely on a specific pattern in log4j.properties. Thanks! Please feel free to notify me for code review on the new patch, and I'll try TestFileSystemOperationsWithThreads with it.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Chris Nauroth for the report and analysis. Sorry I was not aware of the case that captured logs format matters besides the application log itself.

          A simple fix is to use default PatternLayout only if the stdout and console appender are not defined. This should not make the existing code fail; and guards the cases where those appenders are not defined. At least, if an incoming test relys on the log format, it should define the format in module-specific log4j.properties. If this looks good, I can prepare a simple patch for this.

          TestBootstrapStandby#testSharedEditsMissingLogs asserts the log level (FATAL), which is the same problem. Thanks Kihwal Lee for reporting this. This was also missed in pre-commit build.

               private LogCapturer(Logger logger) {
                 this.logger = logger;
          -      this.appender = new WriterAppender(new PatternLayout(), sw);
          -      logger.addAppender(appender);
          +      Appender defaultAppender = Logger.getRootLogger().getAppender("stdout");
          +      if (defaultAppender == null) {
          +        defaultAppender = Logger.getRootLogger().getAppender("console");
          +      }
          +      final Layout layout = (defaultAppender == null) ? new PatternLayout() : defaultAppender.getLayout();
          +      this.appender = new WriterAppender(layout, sw);
          +      logger.addAppender(this.appender);
               }
          
          Show
          liuml07 Mingliang Liu added a comment - Thanks Chris Nauroth for the report and analysis. Sorry I was not aware of the case that captured logs format matters besides the application log itself. A simple fix is to use default PatternLayout only if the stdout and console appender are not defined. This should not make the existing code fail; and guards the cases where those appenders are not defined. At least, if an incoming test relys on the log format, it should define the format in module-specific log4j.properties. If this looks good, I can prepare a simple patch for this. TestBootstrapStandby#testSharedEditsMissingLogs asserts the log level (FATAL), which is the same problem. Thanks Kihwal Lee for reporting this. This was also missed in pre-commit build. private LogCapturer(Logger logger) { this .logger = logger; - this .appender = new WriterAppender( new PatternLayout(), sw); - logger.addAppender(appender); + Appender defaultAppender = Logger.getRootLogger().getAppender( "stdout" ); + if (defaultAppender == null ) { + defaultAppender = Logger.getRootLogger().getAppender( "console" ); + } + final Layout layout = (defaultAppender == null ) ? new PatternLayout() : defaultAppender.getLayout(); + this .appender = new WriterAppender(layout, sw); + logger.addAppender( this .appender); }
          Hide
          kihwal Kihwal Lee added a comment -

          TestBootstrapStandby also started failing after this.

          Show
          kihwal Kihwal Lee added a comment - TestBootstrapStandby also started failing after this.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hello Mingliang Liu. This patch unfortunately broke TestFileSystemOperationsWithThreads in hadoop-azure. It wasn't caught in pre-commit, because TestFileSystemOperationsWithThreads doesn't execute unless the build environment is configured with Azure Storage credentials (similar to hadoop-aws).

          The failing tests have a few assertions that check for log messages containing specific thread names:

          https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationsWithThreads.java#L285-L288

          This is intended to validate that all expected threads in a parallelized operation performed some work. After LogCapturer switched to using a default PatternLayout, the thread name is no longer included in the captured logs.

          Possible solutions for this are either to revert the patch or change the instantiated PatternLayout to use a pattern that includes thread name. I scanned a few of our existing test log4j.properties files, and there isn't a single consistent pattern used across all of them right now, so I guess we'd just have to pick something reasonable and go with it.

          Let me know your thoughts. Thanks.

          Show
          cnauroth Chris Nauroth added a comment - Hello Mingliang Liu . This patch unfortunately broke TestFileSystemOperationsWithThreads in hadoop-azure. It wasn't caught in pre-commit, because TestFileSystemOperationsWithThreads doesn't execute unless the build environment is configured with Azure Storage credentials (similar to hadoop-aws). The failing tests have a few assertions that check for log messages containing specific thread names: https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationsWithThreads.java#L285-L288 This is intended to validate that all expected threads in a parallelized operation performed some work. After LogCapturer switched to using a default PatternLayout , the thread name is no longer included in the captured logs. Possible solutions for this are either to revert the patch or change the instantiated PatternLayout to use a pattern that includes thread name. I scanned a few of our existing test log4j.properties files, and there isn't a single consistent pattern used across all of them right now, so I guess we'd just have to pick something reasonable and go with it. Let me know your thoughts. Thanks.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10280 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10280/)
          HADOOP-13470. GenericTestUtils$LogCapturer is flaky. (Contributed by (liuml07: rev 9336a0495f99cd3fbc7ecef452eb37cfbaf57440)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10280 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10280/ ) HADOOP-13470 . GenericTestUtils$LogCapturer is flaky. (Contributed by (liuml07: rev 9336a0495f99cd3fbc7ecef452eb37cfbaf57440) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk, branch-2 and branch-2.8. Thanks Jitendra Nath Pandey for review.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk , branch-2 and branch-2.8 . Thanks Jitendra Nath Pandey for review.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1 LGTM

          Show
          jnp Jitendra Nath Pandey added a comment - +1 LGTM
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 39s trunk passed
          +1 compile 7m 21s trunk passed
          +1 checkstyle 0m 25s trunk passed
          -1 mvnsite 1m 58s hadoop-common in trunk failed.
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 47s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 41s the patch passed
          +1 compile 7m 30s the patch passed
          +1 javac 7m 30s the patch passed
          +1 checkstyle 0m 23s the patch passed
          -1 mvnsite 2m 14s hadoop-common in the patch failed.
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 52s the patch passed
          +1 javadoc 0m 47s the patch passed
          +1 unit 7m 58s hadoop-common in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          43m 41s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822249/HADOOP-13470.001.patch
          JIRA Issue HADOOP-13470
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 79c650b2ebe2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 18d9e6e
          Default Java 1.8.0_101
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs v3.0.0
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 39s trunk passed +1 compile 7m 21s trunk passed +1 checkstyle 0m 25s trunk passed -1 mvnsite 1m 58s hadoop-common in trunk failed. +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 7m 30s the patch passed +1 javac 7m 30s the patch passed +1 checkstyle 0m 23s the patch passed -1 mvnsite 2m 14s hadoop-common in the patch failed. +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 7m 58s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 43m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822249/HADOOP-13470.001.patch JIRA Issue HADOOP-13470 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 79c650b2ebe2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 18d9e6e Default Java 1.8.0_101 mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs v3.0.0 mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10184/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Failing test seems not related. V1 patch is to address the checkstyle warnings.

          Show
          liuml07 Mingliang Liu added a comment - Failing test seems not related. V1 patch is to address the checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 54s trunk passed
          +1 compile 7m 19s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 24s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 8m 3s the patch passed
          +1 javac 8m 3s the patch passed
          -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18)
          +1 mvnsite 1m 7s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 53s the patch passed
          -1 unit 17m 17s hadoop-common in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          50m 32s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822236/HADOOP-13470.000.patch
          JIRA Issue HADOOP-13470
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a78e608599ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 18d9e6e
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 7m 19s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 8m 3s the patch passed +1 javac 8m 3s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed -1 unit 17m 17s hadoop-common in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 50m 32s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822236/HADOOP-13470.000.patch JIRA Issue HADOOP-13470 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a78e608599ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 18d9e6e Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10183/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -
          Show
          liuml07 Mingliang Liu added a comment - Ping Jitendra Nath Pandey and Arpit Agarwal .

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development