[HADOOP-13470] GenericTestUtils$LogCapturer is flaky

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test, util
• Labels: reviewed
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 05/Aug/16 05:16
• Updated: 22/Jun/17 20:50
• Resolved: 17/Aug/16 00:47

Description

GenericTestUtils$LogCapturer is useful for assertions against service logs. However it should be fixed in following aspects:

1. In the constructor, it uses the stdout appender's layout.

   Layout layout = Logger.getRootLogger().getAppender("stdout").getLayout();
   

   However, the stdout appender may be named "console" or alike which makes the constructor throw NPE. Actually the layout does not matter and we can use a default pattern layout that only captures application logs.

2. stopCapturing() method is not working. The major reason is that the appender internal variable is never assigned and thus removing it to stop capturing makes no sense.
3. It does not support org.slf4j.Logger which is preferred to log4j in many modules.
4. There is no unit test for it.

This jira is to address these.

Issue Links

• is depended upon by: HADOOP-10823 TestReloadingX509TrustManager is flaky
• is related to: HADOOP-14573 regression: Azure tests which capture logs failing with move to SLF4J