Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13412

Move dev-support/checkstyle/suppressions.xml to hadoop-build-tools

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      HADOOP-11889 consolidated common checkstyle config files into directory hadoop-build-tools/src/main/resources/checkstyle.

      Move dev-support/checkstyle/suppressions.xml over there as well.

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Thanks Wei-Chiu Chuang for the review and commit!

        Show
        jzhuge John Zhuge added a comment - Thanks Wei-Chiu Chuang for the review and commit!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed this in branch-2 and trunk. Thanks John Zhuge for contributing the patch!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed this in branch-2 and trunk. Thanks John Zhuge for contributing the patch!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10448 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10448/)
        HADOOP-13412. Move dev-support/checkstyle/suppressions.xml to (weichiu: rev cd099a63d58c6981c45db2b169430d4935e43bd1)

        • (edit) pom.xml
        • (add) hadoop-build-tools/src/main/resources/checkstyle/suppressions.xml
        • (delete) dev-support/checkstyle/suppressions.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10448 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10448/ ) HADOOP-13412 . Move dev-support/checkstyle/suppressions.xml to (weichiu: rev cd099a63d58c6981c45db2b169430d4935e43bd1) (edit) pom.xml (add) hadoop-build-tools/src/main/resources/checkstyle/suppressions.xml (delete) dev-support/checkstyle/suppressions.xml
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        +1. My local yetus precommit does not show the asflicense warning. Will commit soon.

        Show
        jojochuang Wei-Chiu Chuang added a comment - +1. My local yetus precommit does not show the asflicense warning. Will commit soon.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 5m 49s Maven dependency ordering for branch
        +1 mvninstall 9m 10s trunk passed
        +1 compile 8m 48s trunk passed
        +1 mvnsite 10m 34s trunk passed
        +1 mvneclipse 3m 32s trunk passed
        +1 javadoc 5m 2s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 6m 49s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 mvnsite 9m 58s the patch passed
        +1 mvneclipse 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 3s The patch has no ill-formed XML file.
        +1 javadoc 6m 12s the patch passed
        -1 unit 115m 37s root in the patch failed.
        -1 asflicense 0m 23s The patch generated 2 ASF License warnings.
        191m 13s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.yarn.server.nodemanager.TestDirectoryCollection



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819819/HADOOP-13412.001.patch
        JIRA Issue HADOOP-13412
        Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
        uname Linux 96a0cce4c4e4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7052ca8
        Default Java 1.8.0_91
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-build-tools . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 5m 49s Maven dependency ordering for branch +1 mvninstall 9m 10s trunk passed +1 compile 8m 48s trunk passed +1 mvnsite 10m 34s trunk passed +1 mvneclipse 3m 32s trunk passed +1 javadoc 5m 2s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 6m 49s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 mvnsite 9m 58s the patch passed +1 mvneclipse 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 6m 12s the patch passed -1 unit 115m 37s root in the patch failed. -1 asflicense 0m 23s The patch generated 2 ASF License warnings. 191m 13s Reason Tests Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.yarn.server.nodemanager.TestDirectoryCollection Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819819/HADOOP-13412.001.patch JIRA Issue HADOOP-13412 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux 96a0cce4c4e4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7052ca8 Default Java 1.8.0_91 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-build-tools . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10071/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 001:

        • Move dev-support/checkstyle/suppressions.xml to hadoop-build-tools/src/main/resources/checkstyle
        • Update root pom.xml to point to the new path
        Show
        jzhuge John Zhuge added a comment - Patch 001: Move dev-support/checkstyle/suppressions.xml to hadoop-build-tools/src/main/resources/checkstyle Update root pom.xml to point to the new path

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development