Thanks for reviewing the patch, Jonathan Eagles!
From a high level I would still like to see the checkstyle.xml file under the hadoop-build-tools src/main/resources. Perhaps that explains the build failure below.
That's already the case, see patch:
rename from hadoop-common-project/hadoop-common/dev-support/checkstyle.xml
rename to hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
can we remove azure maven-checkstyle-plugin definition?
Meant to do this, but they have different rule sets.
[tw-mbp-gshegalov hadoop-common (HADOOP-11889)]$ diff -u ./hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml ./hadoop-tools/hadoop-azure/src/config/checkstyle.xml | diffstat
checkstyle.xml | 138 ++++++++++++++++++++++++++++-----------------------------
1 file changed, 69 insertions(+), 69 deletions(-)
the mvn checkstyle:checkstyle goal fails to the checkstyle/checkstyle.xml file being in the incorrect location
the location is correct. I forgot to remove RedundantThrows (not supported since 6.2) from azure's checkstyle.xml the same way I dropped it from the main one.
Looks like a few typos
This is the first reference to dependency of hadoop artifact by version. I think we are safe without this.
Please review 003 patch.