Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13220

Follow on fixups after upgraded mini-kdc using Kerby

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a follow up jira from HADOOP-12911.
      1. Now with the findbug warning´╝Ü

      org.apache.hadoop.minikdc.MiniKdc.stop() calls Thread.sleep() with a lock held At MiniKdc.java:lock held At MiniKdc.java:[line 345] 
      

      As discussed in HADOOP-12911:

      Why was this committed with a findbugs errors rather than adding the necessary plumbing in pom.xml to make it go away?

      we will add the findbugsExcludeFile.xml and will get rid of this given kerby-1.0.0-rc3 release.
      2. Add the kerby version hadoop-project/pom.xml

      hadoop-project/pom.xml contains the dependencies of all libraries used in all modules of hadoop, under dependencyManagement. Only here version will be mentioned. All other Hadoop Modules will inherit hadoop-project, so all submodules will use the same version. In submodule, version need not be mentioned in pom.xml. This will make version management easier.

        Issue Links

          Activity

          Hide
          jiajia Jiajia Li added a comment -

          Upload v1, please help to review, thanks.

          Show
          jiajia Jiajia Li added a comment - Upload v1, please help to review, thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 8m 17s trunk passed
          +1 compile 10m 32s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          +1 javadoc 2m 9s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 7m 13s the patch passed
          +1 javac 7m 13s the patch passed
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 6s The patch has no ill-formed XML file.
          +1 javadoc 1m 29s the patch passed
          +1 unit 0m 8s hadoop-project in the patch passed.
          +1 unit 0m 22s hadoop-minikdc in the patch passed.
          +1 unit 3m 27s hadoop-auth in the patch passed.
          +1 unit 9m 59s hadoop-common in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          52m 40s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807065/HADOOP-13220-V1.patch
          JIRA Issue HADOOP-13220
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux a95006280351 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0bc05e4
          Default Java 1.8.0_91
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9641/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9641/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 8m 17s trunk passed +1 compile 10m 32s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 52s trunk passed +1 javadoc 2m 9s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 7m 13s the patch passed +1 javac 7m 13s the patch passed +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. +1 javadoc 1m 29s the patch passed +1 unit 0m 8s hadoop-project in the patch passed. +1 unit 0m 22s hadoop-minikdc in the patch passed. +1 unit 3m 27s hadoop-auth in the patch passed. +1 unit 9m 59s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 52m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807065/HADOOP-13220-V1.patch JIRA Issue HADOOP-13220 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux a95006280351 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0bc05e4 Default Java 1.8.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9641/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9641/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Jiajia Li for the contribution and Akira Ajisaka for the reviewing! I've committed it to trunk.

          Show
          drankye Kai Zheng added a comment - Thanks Jiajia Li for the contribution and Akira Ajisaka for the reviewing! I've committed it to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9927 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9927/)
          HADOOP-13220. Follow on fixups after upgraded mini-kdc using Kerby. (kai.zheng: rev 723432b3387fe69e6bf2b56d2ea1a7b1bda16b97)

          • hadoop-common-project/hadoop-minikdc/dev-support/findbugsExcludeFile.xml
          • hadoop-common-project/hadoop-auth/pom.xml
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-minikdc/pom.xml
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9927 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9927/ ) HADOOP-13220 . Follow on fixups after upgraded mini-kdc using Kerby. (kai.zheng: rev 723432b3387fe69e6bf2b56d2ea1a7b1bda16b97) hadoop-common-project/hadoop-minikdc/dev-support/findbugsExcludeFile.xml hadoop-common-project/hadoop-auth/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-minikdc/pom.xml hadoop-project/pom.xml

            People

            • Assignee:
              jiajia Jiajia Li
              Reporter:
              jiajia Jiajia Li
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development