Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13048

Improvements to StatD metrics2 sink

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • metrics
    • None

    Description

      In some recent offline review of feature HADOOP-12360, jojochuang has some good comments. The feature is overall a nice feature, but can have some improvements:

      • Validation should be more robust:
        public void init(SubsetConfiguration conf) {
            // Get StatsD host configurations.
            final String serverHost = conf.getString(SERVER_HOST_KEY);
            final int serverPort = Integer.parseInt(conf.getString(SERVER_PORT_KEY));
        
      • Javadoc should be more accurate:
        • Inconsistency host.name v.s. hostname
        • Could have better explanation regarding service name and process name
      • StatsDSink#writeMetric should be private.
      • Hopefully a document about this and other metric sinks.

      Thanks Wei-Chiu and dlmarion for the contribution!

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              xiaochen Xiao Chen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: