[HADOOP-13048] Improvements to StatD metrics2 sink

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: metrics
• Assignee: Unassigned
• Reporter: Xiao Chen
• Created: 21/Apr/16 19:24
• Updated: 06/Jun/17 18:08

Description

In some recent offline review of feature HADOOP-12360, jojochuang has some good comments. The feature is overall a nice feature, but can have some improvements:

• Validation should be more robust:

  public void init(SubsetConfiguration conf) {
      // Get StatsD host configurations.
      final String serverHost = conf.getString(SERVER_HOST_KEY);
      final int serverPort = Integer.parseInt(conf.getString(SERVER_PORT_KEY));
  

• Javadoc should be more accurate:
  • Inconsistency host.name v.s. hostname
  • Could have better explanation regarding service name and process name
• StatsDSink#writeMetric should be private.
• Hopefully a document about this and other metric sinks.

Thanks Wei-Chiu and dlmarion for the contribution!

Issue Links

• relates to: HADOOP-12360 Create StatsD metrics2 sink