Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: metrics
    • Labels:
      None
    • Target Version/s:
    • Release Note:
      Added StatsD metrics2 sink

      Description

      Create a metrics sink that pushes to a StatsD daemon.

      1. HADOOP-12360.001.patch
        13 kB
        Dave Marion
      2. HADOOP-12360.002.patch
        13 kB
        Dave Marion
      3. HADOOP-12360.003.patch
        12 kB
        Dave Marion
      4. HADOOP-12360.004.patch
        13 kB
        Dave Marion
      5. HADOOP-12360.005.patch
        13 kB
        Dave Marion
      6. HADOOP-12360.006.patch
        13 kB
        Dave Marion
      7. HADOOP-12360.007.patch
        13 kB
        Dave Marion
      8. HADOOP-12360.008.patch
        13 kB
        Dave Marion
      9. HADOOP-12360.009.patch
        14 kB
        Dave Marion
      10. HADOOP-12360.010.patch
        14 kB
        Dave Marion

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 48s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 48s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 7s The applied patch generated 8 new checkstyle issues (total was 0, now 8).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 10s Tests failed in hadoop-common.
              61m 51s  



          Reason Tests
          FindBugs module:hadoop-common
          Failed unit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752767/HADOOP-12360.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0bf2854
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 7s The applied patch generated 8 new checkstyle issues (total was 0, now 8). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 22m 10s Tests failed in hadoop-common.     61m 51s   Reason Tests FindBugs module:hadoop-common Failed unit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752767/HADOOP-12360.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0bf2854 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7538/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Findbugs and test failures seem to be bogus. Will address checkstyle issues in next patch

          Show
          dlmarion Dave Marion added a comment - Findbugs and test failures seem to be bogus. Will address checkstyle issues in next patch
          Hide
          dlmarion Dave Marion added a comment -

          Attempting to fix checkstyle issues

          Show
          dlmarion Dave Marion added a comment - Attempting to fix checkstyle issues
          Hide
          stevel@apache.org Steve Loughran added a comment -

          One thing that's cropped up a couple of times is codahale metrics integration, something which could be configured to push out its events to statds, graphite, etc (though LGPL licensing would stop its ganglia plugin shipping with Hadoop)

          Other than that, quick code review

          1. use NetUtils methods to get the hostname
          2. logging: you can use the SLF4J APIs and so skip the log level condition wrappers; use debug() instead of trace() as log4j combines them anyway.
          3. you can use j7 <> types in constructors now
          4. exception catch clause in connect() should only catch IOException unless there's some special reason otherwise
          5. inner statsd class should be private

          The connection failure count logic isn't right for very-long lived apps; its very different 5 failures in 30s from 5 failures over 20 days. Maybe after a successful connect the counter should be reset.

          very nice to see tests for this, but...

          1. the tests must have a timeout attribute so timing out operations (here: receive()) have timeouts handled in the test runner, not a brute force jvm kill
          2. socket close() must be in finally clause, so that failed tests clean up

          Finally, some documentation in the form of markdown will be needed to round off the patch

          Show
          stevel@apache.org Steve Loughran added a comment - One thing that's cropped up a couple of times is codahale metrics integration, something which could be configured to push out its events to statds, graphite, etc (though LGPL licensing would stop its ganglia plugin shipping with Hadoop) Other than that, quick code review use NetUtils methods to get the hostname logging: you can use the SLF4J APIs and so skip the log level condition wrappers; use debug() instead of trace() as log4j combines them anyway. you can use j7 <> types in constructors now exception catch clause in connect() should only catch IOException unless there's some special reason otherwise inner statsd class should be private The connection failure count logic isn't right for very-long lived apps; its very different 5 failures in 30s from 5 failures over 20 days. Maybe after a successful connect the counter should be reset. very nice to see tests for this, but... the tests must have a timeout attribute so timing out operations (here: receive()) have timeouts handled in the test runner, not a brute force jvm kill socket close() must be in finally clause, so that failed tests clean up Finally, some documentation in the form of markdown will be needed to round off the patch
          Hide
          dlmarion Dave Marion added a comment -

          Steve Loughran Thanks for looking at this. Can you point me to an example of the markdown documentation that you require?

          Show
          dlmarion Dave Marion added a comment - Steve Loughran Thanks for looking at this. Can you point me to an example of the markdown documentation that you require?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 54s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 0, now 1).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 1m 58s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 25s Tests failed in hadoop-common.
              62m 13s  



          Reason Tests
          FindBugs module:hadoop-common
          Failed unit tests hadoop.conf.TestConfiguration



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752800/HADOOP-12360.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1e5f69e
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 0, now 1). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 1m 58s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 22m 25s Tests failed in hadoop-common.     62m 13s   Reason Tests FindBugs module:hadoop-common Failed unit tests hadoop.conf.TestConfiguration Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752800/HADOOP-12360.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1e5f69e checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7540/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Addressing comments

          Show
          dlmarion Dave Marion added a comment - Addressing comments
          Hide
          dlmarion Dave Marion added a comment -

          Patch 3 addresses the issues below

          use NetUtils methods to get the hostname

          done

          logging: you can use the SLF4J APIs and so skip the log level condition wrappers; use debug() instead of trace() as log4j combines them anyway.

          done

          you can use j7 <> types in constructors now

          Not sure what you mean by this

          exception catch clause in connect() should only catch IOException unless there's some special reason otherwise

          OBE - your comment about connection failure reminded me that this is a UDP client. There is no stateful connection; it's fire and forget, even if it fails. I fixed the StatsD class to reflect this, which means connect() and the connection failure logic was removed. Having said that, I copied the logic from the Graphite sink. If it's wrong here, then it's wrong there also.

          inner statsd class should be private

          I can do this if you can give me a good way to instantiate the class in the tests

          the tests must have a timeout attribute so timing out operations (here: receive()) have timeouts handled in the test runner, not a brute force jvm kill

          done

          socket close() must be in finally clause, so that failed tests clean up

          done

          Show
          dlmarion Dave Marion added a comment - Patch 3 addresses the issues below use NetUtils methods to get the hostname done logging: you can use the SLF4J APIs and so skip the log level condition wrappers; use debug() instead of trace() as log4j combines them anyway. done you can use j7 <> types in constructors now Not sure what you mean by this exception catch clause in connect() should only catch IOException unless there's some special reason otherwise OBE - your comment about connection failure reminded me that this is a UDP client. There is no stateful connection; it's fire and forget, even if it fails. I fixed the StatsD class to reflect this, which means connect() and the connection failure logic was removed. Having said that, I copied the logic from the Graphite sink. If it's wrong here, then it's wrong there also. inner statsd class should be private I can do this if you can give me a good way to instantiate the class in the tests the tests must have a timeout attribute so timing out operations (here: receive()) have timeouts handled in the test runner, not a brute force jvm kill done socket close() must be in finally clause, so that failed tests clean up done
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 48s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 8s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 44s Tests passed in hadoop-common.
              62m 40s  



          Reason Tests
          FindBugs module:hadoop-common



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752814/HADOOP-12360.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 90fe7bc
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. +1 common tests 22m 44s Tests passed in hadoop-common.     62m 40s   Reason Tests FindBugs module:hadoop-common Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752814/HADOOP-12360.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 90fe7bc Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7541/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Findbugs warning seems bogus.

          Show
          dlmarion Dave Marion added a comment - Findbugs warning seems bogus.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          there is a metrics page at hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md , but looking at it , it just lists the metrics published, not the specifics.

          Instead the metrics classes are in the javadocs.

          How about you add some javadocs in your new class, plus a link to it from the metrics2 package

          Show
          stevel@apache.org Steve Loughran added a comment - there is a metrics page at hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md , but looking at it , it just lists the metrics published, not the specifics. Instead the metrics classes are in the javadocs . How about you add some javadocs in your new class, plus a link to it from the metrics2 package
          Hide
          dlmarion Dave Marion added a comment -

          addressing documentation

          Show
          dlmarion Dave Marion added a comment - addressing documentation
          Hide
          dlmarion Dave Marion added a comment -

          Steve Loughran Documentation added. Can this be backported to the 2.6.x and 2.7.x branches?

          Show
          dlmarion Dave Marion added a comment - Steve Loughran Documentation added. Can this be backported to the 2.6.x and 2.7.x branches?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 16s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 0, now 1).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 1m 58s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 0s Tests passed in hadoop-common.
              63m 22s  



          Reason Tests
          FindBugs module:hadoop-common



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753529/HADOOP-12360.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2e251a7
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 16s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 0, now 1). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 1m 58s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. +1 common tests 23m 0s Tests passed in hadoop-common.     63m 22s   Reason Tests FindBugs module:hadoop-common Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753529/HADOOP-12360.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2e251a7 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7572/console This message was automatically generated.
          Hide
          babakbehzad Babak Behzad added a comment -

          Dave Marion, it seems that there is an interest in putting all the new sinks into a separate module as discussed in HADOOP-10949. The main reason being there may be some dependencies that these sinks have, but hadoop-common should not have.

          Show
          babakbehzad Babak Behzad added a comment - Dave Marion , it seems that there is an interest in putting all the new sinks into a separate module as discussed in HADOOP-10949 . The main reason being there may be some dependencies that these sinks have, but hadoop-common should not have.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I hadn't seen that JIRA; a hadoop-metrics JAR under hadoop-tools makes sense for those extras. Even there, I'd be tempted to keep hadoop-metrics-kafka isolated, or in a hadoop-kafka module which would have support for other kafka integration (logging, etc).

          This metrics package doesn't add any new dependencies, but isolating it into a new module now would stop it disappearing from hadoop-common if it were ever later moved into a hadoop-sinks.

          At the same time, this patch is 1-2 iterations from being ready to commit; I don't want to see a nice little feature being put on hold forever.

          thoughts?

          Show
          stevel@apache.org Steve Loughran added a comment - I hadn't seen that JIRA; a hadoop-metrics JAR under hadoop-tools makes sense for those extras. Even there, I'd be tempted to keep hadoop-metrics-kafka isolated, or in a hadoop-kafka module which would have support for other kafka integration (logging, etc). This metrics package doesn't add any new dependencies, but isolating it into a new module now would stop it disappearing from hadoop-common if it were ever later moved into a hadoop-sinks. At the same time, this patch is 1-2 iterations from being ready to commit; I don't want to see a nice little feature being put on hold forever. thoughts?
          Hide
          dlmarion Dave Marion added a comment -

          addressing line length issue

          Show
          dlmarion Dave Marion added a comment - addressing line length issue
          Hide
          dlmarion Dave Marion added a comment -

          fixed line length

          Show
          dlmarion Dave Marion added a comment - fixed line length
          Hide
          dlmarion Dave Marion added a comment -

          I had not seen that JIRA, thanks for bringing it to my attention. Seems to me that the issue of moving all of the metrics sink should be a ticket of its own. To move all of the sinks at once.

          Show
          dlmarion Dave Marion added a comment - I had not seen that JIRA, thanks for bringing it to my attention. Seems to me that the issue of moving all of the metrics sink should be a ticket of its own. To move all of the sinks at once.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. we wouldn't move the existing ones, cause too many surprises. New ones though, they are best done outside.
          2. Looking at the code, you know that you can replace assertEquals(true, condition) with {{Assert.assertTrue(message, condition)}. Having messages are good as they provide more clues than just a number in a stack trace
          Show
          stevel@apache.org Steve Loughran added a comment - we wouldn't move the existing ones, cause too many surprises. New ones though, they are best done outside. Looking at the code, you know that you can replace assertEquals(true, condition) with {{Assert.assertTrue(message, condition)}. Having messages are good as they provide more clues than just a number in a stack trace
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 29s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 10m 12s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 9s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 1m 55s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 55s Tests passed in hadoop-common.
              64m 0s  



          Reason Tests
          FindBugs module:hadoop-common



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753581/HADOOP-12360.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 4620767
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 12s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 9s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 1m 55s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. +1 common tests 22m 55s Tests passed in hadoop-common.     64m 0s   Reason Tests FindBugs module:hadoop-common Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753581/HADOOP-12360.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4620767 Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7575/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Findbugs warning seems bogus.

          Show
          dlmarion Dave Marion added a comment - Findbugs warning seems bogus.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Dave Marion Could you update to assertTrue instead of assertEquals as Steve mentioned?

          + assertEquals(true,
          + result.equals("process.jvm.Context.foo1:1|c") ||
          + result.equals("process.jvm.Context.foo2:2|g"));

          I can help you to backport this to v2.6 and v2.7 if you need.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Dave Marion Could you update to assertTrue instead of assertEquals as Steve mentioned? + assertEquals(true, + result.equals("process.jvm.Context.foo1:1|c") || + result.equals("process.jvm.Context.foo2:2|g")); I can help you to backport this to v2.6 and v2.7 if you need.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          s/update to assertTrue/update to use assertTrue/

          Show
          ozawa Tsuyoshi Ozawa added a comment - s/update to assertTrue/update to use assertTrue/
          Hide
          dlmarion Dave Marion added a comment -

          Addressing unit test concerns

          Show
          dlmarion Dave Marion added a comment - Addressing unit test concerns
          Hide
          dlmarion Dave Marion added a comment -

          Addressed unit test concerns

          Show
          dlmarion Dave Marion added a comment - Addressed unit test concerns
          Hide
          dlmarion Dave Marion added a comment -

          Done. Thanks for helping to backport, I think it should go cleanly.

          Show
          dlmarion Dave Marion added a comment - Done. Thanks for helping to backport, I think it should go cleanly.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 18s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 9m 53s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 7s Tests failed in hadoop-common.
              62m 27s  



          Reason Tests
          FindBugs module:hadoop-common
          Failed unit tests hadoop.fs.TestSymlinkLocalFSFileContext



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753759/HADOOP-12360.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 7d6687f
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 1m 54s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 22m 7s Tests failed in hadoop-common.     62m 27s   Reason Tests FindBugs module:hadoop-common Failed unit tests hadoop.fs.TestSymlinkLocalFSFileContext Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753759/HADOOP-12360.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7d6687f Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7579/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Failed test is unrelated and no findbugs issues.

          Show
          dlmarion Dave Marion added a comment - Failed test is unrelated and no findbugs issues.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          FWIW, if we do decide to put it into a hadoop-metrics JAR, then backporting is out; breaks all the packaging things

          Show
          stevel@apache.org Steve Loughran added a comment - FWIW, if we do decide to put it into a hadoop-metrics JAR, then backporting is out; breaks all the packaging things
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch looks pretty good —Final things needed:

          better error reporting/diagnostics on the socket exceptions than the JRE gives you; this is done in NetUtils.wrapException()

          Could you wrap the code which creates the DatagramSocket or writes to it with something like:

          
          

          try

          { // network operation }

          catch(IOException ioe)

          { throw NetUtils.wrapException(destHost, destPort, localHost, 0, ioe) }

          It's not quite so important/useful for datagrams, but it will still report better outcomes binding to the local host, looking up the hostname of the destination, etc, etc.

          writeMetric loses the exception raised on a write failure.

          It logs it at error, then it attempts a statsd.close(), which will raise an error if it fails, but the original exception gets lost.

          Better:

          1. catch IOException only.
          2. assuming the inner StatsD class has done the exception wrapping, no more needs to be done except convert to a MetricsException through something like throw new MetricsException(ioe.toString(), ioe)

          Use "." instead of "_" in keys.

          This is just because its the convention in the hadoop config options; makes it more consistent with the others.

          in the StatsD.close() operation, have socket=null in a finally clause. That way even if the inner socket.close() failed, the socket reference would be released & the code not reused.

          Show
          stevel@apache.org Steve Loughran added a comment - Patch looks pretty good —Final things needed: better error reporting/diagnostics on the socket exceptions than the JRE gives you; this is done in NetUtils.wrapException() Could you wrap the code which creates the DatagramSocket or writes to it with something like: try { // network operation } catch(IOException ioe) { throw NetUtils.wrapException(destHost, destPort, localHost, 0, ioe) } It's not quite so important/useful for datagrams, but it will still report better outcomes binding to the local host, looking up the hostname of the destination, etc, etc. writeMetric loses the exception raised on a write failure. It logs it at error, then it attempts a statsd.close(), which will raise an error if it fails, but the original exception gets lost. Better: catch IOException only. assuming the inner StatsD class has done the exception wrapping, no more needs to be done except convert to a MetricsException through something like throw new MetricsException(ioe.toString(), ioe) Use "." instead of "_" in keys. This is just because its the convention in the hadoop config options; makes it more consistent with the others. in the StatsD.close() operation, have socket=null in a finally clause. That way even if the inner socket.close() failed, the socket reference would be released & the code not reused.
          Hide
          dlmarion Dave Marion added a comment -

          addressing comments

          Show
          dlmarion Dave Marion added a comment - addressing comments
          Hide
          dlmarion Dave Marion added a comment -

          Addressed comments

          Show
          dlmarion Dave Marion added a comment - Addressed comments
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 8s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 10m 14s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 0, now 1).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 1m 55s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 36s Tests passed in hadoop-common.
              63m 21s  



          Reason Tests
          FindBugs module:hadoop-common



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755718/HADOOP-12360.007.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6955771
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 0, now 1). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 1m 55s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. +1 common tests 22m 36s Tests passed in hadoop-common.     63m 21s   Reason Tests FindBugs module:hadoop-common Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755718/HADOOP-12360.007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6955771 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7656/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          Fixing checkstyle

          Show
          dlmarion Dave Marion added a comment - Fixing checkstyle
          Hide
          dlmarion Dave Marion added a comment -

          Fixed checkstyle

          Show
          dlmarion Dave Marion added a comment - Fixed checkstyle
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 22s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 11m 41s There were no new javadoc warning messages.
          +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 12s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 44s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          -1 findbugs 2m 19s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 common tests 25m 33s Tests failed in hadoop-common.
              68m 59s  



          Reason Tests
          FindBugs module:hadoop-common
          Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken
            hadoop.fs.TestLocalFsFCStatistics



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755739/HADOOP-12360.008.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6955771
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 11m 41s There were no new javadoc warning messages. +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 44s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. -1 findbugs 2m 19s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 common tests 25m 33s Tests failed in hadoop-common.     68m 59s   Reason Tests FindBugs module:hadoop-common Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken   hadoop.fs.TestLocalFsFCStatistics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755739/HADOOP-12360.008.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6955771 Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7660/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          that findbugs report in the jenkins run is empty. If you can run it locally —does it show anything? If so, and they are spurious entries, dev-support/findbugsExcludeFile.xml can be tweaked to exclude the files from the specific bugs.

          Show
          stevel@apache.org Steve Loughran added a comment - that findbugs report in the jenkins run is empty. If you can run it locally —does it show anything? If so, and they are spurious entries, dev-support/findbugsExcludeFile.xml can be tweaked to exclude the files from the specific bugs.
          Hide
          dlmarion Dave Marion added a comment -

          fix findbugs warnings

          Show
          dlmarion Dave Marion added a comment - fix findbugs warnings
          Hide
          dlmarion Dave Marion added a comment -

          Fix findbugs warnings

          Show
          dlmarion Dave Marion added a comment - Fix findbugs warnings
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 47s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 0, now 2).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 0s Tests passed in hadoop-common.
              62m 51s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12759800/HADOOP-12360.009.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 92c1af1
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 0, now 2). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 0s Tests passed in hadoop-common.     62m 51s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12759800/HADOOP-12360.009.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 92c1af1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7676/console This message was automatically generated.
          Hide
          dlmarion Dave Marion added a comment -

          checkstyle issues

          Show
          dlmarion Dave Marion added a comment - checkstyle issues
          Hide
          dlmarion Dave Marion added a comment -

          fix checkstyle issues

          Show
          dlmarion Dave Marion added a comment - fix checkstyle issues
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 51s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 42s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 35s Tests passed in hadoop-common.
              62m 29s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761119/HADOOP-12360.010.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2ff6faf
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 51s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 35s Tests passed in hadoop-common.     62m 29s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761119/HADOOP-12360.010.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2ff6faf hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7677/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1, committed to 2.8.0. Thanks!

          Show
          stevel@apache.org Steve Loughran added a comment - +1, committed to 2.8.0. Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8492 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8492/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8492 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8492/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #416 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/416/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #416 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/416/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2362 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2362/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2362 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2362/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1156/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1156/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #424 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/424/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #424 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/424/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2335 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2335/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2335 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2335/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #397 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/397/)
          HADOOP-12360. Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #397 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/397/ ) HADOOP-12360 . Create StatsD metrics2 sink. (Dave Marion via stevel) (stevel: rev c39ddc306d7efd93332fc1062ff4c9b59e94f3e1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestStatsDMetrics.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/package-info.java
          Hide
          michaelmoss Michael Moss added a comment -

          Hi, I'm curious what this section of code is trying to achieve:
          https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L103

          It seems that in some cases, for some metrics (JVM metrics for example), the sn (serviceName) variable is overridden, which breaks the configured prefix: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L91

          Wondering if this was intended?

          Show
          michaelmoss Michael Moss added a comment - Hi, I'm curious what this section of code is trying to achieve: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L103 It seems that in some cases, for some metrics (JVM metrics for example), the sn (serviceName) variable is overridden, which breaks the configured prefix: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L91 Wondering if this was intended?
          Hide
          dlmarion Dave Marion added a comment - - edited

          Honestly, I don't remember, it's been too long. Can you provide an example of how it's broken for the JVM metrics?

          Show
          dlmarion Dave Marion added a comment - - edited Honestly, I don't remember, it's been too long. Can you provide an example of how it's broken for the JVM metrics?
          Hide
          michaelmoss Michael Moss added a comment - - edited

          Dave, thanks for the (fast) response.

          Here's what we were seeing for the following configuration:
          ubuntu@foo:~$ cat /etc/hadoop/conf/hadoop-metrics2.properties

          datanode.sink.statsd.class=org.apache.hadoop.metrics2.sink.StatsDSink
          datanode.sink.statsd.server.host=localhost
          datanode.sink.statsd.server.port=8125
          datanode.sink.statsd.skip.hostname=true
          datanode.sink.statsd.service.name=our.prefix

          rpc and datanode contexts look good for example:
          our.prefix.rpc.rpc.RpcQueueTimeNumOps:4|c
          our.prefix.dfs.datanode.BlockReportsNumOps:79|

          but the jvm context renders as:
          DataNode.jvm.JvmMetrics.MemNonHeapUsedM:41.624916|g

          losing our prefix (overrides the 'sn' variable, per above)

          We need a consistent prefix to properly namespace our metrics.

          Seemed like a bug, but wasn't sure.

          Show
          michaelmoss Michael Moss added a comment - - edited Dave, thanks for the (fast) response. Here's what we were seeing for the following configuration: ubuntu@foo:~$ cat /etc/hadoop/conf/hadoop-metrics2.properties datanode.sink.statsd.class=org.apache.hadoop.metrics2.sink.StatsDSink datanode.sink.statsd.server.host=localhost datanode.sink.statsd.server.port=8125 datanode.sink.statsd.skip.hostname=true datanode.sink.statsd.service.name=our.prefix rpc and datanode contexts look good for example: our.prefix.rpc.rpc.RpcQueueTimeNumOps:4|c our.prefix.dfs.datanode.BlockReportsNumOps:79| but the jvm context renders as: DataNode.jvm.JvmMetrics.MemNonHeapUsedM:41.624916|g losing our prefix (overrides the 'sn' variable, per above) We need a consistent prefix to properly namespace our metrics. Seemed like a bug, but wasn't sure.
          Hide
          dlmarion Dave Marion added a comment -

          Michael Moss - Seems like we could invert the logic for service name such that if it is not specified in the configuration, then use the process name. I'm not sure if we should change context and hostname, I'm thinking that they should be left alone. Looks like there are planned changes for this class in HADOOP-13048, you might be able to add this problem to that issue, or create a new issue.

          Show
          dlmarion Dave Marion added a comment - Michael Moss - Seems like we could invert the logic for service name such that if it is not specified in the configuration, then use the process name. I'm not sure if we should change context and hostname, I'm thinking that they should be left alone. Looks like there are planned changes for this class in HADOOP-13048 , you might be able to add this problem to that issue, or create a new issue.

            People

            • Assignee:
              dlmarion Dave Marion
              Reporter:
              dlmarion Dave Marion
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development