Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12950

ShutdownHookManager should have a timeout for each of the Registered shutdown hook

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-8325 added a ShutdownHookManager to be used by different components instead of the JVM shutdownhook. For each of the shutdown hook registered, we currently don't have an upper bound for its execution time. We have seen namenode failed to shutdown completely (waiting for shutdown hook to finish after failover) for a long period of time, which breaks the namenode high availability scenarios. This ticket is opened to allow specifying a timeout value for the registered shutdown hook.

      1. HADOOP-12950.04.patch
        11 kB
        Xiaoyu Yao
      2. HADOOP-12950.03.patch
        11 kB
        Xiaoyu Yao
      3. HADOOP-12950.02.patch
        12 kB
        Xiaoyu Yao
      4. HADOOP-12950.01.patch
        14 kB
        Xiaoyu Yao
      5. HADOOP-12950.00.patch
        13 kB
        Xiaoyu Yao

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          This would partially mitigate HADOOP-10219; an example of filesystem shutdown hanging.

          Show
          stevel@apache.org Steve Loughran added a comment - This would partially mitigate HADOOP-10219 ; an example of filesystem shutdown hanging.
          Hide
          xyao Xiaoyu Yao added a comment -

          Attach a patch that allow shutdown hook to be registered with a timeout. For shutdown hook registered without timeout like all existing ones, they will get a maximum of 10s each before JVM termination.

          Show
          xyao Xiaoyu Yao added a comment - Attach a patch that allow shutdown hook to be registered with a timeout. For shutdown hook registered without timeout like all existing ones, they will get a maximum of 10s each before JVM termination.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 58s trunk passed
          +1 compile 12m 0s trunk passed with JDK v1.8.0_74
          +1 compile 9m 21s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 13s trunk passed
          +1 javadoc 1m 29s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95
          +1 mvninstall 1m 4s the patch passed
          +1 compile 12m 26s the patch passed with JDK v1.8.0_74
          +1 javac 12m 26s the patch passed
          +1 compile 8m 17s the patch passed with JDK v1.7.0_95
          +1 javac 8m 17s the patch passed
          -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 4 new + 2 unchanged - 5 fixed = 6 total (was 7)
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 3s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 13s the patch passed with JDK v1.7.0_95
          -1 unit 9m 51s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 9m 22s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 25s Patch generated 2 ASF License warnings.
          87m 38s



          Reason Tests
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794841/HADOOP-12950.00.patch
          JIRA Issue HADOOP-12950
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 386ca7e49f35 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 57ead18
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 58s trunk passed +1 compile 12m 0s trunk passed with JDK v1.8.0_74 +1 compile 9m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 29s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 4s the patch passed +1 compile 12m 26s the patch passed with JDK v1.8.0_74 +1 javac 12m 26s the patch passed +1 compile 8m 17s the patch passed with JDK v1.7.0_95 +1 javac 8m 17s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 4 new + 2 unchanged - 5 fixed = 6 total (was 7) +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_95 -1 unit 9m 51s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 9m 22s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 25s Patch generated 2 ASF License warnings. 87m 38s Reason Tests JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794841/HADOOP-12950.00.patch JIRA Issue HADOOP-12950 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 386ca7e49f35 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57ead18 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8900/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Update the patch that fixes the checkstyle issue.

          Show
          xyao Xiaoyu Yao added a comment - Update the patch that fixes the checkstyle issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 32s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_77
          +1 compile 6m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 6m 6s the patch passed with JDK v1.8.0_77
          +1 javac 6m 6s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_95
          +1 javac 6m 49s the patch passed
          +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 8m 9s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 30s Patch generated 3 ASF License warnings.
          60m 31s



          Reason Tests
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795879/HADOOP-12950.01.patch
          JIRA Issue HADOOP-12950
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e43b105a6e16 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0050fa5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 32s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_77 +1 compile 6m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 6m 6s the patch passed with JDK v1.8.0_77 +1 javac 6m 6s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 7m 23s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 8m 9s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 30s Patch generated 3 ASF License warnings. 60m 31s Reason Tests JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795879/HADOOP-12950.01.patch JIRA Issue HADOOP-12950 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e43b105a6e16 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0050fa5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8956/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for working on this, Xiaoyu Yao! The patch looks good to me. Some minor comments:

          1. Do you think we should only create daemon thread for the executor?
            51	  private static final ExecutorService EXECUTOR =
            52	      HadoopExecutors.newSingleThreadExecutor();
            
          2. Since ShutdownHookEntry's hashCode/equals all depend on ShutdownHookEntry#hook, maybe we can use a SortedMap<Hook, ShutdownHookEntry> in ShutdownHookManager instead of the current HashSet?
          3. Feels like the ShutdownHookEntry should still be kept inside of the ShutdownHookManager, considering it is only used there.
          4. Nit: 10 can be replaced by TIMEOUT_DEFAULT.
                          if (!EXECUTOR.awaitTermination(10, TimeUnit.SECONDS)) {
                            LOG.error("ShutdownHookManger shutdown forcefully.");
                            EXECUTOR.shutdownNow();
            
          Show
          jingzhao Jing Zhao added a comment - Thanks for working on this, Xiaoyu Yao ! The patch looks good to me. Some minor comments: Do you think we should only create daemon thread for the executor? 51 private static final ExecutorService EXECUTOR = 52 HadoopExecutors.newSingleThreadExecutor(); Since ShutdownHookEntry's hashCode/equals all depend on ShutdownHookEntry#hook, maybe we can use a SortedMap<Hook, ShutdownHookEntry> in ShutdownHookManager instead of the current HashSet? Feels like the ShutdownHookEntry should still be kept inside of the ShutdownHookManager, considering it is only used there. Nit: 10 can be replaced by TIMEOUT_DEFAULT. if (!EXECUTOR.awaitTermination(10, TimeUnit.SECONDS)) { LOG.error( "ShutdownHookManger shutdown forcefully." ); EXECUTOR.shutdownNow();
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Jing Zhao for the review and suggestions. Attach patch v02 addresses your comments.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Jing Zhao for the review and suggestions. Attach patch v02 addresses your comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 5m 41s trunk passed with JDK v1.8.0_77
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 39s the patch passed
          +1 compile 5m 35s the patch passed with JDK v1.8.0_77
          +1 javac 5m 35s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.7.0_95
          +1 javac 6m 33s the patch passed
          +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 6m 56s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 21s Patch generated 3 ASF License warnings.
          57m 31s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.fs.TestFileContextDeleteOnExit
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestFileContextDeleteOnExit
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795999/HADOOP-12950.02.patch
          JIRA Issue HADOOP-12950
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 170947a411d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8286270
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 35s trunk passed +1 compile 5m 41s trunk passed with JDK v1.8.0_77 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 39s the patch passed +1 compile 5m 35s the patch passed with JDK v1.8.0_77 +1 javac 5m 35s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_95 +1 javac 6m 33s the patch passed +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 6m 56s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 21s Patch generated 3 ASF License warnings. 57m 31s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.fs.TestFileContextDeleteOnExit JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Failed junit tests hadoop.fs.TestFileContextDeleteOnExit JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795999/HADOOP-12950.02.patch JIRA Issue HADOOP-12950 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 170947a411d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8286270 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8963/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          The failure on TestFileContextDeleteOnExit looks related to the patch. Xiaoyu Yao, could you please check it?

          Show
          jingzhao Jing Zhao added a comment - The failure on TestFileContextDeleteOnExit looks related to the patch. Xiaoyu Yao , could you please check it?
          Hide
          xyao Xiaoyu Yao added a comment -

          Jing Zhao, the SortedSet/SortedMap uses the overwritten Comparator (based on Priority order not the hash of the Runnable) as an optimization (binary vs linear) to search for the hook upon ShutdownHookManger#hasShutdownHook and ShutdownHookManager#removeShutdownHook. I plan to change back to the HashSet without overwite the Comparator and returns a separate sorted list, what do you think?

          Show
          xyao Xiaoyu Yao added a comment - Jing Zhao , the SortedSet/SortedMap uses the overwritten Comparator (based on Priority order not the hash of the Runnable) as an optimization (binary vs linear) to search for the hook upon ShutdownHookManger#hasShutdownHook and ShutdownHookManager#removeShutdownHook. I plan to change back to the HashSet without overwite the Comparator and returns a separate sorted list, what do you think?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 4s trunk passed
          +1 compile 6m 4s trunk passed with JDK v1.8.0_77
          +1 compile 6m 38s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 58s the patch passed with JDK v1.8.0_77
          +1 javac 5m 58s the patch passed
          +1 compile 6m 36s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95
          -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 12s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 23s Patch generated 3 ASF License warnings.
          59m 13s



          Reason Tests
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796149/HADOOP-12950.03.patch
          JIRA Issue HADOOP-12950
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e89d8ad227ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 60e4116
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 4s trunk passed +1 compile 6m 4s trunk passed with JDK v1.8.0_77 +1 compile 6m 38s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 58s the patch passed with JDK v1.8.0_77 +1 javac 5m 58s the patch passed +1 compile 6m 36s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95 -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 7m 12s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 23s Patch generated 3 ASF License warnings. 59m 13s Reason Tests JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796149/HADOOP-12950.03.patch JIRA Issue HADOOP-12950 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e89d8ad227ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 60e4116 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8972/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Yes, sound good to me.

          Show
          jingzhao Jing Zhao added a comment - Yes, sound good to me.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Jing Zhao. Patch v03 has been posted and passed the Jenkins. TestNativeLibraryChecker issue is unrelated.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Jing Zhao . Patch v03 has been posted and passed the Jenkins. TestNativeLibraryChecker issue is unrelated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for updating the patch, Xiaoyu! The 03 patch looks good to me. Just some nits:

          1. How about simplifying the following code to HadoopExecutors.newSingleThreadExecutor(new ThreadFactoryBuilder().setDaemon(true).build())?
            55	      HadoopExecutors.newSingleThreadExecutor(new ThreadFactory() {
            56	        @Override
            57	        public Thread newThread(Runnable r) {
            58	          Thread t =  new Thread(r);
            59	          t.setDaemon(true);
            60	          return t;
            61	        }
            62	      });
            
          2. HookEntry's constructor/getter methods do not need to be public
          3. ShutdownHookManager#hooks can be declared as final.
          4. In TestShutdownHookManager, need to clean the spaces and new lines for the following code:
                      LOG.info("Shutdown hook3 interrupted exception:" ,ExceptionUtils
                          .getStackTrace
                          (ex));
            

          +1 after addressing the comments.

          Show
          jingzhao Jing Zhao added a comment - Thanks for updating the patch, Xiaoyu! The 03 patch looks good to me. Just some nits: How about simplifying the following code to HadoopExecutors.newSingleThreadExecutor(new ThreadFactoryBuilder().setDaemon(true).build()) ? 55 HadoopExecutors.newSingleThreadExecutor( new ThreadFactory() { 56 @Override 57 public Thread newThread( Runnable r) { 58 Thread t = new Thread (r); 59 t.setDaemon( true ); 60 return t; 61 } 62 }); HookEntry's constructor/getter methods do not need to be public ShutdownHookManager#hooks can be declared as final. In TestShutdownHookManager, need to clean the spaces and new lines for the following code: LOG.info( "Shutdown hook3 interrupted exception:" ,ExceptionUtils .getStackTrace (ex)); +1 after addressing the comments.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Jing Zhao! Patch v04 attached based on your comments.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Jing Zhao ! Patch v04 attached based on your comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 29s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_77
          +1 compile 7m 3s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 17s the patch passed with JDK v1.8.0_77
          +1 javac 6m 17s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_95
          +1 javac 6m 49s the patch passed
          -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 1 new + 2 unchanged - 5 fixed = 3 total (was 7)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 51s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          -1 unit 7m 38s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 2 ASF License warnings.
          60m 49s



          Reason Tests
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796194/HADOOP-12950.04.patch
          JIRA Issue HADOOP-12950
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c29a80456255 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7a02147
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 29s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_77 +1 compile 7m 3s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 17s the patch passed with JDK v1.8.0_77 +1 javac 6m 17s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 1 new + 2 unchanged - 5 fixed = 3 total (was 7) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 38s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 2 ASF License warnings. 60m 49s Reason Tests JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796194/HADOOP-12950.04.patch JIRA Issue HADOOP-12950 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c29a80456255 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7a02147 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8993/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Jing Zhao for the reviews. I've committed the patch to trunk, branch-2 and branch-2.8.

          The delta from patch v04 is removing the unused import (java.util.concurrent.ThreadFactory) as reported in the checkstyle report.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Jing Zhao for the reviews. I've committed the patch to trunk, branch-2 and branch-2.8. The delta from patch v04 is removing the unused import (java.util.concurrent.ThreadFactory) as reported in the checkstyle report.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9538 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9538/)
          HADOOP-12950. ShutdownHookManager should have a timeout for each of the (xyao: rev aac4d65bf9c6d68f53610e5fe9997a391e3fa053)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShutdownHookManager.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9538 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9538/ ) HADOOP-12950 . ShutdownHookManager should have a timeout for each of the (xyao: rev aac4d65bf9c6d68f53610e5fe9997a391e3fa053) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShutdownHookManager.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java

            People

            • Assignee:
              xyao Xiaoyu Yao
              Reporter:
              xyao Xiaoyu Yao
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development