Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12805

Annotate CanUnbuffer with @InterfaceAudience.Public

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed
        • Release Note:
          Made CanBuffer interface public for use in client applications.

          Description

          See comments toward the tail of HBASE-9393.

          The change in HBASE-9393 adds dependency on CanUnbuffer interface which is currently marked @InterfaceAudience.Private

          To facilitate downstream projects such as HBase in using this interface, CanUnbuffer interface should be annotated @LimitedPrivate({"HBase", "HDFS"}).

          1. Text File
            HADOOP-12805.v1.patch
            0.9 kB
            Ted Yu
          2. Text File
            HADOOP-12805.v2.patch
            0.7 kB
            Ted Yu

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. HBASE-9393 Hbase does not closing a closed socket resulting in many CLOSE_WAIT

            • Critical - Crashes, loss of data, severe memory leak.
            • Resolved

            Improvement - An improvement or enhancement to an existing feature or task. HDFS-7694 FSDataInputStream should support "unbuffer"

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              busbey Sean Busbey added a comment -

              Any chance the Hadoop community would be willing to promote CanUnbuffer to IA.Public in Hadoop 2.8.0?

              Show
              busbey Sean Busbey added a comment - Any chance the Hadoop community would be willing to promote CanUnbuffer to IA.Public in Hadoop 2.8.0?
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 12s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 6m 58s trunk passed
              +1 compile 6m 26s trunk passed with JDK v1.8.0_66
              +1 compile 7m 11s trunk passed with JDK v1.7.0_91
              +1 checkstyle 0m 21s trunk passed
              +1 mvnsite 1m 6s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 38s trunk passed
              +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66
              +1 javadoc 1m 6s trunk passed with JDK v1.7.0_91
              +1 mvninstall 0m 42s the patch passed
              +1 compile 6m 26s the patch passed with JDK v1.8.0_66
              +1 javac 6m 26s the patch passed
              +1 compile 7m 12s the patch passed with JDK v1.7.0_91
              +1 javac 7m 12s the patch passed
              +1 checkstyle 0m 21s the patch passed
              +1 mvnsite 1m 4s the patch passed
              +1 mvneclipse 0m 14s the patch passed
              +1 whitespace 0m 0s Patch has no whitespace issues.
              +1 findbugs 1m 50s the patch passed
              +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66
              +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91
              -1 unit 16m 59s hadoop-common in the patch failed with JDK v1.8.0_66.
              +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_91.
              +1 asflicense 0m 22s Patch does not generate ASF License warnings.
              73m 9s



              Reason Tests
              JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:0ca8df7
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787823/HADOOP-12805.v1.patch
              JIRA Issue HADOOP-12805
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux bbb81c4e8518 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / ec12ce8
              Default Java 1.7.0_91
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
              findbugs v3.0.0
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
              unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
              JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/console
              Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 58s trunk passed +1 compile 6m 26s trunk passed with JDK v1.8.0_66 +1 compile 7m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 42s the patch passed +1 compile 6m 26s the patch passed with JDK v1.8.0_66 +1 javac 6m 26s the patch passed +1 compile 7m 12s the patch passed with JDK v1.7.0_91 +1 javac 7m 12s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91 -1 unit 16m 59s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 73m 9s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787823/HADOOP-12805.v1.patch JIRA Issue HADOOP-12805 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bbb81c4e8518 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec12ce8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8624/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              cnauroth Chris Nauroth added a comment -

              I think it makes sense for this to be Public and Evolving (to eventually become Stable). This would agree with other similar "file system capability" interfaces like ByteBufferReadable and CanSetReadahead.

              Show
              cnauroth Chris Nauroth added a comment - I think it makes sense for this to be Public and Evolving (to eventually become Stable ). This would agree with other similar "file system capability" interfaces like ByteBufferReadable and CanSetReadahead .
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 12s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 7m 2s trunk passed
              +1 compile 6m 30s trunk passed with JDK v1.8.0_66
              +1 compile 7m 11s trunk passed with JDK v1.7.0_91
              +1 checkstyle 0m 23s trunk passed
              +1 mvnsite 1m 6s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 38s trunk passed
              +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66
              +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91
              +1 mvninstall 0m 45s the patch passed
              +1 compile 6m 26s the patch passed with JDK v1.8.0_66
              +1 javac 6m 26s the patch passed
              +1 compile 7m 13s the patch passed with JDK v1.7.0_91
              +1 javac 7m 13s the patch passed
              +1 checkstyle 0m 21s the patch passed
              +1 mvnsite 1m 4s the patch passed
              +1 mvneclipse 0m 14s the patch passed
              +1 whitespace 0m 0s Patch has no whitespace issues.
              +1 findbugs 1m 53s the patch passed
              +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66
              +1 javadoc 1m 7s the patch passed with JDK v1.7.0_91
              +1 unit 8m 11s hadoop-common in the patch passed with JDK v1.8.0_66.
              +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_91.
              +1 asflicense 0m 22s Patch does not generate ASF License warnings.
              64m 12s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:0ca8df7
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787837/HADOOP-12805.v2.patch
              JIRA Issue HADOOP-12805
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 8da4883892fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / ec12ce8
              Default Java 1.7.0_91
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
              findbugs v3.0.0
              JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8625/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8625/console
              Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 2s trunk passed +1 compile 6m 30s trunk passed with JDK v1.8.0_66 +1 compile 7m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 6m 26s the patch passed with JDK v1.8.0_66 +1 javac 6m 26s the patch passed +1 compile 7m 13s the patch passed with JDK v1.7.0_91 +1 javac 7m 13s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_91 +1 unit 8m 11s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 64m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787837/HADOOP-12805.v2.patch JIRA Issue HADOOP-12805 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8da4883892fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec12ce8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8625/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8625/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ashish singhi Ashish Singhi added a comment -

              Also looking at HDFS-7694 description this was added to support applications so making it public should not be any problem IMO.

              Show
              ashish singhi Ashish Singhi added a comment - Also looking at HDFS-7694 description this was added to support applications so making it public should not be any problem IMO.
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment -

              +1. Will commit shortly.

              Show
              vinayrpet Vinayakumar B added a comment - +1. Will commit shortly.
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment -

              Committed to trunk, branch-2, branch-2.7, branch-2.8 and branch-2.6

              Show
              vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2, branch-2.7, branch-2.8 and branch-2.6
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment -

              Thanks all.

              Show
              vinayrpet Vinayakumar B added a comment - Thanks all.
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #9307 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9307/)
              HADOOP-12805. Annotate CanUnbuffer with @InterfaceAudience.Public (vinayakumarb: rev 4b0e59fdc010be517dd67ddf35c962da204df547)

              • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CanUnbuffer.java
              • hadoop-common-project/hadoop-common/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9307 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9307/ ) HADOOP-12805 . Annotate CanUnbuffer with @InterfaceAudience.Public (vinayakumarb: rev 4b0e59fdc010be517dd67ddf35c962da204df547) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CanUnbuffer.java hadoop-common-project/hadoop-common/CHANGES.txt
              Hide
              Permalink
              busbey Sean Busbey added a comment -

              While I've very happy to have this available in 2.8, I don't think it's necessary or prudent to add a new IA.Public class to the API in patch releases (branch-2.6 and branch-2.7). Especially without a release note.

              Show
              busbey Sean Busbey added a comment - While I've very happy to have this available in 2.8, I don't think it's necessary or prudent to add a new IA.Public class to the API in patch releases (branch-2.6 and branch-2.7). Especially without a release note.
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment -

              Updated the release note.
              Thanks Sean Busbey.

              Show
              vinayrpet Vinayakumar B added a comment - Updated the release note. Thanks Sean Busbey .
              Hide
              Permalink
              vinodkv Vinod Kumar Vavilapalli added a comment -

              Closing the JIRA as part of 2.7.3 release.

              Show
              vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

                People

                • Assignee:
                  yuzhihong@gmail.com Ted Yu
                  Reporter:
                  yuzhihong@gmail.com Ted Yu
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  10 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development