Kuhu Shukla added a comment - 05/Feb/16 01:06 Adding a preliminary patch to get review comments and thoughts on a possible fix. CC: Kihwal Lee , Daryn Sharp Rushabh S Shah

Hadoop QA added a comment - 05/Feb/16 02:08 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 32s trunk passed +1 compile 5m 37s trunk passed with JDK v1.8.0_66 +1 compile 6m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 39s the patch passed +1 compile 5m 30s the patch passed with JDK v1.8.0_66 +1 javac 5m 30s the patch passed +1 compile 6m 29s the patch passed with JDK v1.7.0_91 +1 javac 6m 29s the patch passed -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 2 new + 48 unchanged - 1 fixed = 50 total (was 49) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 50s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_91 +1 unit 6m 29s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 6m 17s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 56m 24s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.net.TestClusterTopology   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786369/HDFS-9762.001.patch JIRA Issue HDFS-9762 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7f2b5ae2c608 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14396/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14396/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14396/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14396/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14396/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Kuhu Shukla added a comment - 05/Feb/16 15:04 Fixing the checkstyle and the if condition in NetworkTopologyWithNodeGroup to prevent NPE. Adding some temporary logging to testChooseRandom to better debug the issue since locally the test passed several times.

Hadoop QA added a comment - 05/Feb/16 16:21 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 8m 14s trunk passed with JDK v1.8.0_66 +1 compile 7m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 42s the patch passed +1 compile 8m 23s the patch passed with JDK v1.8.0_66 +1 javac 8m 23s the patch passed +1 compile 8m 7s the patch passed with JDK v1.7.0_91 +1 javac 8m 7s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 14s the patch passed with JDK v1.7.0_91 -1 unit 9m 23s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 9m 17s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 71m 59s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786490/HDFS-9762.002.patch JIRA Issue HDFS-9762 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6cb15d56c2b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14405/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14405/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14405/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14405/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Kuhu Shukla added a comment - 05/Feb/16 16:43 Attaching revised patch that takes out the temporary change to TestClusterTopology . Asking Daryn Sharp , @ Kihwal Lee , Rushabh Shah for more comments/review. Thanks a lot!

Kihwal Lee added a comment - 05/Feb/16 16:46 Once the precommit returns, I will move it to the common project.

Hadoop QA added a comment - 05/Feb/16 18:19 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 48s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 9m 22s trunk passed +1 compile 11m 10s trunk passed with JDK v1.8.0_66 +1 compile 9m 52s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 25s trunk passed with JDK v1.7.0_91 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 11m 4s the patch passed with JDK v1.8.0_66 +1 javac 11m 4s the patch passed +1 compile 9m 51s the patch passed with JDK v1.7.0_91 +1 javac 9m 51s the patch passed +1 checkstyle 0m 29s hadoop-common-project/hadoop-common: patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 24s the patch passed +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 27s the patch passed with JDK v1.7.0_91 -1 unit 10m 30s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 10m 12s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 90m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786502/HDFS-9762.003.patch JIRA Issue HDFS-9762 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a304a5dbfc8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4e5e1c0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14407/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14407/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14407/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14407/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Kuhu Shukla added a comment - 05/Feb/16 19:20 Thank you Kihwal Lee , moved the JIRA. The test failures are not seen locally and also are unrelated to this change. The TestReloadingX509TrustManager failure seems to b documented by HADOOP-10823 . Requesting for comments/review. Thank you very much.

Hadoop QA added a comment - 05/Feb/16 20:22 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 5m 39s trunk passed with JDK v1.8.0_72 +1 compile 6m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 51s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 41s the patch passed +1 compile 5m 50s the patch passed with JDK v1.8.0_72 +1 javac 5m 50s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_95 +1 javac 6m 45s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 0 new + 48 unchanged - 1 fixed = 48 total (was 49) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 6m 54s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 7m 11s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 58m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786502/HDFS-9762.003.patch JIRA Issue HADOOP-12772 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ffcbbc5cc4b8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9086dd5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8551/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8551/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Kihwal Lee added a comment - 05/Feb/16 21:44 +1 lgtm

Kihwal Lee added a comment - 05/Feb/16 21:52 Thanks for reporting and fixing this, Kuhu.

Hudson added a comment - 05/Feb/16 22:35 FAILURE: Integrated in Hadoop-trunk-Commit #9250 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9250/ ) HADOOP-12772 . NetworkTopologyWithNodeGroup.getNodeGroup() can loop (kihwal: rev 49e176c29f95c179c0f6b07d4d582e6a771a96bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopologyWithNodeGroup.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java hadoop-common-project/hadoop-common/CHANGES.txt

Vinod Kumar Vavilapalli added a comment - 25/Aug/16 22:48 Closing the JIRA as part of 2.7.3 release.