[HADOOP-12772] NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.2
• Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
• Target Version/s: 2.7.3
• Hadoop Flags: Reviewed
• Assignee: Kuhu Shukla
• Reporter: Kuhu Shukla
• Created: 05/Feb/16 00:46
• Updated: 06/Jan/17 01:54
• Resolved: 05/Feb/16 21:52

Description

Although the DatanodInfo/DataNodeDescriptor object tends to have a non-null, non-empty value for its network location, the getNodeGroup method does not handle the case if an empty or a null value is passed and can go on recursively causing StackOverflowError. This is an improvement to check for such a state and error out if the value is null and set the location to ROOT or empty string and if the original location is empty.