Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12735

core-default.xml misspells hadoop.workaround.non.threadsafe.getpwuid

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      The property as defined in core-default.xml is

      hadoop.work.around.non.threadsafe.getpwuid

      But in NativeIO.java (the only place I can see a similar reference), the property is defined as:

      static final String WORKAROUND_NON_THREADSAFE_CALLS_KEY = "hadoop.workaround.non.threadsafe.getpwuid";

      Note the extra period (.) in the word "workaround".

      Should the code be made to match the property or vice versa?

      1. HADOOP-12735.001.patch
        0.8 kB
        Ray Chiang
      2. HADOOP-12735.002.patch
        0.8 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          airbots Chen He added a comment -

          2.8.0 is not released yet, change to 2.7.1

          Show
          airbots Chen He added a comment - 2.8.0 is not released yet, change to 2.7.1
          Hide
          rchiang Ray Chiang added a comment -
          • Fix the property in NativeIO.java. Following the convention that we should stay backwards compatible to the property name as shown in the xml file.
          Show
          rchiang Ray Chiang added a comment - Fix the property in NativeIO.java. Following the convention that we should stay backwards compatible to the property name as shown in the xml file.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 47s trunk passed
          +1 compile 6m 16s trunk passed with JDK v1.8.0_66
          +1 compile 6m 57s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 46s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 34s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_66
          +1 javac 6m 2s the patch passed
          +1 compile 6m 50s the patch passed with JDK v1.7.0_91
          +1 javac 6m 50s the patch passed
          -1 checkstyle 0m 17s hadoop-common-project/hadoop-common: patch generated 1 new + 126 unchanged - 1 fixed = 127 total (was 127)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91
          +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          62m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784197/HADOOP-12735.001.patch
          JIRA Issue HADOOP-12735
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ddb68f60c017 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6eacdea
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 47s trunk passed +1 compile 6m 16s trunk passed with JDK v1.8.0_66 +1 compile 6m 57s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 34s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_66 +1 javac 6m 2s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_91 +1 javac 6m 50s the patch passed -1 checkstyle 0m 17s hadoop-common-project/hadoop-common: patch generated 1 new + 126 unchanged - 1 fixed = 127 total (was 127) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91 +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 62m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784197/HADOOP-12735.001.patch JIRA Issue HADOOP-12735 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ddb68f60c017 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6eacdea Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8466/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Ray Chiang. Let's change the documentation to match the code. Changing the code would be an incompatible change.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Ray Chiang . Let's change the documentation to match the code. Changing the code would be an incompatible change.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix property name in core-default.xml.
          Show
          rchiang Ray Chiang added a comment - Fix property name in core-default.xml.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Ray Chiang. +1.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Ray Chiang . +1.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 10m 58s trunk passed
          +1 compile 11m 40s trunk passed with JDK v1.8.0_66
          +1 compile 10m 13s trunk passed with JDK v1.7.0_91
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 27s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 8s the patch passed
          +1 compile 11m 36s the patch passed with JDK v1.8.0_66
          +1 javac 11m 36s the patch passed
          +1 compile 10m 12s the patch passed with JDK v1.7.0_91
          +1 javac 10m 12s the patch passed
          +1 mvnsite 1m 25s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 29s the patch passed with JDK v1.7.0_91
          -1 unit 11m 17s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 10m 2s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 31s Patch does not generate ASF License warnings.
          89m 17s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
          JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784474/HADOOP-12735.002.patch
          JIRA Issue HADOOP-12735
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux e1b4dc896812 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cf8af7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 58s trunk passed +1 compile 11m 40s trunk passed with JDK v1.8.0_66 +1 compile 10m 13s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 18s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 27s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 8s the patch passed +1 compile 11m 36s the patch passed with JDK v1.8.0_66 +1 javac 11m 36s the patch passed +1 compile 10m 12s the patch passed with JDK v1.7.0_91 +1 javac 10m 12s the patch passed +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 29s the patch passed with JDK v1.7.0_91 -1 unit 11m 17s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 10m 2s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 89m 17s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784474/HADOOP-12735.002.patch JIRA Issue HADOOP-12735 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux e1b4dc896812 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cf8af7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8472/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: No new tests

          Fixing property name in .xml file

          RE: Failing unit tests

          Unit tests pass in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: No new tests Fixing property name in .xml file RE: Failing unit tests Unit tests pass in my tree.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Committed to 2.8. Thanks, Ray Chiang.

          Show
          cmccabe Colin P. McCabe added a comment - Committed to 2.8. Thanks, Ray Chiang .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9193/)
          HADOOP-12735. core-default.xml misspells (cmccabe: rev 2e8ab3d46568162af6aa90b612ed61d487e7c7b0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9193 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9193/ ) HADOOP-12735 . core-default.xml misspells (cmccabe: rev 2e8ab3d46568162af6aa90b612ed61d487e7c7b0) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for the feedback and the commit!

          Show
          rchiang Ray Chiang added a comment - Thanks for the feedback and the commit!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang and Colin P. McCabe for fixing this issue.
          I found the default value in core-default.xml is different from that in NativeIO.java, so I filed HADOOP-12766 and created a patch. Would you please review it?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang and Colin P. McCabe for fixing this issue. I found the default value in core-default.xml is different from that in NativeIO.java, so I filed HADOOP-12766 and created a patch. Would you please review it?
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Akira Ajisaka. I'll take a look.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Akira Ajisaka . I'll take a look.

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development