Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12766

The default value of "hadoop.workaround.non.threadsafe.getpwuid" is different between core-default.xml and NativeIO.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      The default value of "hadoop.workaround.non.threadsafe.getpwuid" is false in core-default.xml, but is true in NativeIO.java.

      1. HADOOP-12766.01.patch
        3 kB
        Akira Ajisaka
      2. HADOOP-12766.02.patch
        0.7 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment - - edited

          I'm thinking we can change the default value to "true" in core-default.xml because the default value "false" in core-default.xml is no-op before HADOOP-12735.
          In addition, I'm thinking we can move the following source code into CommonConfigurationKeysPublic.java for testing (See HADOOP-12738 for the detail).

          NativeIO.java
              static final String WORKAROUND_NON_THREADSAFE_CALLS_KEY =
                "hadoop.workaround.non.threadsafe.getpwuid";
              static final boolean WORKAROUND_NON_THREADSAFE_CALLS_DEFAULT = true;
          
          Show
          ajisakaa Akira Ajisaka added a comment - - edited I'm thinking we can change the default value to "true" in core-default.xml because the default value "false" in core-default.xml is no-op before HADOOP-12735 . In addition, I'm thinking we can move the following source code into CommonConfigurationKeysPublic.java for testing (See HADOOP-12738 for the detail). NativeIO.java static final String WORKAROUND_NON_THREADSAFE_CALLS_KEY = "hadoop.workaround.non.threadsafe.getpwuid" ; static final boolean WORKAROUND_NON_THREADSAFE_CALLS_DEFAULT = true ;
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 7m 11s trunk passed
          +1 compile 6m 53s trunk passed with JDK v1.8.0_66
          +1 compile 7m 21s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 40s the patch passed with JDK v1.8.0_66
          +1 javac 6m 40s the patch passed
          +1 compile 7m 12s the patch passed with JDK v1.7.0_91
          +1 javac 7m 12s the patch passed
          -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: patch generated 2 new + 306 unchanged - 1 fixed = 308 total (was 307)
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 54s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91
          -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          65m 20s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786247/HADOOP-12766.01.patch
          JIRA Issue HADOOP-12766
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux f4a7c75b1e20 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 22a2b22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 11s trunk passed +1 compile 6m 53s trunk passed with JDK v1.8.0_66 +1 compile 7m 21s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 6m 40s the patch passed with JDK v1.8.0_66 +1 javac 6m 40s the patch passed +1 compile 7m 12s the patch passed with JDK v1.7.0_91 +1 javac 7m 12s the patch passed -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: patch generated 2 new + 306 unchanged - 1 fixed = 308 total (was 307) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91 -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 65m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786247/HADOOP-12766.01.patch JIRA Issue HADOOP-12766 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f4a7c75b1e20 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22a2b22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8536/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for finding this Akira. +1 (nonbinding). The change looks simple enough to me.

          Show
          rchiang Ray Chiang added a comment - Thanks for finding this Akira. +1 (nonbinding). The change looks simple enough to me.
          Hide
          cmccabe Colin P. McCabe added a comment - - edited

          Good find.

          Hmm. It's not immediately clear that this configuration key belongs in org/apache/hadoop/fs/CommonConfigurationKeysPublic.java. After all, it may be used outside of the "fs" (filesystem) context by things like YARN. Maybe just change the fault value in core-default.xml?

          Show
          cmccabe Colin P. McCabe added a comment - - edited Good find. Hmm. It's not immediately clear that this configuration key belongs in org/apache/hadoop/fs/CommonConfigurationKeysPublic.java . After all, it may be used outside of the "fs" (filesystem) context by things like YARN. Maybe just change the fault value in core-default.xml ?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Ray Chiang and Colin P. McCabe for review.

          Maybe just change the fault value in core-default.xml?

          Agree. I'll update the patch shortly.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Ray Chiang and Colin P. McCabe for review. Maybe just change the fault value in core-default.xml? Agree. I'll update the patch shortly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 6m 32s trunk passed with JDK v1.8.0_66
          +1 compile 7m 16s trunk passed with JDK v1.7.0_91
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 24s the patch passed with JDK v1.8.0_66
          +1 javac 6m 24s the patch passed
          +1 compile 7m 12s the patch passed with JDK v1.7.0_91
          +1 javac 7m 12s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
          +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 9m 7s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          61m 6s



          Reason Tests
          JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786395/HADOOP-12766.02.patch
          JIRA Issue HADOOP-12766
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux bdf7c501d191 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1bcfab8
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 6m 32s trunk passed with JDK v1.8.0_66 +1 compile 7m 16s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 14s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 6m 24s the patch passed with JDK v1.8.0_66 +1 javac 6m 24s the patch passed +1 compile 7m 12s the patch passed with JDK v1.7.0_91 +1 javac 7m 12s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 9m 7s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 61m 6s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786395/HADOOP-12766.02.patch JIRA Issue HADOOP-12766 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux bdf7c501d191 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8544/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Akira Ajisaka.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Akira Ajisaka .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9249 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9249/)
          HADOOP-12766. The default value of (cmccabe: rev 9086dd58c3fc391ffdc017a913e56d1801040c7a)

          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9249 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9249/ ) HADOOP-12766 . The default value of (cmccabe: rev 9086dd58c3fc391ffdc017a913e56d1801040c7a) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development