Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12712

Fix some cmake plugin and native build warnings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: native
    • Labels:
      None
    • Target Version/s:

      Description

      Fix some native build warnings

      1. HADOOP-12712.003.patch
        8 kB
        Colin P. McCabe
      2. HADOOP-12712.002.patch
        6 kB
        Colin P. McCabe
      3. HADOOP-12712.001.patch
        4 kB
        Colin P. McCabe

        Issue Links

          Activity

          Hide
          cmccabe Colin P. McCabe added a comment -

          Remove some unused imports, clean up some whitespace, etc. etc.

          Show
          cmccabe Colin P. McCabe added a comment - Remove some unused imports, clean up some whitespace, etc. etc.
          Hide
          andrew.wang Andrew Wang added a comment -

          One other thing I noticed, there's a TODO in CompileMojo about setting the # of processors which can be deleted, since we consult Runtime now.

          Show
          andrew.wang Andrew Wang added a comment - One other thing I noticed, there's a TODO in CompileMojo about setting the # of processors which can be deleted, since we consult Runtime now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 9m 28s trunk passed
          -1 compile 3m 1s root in trunk failed with JDK v1.8.0_66.
          -1 compile 7m 8s root in trunk failed with JDK v1.7.0_91.
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 2m 8s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 3m 48s trunk passed
          -1 javadoc 0m 13s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66.
          +1 javadoc 1m 55s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 25s Maven dependency ordering for patch
          +1 mvninstall 2m 23s the patch passed
          -1 compile 1m 0s root in the patch failed with JDK v1.8.0_66.
          -1 cc 1m 0s root in the patch failed with JDK v1.8.0_66.
          -1 javac 1m 0s root in the patch failed with JDK v1.8.0_66.
          -1 compile 7m 4s root in the patch failed with JDK v1.7.0_91.
          -1 cc 7m 4s root in the patch failed with JDK v1.7.0_91.
          -1 javac 7m 4s root in the patch failed with JDK v1.7.0_91.
          +1 checkstyle 1m 8s the patch passed
          +1 mvnsite 1m 54s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 4s the patch passed
          -1 javadoc 0m 13s hadoop-maven-plugins in the patch failed with JDK v1.8.0_66.
          +1 javadoc 1m 47s the patch passed with JDK v1.7.0_91
          +1 unit 0m 13s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66.
          -1 unit 9m 20s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 47s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 13s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 36s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          85m 30s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
            hadoop.ha.TestZKFailoverController
            hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782360/HADOOP-12712.002.patch
          JIRA Issue HADOOP-12712
          Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle
          uname Linux babe2f6aac0b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 817cc1f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 9m 28s trunk passed -1 compile 3m 1s root in trunk failed with JDK v1.8.0_66. -1 compile 7m 8s root in trunk failed with JDK v1.7.0_91. +1 checkstyle 1m 9s trunk passed +1 mvnsite 2m 8s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 3m 48s trunk passed -1 javadoc 0m 13s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66. +1 javadoc 1m 55s trunk passed with JDK v1.7.0_91 0 mvndep 0m 25s Maven dependency ordering for patch +1 mvninstall 2m 23s the patch passed -1 compile 1m 0s root in the patch failed with JDK v1.8.0_66. -1 cc 1m 0s root in the patch failed with JDK v1.8.0_66. -1 javac 1m 0s root in the patch failed with JDK v1.8.0_66. -1 compile 7m 4s root in the patch failed with JDK v1.7.0_91. -1 cc 7m 4s root in the patch failed with JDK v1.7.0_91. -1 javac 7m 4s root in the patch failed with JDK v1.7.0_91. +1 checkstyle 1m 8s the patch passed +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 4s the patch passed -1 javadoc 0m 13s hadoop-maven-plugins in the patch failed with JDK v1.8.0_66. +1 javadoc 1m 47s the patch passed with JDK v1.7.0_91 +1 unit 0m 13s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66. -1 unit 9m 20s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 9m 47s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 13s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91. -1 unit 0m 36s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 9m 20s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 85m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.ha.TestZKFailoverController   hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782360/HADOOP-12712.002.patch JIRA Issue HADOOP-12712 Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle uname Linux babe2f6aac0b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 817cc1f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8410/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          v3:

          • remove TODO about using # of processors since it was already done (thanks, Andrew Wang.)
          • Fix javadoc in Exec.java (this was actually busted even prior to HADOOP-8887).
          Show
          cmccabe Colin P. McCabe added a comment - v3: remove TODO about using # of processors since it was already done (thanks, Andrew Wang .) Fix javadoc in Exec.java (this was actually busted even prior to HADOOP-8887 ).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 8m 4s trunk passed
          -1 compile 0m 46s root in trunk failed with JDK v1.8.0_66.
          -1 compile 0m 43s root in trunk failed with JDK v1.7.0_91.
          +1 checkstyle 0m 59s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 3m 10s trunk passed
          -1 javadoc 0m 10s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66.
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 27s Maven dependency ordering for patch
          +1 mvninstall 2m 7s the patch passed
          -1 compile 0m 46s root in the patch failed with JDK v1.8.0_66.
          -1 cc 0m 46s root in the patch failed with JDK v1.8.0_66.
          -1 javac 0m 46s root in the patch failed with JDK v1.8.0_66.
          -1 compile 2m 9s root in the patch failed with JDK v1.7.0_91.
          -1 cc 2m 9s root in the patch failed with JDK v1.7.0_91.
          -1 javac 2m 9s root in the patch failed with JDK v1.7.0_91.
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 1m 45s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 49s the patch passed
          -1 javadoc 0m 15s hadoop-maven-plugins in the patch failed with JDK v1.8.0_66.
          +1 javadoc 1m 37s the patch passed with JDK v1.7.0_91
          +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66.
          -1 unit 19m 53s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91.
          +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 19s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          85m 43s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.test.TestTimedOutTestsListener
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782360/HADOOP-12712.002.patch
          JIRA Issue HADOOP-12712
          Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle
          uname Linux f40beb5cbdb8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 817cc1f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 8m 4s trunk passed -1 compile 0m 46s root in trunk failed with JDK v1.8.0_66. -1 compile 0m 43s root in trunk failed with JDK v1.7.0_91. +1 checkstyle 0m 59s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 3m 10s trunk passed -1 javadoc 0m 10s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66. +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 0 mvndep 0m 27s Maven dependency ordering for patch +1 mvninstall 2m 7s the patch passed -1 compile 0m 46s root in the patch failed with JDK v1.8.0_66. -1 cc 0m 46s root in the patch failed with JDK v1.8.0_66. -1 javac 0m 46s root in the patch failed with JDK v1.8.0_66. -1 compile 2m 9s root in the patch failed with JDK v1.7.0_91. -1 cc 2m 9s root in the patch failed with JDK v1.7.0_91. -1 javac 2m 9s root in the patch failed with JDK v1.7.0_91. +1 checkstyle 1m 2s the patch passed +1 mvnsite 1m 45s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 49s the patch passed -1 javadoc 0m 15s hadoop-maven-plugins in the patch failed with JDK v1.8.0_66. +1 javadoc 1m 37s the patch passed with JDK v1.7.0_91 +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66. -1 unit 19m 53s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 9m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91. +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 19s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 85m 43s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.test.TestTimedOutTestsListener JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782360/HADOOP-12712.002.patch JIRA Issue HADOOP-12712 Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle uname Linux f40beb5cbdb8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 817cc1f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8411/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 7m 44s trunk passed
          +1 compile 6m 11s trunk passed with JDK v1.8.0_66
          +1 compile 6m 58s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 0s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 findbugs 3m 12s trunk passed
          -1 javadoc 0m 11s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66.
          +1 javadoc 1m 40s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 24s Maven dependency ordering for patch
          +1 mvninstall 2m 12s the patch passed
          -1 compile 5m 15s root in the patch failed with JDK v1.8.0_66.
          -1 cc 5m 15s root in the patch failed with JDK v1.8.0_66.
          -1 javac 5m 15s root in the patch failed with JDK v1.8.0_66.
          -1 compile 2m 2s root in the patch failed with JDK v1.7.0_91.
          -1 cc 2m 2s root in the patch failed with JDK v1.7.0_91.
          -1 javac 2m 2s root in the patch failed with JDK v1.7.0_91.
          +1 checkstyle 1m 0s the patch passed
          +1 mvnsite 1m 44s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 31s the patch passed
          +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 35s the patch passed with JDK v1.7.0_91
          +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 26s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91.
          +1 unit 7m 33s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 8s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          79m 0s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782387/HADOOP-12712.003.patch
          JIRA Issue HADOOP-12712
          Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle
          uname Linux bd5eaff1a5c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cdf8895
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 7m 44s trunk passed +1 compile 6m 11s trunk passed with JDK v1.8.0_66 +1 compile 6m 58s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 0s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 3m 12s trunk passed -1 javadoc 0m 11s hadoop-maven-plugins in trunk failed with JDK v1.8.0_66. +1 javadoc 1m 40s trunk passed with JDK v1.7.0_91 0 mvndep 0m 24s Maven dependency ordering for patch +1 mvninstall 2m 12s the patch passed -1 compile 5m 15s root in the patch failed with JDK v1.8.0_66. -1 cc 5m 15s root in the patch failed with JDK v1.8.0_66. -1 javac 5m 15s root in the patch failed with JDK v1.8.0_66. -1 compile 2m 2s root in the patch failed with JDK v1.7.0_91. -1 cc 2m 2s root in the patch failed with JDK v1.7.0_91. -1 javac 2m 2s root in the patch failed with JDK v1.7.0_91. +1 checkstyle 1m 0s the patch passed +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 31s the patch passed +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_91 +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.8.0_66. -1 unit 0m 26s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 12s hadoop-maven-plugins in the patch passed with JDK v1.7.0_91. +1 unit 7m 33s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 8s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 79m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782387/HADOOP-12712.003.patch JIRA Issue HADOOP-12712 Optional Tests asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle uname Linux bd5eaff1a5c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cdf8895 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/branch-javadoc-hadoop-maven-plugins-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-maven-plugins hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8414/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Overall LGTM, though please take a look at the Jenkins -1s, seem native build related.

          I'm also kind of shocked by the extract_values change. I guess we have a lucky implicit return since extract_values_delim will set EAX and hopefully it bubbles up, but that seems compiler/optimization-level dependent. I think this is undefined behavior.

          Ping Varun Vasudev and Abin Shahab as the original authors, as a heads up on this bug.

          Show
          andrew.wang Andrew Wang added a comment - Overall LGTM, though please take a look at the Jenkins -1s, seem native build related. I'm also kind of shocked by the extract_values change. I guess we have a lucky implicit return since extract_values_delim will set EAX and hopefully it bubbles up, but that seems compiler/optimization-level dependent. I think this is undefined behavior. Ping Varun Vasudev and Abin Shahab as the original authors, as a heads up on this bug.
          Hide
          andrew.wang Andrew Wang added a comment -

          I'll also +1 since these Jenkins failures do not seem related to this precise patch, but possibly the HADOOP-8887 change. Let's track that down in a different JIRA.

          Show
          andrew.wang Andrew Wang added a comment - I'll also +1 since these Jenkins failures do not seem related to this precise patch, but possibly the HADOOP-8887 change. Let's track that down in a different JIRA.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Andrew Wang. I've filed YETUS-286 for the mysterious "failed to map segment from shared object" failures. They seem to come and go. I agree we should get this patch in since it is not the cause of those failures.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Andrew Wang . I've filed YETUS-286 for the mysterious "failed to map segment from shared object" failures. They seem to come and go. I agree we should get this patch in since it is not the cause of those failures.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9124/)
          HADOOP-12712. Fix some cmake plugin and native build warnings (cmccabe) (cmccabe: rev b2c155f810888480d058512a326a5083e1bb4eaa)

          • hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
          • hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java
          • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9124/ ) HADOOP-12712 . Fix some cmake plugin and native build warnings (cmccabe) (cmccabe: rev b2c155f810888480d058512a326a5083e1bb4eaa) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for catching this Colin P. McCabe. My apologies for letting this slip through. Like Andrew, I suspect some implicit return was carried out by the compiler. I've cherry-picked the patch to 2.8 as well.

          Show
          vvasudev Varun Vasudev added a comment - Thanks for catching this Colin P. McCabe . My apologies for letting this slip through. Like Andrew, I suspect some implicit return was carried out by the compiler. I've cherry-picked the patch to 2.8 as well.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Varun Vasudev. Yes, it was very odd that it even worked without the return statement. But it did seem to (on my computer, at least). It's good to have this fixed.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Varun Vasudev . Yes, it was very odd that it even worked without the return statement. But it did seem to (on my computer, at least). It's good to have this fixed.

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development