Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We need a metrics2 sink that can write metrics to HDFS. The sink should accept as configuration a "directory prefix" and do the following in putMetrics()

      • Get yyyyMMddHH from current timestamp.
      • If HDFS dir "dir prefix" + yyyyMMddHH doesn't exist, create it. Close any currently open file and create a new file called <hostname>.log in the new directory.
      • Write metrics to the current log file.
      1. HADOOP-12702.001.patch
        6 kB
        Daniel Templeton
      2. HADOOP-12702.002.patch
        35 kB
        Daniel Templeton
      3. HADOOP-12702.003.patch
        38 kB
        Daniel Templeton
      4. HADOOP-12702.004.patch
        40 kB
        Daniel Templeton
      5. HADOOP-12702.005.patch
        40 kB
        Daniel Templeton
      6. HADOOP-12702.006.patch
        40 kB
        Daniel Templeton

        Issue Links

          Activity

          Hide
          templedf Daniel Templeton added a comment -

          The unit tests will be added in HDFS-9637.

          Show
          templedf Daniel Templeton added a comment - The unit tests will be added in HDFS-9637 .
          Hide
          stevel@apache.org Steve Loughran added a comment -

          line 91: include the exception in the string message, please. Same elsewhere

          line 114. Instead of saying "Error connecting to HDFS", say

          ("error connecting to fs: " + basePath + " : " + ex, ex)

          that is: the URL and path, so that you stand a chance of working out why things went wrong. Just a thought.

          Show
          stevel@apache.org Steve Loughran added a comment - line 91: include the exception in the string message, please. Same elsewhere line 114. Instead of saying "Error connecting to HDFS", say ("error connecting to fs: " + basePath + " : " + ex, ex) that is: the URL and path, so that you stand a chance of working out why things went wrong. Just a thought.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Have you thought of writing as avro records instead? For the machines, you understand.

          Show
          stevel@apache.org Steve Loughran added a comment - Have you thought of writing as avro records instead? For the machines, you understand.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          + use NetUtils.getHostname() to robustly get the hostname

          Show
          stevel@apache.org Steve Loughran added a comment - + use NetUtils.getHostname() to robustly get the hostname
          Hide
          templedf Daniel Templeton added a comment -

          I originally used NetUtils.getHostname, but it requires string parsing
          to get just the hostname. Under the covers it uses InetAddress, so it
          seemed silly to use the wrapper and then spend effort undoing what it does.

          Show
          templedf Daniel Templeton added a comment - I originally used NetUtils.getHostname , but it requires string parsing to get just the hostname. Under the covers it uses InetAddress , so it seemed silly to use the wrapper and then spend effort undoing what it does.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          fine, just handle the failure which comes if the hostname is a complete mess, downgrade to "localhost"

          Show
          stevel@apache.org Steve Loughran added a comment - fine, just handle the failure which comes if the hostname is a complete mess, downgrade to "localhost"
          Hide
          templedf Daniel Templeton added a comment -

          Please define "a complete mess." According to the JavaDocs for getHostname(), worst case scenario is to fall back to an IP address. That sounds fine to me. I did some digging, and I didn't see any evidence of a worse failure scenario.

          Falling back to "localhost" sounds like a bad idea since more than one host may be writing into the same directory.

          Show
          templedf Daniel Templeton added a comment - Please define "a complete mess." According to the JavaDocs for getHostname() , worst case scenario is to fall back to an IP address. That sounds fine to me. I did some digging, and I didn't see any evidence of a worse failure scenario. Falling back to "localhost" sounds like a bad idea since more than one host may be writing into the same directory.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          It's conceivable for things to not know their own name, HADOOP-10011. Admittedly, your system is absolutely hosed at this point and it would never work in production.

          Show
          stevel@apache.org Steve Loughran added a comment - It's conceivable for things to not know their own name, HADOOP-10011 . Admittedly, your system is absolutely hosed at this point and it would never work in production.
          Hide
          templedf Daniel Templeton added a comment -

          If NetUtils.getHostname() gets an UnknownHostException from InetAddress.getLocalhost(), then it returns the exception as a string. Definitely not what I want to use as a filename. As I said above, I also don't want some common default (like "localhost") because then multiple machines may try logging to the same file. In the case that the link gets an UnknownHostException from InetAddress.getLocalhost(), I think the best approach is to simply let it kill the sink, i.e. don't catch it.

          Show
          templedf Daniel Templeton added a comment - If NetUtils.getHostname() gets an UnknownHostException from InetAddress.getLocalhost() , then it returns the exception as a string. Definitely not what I want to use as a filename. As I said above, I also don't want some common default (like "localhost") because then multiple machines may try logging to the same file. In the case that the link gets an UnknownHostException from InetAddress.getLocalhost() , I think the best approach is to simply let it kill the sink, i.e. don't catch it.
          Hide
          templedf Daniel Templeton added a comment -

          I dug into what it would take to switch to Avro and what it would mean for the consumer. The metrics2 data object classes appear to have been written with the express intent of making their use with Avro as painful as possible. It is possible to construct a schema that will accurately represent the objects, but consumption of that schema by the deserializing party will not be straightforward. I would say that we should stay will text files for now and add an option for Avro files as a separate JIRA (that may also encompass rejiggering the metrics data object classes a bit). Work for you, Steve Loughran?

          Show
          templedf Daniel Templeton added a comment - I dug into what it would take to switch to Avro and what it would mean for the consumer. The metrics2 data object classes appear to have been written with the express intent of making their use with Avro as painful as possible. It is possible to construct a schema that will accurately represent the objects, but consumption of that schema by the deserializing party will not be straightforward. I would say that we should stay will text files for now and add an option for Avro files as a separate JIRA (that may also encompass rejiggering the metrics data object classes a bit). Work for you, Steve Loughran ?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          If it's hard, leave it out. I just thought it'd be nice to read into other tools; do some post-mortem analysis in jupyter

          Show
          stevel@apache.org Steve Loughran added a comment - If it's hard, leave it out. I just thought it'd be nice to read into other tools; do some post-mortem analysis in jupyter
          Hide
          vickyuec Vikram Srivastava added a comment -

          Daniel Templeton Can you please create the directory with the UTC timestamp instead of current time zone?

          Show
          vickyuec Vikram Srivastava added a comment - Daniel Templeton Can you please create the directory with the UTC timestamp instead of current time zone?
          Hide
          vickyuec Vikram Srivastava added a comment -

          Also AbstractMetric.value returns a java.lang.Number, so using %d as a formatter will throw exception for Doubles. Instead, something like this will work -

          currentOut.printf("%s%s=%s", separator, metric.name(), String.valueOf(metric.value()));
          
          Show
          vickyuec Vikram Srivastava added a comment - Also AbstractMetric.value returns a java.lang.Number, so using %d as a formatter will throw exception for Doubles. Instead, something like this will work - currentOut.printf("%s%s=%s", separator, metric.name(), String.valueOf(metric.value()));
          Hide
          vickyuec Vikram Srivastava added a comment -

          FileSystem.create(Path) will delete any existing file (line 108). I think we should check if a file already exists and in that case append to it instead of overwriting it.

          Show
          vickyuec Vikram Srivastava added a comment - FileSystem.create(Path) will delete any existing file (line 108). I think we should check if a file already exists and in that case append to it instead of overwriting it.
          Hide
          templedf Daniel Templeton added a comment -

          This patch should address all of the issues that I think can be addressed. FileSystemSink is now more robust in the face of existing files and allows multiple daemons on the same host to each have its own log file.

          I've added a base test class and an implementation for the local file system. HDFS-9637 adds an implementation for HDFS. I've also tested this patch in a 4-node cluster.

          There is still some javadoc cleanup to do, and there may be a couple of style and comment issues still. I'll work on those for the next patch.

          Steve Loughran and Vikram Srivastava, review appreciated.

          Show
          templedf Daniel Templeton added a comment - This patch should address all of the issues that I think can be addressed. FileSystemSink is now more robust in the face of existing files and allows multiple daemons on the same host to each have its own log file. I've added a base test class and an implementation for the local file system. HDFS-9637 adds an implementation for HDFS. I've also tested this patch in a 4-node cluster. There is still some javadoc cleanup to do, and there may be a couple of style and comment issues still. I'll work on those for the next patch. Steve Loughran and Vikram Srivastava , review appreciated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 36s trunk passed
          +1 compile 6m 1s trunk passed with JDK v1.8.0_66
          +1 compile 6m 49s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 41s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_66
          +1 javac 6m 2s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_91
          +1 javac 6m 49s the patch passed
          -1 checkstyle 0m 14s hadoop-common-project/hadoop-common: patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91
          +1 unit 6m 30s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 6m 17s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          60m 15s



          Reason Tests
          JDK v1.7.0_91 Failed junit tests hadoop.test.TestTimedOutTestsListener



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783850/HADOOP-12702.002.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 65342031965e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34a3900
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 6m 1s trunk passed with JDK v1.8.0_66 +1 compile 6m 49s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 41s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_66 +1 javac 6m 2s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_91 +1 javac 6m 49s the patch passed -1 checkstyle 0m 14s hadoop-common-project/hadoop-common: patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91 +1 unit 6m 30s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 6m 17s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 60m 15s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.test.TestTimedOutTestsListener Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783850/HADOOP-12702.002.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 65342031965e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34a3900 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8450/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Redo of patch 2.

          Show
          templedf Daniel Templeton added a comment - Redo of patch 2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 12s trunk passed
          +1 compile 9m 18s trunk passed with JDK v1.8.0_66
          +1 compile 9m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 0s trunk passed
          +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91
          -1 mvninstall 0m 22s hadoop-common in the patch failed.
          +1 compile 7m 15s the patch passed with JDK v1.8.0_66
          -1 javac 11m 58s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 731 unchanged - 0 fixed = 732 total (was 731)
          +1 javac 7m 15s the patch passed
          -1 compile 0m 39s root in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 39s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 0m 17s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          -1 mvnsite 0m 27s hadoop-common in the patch failed.
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 23s hadoop-common in the patch failed.
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
          -1 javadoc 3m 11s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
          -1 unit 17m 1s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 25s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          63m 13s



          Reason Tests
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783867/HADOOP-12702.002.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e3599743d789 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34a3900
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 12s trunk passed +1 compile 9m 18s trunk passed with JDK v1.8.0_66 +1 compile 9m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91 -1 mvninstall 0m 22s hadoop-common in the patch failed. +1 compile 7m 15s the patch passed with JDK v1.8.0_66 -1 javac 11m 58s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 731 unchanged - 0 fixed = 732 total (was 731) +1 javac 7m 15s the patch passed -1 compile 0m 39s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 39s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 0m 17s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 mvnsite 0m 27s hadoop-common in the patch failed. +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 23s hadoop-common in the patch failed. +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 -1 javadoc 3m 11s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 -1 unit 17m 1s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 25s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 63m 13s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783867/HADOOP-12702.002.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e3599743d789 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34a3900 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8451/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Bumping again to get a clean Jenkins run

          Show
          templedf Daniel Templeton added a comment - Bumping again to get a clean Jenkins run
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 27s trunk passed
          +1 compile 5m 55s trunk passed with JDK v1.8.0_66
          +1 compile 6m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 1s trunk passed with JDK v1.7.0_91
          -1 mvninstall 0m 17s hadoop-common in the patch failed.
          +1 compile 5m 45s the patch passed with JDK v1.8.0_66
          -1 javac 9m 50s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 730 unchanged - 0 fixed = 731 total (was 730)
          +1 javac 5m 45s the patch passed
          -1 compile 0m 35s root in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 35s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 0m 14s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          -1 mvnsite 0m 21s hadoop-common in the patch failed.
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 20s hadoop-common in the patch failed.
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
          -1 javadoc 2m 51s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91
          +1 unit 6m 30s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 21s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          43m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783876/HADOOP-12702.002.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 05d5b474a5fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 95363bc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 27s trunk passed +1 compile 5m 55s trunk passed with JDK v1.8.0_66 +1 compile 6m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_91 -1 mvninstall 0m 17s hadoop-common in the patch failed. +1 compile 5m 45s the patch passed with JDK v1.8.0_66 -1 javac 9m 50s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 730 unchanged - 0 fixed = 731 total (was 730) +1 javac 5m 45s the patch passed -1 compile 0m 35s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 35s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 0m 14s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 mvnsite 0m 21s hadoop-common in the patch failed. +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 20s hadoop-common in the patch failed. +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 -1 javadoc 2m 51s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91 +1 unit 6m 30s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 0m 21s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 43m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783876/HADOOP-12702.002.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 05d5b474a5fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 95363bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8452/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Bumping Jenkins again. Let's see if it goes better today.

          Show
          templedf Daniel Templeton added a comment - Bumping Jenkins again. Let's see if it goes better today.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 55s trunk passed
          +1 compile 6m 42s trunk passed with JDK v1.8.0_66
          +1 compile 7m 24s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 1m 6s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91
          -1 mvninstall 0m 22s hadoop-common in the patch failed.
          +1 compile 6m 37s the patch passed with JDK v1.8.0_66
          -1 javac 11m 8s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 731 unchanged - 0 fixed = 732 total (was 731)
          +1 javac 6m 37s the patch passed
          -1 compile 0m 38s root in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 38s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 0m 16s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          -1 mvnsite 0m 25s hadoop-common in the patch failed.
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 23s hadoop-common in the patch failed.
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
          -1 javadoc 3m 10s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_91
          -1 unit 17m 0s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 24s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          57m 29s



          Reason Tests
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784017/HADOOP-12702.002.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9f37b5b533ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99829eb
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 55s trunk passed +1 compile 6m 42s trunk passed with JDK v1.8.0_66 +1 compile 7m 24s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 16s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91 -1 mvninstall 0m 22s hadoop-common in the patch failed. +1 compile 6m 37s the patch passed with JDK v1.8.0_66 -1 javac 11m 8s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new + 731 unchanged - 0 fixed = 732 total (was 731) +1 javac 6m 37s the patch passed -1 compile 0m 38s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 38s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 0m 16s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 mvnsite 0m 25s hadoop-common in the patch failed. +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 23s hadoop-common in the patch failed. +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 -1 javadoc 3m 10s hadoop-common-project_hadoop-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) +1 javadoc 1m 8s the patch passed with JDK v1.7.0_91 -1 unit 17m 0s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 24s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 57m 29s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784017/HADOOP-12702.002.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9f37b5b533ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc hadoop-common-project_hadoop-common-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8458/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Doh. Looks like my IDE quietly jacked up my imports when I wasn't looking. This time it should work.

          Show
          templedf Daniel Templeton added a comment - Doh. Looks like my IDE quietly jacked up my imports when I wasn't looking. This time it should work.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 5s trunk passed
          +1 compile 6m 50s trunk passed with JDK v1.8.0_66
          +1 compile 7m 28s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 57s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 37s the patch passed
          +1 compile 7m 3s the patch passed with JDK v1.8.0_66
          +1 javac 7m 3s the patch passed
          +1 compile 7m 44s the patch passed with JDK v1.7.0_91
          +1 javac 7m 44s the patch passed
          -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 36s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 14s the patch passed with JDK v1.7.0_91
          +1 unit 9m 33s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 59s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          71m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784022/HADOOP-12702.002.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f740fba46ef5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99829eb
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 5s trunk passed +1 compile 6m 50s trunk passed with JDK v1.8.0_66 +1 compile 7m 28s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 37s the patch passed +1 compile 7m 3s the patch passed with JDK v1.8.0_66 +1 javac 7m 3s the patch passed +1 compile 7m 44s the patch passed with JDK v1.7.0_91 +1 javac 7m 44s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 36s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 14s the patch passed with JDK v1.7.0_91 +1 unit 9m 33s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 59s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 71m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784022/HADOOP-12702.002.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f740fba46ef5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8459/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Found an issue on HDFS that's resolved in this new patch. Also fixed the javadocs.

          Show
          templedf Daniel Templeton added a comment - Found an issue on HDFS that's resolved in this new patch. Also fixed the javadocs.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 28s trunk passed
          +1 compile 6m 16s trunk passed with JDK v1.8.0_66
          +1 compile 6m 55s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 1s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 44s the patch passed
          +1 compile 5m 51s the patch passed with JDK v1.8.0_66
          +1 javac 5m 51s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_91
          +1 javac 6m 52s the patch passed
          -1 checkstyle 0m 15s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91
          +1 unit 7m 19s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          62m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784255/HADOOP-12702.003.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 669d17dc9e3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d62b4a4
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 28s trunk passed +1 compile 6m 16s trunk passed with JDK v1.8.0_66 +1 compile 6m 55s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 16s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 44s the patch passed +1 compile 5m 51s the patch passed with JDK v1.8.0_66 +1 javac 5m 51s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_91 +1 javac 6m 52s the patch passed -1 checkstyle 0m 15s hadoop-common-project/hadoop-common: patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91 +1 unit 7m 19s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 62m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784255/HADOOP-12702.003.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 669d17dc9e3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d62b4a4 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8467/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          ...we really need an IOE subclass for unsupported FS feature; avoids checking string values, which is awfully brittle. But that's not your fault.

          Never knew about HDFS-5478; that's kind of serious

          Show
          stevel@apache.org Steve Loughran added a comment - ...we really need an IOE subclass for unsupported FS feature; avoids checking string values, which is awfully brittle. But that's not your fault. Never knew about HDFS-5478 ; that's kind of serious
          Hide
          templedf Daniel Templeton added a comment -
          Show
          templedf Daniel Templeton added a comment - Steve Loughran , that's why HADOOP-12726 .
          Hide
          kasha Karthik Kambatla added a comment -

          Thanks for filing and working on this, Daniel Templeton. Comments on the latest patch:

          1. FileSystemSink:
            1. Given the sink we are adding here as some quirks to its behavior - new directory every hour etc., the class name FileSystemSink seems too simple. Can we capture more of the behavior in the name?
            2. Rename currentPath to currentDirPath, currentFile to currentFilePath, currentOut to currentOutStream for clarity?
            3. While reading BASEPATH_KEY from conf, there is no default value?
            4. checkAppend: If appending throws an IOE that is not because of not being supported, should we allow appending? I would think not.
            5. rollLogDirIfNeeded: For readability, should we split it into two ifs - the first is when the directories don't match. Also, the comment in the method is wrongly indented and slightly confusing.
              if (!path.equals(currentPath)) {
                if (currentOut != null) {
                   currentOut.close();
                   currentOut = null;
                }
                currentPath = path;
              }
              
              if (currentOut == null) {
                // rest of the code
              }
              
            6. Typo in the javadoc for createLogFile - nonExistant
            7. putMetrics: When throwing MetricsException, no need for a new line between setting the message and actually throwing the exception. Also, should just have a method that takes a message (String) and throws an exception if ignore error is not turned on. The only downside would be the intern objects for the strings here.
            8. Should flush be also invoking currentFSOut.hflush?

          The tests look good. Should we play around with the allowed configs also? I am fine with not doing that or following up in another JIRA.

          Show
          kasha Karthik Kambatla added a comment - Thanks for filing and working on this, Daniel Templeton . Comments on the latest patch: FileSystemSink: Given the sink we are adding here as some quirks to its behavior - new directory every hour etc., the class name FileSystemSink seems too simple. Can we capture more of the behavior in the name? Rename currentPath to currentDirPath, currentFile to currentFilePath, currentOut to currentOutStream for clarity? While reading BASEPATH_KEY from conf, there is no default value? checkAppend : If appending throws an IOE that is not because of not being supported, should we allow appending? I would think not. rollLogDirIfNeeded : For readability, should we split it into two ifs - the first is when the directories don't match. Also, the comment in the method is wrongly indented and slightly confusing. if (!path.equals(currentPath)) { if (currentOut != null ) { currentOut.close(); currentOut = null ; } currentPath = path; } if (currentOut == null ) { // rest of the code } Typo in the javadoc for createLogFile - nonExistant putMetrics : When throwing MetricsException, no need for a new line between setting the message and actually throwing the exception. Also, should just have a method that takes a message (String) and throws an exception if ignore error is not turned on. The only downside would be the intern objects for the strings here. Should flush be also invoking currentFSOut.hflush ? The tests look good. Should we play around with the allowed configs also? I am fine with not doing that or following up in another JIRA.
          Hide
          templedf Daniel Templeton added a comment -

          Given the sink we are adding here has some quirks to its behavior - new directory every hour etc., the class name FileSystemSink seems too simple. Can we capture more of the behavior in the name?

          How about RollingFileSystemSink?

          checkAppend: If appending throws an IOE that is not because of not being supported, should we allow appending? I would think not.

          Actually, yes. If the operation isn't supported, the method contains nothing but the exception throw. If we see anything other than that exception, the operation is supported and just not working at the moment. Could be transitive, could be persistent. Either way, the sink should keep trying.

          rollLogDirIfNeeded: For readability, should we split it into two ifs - the first is when the directories don't match. Also, the comment in the method is wrongly indented and slightly confusing.

          Hmmm... I'm not sure that actually improves readability. I really dislike chained logic like that. I find it hard to follow.

          I'll take this point as, "gee that's a long/busy method..." I have a different idea for how to clean it up.

          putMetrics: When throwing MetricsException, no need for a new line between setting the message and actually throwing the exception. Also, should just have a method that takes a message (String) and throws an exception if ignore error is not turned on. The only downside would be the intern objects for the strings here.

          Fair enough. On the blank line, I always put a blank line before a throw because it's kinda a big deal and should jump out at the reader. If it really annoys you, tell me. Otherwise I'm leaving it in.

          Show
          templedf Daniel Templeton added a comment - Given the sink we are adding here has some quirks to its behavior - new directory every hour etc., the class name FileSystemSink seems too simple. Can we capture more of the behavior in the name? How about RollingFileSystemSink? checkAppend: If appending throws an IOE that is not because of not being supported, should we allow appending? I would think not. Actually, yes. If the operation isn't supported, the method contains nothing but the exception throw. If we see anything other than that exception, the operation is supported and just not working at the moment. Could be transitive, could be persistent. Either way, the sink should keep trying. rollLogDirIfNeeded: For readability, should we split it into two ifs - the first is when the directories don't match. Also, the comment in the method is wrongly indented and slightly confusing. Hmmm... I'm not sure that actually improves readability. I really dislike chained logic like that. I find it hard to follow. I'll take this point as, "gee that's a long/busy method..." I have a different idea for how to clean it up. putMetrics: When throwing MetricsException, no need for a new line between setting the message and actually throwing the exception. Also, should just have a method that takes a message (String) and throws an exception if ignore error is not turned on. The only downside would be the intern objects for the strings here. Fair enough. On the blank line, I always put a blank line before a throw because it's kinda a big deal and should jump out at the reader. If it really annoys you, tell me. Otherwise I'm leaving it in.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 56s trunk passed
          +1 compile 7m 25s trunk passed with JDK v1.8.0_66
          +1 compile 8m 22s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 2m 9s trunk passed
          +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 12s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 35s the patch passed
          +1 compile 7m 57s the patch passed with JDK v1.8.0_66
          +1 javac 7m 57s the patch passed
          +1 compile 8m 22s the patch passed with JDK v1.7.0_91
          +1 javac 8m 22s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 11s the patch passed with JDK v1.7.0_91
          +1 unit 8m 47s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 30s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 28s Patch does not generate ASF License warnings.
          73m 30s



          Reason Tests
          JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784648/HADOOP-12702.004.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a741e2b8a23e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c01bee0
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 56s trunk passed +1 compile 7m 25s trunk passed with JDK v1.8.0_66 +1 compile 8m 22s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 9s trunk passed +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 12s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 35s the patch passed +1 compile 7m 57s the patch passed with JDK v1.8.0_66 +1 javac 7m 57s the patch passed +1 compile 8m 22s the patch passed with JDK v1.7.0_91 +1 javac 8m 22s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 11s the patch passed with JDK v1.7.0_91 +1 unit 8m 47s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 30s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 73m 30s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784648/HADOOP-12702.004.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a741e2b8a23e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c01bee0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8478/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 41s trunk passed
          +1 compile 6m 7s trunk passed with JDK v1.8.0_66
          +1 compile 6m 58s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 46s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 43s the patch passed
          +1 compile 5m 46s the patch passed with JDK v1.8.0_66
          +1 javac 5m 46s the patch passed
          +1 compile 6m 41s the patch passed with JDK v1.7.0_91
          +1 javac 6m 41s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91
          +1 unit 7m 5s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 13s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          61m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784652/HADOOP-12702.004.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7999f4333a87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c01bee0
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8480/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8480/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 41s trunk passed +1 compile 6m 7s trunk passed with JDK v1.8.0_66 +1 compile 6m 58s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 43s the patch passed +1 compile 5m 46s the patch passed with JDK v1.8.0_66 +1 javac 5m 46s the patch passed +1 compile 6m 41s the patch passed with JDK v1.7.0_91 +1 javac 6m 41s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91 +1 unit 7m 5s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 13s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 61m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784652/HADOOP-12702.004.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7999f4333a87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c01bee0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8480/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8480/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 50s trunk passed
          +1 compile 7m 57s trunk passed with JDK v1.8.0_66
          +1 compile 8m 12s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 14s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 2m 10s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 8s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 36s the patch passed
          +1 compile 7m 50s the patch passed with JDK v1.8.0_66
          +1 javac 7m 50s the patch passed
          +1 compile 8m 12s the patch passed with JDK v1.7.0_91
          +1 javac 8m 12s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
          +1 unit 8m 48s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          74m 0s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784649/HADOOP-12702.004.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3b76215bd2b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c01bee0
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8479/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8479/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 50s trunk passed +1 compile 7m 57s trunk passed with JDK v1.8.0_66 +1 compile 8m 12s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 10s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 36s the patch passed +1 compile 7m 50s the patch passed with JDK v1.8.0_66 +1 javac 7m 50s the patch passed +1 compile 8m 12s the patch passed with JDK v1.7.0_91 +1 javac 8m 12s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 0s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 +1 unit 8m 48s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 74m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784649/HADOOP-12702.004.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b76215bd2b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c01bee0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8479/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8479/console This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          Looks mostly good. Few minor comments:

          1. Should close() call flush()?
          2. rollLogDirIfNeeded: The comments in the method are wrongly indented. And, the exception message at the end should be fixed up to say "Failed to create new log file".
          Show
          kasha Karthik Kambatla added a comment - Looks mostly good. Few minor comments: Should close() call flush()? rollLogDirIfNeeded: The comments in the method are wrongly indented. And, the exception message at the end should be fixed up to say "Failed to create new log file".
          Hide
          templedf Daniel Templeton added a comment -

          Doh. Missed the comments indent.

          hflush() and flush() call the same code under the covers. hflush() does it with more aggressive parameters (flushPartial=true).

          Show
          templedf Daniel Templeton added a comment - Doh. Missed the comments indent. hflush() and flush() call the same code under the covers. hflush() does it with more aggressive parameters ( flushPartial=true ).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 6m 12s trunk passed with JDK v1.8.0_66
          +1 compile 6m 57s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 40s the patch passed
          +1 compile 6m 5s the patch passed with JDK v1.8.0_66
          +1 javac 6m 5s the patch passed
          +1 compile 6m 57s the patch passed with JDK v1.7.0_91
          +1 javac 6m 57s the patch passed
          -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 1 new + 101 unchanged - 0 fixed = 102 total (was 101)
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_91
          +1 unit 7m 6s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 6m 46s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          60m 14s



          Reason Tests
          JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784719/HADOOP-12702.005.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 18c5e5ce3704 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fb238d7
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 6m 12s trunk passed with JDK v1.8.0_66 +1 compile 6m 57s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 40s the patch passed +1 compile 6m 5s the patch passed with JDK v1.8.0_66 +1 javac 6m 5s the patch passed +1 compile 6m 57s the patch passed with JDK v1.7.0_91 +1 javac 6m 57s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 1 new + 101 unchanged - 0 fixed = 102 total (was 101) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_91 +1 unit 7m 6s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 6m 46s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 60m 14s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784719/HADOOP-12702.005.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18c5e5ce3704 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fb238d7 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8483/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 39s trunk passed
          +1 compile 6m 12s trunk passed with JDK v1.8.0_66
          +1 compile 7m 5s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 48s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 5s the patch passed with JDK v1.8.0_66
          +1 javac 6m 5s the patch passed
          +1 compile 6m 55s the patch passed with JDK v1.7.0_91
          +1 javac 6m 55s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 1s the patch passed
          +1 javadoc 0m 50s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91
          +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 24s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          60m 39s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784742/HADOOP-12702.005.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f778b86954c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fb238d7
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8484/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8484/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 39s trunk passed +1 compile 6m 12s trunk passed with JDK v1.8.0_66 +1 compile 7m 5s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 41s the patch passed +1 compile 6m 5s the patch passed with JDK v1.8.0_66 +1 javac 6m 5s the patch passed +1 compile 6m 55s the patch passed with JDK v1.7.0_91 +1 javac 6m 55s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 50s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91 +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 24s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 60m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784742/HADOOP-12702.005.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f778b86954c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fb238d7 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8484/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8484/console This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          Should close() call flush()?

          Missed the fact that close() calls close() on the underlying stream, that in turn takes care of flush.

          Latest patch looks good, but for one nit - we should null out the underlying streams on close. +1 after that.

          Show
          kasha Karthik Kambatla added a comment - Should close() call flush()? Missed the fact that close() calls close() on the underlying stream, that in turn takes care of flush. Latest patch looks good, but for one nit - we should null out the underlying streams on close. +1 after that.
          Hide
          templedf Daniel Templeton added a comment -

          Streams are now nulled out on close.

          Show
          templedf Daniel Templeton added a comment - Streams are now nulled out on close.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 12m 47s trunk passed
          +1 compile 18m 54s trunk passed with JDK v1.8.0_66
          +1 compile 13m 43s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 43s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 3m 8s trunk passed
          +1 javadoc 1m 57s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 51s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 13s the patch passed
          +1 compile 18m 52s the patch passed with JDK v1.8.0_66
          +1 javac 18m 52s the patch passed
          +1 compile 13m 57s the patch passed with JDK v1.7.0_91
          +1 javac 13m 57s the patch passed
          +1 checkstyle 0m 42s the patch passed
          +1 mvnsite 1m 47s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 28s the patch passed
          +1 javadoc 2m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91
          -1 unit 15m 40s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 20m 38s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 38s Patch does not generate ASF License warnings.
          138m 26s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.find.TestName
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.ha.TestZKFailoverController
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestAnd
            hadoop.fs.shell.find.TestIname
          JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.find.TestName
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestIname
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785032/HADOOP-12702.006.patch
          JIRA Issue HADOOP-12702
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 165be06ca926 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9fab22b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 47s trunk passed +1 compile 18m 54s trunk passed with JDK v1.8.0_66 +1 compile 13m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 3m 8s trunk passed +1 javadoc 1m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 51s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 13s the patch passed +1 compile 18m 52s the patch passed with JDK v1.8.0_66 +1 javac 18m 52s the patch passed +1 compile 13m 57s the patch passed with JDK v1.7.0_91 +1 javac 13m 57s the patch passed +1 checkstyle 0m 42s the patch passed +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 28s the patch passed +1 javadoc 2m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91 -1 unit 15m 40s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 20m 38s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 38s Patch does not generate ASF License warnings. 138m 26s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.find.TestName   hadoop.ipc.TestRPCWaitForProxy   hadoop.ha.TestZKFailoverController   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestAnd   hadoop.fs.shell.find.TestIname JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.find.TestName   hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestIname JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785032/HADOOP-12702.006.patch JIRA Issue HADOOP-12702 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 165be06ca926 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9fab22b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8489/console This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          The unit test failures look unrelated.

          +1, checking this in.

          Show
          kasha Karthik Kambatla added a comment - The unit test failures look unrelated. +1, checking this in.
          Hide
          kasha Karthik Kambatla added a comment -

          Thanks Daniel for reporting and working on this.

          Just committed to trunk and branch-2.

          Show
          kasha Karthik Kambatla added a comment - Thanks Daniel for reporting and working on this. Just committed to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9203 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9203/)
          HADOOP-12702. Add an HDFS metrics sink. (Daniel Templeton via kasha) (kasha: rev ee005e010cff3f97a5daa8000ac2cd151e2631ca)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSinkTestBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSink.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/TestRollingFileSystemSink.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9203 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9203/ ) HADOOP-12702 . Add an HDFS metrics sink. (Daniel Templeton via kasha) (kasha: rev ee005e010cff3f97a5daa8000ac2cd151e2631ca) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSinkTestBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSink.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/TestRollingFileSystemSink.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              templedf Daniel Templeton
              Reporter:
              templedf Daniel Templeton
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development